You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2011/10/19 23:57:10 UTC

[jira] [Issue Comment Edited] (HBASE-4626) Filters unnecessarily copy byte arrays...

    [ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131047#comment-13131047 ] 

Ted Yu edited comment on HBASE-4626 at 10/19/11 9:56 PM:
---------------------------------------------------------

Interesting finding.
WritableByteArrayComparable should be enhanced with:
{code}
  public int compareTo(byte[] buffer, int offset, int length)
{code}
which would delegate to this method in Bytes:
{code}
   public static int compareTo(byte[] buffer1, int offset1, int length1,
      byte[] buffer2, int offset2, int length2) {
{code}
                
      was (Author: yuzhihong@gmail.com):
    Interesting finding.
WritableByteArrayComparable should be enhanced with:
{code}
  public int compareTo(byte[] buffer, int offset, int length)
{code}
                  
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
>                 Key: HBASE-4626
>                 URL: https://issues.apache.org/jira/browse/HBASE-4626
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira