You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ab...@apache.org on 2022/12/15 23:16:14 UTC

[kafka] 01/02: KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java (#12985)

This is an automated email from the ASF dual-hosted git repository.

ableegoldman pushed a commit to branch 3.4
in repository https://gitbox.apache.org/repos/asf/kafka.git

commit 975ab3bdae5160732e8bc7e4017ea76de0c120e3
Author: vamossagar12 <sa...@gmail.com>
AuthorDate: Tue Dec 13 21:06:00 2022 +0530

    KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java (#12985)
    
    There is unwanted logging introduced by #12803 as pointed out in this comment: #12803 (comment). This PR removes it.
    
    Reviewers: Lucas Brutschy <lb...@confluent.io>, Bruno Cadonna <ca...@apache.org>
---
 .../apache/kafka/streams/processor/internals/RecordCollectorImpl.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
index 43c329896f6..51eec220833 100644
--- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
+++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
@@ -159,7 +159,8 @@ public class RecordCollectorImpl implements RecordCollector {
                     final Set<Integer> multicastPartitions = maybeMulticastPartitions.get();
                     if (multicastPartitions.isEmpty()) {
                         // If a record is not to be sent to any partition, mark it as a dropped record.
-                        log.debug("Not sending the record with key {} , value {} to any partition", key, value);
+                        log.warn("Skipping record as partitioner returned empty partitions. "
+                                + "topic=[{}]", topic);
                         droppedRecordsSensor.record();
                     } else {
                         for (final int multicastPartition: multicastPartitions) {
@@ -227,7 +228,6 @@ public class RecordCollectorImpl implements RecordCollector {
 
             if (exception == null) {
                 final TopicPartition tp = new TopicPartition(metadata.topic(), metadata.partition());
-                log.info("Produced key:{}, value:{} successfully to tp:{}", key, value, tp);
                 if (metadata.offset() >= 0L) {
                     offsets.put(tp, metadata.offset());
                 } else {