You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2026/10/15 04:03:16 UTC

[PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

morrySnow opened a new pull request, #69109:
URL: https://github.com/apache/doris/pull/69109

   ### What problem does this PR solve?
   
   Issue Number: N/A
   Related PR: https://github.com/apache/doris/pull/66902
   
   Problem Summary: String literal lexing evaluated SQL-mode predicates for every character. Select the mode-specific loop after the opening quote while preserving token semantics. Map the grammar and tests into branch-4.2 fe-core, use Java 8-compatible APIs, and adapt optional JMH tools to the existing syntax parser and benchmark profile.
   
   ### Release note
   
   Reduce string literal lexing overhead while preserving SQL-mode behavior.
   
   ### Backport validation
   
   - Test: Unit Test: DorisLexerStringLiteralTest, NereidsParserTest; optional parser benchmark sources compiled by run-fe-ut.sh; FE Checkstyle (0 violations).
       - Combined eight-backport validation: 283 tests across 13 classes, 0 failures/errors after correcting identity-cast assertions. This standalone backport has not had a separate unit-test run.
       - Regression tests were not run: no isolated branch-4.2 cluster was deployed.
       - Full build.sh --fe packaging was blocked by incomplete native third-party dependencies; the prescribed FE unit-test entry point compiled FE sources.
   - Behavior changed: No (SQL semantics are unchanged)
   - Does this need documentation: No
   
   (cherry picked from commit 5e83a92277132f1c4533ec14b2752d160e282403)
   
   ### Scope
   
   This is an independent backport of #66902 onto branch-4.2.
   The branch contains one commit and does not include the other seven picks.
   The 283-test result above was obtained from the combined backport tree; this standalone branch has not had a separate unit-test run.
   
   ### Check List (For Author)
   
   - Test:
       - [x] Unit Test: 283 targeted tests passed on the combined backport tree.
       - [x] Manual test: standalone patch matches the validated pick; FE Checkstyle passed on the combined tree.
       - [ ] Regression test: no isolated branch-4.2 cluster was deployed.
   - Behavior changed: see the backport validation details above.
   - Does this need documentation: No.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69109:
URL: https://github.com/apache/doris/pull/69109#issuecomment-6209340390

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69109:
URL: https://github.com/apache/doris/pull/69109#issuecomment-6188108226

   # FE Regression Coverage Report
   Increment line coverage `  100% (0/0)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/69109_5bedb9f74ff3dca21984567b2fdda09f8ec18b7c_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/69109_5bedb9f74ff3dca21984567b2fdda09f8ec18b7c_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69109:
URL: https://github.com/apache/doris/pull/69109#issuecomment-6184124454

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69109:
URL: https://github.com/apache/doris/pull/69109#issuecomment-6209340976

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69109:
URL: https://github.com/apache/doris/pull/69109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [improvement](parser) Optimize string literal lexing (#66902) [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #69109:
URL: https://github.com/apache/doris/pull/69109#issuecomment-6184157792

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org