You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2008/02/15 21:22:07 UTC
[jira] Created: (JCR-1390) TCK does not allow diverse Value types
in setProperty
TCK does not allow diverse Value types in setProperty
-----------------------------------------------------
Key: JCR-1390
URL: https://issues.apache.org/jira/browse/JCR-1390
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-jcr-tests
Affects Versions: 1.4, 1.3.3, 1.3.1, 1.3
Reporter: Jukka Zitting
Priority: Minor
I don't see the JCR API justifying the following test cases in SetPropertyValueTest:
testSetMixedValueArrayValueFormatException
testSetMixedValueArrayValueFormatExceptionWithPropertyType
I propose to remove those tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (JCR-1390) TCK does not allow diverse Value
types in setProperty
Posted by Julian Reschke <ju...@gmx.de>.
Jukka Zitting (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/JCR-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jukka Zitting resolved JCR-1390.
> --------------------------------
>
> Resolution: Invalid
>
> Hmm, in fact there is a justification in the spec for this behaviour.
>
> "All Value objects in the array must be of the same type, otherwise a ValueFormatException is thrown."
>
> Sorry about the noise, resolved as Invalid.
> ...
Proposal: new TCK tests (-> JSR-283) optimally should link to the spec
that holds the requirement that is being tested. Optimally *hyper*link.
See <https://jsr-283.dev.java.net/issues/show_bug.cgi?id=230>.
BR, Julian
[jira] Resolved: (JCR-1390) TCK does not allow diverse Value types
in setProperty
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-1390.
--------------------------------
Resolution: Invalid
Hmm, in fact there is a justification in the spec for this behaviour.
"All Value objects in the array must be of the same type, otherwise a ValueFormatException is thrown."
Sorry about the noise, resolved as Invalid.
> TCK does not allow diverse Value types in setProperty
> -----------------------------------------------------
>
> Key: JCR-1390
> URL: https://issues.apache.org/jira/browse/JCR-1390
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Affects Versions: 1.3, 1.3.1, 1.3.3, 1.4
> Reporter: Jukka Zitting
> Priority: Minor
>
> I don't see the JCR API justifying the following test cases in SetPropertyValueTest:
> testSetMixedValueArrayValueFormatException
> testSetMixedValueArrayValueFormatExceptionWithPropertyType
> I propose to remove those tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1390) TCK does not allow diverse Value types
in setProperty
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569523#action_12569523 ]
Jukka Zitting commented on JCR-1390:
------------------------------------
The behaviour is unspecified, and so I think implementations should be free to choose how to treat mixed multivalues.
As for JSR 283, it might make sense to explicitly allow mixed values. If an explicit target type is given either in the method call or in a property definition, then all the values should be converted to that type. Otherwise a default conversion to STRING probably makes most sense, but I'd be fine also to leave the default behaviour unspecified. I'll follow up in the JSR 283 expert group on that.
> TCK does not allow diverse Value types in setProperty
> -----------------------------------------------------
>
> Key: JCR-1390
> URL: https://issues.apache.org/jira/browse/JCR-1390
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Affects Versions: 1.3, 1.3.1, 1.3.3, 1.4
> Reporter: Jukka Zitting
> Priority: Minor
>
> I don't see the JCR API justifying the following test cases in SetPropertyValueTest:
> testSetMixedValueArrayValueFormatException
> testSetMixedValueArrayValueFormatExceptionWithPropertyType
> I propose to remove those tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1390) TCK does not allow diverse Value types
in setProperty
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569427#action_12569427 ]
Julian Reschke commented on JCR-1390:
-------------------------------------
Jukka,
are you saying a JCR store needs to be able to do that, or is your point that there's something in JSR-170 missing spelling out that this is not supported?
> TCK does not allow diverse Value types in setProperty
> -----------------------------------------------------
>
> Key: JCR-1390
> URL: https://issues.apache.org/jira/browse/JCR-1390
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Affects Versions: 1.3, 1.3.1, 1.3.3, 1.4
> Reporter: Jukka Zitting
> Priority: Minor
>
> I don't see the JCR API justifying the following test cases in SetPropertyValueTest:
> testSetMixedValueArrayValueFormatException
> testSetMixedValueArrayValueFormatExceptionWithPropertyType
> I propose to remove those tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.