You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/26 19:17:35 UTC
[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #4234: espressif/esp32/esp32s2/esp32c3: Disable wdt on initialization.
saramonteiro opened a new pull request #4234:
URL: https://github.com/apache/incubator-nuttx/pull/4234
## Summary
This MR aims to:
* Fix esp32s2 wdt disabling and wrap it under a function.
* Wrap wdt disabling in esp32.
* Implement wdt disabling in esp32c3.
## Impact
From now on, it's not necessary to disable WDT in bootloader. Start initialization will take care of disabling wdt that was enabled by bootloader.
## Test
I used a bootloader with RWDT enabled for the 3 SoCs and I commented the function that disables it and could see the chips rebooting then I uncommented and the nsh was kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4234: espressif/esp32/esp32s2/esp32c3: Disable wdt on initialization.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4234:
URL: https://github.com/apache/incubator-nuttx/pull/4234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4234: espressif/esp32/esp32s2/esp32c3: Disable wdt on initialization.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4234:
URL: https://github.com/apache/incubator-nuttx/pull/4234#issuecomment-887164403
CI for macOS(sim) fail to download the artifact, since this patch doesn't relate to sim or macOS, let's ignore the CI issue and merge it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4234: espressif/esp32/esp32s2/esp32c3: Disable wdt on initialization.
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on a change in pull request #4234:
URL: https://github.com/apache/incubator-nuttx/pull/4234#discussion_r676973880
##########
File path: arch/risc-v/src/esp32c3/hardware/esp32c3_rtccntl.h
##########
@@ -49,13 +49,13 @@
* write-enable the wdt registers
*/
-#define RTC_CNTL_WDT_WKEY_VALUE 0x50D83AA1
+#define RTC_CNTL_WDT_WKEY_VALUE 0x50D83AA1
/* The value that needs to be written to RTC_CNTL_SWD_WPROTECT_REG
* to write-enable the wdt registers
*/
-#define RTC_CNTL_SWD_WKEY_VALUE 0x8F1D312A
+#define RTC_CNTL_SWD_WKEY_VALUE 0x8F1D312A
Review comment:
Good catch! Solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4234: espressif/esp32/esp32s2/esp32c3: Disable wdt on initialization.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4234:
URL: https://github.com/apache/incubator-nuttx/pull/4234#discussion_r676963068
##########
File path: arch/risc-v/src/esp32c3/hardware/esp32c3_rtccntl.h
##########
@@ -49,13 +49,13 @@
* write-enable the wdt registers
*/
-#define RTC_CNTL_WDT_WKEY_VALUE 0x50D83AA1
+#define RTC_CNTL_WDT_WKEY_VALUE 0x50D83AA1
Review comment:
```suggestion
#define RTC_CNTL_WDT_WKEY_VALUE 0x50d83aa1
```
It is common practice to use lowercase letters for hex literals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4234: espressif/esp32/esp32s2/esp32c3: Disable wdt on initialization.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4234:
URL: https://github.com/apache/incubator-nuttx/pull/4234#discussion_r676963170
##########
File path: arch/risc-v/src/esp32c3/hardware/esp32c3_rtccntl.h
##########
@@ -49,13 +49,13 @@
* write-enable the wdt registers
*/
-#define RTC_CNTL_WDT_WKEY_VALUE 0x50D83AA1
+#define RTC_CNTL_WDT_WKEY_VALUE 0x50D83AA1
/* The value that needs to be written to RTC_CNTL_SWD_WPROTECT_REG
* to write-enable the wdt registers
*/
-#define RTC_CNTL_SWD_WKEY_VALUE 0x8F1D312A
+#define RTC_CNTL_SWD_WKEY_VALUE 0x8F1D312A
Review comment:
```suggestion
#define RTC_CNTL_SWD_WKEY_VALUE 0x8f1d312a
```
It is common practice to use lowercase letters for hex literals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org