[jira] [Commented] (AIRFLOW-4414) AWSAthenaOperator does not push QueryExecutionID to XCom

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838882#comment-16838882 ] 

ASF GitHub Bot commented on AIRFLOW-4414:
-----------------------------------------

mrshu commented on pull request #5276: [AIRFLOW-4414] AWSAthenaOperator: Push QueryExecutionID to XCom
URL: https://github.com/apache/airflow/pull/5276
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-4414) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-4414
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   * Currently it is not possible to make use of QueryExecutionID (the
     unique identifier of the query submitted to Athena) in the tasks that
     follow.
   
   * This commit changes the situation by making sure QueryExecutionID gets
     pushed to XCom when BaseOperator.do_xcom_push is set to True.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   There currently does not seem to exist a simple way of testing XCom pushing of Operators.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> AWSAthenaOperator does not push QueryExecutionID to XCom
> --------------------------------------------------------
>
>                 Key: AIRFLOW-4414
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4414
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws
>            Reporter: Marek Suppa
>            Assignee: Marek Suppa
>            Priority: Minor
>
> AWSAthenaOperator should make it easy to push QueryExecutionID to XCom which it currently does not. The best way of achieving that would currently most probably be
> {code}
> class MyAWSAthenaOperator(AWSAthenaOperator):
>     def execute(self, context):
>         super(MyAWSAthenaOperator, self).execute(context)
>         # just so that this gets `xcom_push`(ed)
>         return self.query_execution_id
> {code}
> The fix should be as simple as adding {code}return self.query_execution_id{code} at the end of {{execute}} function.
> I will add that as part of this task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)