You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@ofbiz.apache.org by jl...@apache.org on 2008/08/21 11:49:36 UTC

svn commit: r687675 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

Author: jleroux
Date: Thu Aug 21 02:49:36 2008
New Revision: 687675

URL: http://svn.apache.org/viewvc?rev=687675&view=rev
Log:
A patch from Bilgin Ibryam on dev ML

Modified:
    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java?rev=687675&r1=687674&r2=687675&view=diff
==============================================================================
--- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java (original)
+++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java Thu Aug 21 02:49:36 2008
@@ -340,7 +340,8 @@
 
         }
         if (listSize > 0) {
-            writer.append("          <span class=\"tabletext\">" + (lowIndex + 1) + " - " + (lowIndex + actualPageSize) + " of " + listSize + "</span> \n");
+            String ofLabel = UtilProperties.getMessage("CommonUiLabels", "CommonOf", (Locale) context.get("locale"));
+            writer.append(" <span class=\"tabletext\">" + (lowIndex + 1) + " - " + (lowIndex + actualPageSize) + " "+ ofLabel + " " + listSize + "</span> \n");
         }
         if (highIndex < listSize) {
             writer.append(" <a href=\"");

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

Posted by Adam Heath <do...@brainfood.com>.

Scott Gray wrote:
> Done in r688212

Yeah, that looks good.

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

Posted by Scott Gray <le...@gmail.com>.

Done in r688212

2008/8/23 Scott Gray <le...@gmail.com>:
> I'll go ahead and recommit it, I've run through a few processes that
> were having issues and they seem fine now.
>
> Regards
> Scott
>
> 2008/8/23 Scott Gray <le...@gmail.com>:
>> Oops not r687675 but r687578, I was looking at the subject of this thread.
>>
>> 2008/8/23 Scott Gray <le...@gmail.com>:
>>> Adam, I reverted 687675 yesterday a few hours before you committed
>>> your last fix, I think it's related to that.  The base compare method
>>> is still expecting a comparable rhs.
>>>
>>> 2008/8/23 Adam Heath <do...@brainfood.com>:
>>>> Jacques Le Roux wrote:
>>>>>
>>>>> Yes, + clean and even a fresh DB. To reproduce : create a fin account,
>>>>> then try to update it
>>>>
>>>> Please don't leave out any steps.  Tell me exactly what you did, all of it.
>>>>
>>>>
>>>>
>>>
>>
>

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

Posted by Scott Gray <le...@gmail.com>.

I'll go ahead and recommit it, I've run through a few processes that
were having issues and they seem fine now.

Regards
Scott

2008/8/23 Scott Gray <le...@gmail.com>:
> Oops not r687675 but r687578, I was looking at the subject of this thread.
>
> 2008/8/23 Scott Gray <le...@gmail.com>:
>> Adam, I reverted 687675 yesterday a few hours before you committed
>> your last fix, I think it's related to that.  The base compare method
>> is still expecting a comparable rhs.
>>
>> 2008/8/23 Adam Heath <do...@brainfood.com>:
>>> Jacques Le Roux wrote:
>>>>
>>>> Yes, + clean and even a fresh DB. To reproduce : create a fin account,
>>>> then try to update it
>>>
>>> Please don't leave out any steps.  Tell me exactly what you did, all of it.
>>>
>>>
>>>
>>
>

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

Posted by Scott Gray <le...@gmail.com>.

Oops not r687675 but r687578, I was looking at the subject of this thread.

2008/8/23 Scott Gray <le...@gmail.com>:
> Adam, I reverted 687675 yesterday a few hours before you committed
> your last fix, I think it's related to that.  The base compare method
> is still expecting a comparable rhs.
>
> 2008/8/23 Adam Heath <do...@brainfood.com>:
>> Jacques Le Roux wrote:
>>>
>>> Yes, + clean and even a fresh DB. To reproduce : create a fin account,
>>> then try to update it
>>
>> Please don't leave out any steps.  Tell me exactly what you did, all of it.
>>
>>
>>
>