[GitHub] [activemq-artemis] gtully commented on pull request #3282: ARTEMIS-2859 - ensure remote binding does not trigger paging to store…

[GitBox <gi...@apache.org>]

gtully commented on pull request #3282:
URL: https://github.com/apache/activemq-artemis/pull/3282#issuecomment-701364383


   This seems quite a big change but I think it is the root cause. I see that routing to the remote binding can attempt to page the message to the cluster connection queue store, which competes with the local queue binding paging to the target address, the topic address. This seems wrong.
   Having the remote binding just add the store and forward queue to the topic binding, rather than an entry in the routing context bindings map  for the store and forward address, avoids the contention. It seems wrong that it would page to the store and forward queue address!
   
   Lets hope some existing test can show me the error if this logic is flawed. The new test that verifies the non negative size of the page store for the topic works as expected with this fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org