You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/27 13:35:17 UTC
[GitHub] [apisix] Demogorgon314 opened a new pull request #4325: feat: nacos discovery support group
Demogorgon314 opened a new pull request #4325:
URL: https://github.com/apache/apisix/pull/4325
### What this PR does / why we need it:
nacos discovery support group
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4325: feat: nacos discovery support group
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4325:
URL: https://github.com/apache/apisix/pull/4325#discussion_r641382016
##########
File path: docs/en/latest/discovery/nacos.md
##########
@@ -100,6 +100,17 @@ The formatted response as below:
}
```
+### Use namespace or group
+
+#### discovery_args
Review comment:
We can remove `### Use namespace or group` and use `### discovery_args`, as you will add the nacos URL to `discovery_args` soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4325: feat: nacos discovery support group
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4325:
URL: https://github.com/apache/apisix/pull/4325#discussion_r641084748
##########
File path: docs/en/latest/discovery/nacos.md
##########
@@ -124,7 +124,7 @@ The formatted response as below:
"node": {
Review comment:
It would be better if we can add a table of "discovery args" to `nacos.md` like https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md#attributes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Demogorgon314 commented on a change in pull request #4325: feat: nacos discovery support group
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on a change in pull request #4325:
URL: https://github.com/apache/apisix/pull/4325#discussion_r641364434
##########
File path: docs/en/latest/discovery/nacos.md
##########
@@ -124,7 +124,7 @@ The formatted response as below:
"node": {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4325: feat: nacos discovery support group
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #4325:
URL: https://github.com/apache/apisix/pull/4325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org