You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/02/09 03:59:53 UTC
[GitHub] incubator-gearpump pull request #142: [GEARPUMP-268] Accept java.time.Instan...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/142
[GEARPUMP-268] Accept java.time.Instant in Message
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump instant
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 0e0d8a135523d1537f542cc08941afce0dde4e85
Author: manuzhang <ow...@gmail.com>
Date: 2017-02-09T03:59:01Z
[GEARPUMP-268] Accept java.time.Instant in Message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #142: [GEARPUMP-268] Accept java.time.Instan...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/142#discussion_r100280398
--- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala ---
@@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig)
}
override def processMessage(state: PersistentState[Int], message: Message): Unit = {
- state.update(message.timestamp, 1)
+ state.update(message.timestamp.toEpochMilli, 1)
--- End diff --
It's only used internally in `Subscription` and can be replaced in the future as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #142: [GEARPUMP-268] Accept java.time.Instant in Me...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/142
R: @huafengw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #142: [GEARPUMP-268] Accept java.time.Instant in Me...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/142
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #142: [GEARPUMP-268] Accept java.time.Instan...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/142#discussion_r100279994
--- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala ---
@@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig)
}
override def processMessage(state: PersistentState[Int], message: Message): Unit = {
- state.update(message.timestamp, 1)
+ state.update(message.timestamp.toEpochMilli, 1)
--- End diff --
yes, but I propose to hide `timeInMillis` from users in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #142: [GEARPUMP-268] Accept java.time.Instan...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/142#discussion_r100256683
--- Diff: examples/streaming/state/src/main/scala/org/apache/gearpump/streaming/examples/state/processor/CountProcessor.scala ---
@@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig)
}
override def processMessage(state: PersistentState[Int], message: Message): Unit = {
- state.update(message.timestamp, 1)
+ state.update(message.timestamp.toEpochMilli, 1)
--- End diff --
message.timestamp.toEpochMilli == message.timeInMillis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #142: [GEARPUMP-268] Accept java.time.Instan...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #142: [GEARPUMP-268] Accept java.time.Instant in Me...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/142
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/142?src=pr&el=h1) Report
> Merging [#142](https://codecov.io/gh/apache/incubator-gearpump/pull/142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/c27cd808c2d38a9b105fafc1aa0575f7beee2978?src=pr&el=desc) will **decrease** coverage by `-0.03%`.
```diff
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 69.69% 69.66% -0.03%
==========================================
Files 191 191
Lines 6061 6069 +8
Branches 513 516 +3
==========================================
+ Hits 4224 4228 +4
- Misses 1837 1841 +4
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/142?src=pr&el=footer). Last update [c27cd80...3221abe](https://codecov.io/gh/apache/incubator-gearpump/compare/c27cd808c2d38a9b105fafc1aa0575f7beee2978...3221abeb1fca6a8bced80473331a44aa56c99b3c?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #142: [GEARPUMP-268] Accept java.time.Instant in Me...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/142
travis has passed but not synced here somehow. Please check https://travis-ci.org/apache/incubator-gearpump/builds/199856894. Also, code coverage only runs when travis has passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---