You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/27 12:21:16 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils

DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-907161828


   > I choose org.apache.commons.lang3.StringUtils because our facade com.cloud.utils.StringUtils has a lack of methods to be a really facade of org.apache.commons.lang3.StringUtils and the methods it already implements are deprecated.
   
   @GutoVeronezi I see some of your argument, there is one thing that remains; if we ever need to upgrade and hit discrepancies we can fix them in one place if we use a facade. Did you start a discuss thread on this on the mailing list? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org