You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "moiseenkov (via GitHub)" <gi...@apache.org> on 2023/07/26 08:35:00 UTC
[GitHub] [airflow] moiseenkov opened a new pull request, #32857: Refactore SqlAlchemy Session.execute() to 2.0 style
moiseenkov opened a new pull request, #32857:
URL: https://github.com/apache/airflow/pull/32857
Refactored `Session.execute()` calls to SqlAlchemy 2.0 style by wrapping plain text SQL queries with `text()` function.
It eliminates the warning message:
`
Using plain strings to indicate SQL statements without using the text() construct is deprecated and will be removed in version 2.0. Ensure plain SQL statements are passed using the text() construct. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
`
SqlAlchemy documentation: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#execute-method-more-strict-execution-options-are-more-prominent
Related issue: #28723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on PR #32857:
URL: https://github.com/apache/airflow/pull/32857#issuecomment-1686054857
@uranusjr , thanks for the good news! Can we merge it then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on PR #32857:
URL: https://github.com/apache/airflow/pull/32857#issuecomment-1692862477
@jedcunningham , @potiuk , hi,
can we merge it please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #32857:
URL: https://github.com/apache/airflow/pull/32857#issuecomment-1685820001
2.7.0 is now out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova commented on pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #32857:
URL: https://github.com/apache/airflow/pull/32857#issuecomment-1651767027
Hi @uranusjr !
Wanted to ask if you have some information why the whole update was postponed until release of 2.7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis merged pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #32857:
URL: https://github.com/apache/airflow/pull/32857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] moiseenkov commented on pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "moiseenkov (via GitHub)" <gi...@apache.org>.
moiseenkov commented on PR #32857:
URL: https://github.com/apache/airflow/pull/32857#issuecomment-1651410771
> Can you amend the commit and force-push to fix the typo in the commit message?
Fixed. Thanks for noticing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #32857: Refactor SqlAlchemy Session.execute() to 2.0 style
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #32857:
URL: https://github.com/apache/airflow/pull/32857#issuecomment-1656422910
Looks good. Moving to draft to prevent accidental merge before we get 2.7 out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org