You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:13:05 UTC
[GitHub] [superset] villebro opened a new pull request, #22218: fix(plugin-chart-echarts): tooltip overflow bug
villebro opened a new pull request, #22218:
URL: https://github.com/apache/superset/pull/22218
### SUMMARY
This fixes a regression from #22082 which caused the tooltip to become cut when overflowing the chart dom element. By making sure all tooltips have the `appendToBody` (see: https://echarts.apache.org/en/option.html#tooltip.appendToBody) property set to `true` we can ensure overflowing is handled correctly on all ECharts plugins.
When reviewing the PR, make sure to use "remove whitespace changes", as the changes to the tooltip position function are all indentation changes.
### AFTER
Now overflowing works as expected:
https://user-images.githubusercontent.com/33317356/203728064-0e0f2ab4-c126-4d60-bd4e-2d0cc66f5c7a.mp4
### BEFORE
Previously overflowing on certain charts caused the tooltip to be cut:
https://user-images.githubusercontent.com/33317356/203728137-848ad5af-7943-416c-82e7-adb3fe8d6f5d.mp4
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326366522
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326106096
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326106551
@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326106544
@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326130728
@zhaoyongjie Ephemeral environment spinning up at http://52.12.29.135:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326128814
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
villebro merged PR #22218:
URL: https://github.com/apache/superset/pull/22218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326254783
There is an issue unrelated to this PR but label related when I test this. @jinghua-qa
https://user-images.githubusercontent.com/2016594/203760666-3b02005b-3243-408f-8d0c-c9f8b4a19c7a.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326140722
# [Codecov](https://codecov.io/gh/apache/superset/pull/22218?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22218](https://codecov.io/gh/apache/superset/pull/22218?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b31f2aa) into [master](https://codecov.io/gh/apache/superset/commit/3bc0865d9071cdf32d268ee8fee4c4ad93680429?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bc0865) will **not change** coverage.
> The diff coverage is `5.88%`.
> :exclamation: Current head b31f2aa differs from pull request most recent head 4baf5a7. Consider uploading reports for the commit 4baf5a7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22218 +/- ##
=======================================
Coverage 66.92% 66.92%
=======================================
Files 1835 1835
Lines 69988 69988
Branches 7612 7612
=======================================
Hits 46839 46839
Misses 21183 21183
Partials 1966 1966
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.75% <5.88%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...BigNumber/BigNumberWithTrendline/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlcldpdGhUcmVuZGxpbmUvdHJhbnNmb3JtUHJvcHMudHM=) | `47.82% <ø> (ø)` | |
| [...plugin-chart-echarts/src/BoxPlot/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQm94UGxvdC90cmFuc2Zvcm1Qcm9wcy50cw==) | `55.00% <ø> (ø)` | |
| [.../plugin-chart-echarts/src/Funnel/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvRnVubmVsL3RyYW5zZm9ybVByb3BzLnRz) | `72.34% <ø> (ø)` | |
| [...s/plugin-chart-echarts/src/Gauge/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR2F1Z2UvdHJhbnNmb3JtUHJvcHMudHM=) | `77.21% <ø> (ø)` | |
| [...s/plugin-chart-echarts/src/Graph/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvdHJhbnNmb3JtUHJvcHMudHM=) | `72.36% <ø> (ø)` | |
| [...hart-echarts/src/MixedTimeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <ø> (ø)` | |
| [...ins/plugin-chart-echarts/src/Pie/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvUGllL3RyYW5zZm9ybVByb3BzLnRz) | `55.71% <ø> (ø)` | |
| [...s/plugin-chart-echarts/src/Radar/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvUmFkYXIvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <ø> (ø)` | |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `52.27% <ø> (ø)` | |
| [...plugin-chart-echarts/src/Treemap/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVHJlZW1hcC90cmFuc2Zvcm1Qcm9wcy50cw==) | `52.23% <ø> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/22218/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22218: fix(plugin-chart-echarts): tooltip overflow bug
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22218:
URL: https://github.com/apache/superset/pull/22218#issuecomment-1326365989
> There is an issue unrelated to this PR but label related when I test this. @jinghua-qa
@zhaoyongjie this bug seems to be unrelated to this PR (I was able to repro on master), but I can look into it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org