You are viewing a plain text version of this content. The canonical link for it is here.
- Review Request 71419: Fixed anchor name in upgrades guide. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 08:14:13 UTC, 1 replies.
- Review Request 71420: Fixed typo in reservation documentation. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 08:14:16 UTC, 1 replies.
- Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 09:35:30 UTC, 1 replies.
- Review Request 71422: Added Coverity support to mesos-build. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 09:53:18 UTC, 0 replies.
- Review Request 71423: Removed legacy docker-build script. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 09:57:45 UTC, 1 replies.
- Re: Review Request 71390: Fixed the snapshot script to be non-interactive. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 11:19:58 UTC, 1 replies.
- Re: Review Request 71391: Fixed sed arg to work on Linux and OSX. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 12:41:01 UTC, 0 replies.
- Re: Review Request 71392: Improved snapshot script to deduce the Mesos version. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 12:41:19 UTC, 2 replies.
- Re: Review Request 71393: Skiped GPG signing during `maven-install` in Makefile. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 12:44:03 UTC, 1 replies.
- Re: Review Request 71394: Skipped GPG signing for snapshot builds. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 12:45:17 UTC, 1 replies.
- Re: Review Request 71395: Implemented snapshot bot. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/02 12:50:30 UTC, 2 replies.
- Review Request 71424: Added `SlaveOptions` for wrapping all parameters of `StartSlave`. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/09/02 16:36:52 UTC, 6 replies.
- Re: Review Request 71382: Removed unused and unimplemented method declaration. - posted by Jan Schlicht <ja...@d2iq.com> on 2019/09/03 12:50:49 UTC, 0 replies.
- Re: Review Request 71383: Added stringification for resource provider calls. - posted by Jan Schlicht <ja...@d2iq.com> on 2019/09/03 12:58:17 UTC, 0 replies.
- Re: Review Request 71384: Passed down failures into resource provider fatal handler. - posted by Jan Schlicht <ja...@d2iq.com> on 2019/09/03 13:02:53 UTC, 1 replies.
- Re: Review Request 71240: Added a `dist` target to the cmake build. - posted by Benno Evers <be...@mesosphere.com> on 2019/09/03 13:08:18 UTC, 7 replies.
- Re: Review Request 71241: Added a `distcheck` target to the cmake build. - posted by Benno Evers <be...@mesosphere.com> on 2019/09/03 13:08:34 UTC, 6 replies.
- Re: Review Request 71398: Made `allocated` mean "allocated but not offered" in `allocator::Slave`. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/03 13:16:45 UTC, 1 replies.
- Re: Review Request 71399: Renamed `allocate` and its derivatives in HierarchialAllocatorProcess. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/03 13:23:37 UTC, 2 replies.
- Re: Review Request 71400: Renamed `toAllocate` into `toOffer` in `HierarchialAllocatorProcess`. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/03 13:24:53 UTC, 0 replies.
- Re: Review Request 71402: Renamed *Allocation into *Offering in __generateOffers(). - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/03 13:26:06 UTC, 1 replies.
- Re: Review Request 71385: Added restart logic for failing resource providers. - posted by Jan Schlicht <ja...@d2iq.com> on 2019/09/03 13:28:07 UTC, 3 replies.
- Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/03 20:49:19 UTC, 1 replies.
- Review Request 71428: Removed `Sorter::allocation(const SlaveID& slaveId)`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/03 20:50:06 UTC, 4 replies.
- Review Request 71429: Precalculated the master per-framework metrics prefix. - posted by James Peach <jp...@apache.org> on 2019/09/04 04:52:22 UTC, 1 replies.
- Review Request 71430: Included new Python CLI in distribution tarball. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/04 07:48:44 UTC, 2 replies.
- Review Request 71433: Separated handling offer validation failure from handling success. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/04 17:52:41 UTC, 3 replies.
- Review Request 71434: Moved `removeOffers()` from `Master::accept()` into `Master::_accept()`. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/04 17:53:16 UTC, 3 replies.
- Review Request 71435: Moved setting expectation for recoverResources() to a proper place. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/04 17:53:47 UTC, 1 replies.
- Review Request 71436: Replaced removeOffer + recoverResources pairs with specialized helpers. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/04 17:54:32 UTC, 6 replies.
- Review Request 71440: Improved allocator inverse offer test. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/05 21:12:15 UTC, 4 replies.
- Review Request 71441: Fixed Docker registry malformed URI contruction. - posted by James Peach <jp...@apache.org> on 2019/09/06 06:20:06 UTC, 11 replies.
- Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/06 12:39:52 UTC, 4 replies.
- Review Request 71451: Bumped Boost to 1.71.0. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/09 10:57:31 UTC, 0 replies.
- Review Request 71450: Bumped Boost to 1.71.0. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/09 10:57:31 UTC, 0 replies.
- Review Request 71452: Bumped Boost to 1.71.0. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/09 10:57:32 UTC, 1 replies.
- Review Request 71453: Punctually disabled pylint's `cyclic-import` warning. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/09 13:54:18 UTC, 1 replies.
- Re: Review Request 71300: Removed mesos-style transition script. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/09/09 13:56:47 UTC, 1 replies.
- Re: Review Request 69411: Added new interface for constructing `cluster::Master`. - posted by Benno Evers <be...@mesosphere.com> on 2019/09/09 13:56:50 UTC, 2 replies.
- Review Request 71454: Added `futureTracker` to the `SlaveOptions` in tests. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/09/09 14:53:10 UTC, 3 replies.
- Review Request 71455: Implemented an integration test for /containerizer/debug endpoint. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/09/09 14:53:14 UTC, 4 replies.
- Review Request 71457: Activated tests for `src/python/lib`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/09 16:20:58 UTC, 4 replies.
- Review Request 71459: Added method `Resources::allocationRole()`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/09 20:58:42 UTC, 0 replies.
- Review Request 71460: Tracked offered and allocated resources in the role tree. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/09 20:58:50 UTC, 8 replies.
- Re: Review Request 71205: Switched commit hooks to pre-commit. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/10 10:02:48 UTC, 0 replies.
- Review Request 71464: Allowed setting quota the default "*" role. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/10 18:56:37 UTC, 2 replies.
- Review Request 71478: Windows: Moved definition out of inline function call. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/12 19:35:08 UTC, 3 replies.
- Review Request 71476: Simplified recover resources when removing frameworks or agents. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/12 22:42:53 UTC, 3 replies.
- Review Request 71479: Added a test to ensure resources are recovered during agent removal. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/12 22:47:14 UTC, 4 replies.
- Review Request 71480: Fixed a bug for non-partition-aware schedulers. - posted by Greg Mann <gr...@mesosphere.io> on 2019/09/12 23:18:15 UTC, 2 replies.
- Review Request 71481: Added some extra ASSERTs to a role test. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/13 00:48:35 UTC, 2 replies.
- Re: Review Request 71178: Implemented displaying roles of multi-role frameworks as a tree. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/14 20:08:14 UTC, 3 replies.
- Review Request 71494: Removed documentation on cquery. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/17 07:44:01 UTC, 1 replies.
- Review Request 71496: Removed an outdated reference to the 'libprocess' hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/09/17 12:35:53 UTC, 1 replies.
- Review Request 71497: Introduced new names for SSL-related libprocess flags. - posted by Benno Evers <be...@mesosphere.com> on 2019/09/17 12:50:15 UTC, 11 replies.
- Re: Review Request 65042: Adjusted CSI example framework for recent changes. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/17 13:00:14 UTC, 1 replies.
- Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:25:41 UTC, 5 replies.
- Review Request 71491: Added tests of metrics for tracking quota consumption. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:26:30 UTC, 0 replies.
- Review Request 71490: Added quota consumption metrics to the hierarchial allocator. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:27:22 UTC, 1 replies.
- Review Request 71489: Replaced removal+adding of quota metrics with updating them. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:28:12 UTC, 1 replies.
- Review Request 71488: Track per-role allocated resources in the roles tree. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:29:23 UTC, 6 replies.
- Review Request 71487: Added method to notify allocator that offered transitioned to allocated. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:29:59 UTC, 3 replies.
- Review Request 71486: Added `allocated` flag to the `Allocator::recoverResources()` method. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/17 13:30:29 UTC, 2 replies.
- Review Request 71501: Gc'ed nested container sandbox only if we have root container sandbox. - posted by Qian Zhang <zh...@gmail.com> on 2019/09/18 10:49:06 UTC, 2 replies.
- Review Request 71503: Manually created clang-tidy config in mesos-tidy setup. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/18 12:09:34 UTC, 1 replies.
- Re: Review Request 71179: WIP: Added a flag for running example framework with a list of roles. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/09/18 15:57:05 UTC, 0 replies.
- Review Request 71507: Windows: Disable the dist and distcheck targets with a note. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/18 19:26:45 UTC, 0 replies.
- Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/18 20:07:28 UTC, 3 replies.
- Review Request 71509: Windows: Fixed AllocationRoleEnvironmentVariable tests. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/18 22:57:29 UTC, 2 replies.
- Review Request 71510: Windows: Fixed parallel test execution. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/18 23:00:28 UTC, 5 replies.
- Review Request 71512: Windows: Libprocess: Fixed parallel test execution. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/18 23:00:42 UTC, 3 replies.
- Review Request 71511: Windows: Stout: Fixed parallel test execution. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/09/18 23:00:44 UTC, 1 replies.
- Review Request 71515: Fixed a bug where sorter may leak clients. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/19 03:25:18 UTC, 1 replies.
- Review Request 71516: Refactored framework role tracking logic in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/19 03:30:43 UTC, 3 replies.
- Re: Review Request 71441: Fixed URI stringification. - posted by James Peach <jp...@apache.org> on 2019/09/19 05:11:29 UTC, 3 replies.
- Review Request 71518: Added the test `GarbageCollectorIntegrationTest.OrphanContainer`. - posted by Qian Zhang <zh...@gmail.com> on 2019/09/19 12:19:01 UTC, 1 replies.
- Review Request 71520: Fixed inefficient `hashmap` access patterns. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/19 13:44:03 UTC, 4 replies.
- Review Request 71519: Fixed inefficient `hashmap` access patterns. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/19 13:44:06 UTC, 1 replies.
- Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`. - posted by Qian Zhang <zh...@gmail.com> on 2019/09/20 03:06:05 UTC, 2 replies.
- Review Request 71522: Added missing member initialization in `JSON::WriterProxy`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/20 07:53:33 UTC, 2 replies.
- Review Request 71523: Bumped mesos-tidy onto upstream release_90. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/20 07:53:36 UTC, 2 replies.
- Review Request 71533: Cleaned up `HTTPTest.WWWAuthenticateHeader`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/23 11:02:15 UTC, 1 replies.
- Review Request 71534: Properly handled quoted HTTP authentication headers. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/23 11:02:16 UTC, 1 replies.
- Review Request 71535: Fixed certificate write functions for windows. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/09/24 00:36:57 UTC, 4 replies.
- [GitHub] [mesos] DominikDary opened a new pull request #343: fixing fault-domain syntax. - posted by GitBox <gi...@apache.org> on 2019/09/24 08:46:35 UTC, 0 replies.
- [GitHub] [mesos] bbannier commented on issue #343: Fixed documentation on master fault domains. - posted by GitBox <gi...@apache.org> on 2019/09/24 08:58:29 UTC, 0 replies.
- [GitHub] [mesos] bbannier closed pull request #343: Fixed documentation on master fault domains. - posted by GitBox <gi...@apache.org> on 2019/09/24 08:58:29 UTC, 0 replies.
- Review Request 71538: Allowed disabling use of NVML headers. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/24 22:08:29 UTC, 1 replies.
- Re: Review Request 71534: Fixed parsing of HTTP authentication headers. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/25 09:21:12 UTC, 3 replies.
- Review Request 71541: Fixed Javascript linting and IE compatibility of the UI roles tree. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/25 12:11:18 UTC, 2 replies.
- Re: Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`. - posted by Benjamin Mahler <bm...@apache.org> on 2019/09/25 20:01:52 UTC, 5 replies.
- Review Request 71546: Kept SlaveID in the Slave struct in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/25 22:29:23 UTC, 1 replies.
- Review Request 71547: Refactored `removeFramework()` in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/25 22:29:53 UTC, 2 replies.
- Review Request 71548: Documented setting quota on the default role in the release note. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/09/25 22:44:11 UTC, 2 replies.
- [GitHub] [mesos] HHSande opened a new pull request #344: Test - posted by GitBox <gi...@apache.org> on 2019/09/29 13:40:39 UTC, 0 replies.
- [GitHub] [mesos] HHSande closed pull request #344: Test - posted by GitBox <gi...@apache.org> on 2019/09/29 13:41:08 UTC, 0 replies.
- Review Request 71559: Added early exit in reviewbot if nothing to review. - posted by Benjamin Bannier <bb...@apache.org> on 2019/09/30 13:06:38 UTC, 1 replies.
- Review Request 71560: Made the MaintenanceInverseOffers test use only one framework. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/09/30 13:33:04 UTC, 2 replies.