reviews@mesos.apache.org, 2019-06

You are viewing a plain text version of this content. The canonical link for it is here.

- Re: Review Request 70750: Removed quota role sorter in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/03 00:15:55 UTC, 0 replies.
- Review Request 70773: Added `disallow_sharing_agent_ipc_namespace` agent flag. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/03 03:16:16 UTC, 1 replies.
- Review Request 70774: Added `default_shm_size` agent flag. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/03 03:17:12 UTC, 2 replies.
- Review Request 70775: Added `ipc_mode` and `shm_size` fields into `LinuxInfo`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/03 03:17:46 UTC, 6 replies.
- Re: Review Request 70715: Added method `empty()` for `ResourceLimits`. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/06/03 06:22:25 UTC, 0 replies.
- Review Request 70777: WIP: Stopped using rDNS for hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/03 17:19:13 UTC, 3 replies.
- Re: Review Request 70690: Added `repeated QuotaConfig` to `QuotaStatus`. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/03 18:57:52 UTC, 0 replies.
- Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/03 19:12:00 UTC, 0 replies.
- Re: Review Request 70550: Added `UPDATE_QUOTA_WITH_CONFIG` authorization in the local authorizor. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/03 19:14:49 UTC, 0 replies.
- Re: Review Request 70766: Fixed chaining futures infinitely in `UriDiskProfileAdaptor`. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/03 19:41:11 UTC, 2 replies.
- Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/03 19:55:50 UTC, 6 replies.
- Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/03 20:14:32 UTC, 1 replies.
- Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/03 20:16:59 UTC, 9 replies.
- Re: Review Request 70756: Refactored some of `MasterAPITest`s using MockMasterAPISubscriber. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/06/03 21:58:27 UTC, 2 replies.
- Review Request 70778: Fixed a deadlock in libprocess. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/04 03:49:24 UTC, 10 replies.
- Review Request 70779: Added `<<` operator for `ResourceLimits`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/04 04:26:57 UTC, 2 replies.
- Review Request 70780: Added comments on allocating non-scalar resources in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/04 04:27:41 UTC, 1 replies.
- Review Request 70738: Allow roles to burst up to quota limits in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/04 04:53:49 UTC, 5 replies.
- Re: Review Request 70749: WIP: Use openssl hostname validation. - posted by Alexander Rukletsov <ru...@gmail.com> on 2019/06/04 11:39:58 UTC, 5 replies.
- Review Request 70782: Added a crude probabilistic test for MESOS-9808. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/04 12:54:04 UTC, 1 replies.
- Review Request 70783: Added debug logging for metrics which are slow to become ready. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/04 14:55:00 UTC, 11 replies.
- Review Request 70786: Moved `class ResourceQuantities` to public header. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/05 04:17:09 UTC, 2 replies.
- Re: Review Request 70741: Adopted container file operations for secrets volumes. - posted by Jiang Yan Xu <ya...@jxu.me> on 2019/06/05 07:16:35 UTC, 5 replies.
- Re: Review Request 70782: Added a non-deterministic test for MESOS-9808. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/05 15:42:22 UTC, 8 replies.
- Re: Review Request 70728: Backed `MockResourceProvider` by a process. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/06/05 22:53:52 UTC, 1 replies.
- Review Request 70788: Garbage-collected disappeared RPs when agent resources remain unchanged. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/06/06 04:56:05 UTC, 3 replies.
- Re: Review Request 70765: Renamed struct `ProfileRecord` to `ProfileData` for consistency. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/06/06 05:28:24 UTC, 0 replies.
- Re: Review Request 70751: Implemented V0 UPDATE_FRAMEWORK call. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/06 21:48:36 UTC, 0 replies.
- Re: Review Request 70748: Disallow verification of empty TLS server certificates. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/06 23:12:40 UTC, 5 replies.
- Re: Review Request 70749: WIP: Introduced optional new algorithm for hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/06 23:15:51 UTC, 1 replies.
- Review Request 70795: WIP: Updated SSL docs to include new libprocess flag. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/06 23:24:30 UTC, 0 replies.
- Review Request 70796: WIP: Fix Mesos unit tests after API change. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/06 23:24:57 UTC, 0 replies.
- Review Request 70797: WIP: Unit tests for hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/06 23:25:14 UTC, 4 replies.
- Review Request 70798: WIP: Improved `namespaces/ipc` isolator for configurable IPC support. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/06 23:45:20 UTC, 2 replies.
- Review Request 70799: Added a wrapper struct for quota guarantees and limits. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:22:37 UTC, 1 replies.
- Review Request 70800: Refactored quota overcommit check. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:22:55 UTC, 1 replies.
- Review Request 70801: Refactored allocator with the new quota wrapper struct. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:23:26 UTC, 2 replies.
- Review Request 70802: Added `Metrics::updateQuota` for quota metrics. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:24:16 UTC, 3 replies.
- Review Request 70803: Added `updateQuota` method to the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:25:13 UTC, 1 replies.
- Review Request 70804: Used the new quota struct for the allocator recover call. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/07 05:25:50 UTC, 4 replies.
- Review Request 70809: Fixed non-deferred callback calling Master::send() in UpdateFramework. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 12:01:59 UTC, 1 replies.
- Review Request 70810: Updated SSL docs with suggested runtime configuration. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/07 14:56:02 UTC, 6 replies.
- Re: Review Request 70752: Supported updating framework in MesosSchedulerDriver. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 16:26:28 UTC, 2 replies.
- Review Request 70811: Fixed compilation error on Mac OS. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/07 17:21:44 UTC, 8 replies.
- Review Request 70814: Added explicit roles to ACL of script tests for UpdateFramework testing. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 18:45:51 UTC, 0 replies.
- Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 18:48:47 UTC, 5 replies.
- Review Request 70815: Added using updateFramework() to java V0 example framework. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 18:49:50 UTC, 8 replies.
- Re: Review Request 70814: Added explicit roles to ACL of script tests for UpdateFramework testing - WIP - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 18:52:30 UTC, 0 replies.
- Review Request 70820: Updated `filesystem/linux` isolator for configurable IPC support. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/10 01:20:41 UTC, 7 replies.
- Review Request 70822: Made common protobuf changes for agent draining. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/10 10:57:58 UTC, 0 replies.
- Re: Review Request 70822: Added common protobufs for agent draining. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/10 11:24:32 UTC, 25 replies.
- Review Request 70824: Fixed test `QuotaRoleAllocateNonQuotaResource`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/11 00:53:59 UTC, 2 replies.
- Review Request 70826: Supported file operations for command tasks. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/11 02:46:14 UTC, 1 replies.
- Review Request 70827: Improved container-specific cgroups test by checking `cpu.shares`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/11 02:47:06 UTC, 3 replies.
- Review Request 70829: Added logrotate option to force Jenkins into removing older artefacts. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/06/11 11:42:13 UTC, 2 replies.
- Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/11 12:38:20 UTC, 0 replies.
- Re: Review Request 70798: Improved `namespaces/ipc` isolator for configurable IPC support. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/11 14:33:54 UTC, 4 replies.
- Re: Review Request 70753: Templatized UPDATE_FRAMEWORK test helpers over type of FrameworkInfo. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/11 19:01:27 UTC, 1 replies.
- Re: Review Request 70754: Moved UPDATE_FRAMEWORK test helpers to appropriate namespaces. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/11 19:02:21 UTC, 1 replies.
- Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/11 20:40:14 UTC, 12 replies.
- Review Request 70835: Added the DrainInfo to agent API outputs. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/11 20:41:45 UTC, 0 replies.
- Review Request 70836: Added test for DrainInfo in agent API outputs. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/11 20:52:38 UTC, 6 replies.
- Review Request 70839: Added agent capability for agent draining. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/12 08:10:13 UTC, 5 replies.
- Re: Review Request 70702: Sequentialized all events to master's `/api/v1` subscribers. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/12 13:31:31 UTC, 0 replies.
- Review Request 70843: Replaced a pointer to managed MockMasterAPISubscriberProcess with a pid. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/12 13:59:31 UTC, 2 replies.
- Review Request 70844: Implemented `cleanup` method of the `namespaces/ipc` isolator. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/12 14:32:23 UTC, 3 replies.
- Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/12 14:38:11 UTC, 2 replies.
- Re: Review Request 70814: Replaced a set of single '*' role in SCRIPT_TEST ACL with ANY. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/12 16:34:43 UTC, 1 replies.
- Review Request 70849: Added the test `NamespacesIsolatorTest.ROOT_PrivateIPCNamespace`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/13 07:25:19 UTC, 1 replies.
- Review Request 70851: Added seconds precision to the DurationInfo protobuf. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/13 11:47:33 UTC, 2 replies.
- Review Request 70855: Added tests for handling of FrameworkID by V0 framework updates. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/13 19:04:39 UTC, 0 replies.
- Review Request 70854: Made scheduler driver's updateFramework() accept FrameworkInfo with ID. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/13 19:04:47 UTC, 2 replies.
- Review Request 70852: Added the test `NamespacesIsolatorTest.ROOT_ShareAgentIPCNamespace`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/14 03:00:49 UTC, 1 replies.
- Review Request 70857: Added the test `ROOT_DisallowShareAgentIPCNamespace`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/14 03:01:25 UTC, 1 replies.
- Review Request 70859: Updated the test `NamespacesIsolatorTest.ROOT_IPCNamespace`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/14 09:54:07 UTC, 0 replies.
- Review Request 70860: Added the test `ROOT_IPCNamespaceWithIPCIsolatorDisabled`. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/14 09:56:16 UTC, 1 replies.
- Re: Review Request 70854: Made scheduler driver's updateFramework() require FrameworkInfo with ID. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/14 12:32:24 UTC, 2 replies.
- Re: Review Request 70855: Adapted UpdateFrameworkV0 tests to the fix of FrameworkID handling. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/14 12:36:44 UTC, 2 replies.
- Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests. - posted by James Peach <jp...@apache.org> on 2019/06/17 02:13:11 UTC, 3 replies.
- Review Request 70863: Assign cgroup processes after configuring the subsystem. - posted by James Peach <jp...@apache.org> on 2019/06/17 02:47:03 UTC, 3 replies.
- Review Request 70868: Clarified ERROR event as first event in the scheduler HTTP API docs. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/17 22:49:05 UTC, 2 replies.
- Review Request 70870: Updated `namespaces-ipc.md` for configurable IPC namespace and /dev/shm. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/18 02:42:07 UTC, 3 replies.
- Review Request 70877: Updated master's /roles endpoint to use jsonify. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/18 19:13:15 UTC, 3 replies.
- Review Request 70879: Updated webui Roles tab to consistently display '-' for 0 entries. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/18 20:22:05 UTC, 2 replies.
- Re: Review Request 70740: Windows: Removed multiple categories of sources from the build. - posted by Gilbert Song <so...@gmail.com> on 2019/06/18 23:09:23 UTC, 2 replies.
- Review Request 70881: Improve master CHECK messages. - posted by James Peach <jp...@apache.org> on 2019/06/19 05:06:02 UTC, 5 replies.
- Re: Review Request 70773: Added `--disallow_sharing_agent_ipc_namespace` agent flag. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/19 06:21:05 UTC, 2 replies.
- Re: Review Request 70774: Added `--default_shm_size` agent flag. - posted by Qian Zhang <zh...@gmail.com> on 2019/06/19 06:26:34 UTC, 1 replies.
- [GitHub] [mesos] carlonelong opened a new pull request #336: Cgroups isolators do not require Linux launcher. - posted by GitBox <gi...@apache.org> on 2019/06/19 09:11:03 UTC, 0 replies.
- Re: Review Request 70748: Changed semantics of some libprocess TLS flags. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:28:11 UTC, 2 replies.
- Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect(). - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:34:42 UTC, 1 replies.
- Review Request 70884: WIP: Added optional hostname field to UPID. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:42:42 UTC, 0 replies.
- Review Request 70885: Renamed 'libprocess::network::Address::hostname()'. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:44:03 UTC, 2 replies.
- Re: Review Request 70796: Fixed Mesos unit tests after Address API change. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:44:57 UTC, 1 replies.
- Re: Review Request 70749: Introduced optional new algorithm for hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:46:00 UTC, 0 replies.
- Re: Review Request 70795: Updated SSL docs to include new libprocess flag. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:46:49 UTC, 7 replies.
- Review Request 70886: WIP: Override source address for executors. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/19 14:48:03 UTC, 3 replies.
- Review Request 70887: Added `track`, `pendingFutures` functions for tracking pending futures. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/19 14:49:12 UTC, 0 replies.
- Review Request 70888: Added `IsolatorTracker` for tracking calls of isolator methods. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/19 14:49:16 UTC, 0 replies.
- Review Request 70889: Wrapped isolators in `IsolatorTracker`. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/19 14:49:24 UTC, 0 replies.
- Review Request 70890: Added `LauncherTracker` for tracking calls of launcher methods. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/19 14:49:33 UTC, 0 replies.
- Review Request 70891: Wrapped launcher in `LauncherTracker`. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/19 14:49:40 UTC, 0 replies.
- Review Request 70892: Added `/containerizer/debug` endpoint. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/19 14:49:49 UTC, 1 replies.
- Re: Review Request 70747: Updated some flag description for libprocess SSL flags. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/06/19 16:16:42 UTC, 0 replies.
- Review Request 70894: Provided ability to change suppressed roles via V0 updateFramework(). - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/19 18:26:27 UTC, 8 replies.
- Review Request 70895: Added test for supperssing roles via V0 updateFramework(). - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/19 18:26:39 UTC, 0 replies.
- Review Request 70896: Consolidated creating std::vector from Collection in V0 Java bindings. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/19 18:27:01 UTC, 2 replies.
- Review Request 70897: Supported suppressedRoles in updateFramework() in V0 Java bindings. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/19 18:27:15 UTC, 3 replies.
- Review Request 70898: Fixed flaky UpdateFrameworkV0Test.DriverErrorOnFrameworkIDMismatch. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/19 18:37:09 UTC, 1 replies.
- Review Request 70899: Refactored the agent's task-killing code. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/19 18:55:33 UTC, 4 replies.
- Review Request 70900: Updated an equality operator. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/19 18:59:38 UTC, 1 replies.
- Review Request 70901: Added kill policy to the 'Task' message. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/19 19:00:34 UTC, 1 replies.
- Review Request 70903: Killed all tasks on the agent when draining. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/19 19:07:23 UTC, 4 replies.
- Review Request 70904: Added tests for task killing when draining the agent. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/19 19:10:20 UTC, 4 replies.
- Review Request 70905: Avoided a double map lookup in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/19 22:38:40 UTC, 1 replies.
- Review Request 70906: Fixed pid checkpointing for `TestContainerizer`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/20 13:30:16 UTC, 2 replies.
- Review Request 70907: WIP: Added recovery of agent drain information. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/20 13:30:24 UTC, 1 replies.
- Re: Review Request 70749: Introduced optional new scheme for hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/20 17:48:39 UTC, 5 replies.
- Review Request 70910: Added ACLs for agent draining APIs. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/20 21:00:59 UTC, 1 replies.
- Review Request 70911: WIP: Added master endpoints for agent draining. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/20 21:01:02 UTC, 0 replies.
- Review Request 70912: Removed const ref lifetime extension use in `slave::state::recover`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/20 21:44:23 UTC, 2 replies.
- Re: Review Request 70907: Added recovery of agent drain information. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/20 21:45:19 UTC, 10 replies.
- Review Request 70914: Defined `mapped_type` for `ResourceQuantities` and `ResourceLimits`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:27:35 UTC, 2 replies.
- Review Request 70915: Made `/roles` endpoint also return quota limits. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:29:01 UTC, 4 replies.
- Review Request 70916: Replaced `Quota` with `Quota2` in the master state. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:29:58 UTC, 3 replies.
- Review Request 70917: Refactored the allocator test to use the `updateQuota` method. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:31:16 UTC, 1 replies.
- Review Request 70918: Removed `setQuota` and `removeQuota` methods in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:31:47 UTC, 1 replies.
- Review Request 70919: Replaced the old `struct Quota`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:32:46 UTC, 2 replies.
- Re: Review Request 70911: Added master endpoints for agent draining. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/21 13:10:40 UTC, 7 replies.
- Re: Review Request 70748: Changed semantics of libprocess TLS flags. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/21 15:01:14 UTC, 0 replies.
- Review Request 70921: Add OpenSSL related changes to CHANGELOG. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/21 15:02:22 UTC, 0 replies.
- Review Request 70922: Added master minimum capability for agent draining. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/21 15:08:07 UTC, 2 replies.
- Review Request 70923: Added a registry operation for the DRAIN_AGENT call. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/21 16:00:53 UTC, 5 replies.
- Review Request 70924: Added registry operations for DE/RE-ACTIVATE_AGENT calls. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/21 16:49:29 UTC, 3 replies.
- Review Request 70925: Exposed the MESOS-9856 bug in revivieOffers() in a test. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/21 17:34:31 UTC, 1 replies.
- Review Request 70926: Fixed clearing offer filters for unrelated roles by reviveOffers(). - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/21 17:36:37 UTC, 1 replies.
- Re: Review Request 70884: Added optional 'host' string member to UPID. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/21 22:25:26 UTC, 3 replies.
- Review Request 70927: Fixed a memory "leak" of filters in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/21 23:12:05 UTC, 7 replies.
- Review Request 70928: WIP: leak test. - posted by Benjamin Mahler <bm...@apache.org> on 2019/06/21 23:12:06 UTC, 0 replies.
- [GitHub] [mesos] bbannier opened a new pull request #337: Removed executable bit from files would should be `source`'d. - posted by GitBox <gi...@apache.org> on 2019/06/24 09:35:41 UTC, 0 replies.
- [GitHub] [mesos] aaniin opened a new pull request #338: Documentation: Garbage Collection - Nanoseconds - posted by GitBox <gi...@apache.org> on 2019/06/24 10:30:40 UTC, 0 replies.
- Review Request 70933: Refactored raw duration into const variable. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/24 12:22:54 UTC, 1 replies.
- Review Request 70935: Sped up `SlaveTest.KillQueuedTaskDuringExecutorRegistration`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/24 13:58:11 UTC, 1 replies.
- Review Request 70936: Adjusted task status updates during draining. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/24 14:03:13 UTC, 10 replies.
- [GitHub] [mesos] asfgit closed pull request #338: Documentation: Garbage Collection - Nanoseconds - posted by GitBox <gi...@apache.org> on 2019/06/24 19:06:15 UTC, 0 replies.
- Review Request 70939: Updated the UI to show quota limits differently from guarantees. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/24 23:24:29 UTC, 1 replies.
- Re: Review Request 70933: Moved an inline duration for slow DNS logging into a const variable. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/25 12:20:00 UTC, 0 replies.
- Re: Review Request 70887: Added `track`, `pendingFutures` functions for tracking pending futures. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/06/25 12:20:06 UTC, 0 replies.
- Re: Review Request 70895: Added a test for supperssing roles via V0 updateFramework(). - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 15:30:09 UTC, 2 replies.
- [GitHub] [mesos] bbannier merged pull request #337: Removed executable bit from files which should be `source`'d. - posted by GitBox <gi...@apache.org> on 2019/06/25 15:48:40 UTC, 0 replies.
- Review Request 70941: Added to the scheduler driver a method to revive a subset of roles. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 15:57:50 UTC, 1 replies.
- Review Request 70942: Added a test for 'reviveOffers(roles)'. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 16:03:04 UTC, 2 replies.
- Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 16:23:14 UTC, 1 replies.
- Review Request 70943: Added scheduler driver constructors which set initial suppressed roles. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 16:26:33 UTC, 1 replies.
- Review Request 70944: Added a test for scheduler driver registering with a suppressed role. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 16:27:18 UTC, 1 replies.
- Review Request 70945: Added a constructor with a list of suppressed roles to Java V0 bindings. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 16:28:02 UTC, 1 replies.
- Review Request 70946: WIP: Added reviveOffers() and the new constructor to Java TestFramework. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 16:30:05 UTC, 0 replies.
- Re: Review Request 70835: Added the DrainConfig to agent API outputs. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/25 19:59:36 UTC, 1 replies.
- Re: Review Request 70836: Added test for DrainConfig in agent API outputs. - posted by Greg Mann <gr...@mesosphere.io> on 2019/06/25 20:00:28 UTC, 2 replies.
- Review Request 70948: Attempting to get Jenkins pipeline build expiry fixed. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/06/26 00:14:52 UTC, 2 replies.
- Re: Review Request 70797: Added unit tests for hostname validation. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/26 00:18:25 UTC, 0 replies.
- Review Request 70949: Added master minimum capability for update quota. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/26 01:36:37 UTC, 0 replies.
- Review Request 70950: Added a registry field for `QuotaConfig`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/26 01:37:08 UTC, 3 replies.
- Review Request 70951: Added registry operations for updating quota configurations. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/26 01:37:32 UTC, 0 replies.
- Re: Review Request 70949: Added master minimum capability `QUOTA_V2`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/26 05:58:46 UTC, 4 replies.
- Re: Review Request 70951: Updated registry operation `UpdateQuota` to persist `QuotaConfig`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/26 06:03:45 UTC, 6 replies.
- Re: Review Request 70748: Changed semantics of TLS certificate verification flags. - posted by Benno Evers <be...@mesosphere.com> on 2019/06/26 10:26:11 UTC, 0 replies.
- Re: Review Request 70895: Added a test for suppressing roles via V0 updateFramework(). - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/26 15:33:43 UTC, 1 replies.
- Review Request 70956: Modified registry operations for unreachable draining agents. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/26 20:45:01 UTC, 0 replies.
- Review Request 70957: Added registry operation for marking an agent as drained. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/06/26 20:45:45 UTC, 0 replies.
- Review Request 70958: Changed agent to fail task launches received during draining. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/26 23:55:10 UTC, 1 replies.
- Review Request 70959: Cleared agent drain state when draining is finished. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/26 23:55:11 UTC, 10 replies.
- Review Request 70960: Added test for agent to leave draining state on its own. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/26 23:55:12 UTC, 8 replies.
- Review Request 70965: WIP: Test for adding a role in a suppressed state. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 16:43:39 UTC, 0 replies.
- Review Request 70967: Improved readability of updateFramework() in the hierarchial allocator. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 19:37:54 UTC, 2 replies.
- Review Request 70968: Fixed adding and removing framework roles in suppressed state. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 19:38:54 UTC, 1 replies.
- Re: Review Request 70965: Test for adding a role in a suppressed state. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 19:39:57 UTC, 2 replies.
- Review Request 70966: Test for removing a role from both roles and suppressed roles. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 19:40:06 UTC, 2 replies.
- Review Request 70970: Deactivated clang-tidy check `clang-analyzer-cplusplus.Move`. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/28 13:37:57 UTC, 1 replies.
- Review Request 70971: Bumped mesos-tidy to 8.0.0. - posted by Benjamin Bannier <bb...@apache.org> on 2019/06/28 13:37:58 UTC, 1 replies.
- Review Request 70972: Added helpers to add and remove master minimum capabilities. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/06/28 21:40:16 UTC, 0 replies.
- Review Request 70974: Added 'operator-()' for set difference to stout. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:46:33 UTC, 0 replies.
- Review Request 70975: Refactored updateFramework() method of the hierarchial allocator. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:47:47 UTC, 0 replies.
- Review Request 70976: Fixed calling suppressRole() before addSubscribedRole() in allocator. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:48:53 UTC, 0 replies.
- Review Request 70977: Fixed spurious activation of a role added in a suppressed state. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:50:03 UTC, 0 replies.
- Review Request 70978: Fixed calling reviveRole() after removeSubscribedRole() in allocator. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:50:40 UTC, 0 replies.
- Review Request 70979: Fixed building set of roles to be activated. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:51:12 UTC, 0 replies.
- Review Request 70980: Removed deactivation of already inactive roles on framework update. - posted by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/29 12:56:08 UTC, 0 replies.