reviews@mesos.apache.org, 2019-02

You are viewing a plain text version of this content. The canonical link for it is here.

- Re: Review Request 69876: Removed operations from master state when an agent is downgraded. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2019/02/01 00:44:36 UTC, 9 replies.
- Review Request 69880: Added header comments for two master methods. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/02 01:16:16 UTC, 6 replies.
- Re: Review Request 69862: Validated static framework offer filters. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/04 11:14:35 UTC, 4 replies.
- Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/04 11:14:37 UTC, 17 replies.
- Re: Review Request 69818: Added offer filters to static framework configuration. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/04 11:14:40 UTC, 12 replies.
- Review Request 69885: Sped up some resource benchmark test instantiations. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/04 12:55:20 UTC, 9 replies.
- Re: Review Request 69871: Added more documentation for operation feedback. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/04 21:43:50 UTC, 2 replies.
- Review Request 69889: Stored static framework offer filters in allocator framework class. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/04 22:05:07 UTC, 8 replies.
- Review Request 69890: Added test for per-framework, per-role minimal allocatable resources. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/04 22:05:09 UTC, 19 replies.
- Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:38:19 UTC, 2 replies.
- Review Request 69892: Made SLRP recover node-published volumes after reboot. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:40:16 UTC, 13 replies.
- Review Request 69893: Clean up persistent volumes on SLRP disks. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:42:29 UTC, 8 replies.
- Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:43:49 UTC, 4 replies.
- Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:51:33 UTC, 5 replies.
- Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 08:01:17 UTC, 5 replies.
- Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 08:04:14 UTC, 4 replies.
- Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 08:06:40 UTC, 9 replies.
- Re: Review Request 69858: Persisted intentionally dropped operations in SLRP. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/05 12:08:48 UTC, 3 replies.
- Review Request 69891: Sent operation updates to schedulers when agents are removed. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/05 16:24:17 UTC, 7 replies.
- Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/05 16:40:51 UTC, 2 replies.
- Re: Review Request 69854: Set status update UUID in MockResourceProvider. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/05 17:30:55 UTC, 0 replies.
- Review Request 69900: Reduced unnecessary agent lookups in the allocation loops. - posted by Benjamin Mahler <bm...@apache.org> on 2019/02/05 22:30:15 UTC, 2 replies.
- Review Request 69902: Fixed incorrect skipping in the allocation loops. - posted by Benjamin Mahler <bm...@apache.org> on 2019/02/05 22:30:18 UTC, 7 replies.
- Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/06 00:05:42 UTC, 4 replies.
- Re: Review Request 69869: [WIP] Added test for tearing down frameworks while creating disks. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2019/02/06 02:55:11 UTC, 0 replies.
- Review Request 69904: Extracted common offer matching functions from SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/06 05:37:52 UTC, 6 replies.
- Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/06 05:38:41 UTC, 3 replies.
- Review Request 69907: Fixed variable names in `Master::_doRegistryGC()`. - posted by Vinod Kone <vi...@apache.org> on 2019/02/06 16:35:21 UTC, 2 replies.
- Review Request 69908: Removed unreachable tasks from `Master::Framework` on agent GC. - posted by Vinod Kone <vi...@apache.org> on 2019/02/06 16:38:14 UTC, 2 replies.
- Review Request 69909: Tested unreachable task behavior on agent GC. - posted by Vinod Kone <vi...@apache.org> on 2019/02/06 16:41:12 UTC, 6 replies.
- Review Request 69911: Added tests for reconciliation of operations on agent default resources. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/06 21:02:45 UTC, 8 replies.
- Review Request 69910: Added tests for feedback for operations on agent default resources. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/06 21:02:48 UTC, 7 replies.
- Review Request 69912: Added agent/RP IDs to some operation updates generated by the master. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/06 22:04:26 UTC, 3 replies.
- Review Request 69913: Added more operation reconciliation tests. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/06 22:04:27 UTC, 5 replies.
- Review Request 69920: Removed `MasterAPITest.OperationFeedbackOnAgentDefaultResources`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/07 21:53:54 UTC, 1 replies.
- Review Request 69919: Added missing periods at the end of comments. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/07 21:54:45 UTC, 1 replies.
- Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/07 23:23:51 UTC, 7 replies.
- Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/02/08 16:16:40 UTC, 0 replies.
- Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/02/08 16:35:18 UTC, 0 replies.
- Review Request 69931: Empty test commit. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/02/08 17:02:55 UTC, 2 replies.
- Re: Review Request 69615: Disable containerizer ptrace attach. - posted by James Peach <jp...@apache.org> on 2019/02/08 21:09:08 UTC, 6 replies.
- Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources. - posted by Clement Michaud <cl...@gmail.com> on 2019/02/10 11:15:42 UTC, 14 replies.
- Review Request 69942: Added a test for MESOS-9554. - posted by Benjamin Mahler <bm...@apache.org> on 2019/02/11 18:21:11 UTC, 5 replies.
- Review Request 69943: Added Linux memfd support. - posted by Jie Yu <yu...@gmail.com> on 2019/02/11 19:13:34 UTC, 1 replies.
- Review Request 69944: Made the code more robust related to sendfile. - posted by Jie Yu <yu...@gmail.com> on 2019/02/11 19:14:08 UTC, 1 replies.
- Review Request 69945: Added a test to test memfd file clone. - posted by Jie Yu <yu...@gmail.com> on 2019/02/11 19:14:34 UTC, 1 replies.
- Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit. - posted by Gilbert Song <so...@gmail.com> on 2019/02/11 19:21:38 UTC, 2 replies.
- Review Request 69947: Cloned a sealed file of launcher binary. - posted by Gilbert Song <so...@gmail.com> on 2019/02/11 19:21:44 UTC, 1 replies.
- Review Request 69948: Cleaned up command executor redundant command string. - posted by Gilbert Song <so...@gmail.com> on 2019/02/11 19:21:57 UTC, 2 replies.
- Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer. - posted by Jason Lai <ja...@jasonlai.net> on 2019/02/11 23:10:44 UTC, 8 replies.
- Review Request 69954: Added a SLRP unit test for persistent block volume creation. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/12 05:27:50 UTC, 0 replies.
- Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/12 05:28:19 UTC, 1 replies.
- Review Request 69957: Updated master operation handling to account for new agent capability. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/12 21:48:03 UTC, 7 replies.
- Review Request 69958: Made an agent capability required for agent startup. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/12 21:49:01 UTC, 2 replies.
- Review Request 69964: Added tests related to operation feedback agent capabilities. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/12 23:42:38 UTC, 6 replies.
- Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:03:50 UTC, 2 replies.
- Review Request 69968: Copied operation removal logic in agent removal code path. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:05:04 UTC, 3 replies.
- Review Request 69969: Updated docs related to agent capabilities. - posted by Greg Mann <gr...@mesosphere.io> on 2019/02/13 02:08:07 UTC, 4 replies.
- Review Request 69960: Added the concept of "orphaned operations" to the master. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:12:17 UTC, 7 replies.
- Review Request 69961: Handle possible orphaned operations after master/agent failover. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:14:38 UTC, 1 replies.
- Review Request 69962: Added cleanup logic for orphaned operations. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:15:35 UTC, 3 replies.
- Review Request 69963: Handled terminal operation status updates for orphans. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:17:22 UTC, 2 replies.
- Review Request 69967: Added a recovery path for orphan operation. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:19:42 UTC, 5 replies.
- Re: Review Request 69893: Cleaned up persistent volumes on SLRP disks. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/13 03:11:32 UTC, 0 replies.
- Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/13 05:54:30 UTC, 4 replies.
- Review Request 69971: Removed an outdated comment in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/13 05:55:09 UTC, 2 replies.
- Review Request 69972: Skipped the container which has no checkpointed volumes during recovery. - posted by Qian Zhang <zh...@gmail.com> on 2019/02/13 08:26:43 UTC, 7 replies.
- Review Request 69977: Improved agent operation recovery process. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/13 22:45:12 UTC, 5 replies.
- Review Request 69978: Added garbage collection of terminated operations status update streams. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/13 22:49:14 UTC, 19 replies.
- Review Request 69980: Modified when master responds to operation status updates. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 23:23:11 UTC, 10 replies.
- Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/14 00:27:22 UTC, 4 replies.
- Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/14 01:30:03 UTC, 0 replies.
- Review Request 69986: Added a log line for simplified debugging. - posted by Alexander Rukletsov <ru...@gmail.com> on 2019/02/14 15:24:56 UTC, 2 replies.
- Review Request 69989: Fixed an allocator crash during reservation tracking. - posted by Benjamin Mahler <bm...@apache.org> on 2019/02/14 20:55:54 UTC, 1 replies.
- Review Request 69990: Added a regression test for MESOS-9555. - posted by Benjamin Mahler <bm...@apache.org> on 2019/02/14 20:56:39 UTC, 2 replies.
- Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`. - posted by Qian Zhang <zh...@gmail.com> on 2019/02/15 08:40:21 UTC, 13 replies.
- Re: Review Request 69986: Added a log line to isolator for simplified debugging. - posted by Alexander Rukletsov <ru...@gmail.com> on 2019/02/15 08:54:50 UTC, 1 replies.
- [GitHub] jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy. - posted by GitBox <gi...@apache.org> on 2019/02/15 15:16:37 UTC, 0 replies.
- [GitHub] vinodkone merged pull request #294: FaultDomain, conventions for additional hierarchy. - posted by GitBox <gi...@apache.org> on 2019/02/16 02:25:29 UTC, 0 replies.
- Review Request 69999: Fixed some lint issues in verify-reviews.py. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/17 17:48:37 UTC, 1 replies.
- Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/17 17:48:39 UTC, 13 replies.
- Review Request 69998: Reformated verify-reviews.py with yapf. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/17 17:48:44 UTC, 1 replies.
- Review Request 70001: Fixed an inaccurate comment in agent code. - posted by Qian Zhang <zh...@gmail.com> on 2019/02/18 08:15:20 UTC, 4 replies.
- Review Request 70002: Updated links to internal source files in documentation. - posted by Benno Evers <be...@mesosphere.com> on 2019/02/18 09:41:10 UTC, 2 replies.
- Re: Review Request 69972: Skipped orphan container which has no checkpointed volumes in recovery. - posted by Qian Zhang <zh...@gmail.com> on 2019/02/18 14:26:30 UTC, 2 replies.
- Review Request 70009: Exposed `memfd_create` syscall via `createMemFd` function. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/02/19 17:06:30 UTC, 2 replies.
- Review Request 70010: Store `logrotate` config in memfd file instead of container's sandbox. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/02/19 17:06:36 UTC, 4 replies.
- Review Request 70011: Modified `LOGROTATE_CustomRotateOptions` test after memfd change. - posted by Andrei Budnik <ab...@mesosphere.com> on 2019/02/19 17:06:43 UTC, 6 replies.
- Review Request 70012: Fixed type error in verify-reviews.py. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/19 20:45:03 UTC, 2 replies.
- Review Request 70014: Removed operations when removing resource providers. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/20 01:30:14 UTC, 7 replies.
- Re: Review Request 69972: Handled containers which has no checkpointed volumes during recovery. - posted by Qian Zhang <zh...@gmail.com> on 2019/02/20 06:17:26 UTC, 3 replies.
- Review Request 70016: Supported nvidia-docker 2.0 for CUDA 10+. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/20 06:26:23 UTC, 8 replies.
- Review Request 70017: Added a unit test to run Tensorflow on a GPU. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/20 06:27:02 UTC, 1 replies.
- Review Request 70018: Avoided waiting for 180s when test `NvidiaDockerImage` fails. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/20 06:27:43 UTC, 3 replies.
- Review Request 70022: Added master load tests to cmake build. - posted by Benno Evers <be...@mesosphere.com> on 2019/02/20 15:06:45 UTC, 5 replies.
- Review Request 70023: Fixed filename in warning message. - posted by Benno Evers <be...@mesosphere.com> on 2019/02/20 16:52:02 UTC, 3 replies.
- Re: Review Request 67762: Added minimum capability check during master recovery. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/20 18:46:22 UTC, 5 replies.
- Review Request 70024: Failed the scripts if `--points-at` is not supported. - posted by Jie Yu <yu...@gmail.com> on 2019/02/20 19:18:25 UTC, 1 replies.
- Review Request 70025: Blacklisted the "ubuntu-4" Jenkins box. - posted by Jie Yu <yu...@gmail.com> on 2019/02/20 19:18:48 UTC, 2 replies.
- Review Request 70026: Increased the number of review requests queried by ReviewBot to 200. - posted by Vinod Kone <vi...@apache.org> on 2019/02/20 21:25:02 UTC, 3 replies.
- Re: Review Request 69614: Reverted "Added `libacl` into a few Dockerfiles.". - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2019/02/20 22:40:46 UTC, 2 replies.
- Re: Review Request 67228: Added allocator benchmark test for various simulations. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/20 23:11:36 UTC, 0 replies.
- Re: Review Request 67825: Added a resources utility `hasShared()`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2019/02/20 23:15:25 UTC, 0 replies.
- Re: Review Request 67444: Made quota consumption tracking event-driven in the allocator. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2019/02/20 23:17:48 UTC, 1 replies.
- Re: Review Request 69411: Added new interface for constructing `cluster::Master`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2019/02/21 00:15:02 UTC, 1 replies.
- Review Request 70028: Added garbage collection of terminated operation status streams. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/21 00:21:17 UTC, 0 replies.
- Re: Review Request 67921: Bug fix for semaphore decomission "deadlock". - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 01:43:57 UTC, 0 replies.
- Re: Review Request 67968: Added logging to some containerizer destroy paths. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 04:31:45 UTC, 0 replies.
- Re: Review Request 68187: Always built shared protobuf libraries. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 10:15:29 UTC, 0 replies.
- Re: Review Request 65116: Getting Started using the Mesos Binaries. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 11:10:03 UTC, 0 replies.
- Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/21 11:33:52 UTC, 2 replies.
- Re: Review Request 68736: Added `task cat` command to new CLI. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 12:07:27 UTC, 0 replies.
- Re: Review Request 68761: Made the actors in resource providers managed by libprocess. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 13:02:21 UTC, 0 replies.
- Re: Review Request 68807: Used `Future::discard` to abort an outdated resuorce provider launches. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 15:45:44 UTC, 0 replies.
- Re: Review Request 68814: Added a test for `Option` / `Option`. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 18:13:22 UTC, 0 replies.
- Review Request 70037: Bumped SVN yum repo URL. - posted by Jie Yu <yu...@gmail.com> on 2019/02/21 19:00:26 UTC, 3 replies.
- Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 19:09:19 UTC, 0 replies.
- Re: Review Request 69287: Added test cases for the `volume/host_path` isolator. - posted by Gilbert Song <so...@gmail.com> on 2019/02/21 20:08:09 UTC, 5 replies.
- Re: Review Request 68903: Avoid deadlock-prone blocking in master's parallel endpoint serving. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 20:26:23 UTC, 0 replies.
- Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 21:46:08 UTC, 0 replies.
- Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 22:42:52 UTC, 0 replies.
- Re: Review Request 70016: Supported CUDA 10+ images that are based on nvidia-container-runtime. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/21 22:55:26 UTC, 3 replies.
- Re: Review Request 69869: Added test for tearing down frameworks while creating disks. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/22 00:08:55 UTC, 6 replies.
- Review Request 70040: Added test for terminal operation updates after master failover. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/22 00:31:17 UTC, 6 replies.
- Re: Review Request 68090: Added log_auto_compact flag to the master. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 01:14:34 UTC, 0 replies.
- Re: Review Request 69325: WIP: Fixed CSI build problems for `make distcheck`. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 04:02:14 UTC, 0 replies.
- Re: Review Request 69403: Removed empty filters in SLRP tests. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 06:57:09 UTC, 0 replies.
- Re: Review Request 69313: Enabled parallel test runner to cmake build. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 09:25:14 UTC, 0 replies.
- Re: Review Request 67185: Added request_protobuf to mesos.http. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 13:33:47 UTC, 0 replies.
- Re: Review Request 68654: Enabled isort for src/python/lib. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 16:49:13 UTC, 0 replies.
- Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 19:18:37 UTC, 0 replies.
- Re: Review Request 68785: Added jsonschema.py for managing json-based configs. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 21:50:07 UTC, 0 replies.
- Re: Review Request 69342: Added an agent flag `--volume_gid_range`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/22 22:38:41 UTC, 2 replies.
- Re: Review Request 69551: Renamed `Metrics()` function in test utils. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 22:53:46 UTC, 0 replies.
- Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/22 23:53:15 UTC, 0 replies.
- Re: Review Request 69701: Improved debuggability of `verify-reviews.py`. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/23 00:46:09 UTC, 0 replies.
- Review Request 70044: Moved status update streams of operations on agent's default resources. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/23 01:33:45 UTC, 9 replies.
- Re: Review Request 69675: Added volume gid manager. - posted by Gilbert Song <so...@gmail.com> on 2019/02/23 07:02:50 UTC, 6 replies.
- Re: Review Request 69553: Changed the definition of `uid_t` and `gid_t` to UNIT for Windows. - posted by Gilbert Song <so...@gmail.com> on 2019/02/23 07:13:38 UTC, 0 replies.
- Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor. - posted by Gilbert Song <so...@gmail.com> on 2019/02/23 07:14:36 UTC, 0 replies.
- Review Request 70045: Skipped tests when verifying `master` as part of review verification. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/23 20:18:40 UTC, 7 replies.
- Review Request 70046: Prevented closing invalid file descriptors. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/23 20:41:00 UTC, 6 replies.
- Review Request 70048: Documented the new `--host_path_volume_force_creation` agent option. - posted by Jason Lai <ja...@jasonlai.net> on 2019/02/25 01:19:50 UTC, 4 replies.
- Review Request 70047: Updated build specific artefact generation. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/02/25 01:32:48 UTC, 6 replies.
- Review Request 70049: Assured a set USER within RPM build. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/02/25 01:56:53 UTC, 5 replies.
- Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:33:13 UTC, 7 replies.
- Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:33:30 UTC, 0 replies.
- Re: Review Request 69544: Made non-root containers can access shared persistent volume. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:43:11 UTC, 5 replies.
- Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:43:27 UTC, 0 replies.
- Re: Review Request 69676: Implemented recovery for volume gid manager. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:43:51 UTC, 8 replies.
- Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:44:04 UTC, 2 replies.
- Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:44:13 UTC, 2 replies.
- Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:44:23 UTC, 2 replies.
- Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:44:31 UTC, 2 replies.
- Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:44:37 UTC, 2 replies.
- Re: Review Request 69613: Added tests for volume gid manager. - posted by Gilbert Song <so...@gmail.com> on 2019/02/25 03:44:46 UTC, 2 replies.
- Review Request 70053: Used std::string as buffer instead of manually managed dynamic array. - posted by Benjamin Bannier <be...@mesosphere.io> on 2019/02/25 21:20:05 UTC, 5 replies.
- Review Request 70054: Added FrameworkInfo.offer_filters to multi-scheduler scalability docs. - posted by Benjamin Mahler <bm...@apache.org> on 2019/02/25 22:24:33 UTC, 4 replies.
- Review Request 70055: Output Review Request URL in Reviewbot output. - posted by Vinod Kone <vi...@apache.org> on 2019/02/25 23:44:06 UTC, 1 replies.
- Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/26 21:33:44 UTC, 0 replies.
- Review Request 70060: Updated ReviewBot to catch diff updates recursively up the chain. - posted by Vinod Kone <vi...@apache.org> on 2019/02/26 23:45:32 UTC, 3 replies.
- Re: Review Request 67044: Renamed a method in the master metrics. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/27 00:10:56 UTC, 0 replies.
- Review Request 70061: Added method `fromScalarResources` in `ResourceQuantities`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/27 01:28:40 UTC, 2 replies.
- Review Request 70062: Refactored and augmented `class ResourceQuantities`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/27 01:29:12 UTC, 2 replies.
- Review Request 70063: Added test for `ResourceQuantities` arithmetic operations. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/27 01:30:41 UTC, 6 replies.
- Re: Review Request 67761: Added a new registry field `minimum_capabilities`. - posted by Joseph Wu <jo...@mesosphere.io> on 2019/02/27 01:47:17 UTC, 0 replies.
- Review Request 70067: Added star operator for `Result`, `Try` and `Option`. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/27 18:15:08 UTC, 8 replies.
- Re: Review Request 69403: Removed unnecessary filters in SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/28 00:24:54 UTC, 0 replies.
- Review Request 70069: Improved `ResourceQuantities` test's readability. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/28 01:21:44 UTC, 0 replies.
- Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/28 08:47:34 UTC, 1 replies.
- Re: Review Request 66150: WIP: Add -Werror semantics to CMake. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/28 11:03:30 UTC, 0 replies.
- Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively. - posted by Vinod Kone <vi...@apache.org> on 2019/02/28 18:53:29 UTC, 0 replies.
- Review Request 70077: Added documentation regarding downgrading a Mesos cluster. - posted by Meng Zhu <mz...@mesosphere.io> on 2019/02/28 21:56:07 UTC, 0 replies.