You are viewing a plain text version of this content. The canonical link for it is here.
- Review Request 67794: Moved `validation::healthCheck` to common code. - posted by James Peach <jp...@apache.org> on 2018/07/01 10:08:06 UTC, 5 replies.
- Review Request 67795: Moved `CheckInfo` validation to common code. - posted by James Peach <jp...@apache.org> on 2018/07/01 10:09:58 UTC, 4 replies.
- Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator. - posted by Gilbert Song <so...@gmail.com> on 2018/07/02 04:04:37 UTC, 0 replies.
- Review Request 67798: Added "old" cli to the cmake build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/02 06:03:01 UTC, 4 replies.
- Re: Review Request 67632: Always define PICOJSON_USE_INT64. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/07/02 09:14:22 UTC, 1 replies.
- Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/07/02 09:42:29 UTC, 17 replies.
- Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/07/02 10:20:05 UTC, 0 replies.
- Re: Review Request 67722: Fixed unproperly guarded future. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/07/02 13:48:36 UTC, 11 replies.
- Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/02 22:42:16 UTC, 10 replies.
- Re: Review Request 67773: Removed redundant 'toUnreserved()' call in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/02 22:43:44 UTC, 0 replies.
- Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/03 14:32:21 UTC, 4 replies.
- Review Request 67808: Added per-framework metrics for scheduler calls. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 18:58:50 UTC, 2 replies.
- Review Request 67809: Added per-framework metrics for scheduler events. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 19:06:31 UTC, 7 replies.
- Review Request 67812: Added per-framework offer metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 19:08:06 UTC, 10 replies.
- Review Request 67817: Improved logging for offers and inverse offers. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/07/03 19:16:55 UTC, 6 replies.
- Review Request 67813: Added per-framework metrics for task states. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:26:11 UTC, 7 replies.
- Review Request 67814: Added per-framework metrics for offer operations. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:27:46 UTC, 6 replies.
- Re: Review Request 66841: Added a hash function for 'Duration'. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:28:39 UTC, 2 replies.
- Re: Review Request 66842: Added per-framework metrics for offer filter durations. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:29:23 UTC, 5 replies.
- Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:29:55 UTC, 2 replies.
- Re: Review Request 67147: Included a missing header in the master metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:30:31 UTC, 3 replies.
- Review Request 67820: Fixed XfsDiskIsolatorProcess::recover() signature. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/03 21:31:09 UTC, 2 replies.
- Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/03 21:31:11 UTC, 4 replies.
- Re: Review Request 66844: Added framework metrics for filtered resources to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:31:53 UTC, 1 replies.
- Re: Review Request 66855: Changed the 'capacity_' member of 'BoundedHashMap' to non-const. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:32:31 UTC, 2 replies.
- Re: Review Request 66861: Added per-framework DRF position metrics to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:33:30 UTC, 2 replies.
- Re: Review Request 66856: Tracked completed framework metrics in the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:35:27 UTC, 7 replies.
- Re: Review Request 66870: Added per-framework metrics for suppressed roles. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:38:20 UTC, 10 replies.
- Re: Review Request 66883: Added/updated tests to check per-framework metrics. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/07/03 21:39:17 UTC, 2 replies.
- Re: Review Request 66874: Added per-framework metrics for active task states. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:39:49 UTC, 0 replies.
- Re: Review Request 67187: Tested per-framework task state metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:40:44 UTC, 13 replies.
- Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:41:42 UTC, 2 replies.
- Review Request 67822: Avoid duplicate unmount dangling mount point. - posted by Zhitao Li <zh...@gmail.com> on 2018/07/03 22:08:41 UTC, 3 replies.
- Review Request 67823: Added a master benchmark test for metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/03 22:33:11 UTC, 11 replies.
- Review Request 67824: Reduced likelihood of a stack overflow in libprocess socket recv path. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/04 00:06:50 UTC, 1 replies.
- Review Request 67826: Made `Slave::getAvailable()` return all shared resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/04 00:57:37 UTC, 7 replies.
- Review Request 67825: Added a resources utility `hasShared()`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/04 00:57:52 UTC, 1 replies.
- Review Request 67827: Added a helper `stripIncapableResources` in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/04 01:01:00 UTC, 13 replies.
- Re: Review Request 67488: Updated CLI to Python 3. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/07/04 13:10:50 UTC, 19 replies.
- Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am. - posted by Kevin Klues <kl...@gmail.com> on 2018/07/04 14:31:18 UTC, 0 replies.
- Review Request 67830: Moved `executor::Call` validation to common validation library. - posted by James Peach <jp...@apache.org> on 2018/07/05 06:17:22 UTC, 3 replies.
- Review Request 67832: Changed docker subprocess calls to use exec form. - posted by Akash Gupta <ak...@hotmail.com> on 2018/07/05 09:16:05 UTC, 4 replies.
- Re: Review Request 67444: Persisted role consumed quota info in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/05 21:22:09 UTC, 1 replies.
- Re: Review Request 67820: Fixed recover() virtual method signature in several isolators. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/05 21:31:57 UTC, 4 replies.
- Re: Review Request 67821: Added override specifiers to virtual methods of several isolators. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/05 21:32:06 UTC, 1 replies.
- Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/05 21:55:40 UTC, 6 replies.
- Re: Review Request 67671: Prevented resource providers from changing their name or type. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/05 22:47:01 UTC, 6 replies.
- Re: Review Request 65875: Improved logging for offers and inverse offers. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/07/06 08:32:11 UTC, 0 replies.
- Review Request 67840: Renamed committer checklist into committer guidelines. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/07/06 08:50:06 UTC, 0 replies.
- Review Request 67841: Updated committer candidate guidelines. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/07/06 08:50:19 UTC, 1 replies.
- Review Request 67842: Refactored base of Python CLI tests. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/06 10:02:53 UTC, 5 replies.
- Re: Review Request 66819: Added FrameworkMetrics struct in framework struct. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/06 17:45:44 UTC, 2 replies.
- Re: Review Request 66823: Added per framework metrics for framework events. - posted by Gilbert Song <so...@gmail.com> on 2018/07/06 18:02:22 UTC, 2 replies.
- Re: Review Request 67786: Added per framework metrics for framework events. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/06 18:02:58 UTC, 0 replies.
- Re: Review Request 66845: Made per-framework metrics count heartbeat events. - posted by Gilbert Song <so...@gmail.com> on 2018/07/06 18:03:19 UTC, 0 replies.
- Review Request 67810: Added per-framework offer metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/06 18:03:40 UTC, 0 replies.
- Review Request 67811: Added per-framework offer metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/06 18:04:03 UTC, 0 replies.
- Re: Review Request 66822: Added per Framework Calls to metrics. - posted by Gilbert Song <so...@gmail.com> on 2018/07/06 18:05:46 UTC, 2 replies.
- Re: Review Request 67776: Added per-framework metrics for scheduler calls. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/06 18:06:41 UTC, 8 replies.
- Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/07/06 18:58:21 UTC, 0 replies.
- Review Request 67847: Fixed installation of storage disk profile adaptor header. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/06 20:50:30 UTC, 1 replies.
- Review Request 67848: Installed CSI bindings as part of Mesos. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/06 20:50:32 UTC, 1 replies.
- Review Request 67849: Made some CSI-related utility headers public. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/06 20:50:33 UTC, 3 replies.
- Re: Review Request 65640: Fixed a race condition in `UriDiskProfileAdaptorTests`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:23:37 UTC, 0 replies.
- Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:24:36 UTC, 4 replies.
- Re: Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:25:07 UTC, 0 replies.
- Re: Review Request 67666: Added a `TestDiskProfileServer` helper. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:25:55 UTC, 0 replies.
- Re: Review Request 67669: Allow resources to be removed when updating the sorter. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:27:38 UTC, 8 replies.
- Re: Review Request 67670: Added a unit test for disappeared profiles. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:30:13 UTC, 3 replies.
- Re: Review Request 67739: Documented the container-specific cgroups mounts feature. - posted by Gilbert Song <so...@gmail.com> on 2018/07/07 01:20:49 UTC, 0 replies.
- Review Request 67853: Updated build-virtualenv to use Python 3 features. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/09 10:33:18 UTC, 4 replies.
- Review Request 67855: Added virtualenv requirements watcher to Python 3 mesos-style.py. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/09 10:35:03 UTC, 2 replies.
- Review Request 67856: Updated Python virtual environment dependencies. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/09 10:38:59 UTC, 2 replies.
- Review Request 67857: Improved release policy documentation visibility. - posted by James Peach <jp...@apache.org> on 2018/07/09 20:29:49 UTC, 2 replies.
- Review Request 67859: Updated apply-reviews.py messaging for submitted reviews. - posted by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/07/09 23:46:36 UTC, 3 replies.
- Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/10 01:40:48 UTC, 6 replies.
- Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 03:10:59 UTC, 8 replies.
- Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 03:11:53 UTC, 6 replies.
- Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 03:12:44 UTC, 11 replies.
- Review Request 67866: Apply the `override` keyword to stout. - posted by James Peach <jp...@apache.org> on 2018/07/10 03:30:54 UTC, 5 replies.
- Review Request 67867: Apply the `override` keyword to libprocess. - posted by James Peach <jp...@apache.org> on 2018/07/10 03:31:10 UTC, 5 replies.
- Review Request 67868: Apply the `override` keyword to Mesos. - posted by James Peach <jp...@apache.org> on 2018/07/10 03:35:45 UTC, 5 replies.
- Review Request 67869: Add use of `override` to the Mesos C++ style guide. - posted by James Peach <jp...@apache.org> on 2018/07/10 03:36:41 UTC, 8 replies.
- Review Request 67870: Fixed an incorrect type in the master's metrics code. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/10 06:01:40 UTC, 5 replies.
- Review Request 67871: Optimized the generation of metrics snapshots. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/10 06:20:41 UTC, 19 replies.
- Review Request 67872: Added a stout helper to percent-encode strings. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/10 06:49:52 UTC, 0 replies.
- Re: Review Request 67502: Refactored API functionality into separate module - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/10 09:51:09 UTC, 1 replies.
- Re: Review Request 67503: Added helper for fetching review id - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/10 11:48:40 UTC, 0 replies.
- Re: Review Request 67504: Added helper for posting the result of a build - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/10 12:26:41 UTC, 0 replies.
- Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/10 12:49:52 UTC, 0 replies.
- Review Request 67875: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/10 15:39:43 UTC, 2 replies.
- Re: Review Request 67730: Made Git normalize all line endings automatically. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/10 17:31:00 UTC, 6 replies.
- Re: Review Request 67669: Allowed resources to be removed when updating the sorter. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 20:31:22 UTC, 1 replies.
- Review Request 67877: Added a metrics scalability benchmark in libprocess. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/10 20:51:08 UTC, 8 replies.
- Review Request 67876: Allowed resources to be removed in the hierarchical allocator. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 21:13:15 UTC, 2 replies.
- Review Request 67878: Added/updated tests to check per-framework metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/10 21:25:23 UTC, 5 replies.
- Re: Review Request 66048: Added missing comment on a test case. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 22:56:57 UTC, 1 replies.
- Review Request 67881: Fixed the error log in POSIX `os::rmdir`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 23:14:47 UTC, 2 replies.
- Re: Review Request 67502: Refactored API functionality into separate module. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/11 11:52:37 UTC, 1 replies.
- Re: Review Request 67503: Added helper for fetching review id. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/11 11:52:40 UTC, 1 replies.
- Re: Review Request 67504: Added helper for posting the result of a build. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/11 11:54:06 UTC, 0 replies.
- Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/11 11:54:10 UTC, 4 replies.
- Review Request 67889: Installed google's signal handler for libprocess benchmarks. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/11 22:51:56 UTC, 1 replies.
- Review Request 67890: Updated metrics add / remove to avoid double lookups. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/11 22:53:36 UTC, 4 replies.
- Re: Review Request 65112: Added documentation about standalone containers. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/11 23:19:45 UTC, 1 replies.
- Review Request 67891: Added multi-framework scalability guidelines to the documentation. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/12 03:33:30 UTC, 8 replies.
- Review Request 67892: Made disk type checks in SLRP hard assertions. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/12 04:57:05 UTC, 2 replies.
- Review Request 67893: Updated site's sprockets package. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/12 07:07:52 UTC, 3 replies.
- Review Request 67894: Migrated mesos python package to python3.6. - posted by Eric Chung <ci...@gmail.com> on 2018/07/12 08:09:03 UTC, 2 replies.
- Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/12 14:16:04 UTC, 4 replies.
- Review Request 67897: Updated two tests to verfiy freezer subsystem. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/12 14:17:08 UTC, 3 replies.
- Re: Review Request 67870: Avoided implicit construction of a hashmap in the metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/12 18:17:30 UTC, 1 replies.
- Review Request 67882: Windows: Made `int_fd` cast operators explicit. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/12 19:10:46 UTC, 1 replies.
- Review Request 67883: Windows: Explicitly cast to `SOCKET`/`HANDLE` where appropriate. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/12 19:10:59 UTC, 1 replies.
- Review Request 67884: Windows: Explicitly cast to `SOCKET` where appropriate. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/12 19:11:50 UTC, 1 replies.
- Review Request 67900: Fixed compilation error with `DispatchProcess` code. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/12 20:35:58 UTC, 5 replies.
- Review Request 67901: Removed outdated comments regarding `Slave::executorTerminated`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/12 23:01:14 UTC, 1 replies.
- Review Request 67905: Added missing anchor. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/13 07:22:12 UTC, 2 replies.
- Review Request 67904: Fixed documentation links. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/13 07:22:14 UTC, 1 replies.
- Review Request 67903: Fixed breadcrumb links in site templates. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/13 07:22:14 UTC, 1 replies.
- Review Request 67906: Updated tox usage in mesos-style.py to run in support virtualenv. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/13 08:20:23 UTC, 2 replies.
- Review Request 67907: Updated pylint usage in mesos-style.py to be less verbose. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/13 11:20:00 UTC, 1 replies.
- Review Request 67910: Fixed virtualenv management in support directory. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/13 16:22:04 UTC, 3 replies.
- Review Request 67911: Fixed `build-virtualenv` to correctly clear virtual environment. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/07/13 16:37:57 UTC, 1 replies.
- Review Request 67915: Factored out ROOT_XFS_TestBase::getSandboxes(). - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/13 20:54:44 UTC, 1 replies.
- Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/13 20:54:49 UTC, 16 replies.
- Review Request 67916: Patched Google Test with upstream bugfix. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/13 21:04:46 UTC, 12 replies.
- Review Request 67918: Updated documentation for `CREATE_DISK` and `DESTROY_DISK`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/13 22:23:28 UTC, 3 replies.
- Review Request 67921: Bug fix for semaphore decomission "deadlock". - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/15 17:09:33 UTC, 3 replies.
- Review Request 67922: Removed unused `TestStore` mock. - posted by James Peach <jp...@apache.org> on 2018/07/16 00:27:16 UTC, 4 replies.
- Review Request 67923: Improved performance of cgroups::read by verifying after failure. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/16 02:03:43 UTC, 5 replies.
- Review Request 67924: Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/16 11:23:38 UTC, 2 replies.
- Review Request 67925: Fixed image link in docker volume isolator docs. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/16 12:13:28 UTC, 2 replies.
- Review Request 67927: Removed unneeded lambda capture. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/16 12:37:37 UTC, 2 replies.
- Review Request 67928: Added balloon framework metric for tasks which were running. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/16 14:48:03 UTC, 6 replies.
- Review Request 67930: Get tests ready for Windows UCR development. - posted by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/07/16 18:35:05 UTC, 6 replies.
- Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers. - posted by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/07/16 18:35:35 UTC, 15 replies.
- Review Request 67931: Support Image Manifest Version 2 Schema 2. - posted by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/07/16 18:35:50 UTC, 13 replies.
- Re: Review Request 67927: Removed potentially unneeded lambda capture. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/16 19:22:04 UTC, 2 replies.
- Review Request 67933: Replaced `` with `` in stout. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/16 21:43:38 UTC, 1 replies.
- Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/16 23:14:17 UTC, 7 replies.
- Review Request 67938: Made gRPC call options configurable. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/17 01:21:26 UTC, 4 replies.
- Review Request 67945: Made getters in the Slave class in the allocator return references. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/17 19:18:30 UTC, 3 replies.
- Review Request 67947: Passed the default options when making gRPC calls. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/17 20:21:11 UTC, 2 replies.
- Review Request 67950: Disabled override warnings for mocked methods. - posted by James Peach <jp...@apache.org> on 2018/07/17 21:54:59 UTC, 1 replies.
- Review Request 67951: Added optional `path_separator` parameter to `Path` constructor. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/17 22:27:31 UTC, 5 replies.
- Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/17 22:27:43 UTC, 5 replies.
- Review Request 67953: Disabled the clang `-Winconsistent-missing-override` warning. - posted by James Peach <jp...@apache.org> on 2018/07/18 00:05:34 UTC, 2 replies.
- Review Request 67955: Added some new generic flag parsers. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:19:47 UTC, 2 replies.
- Review Request 67956: Removed some generic flag parsers that are now in stout. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:19:49 UTC, 1 replies.
- Review Request 67957: Refactored TemporaryDirectoryTest to be a mixin. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:19:54 UTC, 0 replies.
- Review Request 67958: Added LibprocessTest for easily configuring the library for a test. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:19:56 UTC, 0 replies.
- Review Request 67959: Added support for instrumenting processes. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:20:01 UTC, 0 replies.
- Review Request 67960: Added support for instrumenting HTTP endpoints. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:20:05 UTC, 1 replies.
- Review Request 67962: Enabled per-framework metrics in the master. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/18 01:23:42 UTC, 1 replies.
- Re: Review Request 66820: Added per-framework 'subscribed' metric and helpers. - posted by Gilbert Song <so...@gmail.com> on 2018/07/18 01:33:31 UTC, 1 replies.
- Re: Review Request 66843: Enabled per-framework metrics in the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/18 01:43:34 UTC, 1 replies.
- Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/18 08:50:36 UTC, 2 replies.
- Re: Review Request 67503: Added support helper for fetching review ids. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/18 08:50:50 UTC, 1 replies.
- Re: Review Request 67504: Added support script to post build results. - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/07/18 08:50:53 UTC, 2 replies.
- Review Request 67963: Added missing header to libprocess build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/18 09:04:15 UTC, 1 replies.
- Review Request 67965: Optimized ranges subtraction operation. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/18 18:29:33 UTC, 10 replies.
- Review Request 67968: Added logging to some containerizer destroy paths. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/18 20:48:04 UTC, 1 replies.
- Review Request 67972: RFC: Added RetentionPolicy for task metadata and sandboxes. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/07/19 12:59:09 UTC, 1 replies.
- Review Request 67976: Windows: Added `nullptr` checks when using `libwinio_loop` pointer. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/19 20:43:15 UTC, 1 replies.
- Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/19 20:44:09 UTC, 2 replies.
- Review Request 67978: Windows: Enabled `RemoteLink` tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/19 20:44:29 UTC, 1 replies.
- Review Request 67979: Windows: Documented why the `RemoteLinkLeak` test is not enabled. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/19 20:46:40 UTC, 1 replies.
- Review Request 67980: Windows: Enabled rest of `ProcessTest` suite. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/19 20:47:16 UTC, 4 replies.
- Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`. - posted by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/07/20 00:06:13 UTC, 3 replies.
- Review Request 67985: Added rapidjson to the stout build. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:50 UTC, 2 replies.
- Review Request 67986: Added rapidjson to the libprocess build. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:51 UTC, 2 replies.
- Review Request 67987: Added rapidjson to the mesos build. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:53 UTC, 14 replies.
- Review Request 67988: Improved performance of jsonify by integrating with rapidjson. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:54 UTC, 7 replies.
- Review Request 67989: Fixed issues with the JSON serialization tests. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:56 UTC, 1 replies.
- Review Request 67990: Fixed libprocess tests against rapidjson. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:57 UTC, 4 replies.
- Review Request 67991: Adjusted Mesos to compile against jsonify rapidjson changes. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:59 UTC, 3 replies.
- Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:39:01 UTC, 3 replies.
- Review Request 67993: Avoid resource copying while serving state json. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/20 05:23:03 UTC, 3 replies.
- Review Request 67994: Extended log message for assertion. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/20 07:01:27 UTC, 2 replies.
- Review Request 67995: Normalized paths passed to mesos-style. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/20 07:07:18 UTC, 2 replies.
- Re: Review Request 66814: Added a test `FsAclTest.ManipulateAcl`. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/20 08:13:37 UTC, 0 replies.
- Review Request 67996: Granted container user permissions for SANDBOX volume of PARENT type. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/20 08:19:04 UTC, 2 replies.
- Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/20 08:21:16 UTC, 1 replies.
- Re: Review Request 67751: WIP: Added missing files to CMake build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/20 10:00:16 UTC, 0 replies.
- Review Request 67998: Improved cmake missing files check script. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/20 10:08:01 UTC, 2 replies.
- Review Request 67983: Enabled `TimeTest.Now` on Windows. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/20 17:19:02 UTC, 3 replies.
- Re: Review Request 68001: Fix padding in MpscLinkedQueue. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/07/20 18:00:07 UTC, 12 replies.
- Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty libraries. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:56:02 UTC, 0 replies.
- Review Request 68016: Added libseccomp to the build. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:56:12 UTC, 1 replies.
- Review Request 68017: Added Seccomp-related protobuf messages. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:56:20 UTC, 0 replies.
- Review Request 68018: Added `SeccompFilter` class. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:56:26 UTC, 0 replies.
- Review Request 68019: Added a parser for the Docker Seccomp config format. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:56:50 UTC, 0 replies.
- Review Request 68020: Added new `--seccomp_config_dir` flag to the agent. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:56:57 UTC, 0 replies.
- Review Request 68021: Added `linux/seccomp` isolator. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:57:07 UTC, 0 replies.
- Review Request 68022: Enabled Seccomp filter in the containerizer launcher. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/07/23 13:57:13 UTC, 2 replies.
- Review Request 68029: Updated XFS disk isolator docs. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/24 00:43:15 UTC, 8 replies.
- Review Request 68030: Fixed a linking issue with gRPC. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/07/24 10:49:26 UTC, 5 replies.
- Review Request 68033: Fixed flaky test `DefaultExecutorTest.TaskWithFileURI`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/24 17:28:26 UTC, 2 replies.
- Review Request 68039: Padded using the type name in `MpscLinkedQueue`. - posted by James Peach <jp...@apache.org> on 2018/07/25 14:42:31 UTC, 2 replies.
- Review Request 68040: Added a new method `getDefaultBackend()` to the provisioner. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/25 14:44:28 UTC, 0 replies.
- Review Request 68041: Granted container user permissions for IMAGE volume. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/25 14:46:43 UTC, 0 replies.
- Review Request 68043: Added test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithoutRootFilesystem`. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/25 14:48:02 UTC, 0 replies.
- Review Request 68044: Added a test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/25 14:48:55 UTC, 2 replies.
- Re: Review Request 67878: Updated tests to check per-framework metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/25 15:36:10 UTC, 3 replies.
- Review Request 68048: Added documentation for per-framework metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/25 23:06:59 UTC, 3 replies.
- Review Request 68049: Added pause and resume helpers to the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/25 23:35:52 UTC, 0 replies.
- Review Request 68050: WIP: Refactored allocator performance benchmarks. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/25 23:50:43 UTC, 2 replies.
- Review Request 68051: Added Sergey Urbanovich to the contributor list. - posted by Sergey Urbanovich <se...@gmail.com> on 2018/07/26 05:35:03 UTC, 1 replies.
- Review Request 68052: Discard the queue's promises in the destructor. - posted by Sergey Urbanovich <se...@gmail.com> on 2018/07/26 05:39:12 UTC, 3 replies.
- Review Request 68053: Call any function in a specified namespace. - posted by Sergey Urbanovich <se...@gmail.com> on 2018/07/26 05:41:24 UTC, 5 replies.
- Review Request 68054: Added networking statistics to cni isolator. - posted by Sergey Urbanovich <se...@gmail.com> on 2018/07/26 05:42:55 UTC, 7 replies.
- Re: Review Request 67602: Improve the debug logging in mesos container - posted by CHEN RUNCONG <ch...@163.com> on 2018/07/26 08:21:23 UTC, 0 replies.
- Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor. - posted by Benno Evers <be...@mesosphere.com> on 2018/07/26 10:17:05 UTC, 4 replies.
- Review Request 68065: Enabled garbage collection of terminated tasks' metadata. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:56 UTC, 1 replies.
- Review Request 68066: Shared GC actor between Agent and MesosContainerizer. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:58 UTC, 0 replies.
- Review Request 68068: Added tests for task metadata GC using the default executor. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:59 UTC, 4 replies.
- Review Request 68067: Added flag to control GC-ing of nested container sandboxes. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:59 UTC, 4 replies.
- Review Request 68073: Fixed rapidjson cmake compilation. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/26 23:34:55 UTC, 2 replies.
- Review Request 68074: Enabled gRPC compilation by default. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/26 23:37:50 UTC, 1 replies.
- Review Request 68082: Clarified instructions in docs. - posted by Benno Evers <be...@mesosphere.com> on 2018/07/27 14:14:46 UTC, 2 replies.
- Review Request 68085: Extended a v1 test helper. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/27 16:23:56 UTC, 1 replies.
- Review Request 68087: Added new agent flag `cgroups_destroy_timeout`. - posted by Zhitao Li <zh...@gmail.com> on 2018/07/27 18:15:52 UTC, 0 replies.
- Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with agent flag. - posted by Zhitao Li <zh...@gmail.com> on 2018/07/27 18:16:53 UTC, 1 replies.
- Review Request 68091: Always build gRPC in libprocess. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/27 19:07:50 UTC, 1 replies.
- Re: Review Request 67751: Add missing files to CMake build. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/27 19:10:29 UTC, 1 replies.
- Review Request 68093: Add XFS disk isolator files to CMake. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/27 19:11:11 UTC, 0 replies.
- Review Request 68094: Add port mapping and network ports isolators sources to CMake. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/27 19:11:46 UTC, 3 replies.
- Re: Review Request 68074: Autotools: Always build gRPC in Mesos. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/27 19:12:31 UTC, 2 replies.
- Review Request 68092: CMake: Always build gRPC in Mesos. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/27 19:12:41 UTC, 3 replies.
- Review Request 68089: Added LevelDB compaction after replicated log truncation. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/27 20:12:04 UTC, 0 replies.
- Review Request 68090: Added log_auto_compact flag to the master. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/07/27 20:12:08 UTC, 1 replies.
- Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/07/28 00:22:22 UTC, 1 replies.
- Review Request 68098: Fixed rapidjson make install directory structure. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/29 21:46:25 UTC, 4 replies.
- Review Request 68103: Added an authorizer action for viewing of resource provider information. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/30 08:57:28 UTC, 3 replies.
- Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROROVIDER` calls. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/30 08:57:29 UTC, 1 replies.
- Review Request 68105: WIP: Bumped bundled zookeeper. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/07/30 09:06:27 UTC, 1 replies.
- Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag. - posted by Zhitao Li <zh...@gmail.com> on 2018/07/30 17:50:27 UTC, 2 replies.
- Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/07/30 20:12:04 UTC, 12 replies.
- Review Request 68114: Fixed a gRPC compilation issue for Clang. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/31 00:06:00 UTC, 2 replies.
- Review Request 68120: UI: Pull up the leader URL generation to a top-level function. - posted by Benjamin Mahler <bm...@apache.org> on 2018/07/31 02:40:22 UTC, 5 replies.
- Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/31 03:38:45 UTC, 5 replies.
- Review Request 68118: Introduced helpers to track agent resources in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 05:17:11 UTC, 0 replies.
- Review Request 68119: Introduced a helper `updateSlaveResources` in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 05:17:18 UTC, 0 replies.
- Review Request 68122: Fixed couple of typos in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 05:17:21 UTC, 0 replies.
- Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 05:17:26 UTC, 1 replies.
- Review Request 68125: Granted container user permissions for DOCKER_VOLUME volume. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/31 08:31:58 UTC, 0 replies.
- Review Request 68126: Added a test `ROOT_UNPRIVILEGED_USER_CommandTaskNoRootfsWithVolume`. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/31 08:33:21 UTC, 0 replies.
- Review Request 68127: Add `ROOT_INTERNET_CURL_UNPRIVILEGED_USER_CommandTaskRootfsWithVolume`. - posted by Qian Zhang <zh...@gmail.com> on 2018/07/31 08:35:38 UTC, 1 replies.
- Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/07/31 13:39:53 UTC, 0 replies.
- Review Request 68132: Batch '/state' requests on Master. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/07/31 13:39:56 UTC, 4 replies.
- Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration. - posted by Greg Mann <gr...@mesosphere.io> on 2018/07/31 18:57:35 UTC, 0 replies.
- Re: Review Request 67444: Made quota consumption tracking event-driven in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/07/31 23:56:55 UTC, 1 replies.