You are viewing a plain text version of this content. The canonical link for it is here.

---

- Re: Review Request 67371: Introduced a random sorter as an alternative to the DRF sorter. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/01 00:26:33 UTC, 1 replies.
- Re: Review Request 65666: Added a unit test for SLRP operation state metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/01 00:45:56 UTC, 0 replies.
- Re: Review Request 67256: Added a unit test for CSI plugin RPC metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/01 00:47:37 UTC, 0 replies.
- Re: Review Request 67257: Fixed filters in test `ROOT_ReconcileDroppedOperation` for consistency. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/01 00:48:35 UTC, 0 replies.
- Re: Review Request 67395: Fixed socket creation bug in docker.cpp. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/06/01 00:56:26 UTC, 1 replies.
- Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/01 01:44:33 UTC, 7 replies.
- Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/06/01 02:53:36 UTC, 0 replies.
- Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/01 03:00:04 UTC, 5 replies.
- Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/01 03:00:23 UTC, 2 replies.
- Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/01 03:28:31 UTC, 9 replies.
- Re: Review Request 67185: Added request_protobuf to mesos.http. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/06/01 05:03:24 UTC, 4 replies.
- Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger. - posted by Gilbert Song <so...@gmail.com> on 2018/06/01 05:59:50 UTC, 0 replies.
- Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/06/01 07:23:17 UTC, 3 replies.
- Re: Review Request 67403: Handled race condition when removing maintenance windows. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/06/01 09:36:12 UTC, 8 replies.
- Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/06/01 12:01:09 UTC, 1 replies.
- Review Request 67411: Broadened check for Autotools Python environment variables. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/01 15:06:37 UTC, 4 replies.
- Review Request 67414: Added default message bodies to libprocess HTTP error responses. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/01 15:14:23 UTC, 6 replies.
- Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/01 15:14:52 UTC, 4 replies.
- Review Request 67413: Added `PYTHON_2` and `PYTHON_3` environment variables in `configure.ac`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/01 15:21:50 UTC, 3 replies.
- Re: Review Request 67344: WIP: Made disk allocatable on their own. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/01 15:41:13 UTC, 2 replies.
- Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/01 15:55:07 UTC, 12 replies.
- Re: Review Request 67373: Added typedefs for using the allocator with random sorters. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/01 20:13:26 UTC, 0 replies.
- Re: Review Request 67374: Updated flags to support choosing the random sorter. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/01 20:53:58 UTC, 1 replies.
- Re: Review Request 67372: Updated sorter tests to run against multiple sorters where possible. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/01 21:37:48 UTC, 1 replies.
- Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/06/01 21:58:43 UTC, 3 replies.
- Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/06/01 21:58:52 UTC, 5 replies.
- Re: Review Request 67390: Windows: Integrated libwinio with libprocess code. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/06/01 23:09:10 UTC, 5 replies.
- Review Request 67421: Added a test for verifying GC can handle dangling persistent volume. - posted by Zhitao Li <zh...@gmail.com> on 2018/06/02 01:23:56 UTC, 4 replies.
- Review Request 67423: Skipped metric for non existing paths in gc. - posted by Zhitao Li <zh...@gmail.com> on 2018/06/02 05:30:31 UTC, 4 replies.
- Re: Review Request 67369: Introduced a weighted shuffle algorithm implementation. - posted by Benjamin Mahler <bm...@apache.org> on 2018/06/03 01:25:34 UTC, 0 replies.
- Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys. - posted by Clement Michaud <cl...@gmail.com> on 2018/06/03 09:55:23 UTC, 6 replies.
- Review Request 67431: Removed unused libprocess test tools. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/04 08:36:44 UTC, 3 replies.
- Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/06/04 13:40:24 UTC, 0 replies.
- Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/04 20:49:57 UTC, 0 replies.
- Review Request 67441: Testing windows reviewbot utf8 handling. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/06/04 22:34:01 UTC, 2 replies.
- Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/04 23:42:38 UTC, 4 replies.
- Re: Review Request 67388: Moved: `io::internal::read/write` to separate file. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/04 23:53:57 UTC, 1 replies.
- Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/05 19:06:20 UTC, 4 replies.
- Review Request 67454: Fixed failing ArchiverTest due to long filename. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/06/05 19:09:22 UTC, 2 replies.
- Review Request 67455: Windows: Fixed incorrect return code for `os:kill`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/05 20:34:43 UTC, 1 replies.
- Review Request 67456: Windows: Wrapped docker executor code in job object. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/05 20:38:32 UTC, 1 replies.
- Review Request 67457: Windows: Ported docker_containerizer_tests.cpp. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/05 20:40:00 UTC, 9 replies.
- Review Request 67463: Fixed type error when using `check_output` in Python 3 scripts. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/05 22:22:35 UTC, 3 replies.
- Review Request 67464: Fixed `python3/mesos-style.py`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/05 23:15:40 UTC, 3 replies.
- Review Request 67465: Windows: Log a fatal error if `WindowsFD(int)` is incorrectly used. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/05 23:16:26 UTC, 6 replies.
- Re: Review Request 67460: Enable stouttest EnvTest.EraseEnv. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/06/05 23:31:11 UTC, 1 replies.
- Re: Review Request 67264: Unmounted any mount points in gc paths. - posted by Zhitao Li <zh...@gmail.com> on 2018/06/06 00:07:49 UTC, 5 replies.
- Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior. - posted by Zhitao Li <zh...@gmail.com> on 2018/06/06 00:08:46 UTC, 6 replies.
- Re: Review Request 67389: Windows: Implemented Windows IOCP async backend. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/06 00:31:15 UTC, 3 replies.
- Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/06 07:41:27 UTC, 3 replies.
- Re: Review Request 67357: Added constant time comparison of JWT signatures. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/06/06 08:20:17 UTC, 9 replies.
- Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 08:31:28 UTC, 2 replies.
- Re: Review Request 66559: Made agent flag '--hadoop_home' as optional. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 08:40:14 UTC, 0 replies.
- Re: Review Request 66650: Removed an invalid TODO in puller.cpp. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 08:40:39 UTC, 1 replies.
- Re: Review Request 66651: Supported host and port in hdfs constructor. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 08:42:07 UTC, 1 replies.
- Re: Review Request 66561: Supported hdfs fetching in local puller. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 08:43:03 UTC, 4 replies.
- Re: Review Request 66652: Renamed local_puller to image_tar_puller. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 08:44:04 UTC, 2 replies.
- Re: Review Request 67223: Used move constructors for making CSI gRPC calls. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/06 09:46:33 UTC, 6 replies.
- Review Request 67476: Added guideline for contributions modifying Makefile.am. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/06/06 13:56:51 UTC, 3 replies.
- Review Request 67478: Addition to contributors.yaml in peparation for submitting an actual patch - posted by Kjetil Joergensen <kj...@gmail.com> on 2018/06/06 18:02:22 UTC, 1 replies.
- Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`. - posted by Gilbert Song <so...@gmail.com> on 2018/06/06 23:37:09 UTC, 1 replies.
- Review Request 67487: Used new Python environment variables in configure.ac and Makefile.am. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/07 14:07:50 UTC, 2 replies.
- Review Request 67489: Docker::__pull - docker pull stdout to /dev/null to avoid deadlock - posted by Kjetil Joergensen <kj...@gmail.com> on 2018/06/07 17:43:43 UTC, 2 replies.
- Re: Review Request 67494: Add notes against disabled tests and enbale RemoveWithContinueOnError. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/06/07 23:06:10 UTC, 1 replies.
- Review Request 67496: Ported `EnvTest.EraseEnv` to Windows, with added comments. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/07 23:19:40 UTC, 4 replies.
- Review Request 67501: Added authorization for resource provider operations. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/06/08 10:50:20 UTC, 2 replies.
- Review Request 67502: Refactored API functionality into separate module - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:43 UTC, 2 replies.
- Review Request 67503: Added helper for fetching review id - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:43 UTC, 2 replies.
- Review Request 67504: Added helper for posting the result of a build - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:44 UTC, 2 replies.
- Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse - posted by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:46 UTC, 6 replies.
- Re: Review Request 67335: Added `windows/cpu` and `windows/mem` isolators into `agent.md`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 17:26:15 UTC, 0 replies.
- Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 17:29:28 UTC, 2 replies.
- Re: Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 17:38:06 UTC, 2 replies.
- Re: Review Request 67387: Updated Mesos code to use `io::prepare_async`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 17:38:47 UTC, 2 replies.
- Re: Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 22:58:54 UTC, 3 replies.
- Re: Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 22:59:26 UTC, 0 replies.
- Re: Review Request 67393: Windows: Ported io_tests.cpp. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/08 23:06:01 UTC, 0 replies.
- Re: Review Request 67286: White list fds that child processes can inherit in stout. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/09 01:28:27 UTC, 4 replies.
- Re: Review Request 67287: White list fds that child processes can inherit in libprocess. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/09 01:30:04 UTC, 5 replies.
- Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/09 01:34:05 UTC, 10 replies.
- Review Request 67522: Moved some constant definitions into header file. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/11 09:58:48 UTC, 3 replies.
- Review Request 67521: Made some headers standalone. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/11 09:58:48 UTC, 3 replies.
- Review Request 67525: Removed static variable with non-constant initialization. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/11 12:36:47 UTC, 7 replies.
- Review Request 67526: WIP: Added container-specific cgroup FS mounts. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/11 15:58:54 UTC, 2 replies.
- Review Request 67510: Fixed a bug in `createStrippedScalarQuantity()`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 17:30:05 UTC, 2 replies.
- Review Request 67516: Added a resource utility `isScalarQuantity`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 17:34:06 UTC, 3 replies.
- Review Request 67532: Removed superfluous guard around `signals.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/11 20:12:24 UTC, 2 replies.
- Review Request 67533: Removed superfluous guard around `signals.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/11 20:12:36 UTC, 2 replies.
- Review Request 67513: Added a master flag to configure minimum allocatable resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 21:37:45 UTC, 9 replies.
- Review Request 67517: Added a test to verify `min_allocatable_resources` flag. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 21:41:48 UTC, 12 replies.
- Review Request 67534: CMake: Added libapr as interface dependency of libsvn. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/11 21:57:31 UTC, 3 replies.
- Review Request 67535: CMake: Removed explicit linkage of libapr. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/11 21:57:38 UTC, 3 replies.
- Review Request 67541: Made `NoopResourceEstimator` return a forever-pending future. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/11 23:51:22 UTC, 2 replies.
- Review Request 67538: Add zhengbin. - posted by bin zheng <zh...@chinaunicom.cn> on 2018/06/12 05:46:09 UTC, 3 replies.
- Review Request 67542: submmit my user information - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/12 05:52:30 UTC, 3 replies.
- Re: Review Request 67538: Added Bin Zheng to the contributors list. - posted by bin zheng <zh...@chinaunicom.cn> on 2018/06/12 06:36:11 UTC, 2 replies.
- Re: Review Request 67413: Added `PYTHON_3` and `PYTHON_3_VERSION` variables in `configure.ac`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/12 13:46:57 UTC, 0 replies.
- Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/12 14:51:12 UTC, 2 replies.
- Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/06/12 15:17:11 UTC, 4 replies.
- Review Request 67546: Moved RecordIO documentation into separate file. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/12 16:08:01 UTC, 2 replies.
- Review Request 67547: Added check for API endpoints not supporting streaming responses. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/12 16:08:06 UTC, 7 replies.
- Review Request 67488: Updated CLI to Python 3. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/06/12 16:30:00 UTC, 11 replies.
- Review Request 67549: modify my user information - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/12 17:18:53 UTC, 3 replies.
- Review Request 67552: Added LongFei Niu to contributors list. - posted by longfei niu <sm...@gmail.com> on 2018/06/12 17:37:45 UTC, 3 replies.
- Review Request 67551: Fixed `push-commits.py` for Windows. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/12 17:41:48 UTC, 3 replies.
- Re: Review Request 67547: Added check for API endpoints that do not support streaming responses. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/06/12 17:42:50 UTC, 2 replies.
- Review Request 67553: Added Xiang Chaosheng to the contributors list. - posted by xiang chaosheng <zh...@qq.com> on 2018/06/12 17:57:14 UTC, 2 replies.
- Review Request 67557: Add contributor info at the file contributors.yaml. - posted by cui dt <cu...@outlook.com> on 2018/06/12 19:19:14 UTC, 9 replies.
- Review Request 67559: Added Yihua He to the contributor list. - posted by he yi hua <yh...@163.com> on 2018/06/12 20:04:15 UTC, 2 replies.
- Review Request 67558: Cai change. - posted by cai shuhua <ca...@163.com> on 2018/06/12 20:12:48 UTC, 5 replies.
- Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/12 21:09:13 UTC, 3 replies.
- Review Request 67562: The container should not be access when the container is destroyed in the mean time. - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/12 22:41:25 UTC, 2 replies.
- Review Request 67561: Refactored `struct Slave` in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/12 22:44:17 UTC, 1 replies.
- Review Request 67563: Added a new agent flag `--cgroups_enable_container_specific_mounts`. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/13 02:41:43 UTC, 0 replies.
- Re: Review Request 67526: Added container-specific cgroup FS mounts. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/13 02:42:47 UTC, 7 replies.
- Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/13 02:43:52 UTC, 4 replies.
- Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/13 02:44:42 UTC, 9 replies.
- Review Request 67567: Rename variable names in slave.hpp to be more explicit. - posted by bin zheng <zh...@chinaunicom.cn> on 2018/06/13 06:17:02 UTC, 5 replies.
- Re: Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/06/13 11:31:32 UTC, 2 replies.
- Review Request 67574: Made `PerfEventSubsystemProcess` can be created without `--perf_events`. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/13 14:23:48 UTC, 1 replies.
- Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/13 14:25:50 UTC, 1 replies.
- Review Request 67575: Changed operator API to notify subscribers on every status change. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/13 16:37:15 UTC, 4 replies.
- Review Request 67577: Change contributor name by full name. - posted by cui dt <cu...@outlook.com> on 2018/06/13 17:15:32 UTC, 2 replies.
- Review Request 67578: add user information - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/13 17:18:40 UTC, 0 replies.
- Review Request 67579: Added chenrc to the contributors list - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/13 17:24:01 UTC, 3 replies.
- Review Request 67580: Fixed use of rbt command in `push-commits.py` for Windows. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/13 17:31:33 UTC, 2 replies.
- Review Request 67581: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here. - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/13 18:14:38 UTC, 1 replies.
- Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here. - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/13 21:22:34 UTC, 7 replies.
- Re: Review Request 67567: Renamed variable names in slave.hpp to be more explicit. - posted by bin zheng <zh...@chinaunicom.cn> on 2018/06/13 21:47:47 UTC, 1 replies.
- Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/13 22:30:25 UTC, 2 replies.
- Review Request 67590: Added a dedicated benchmark for range resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/13 23:28:24 UTC, 3 replies.
- Review Request 67591: Improving the accuracy of this failure message. - posted by he yi hua <yh...@163.com> on 2018/06/13 23:31:22 UTC, 4 replies.
- Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/13 23:36:13 UTC, 4 replies.
- Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/13 23:58:53 UTC, 2 replies.
- Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 00:02:40 UTC, 5 replies.
- Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 00:07:49 UTC, 4 replies.
- Re: Review Request 65640: Fixed a race condition in `UriDiskProfileAdaptorTests`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 00:20:47 UTC, 4 replies.
- Re: Review Request 65875: Improved logging for offers and inverse offers. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 00:22:04 UTC, 9 replies.
- Review Request 67594: Improve the debug logging in mesos container - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/14 00:35:49 UTC, 2 replies.
- Review Request 67596: Fixed the flakiness in the `NVIDIA_GPU_NvidiaDockerImage` test. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 03:47:40 UTC, 3 replies.
- Review Request 67597: Fixed an issue where agent may fail to recover. - posted by bin zheng <zh...@chinaunicom.cn> on 2018/06/14 07:48:09 UTC, 11 replies.
- Review Request 67600: Fixed break of `port_mapping_tests.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/14 17:38:32 UTC, 7 replies.
- Review Request 67602: Improve the debug logging in mesos container - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/14 19:45:01 UTC, 3 replies.
- Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint. - posted by longfei niu <sm...@gmail.com> on 2018/06/14 19:54:45 UTC, 10 replies.
- Review Request 67603: Made sure all configured shell script outputs are executable. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/14 22:13:15 UTC, 4 replies.
- Review Request 67604: Made configured shell script inputs executable. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/14 22:20:08 UTC, 3 replies.
- Re: Review Request 67579: Added chenrc to the contributors list. - posted by CHEN RUNCONG <ch...@163.com> on 2018/06/14 22:37:42 UTC, 0 replies.
- Review Request 67607: Windows: Fixed libarchive and zlib linkage warnings. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/14 23:20:47 UTC, 2 replies.
- Review Request 67609: Added DaoTan Cui to the contributors list. - posted by cui dt <cu...@outlook.com> on 2018/06/15 00:08:54 UTC, 5 replies.
- Review Request 67606: Allow for unbundled libevent cmake builds. - posted by Till Toenshoff <to...@me.com> on 2018/06/15 02:07:16 UTC, 12 replies.
- Re: Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/06/15 13:36:12 UTC, 0 replies.
- Review Request 67614: Removed memcpy from os::Fork::instantiate. - posted by James Peach <jp...@apache.org> on 2018/06/15 18:36:19 UTC, 2 replies.
- Review Request 67616: Added the limitation of the nested container id length. - posted by wei xiao <xw...@outlook.com> on 2018/06/15 19:07:37 UTC, 3 replies.
- Re: Review Request 67308: Documented how to setup and use cquery with Mesos. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/15 20:45:22 UTC, 2 replies.
- Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/15 20:46:28 UTC, 6 replies.
- Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/06/15 23:57:53 UTC, 4 replies.
- Re: Review Request 67606: Allowed for unbundled libevent cmake builds. - posted by Till Toenshoff <to...@me.com> on 2018/06/16 02:06:23 UTC, 1 replies.
- Review Request 67631: Added non-const accessor for JSON values. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:52:11 UTC, 2 replies.
- Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:53:14 UTC, 5 replies.
- Review Request 67633: Removed PICOJSON_USE_INT64 from libprocess build system. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:53:27 UTC, 2 replies.
- Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:53:39 UTC, 6 replies.
- Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`. - posted by Jason Lai <ja...@jasonlai.net> on 2018/06/18 21:48:27 UTC, 2 replies.
- Re: Review Request 66875: Added an hourly timer for docker store pull latency. - posted by Jason Lai <ja...@jasonlai.net> on 2018/06/18 21:49:00 UTC, 4 replies.
- Re: Review Request 67616: Added the limitation of the container id length. - posted by wei xiao <xw...@outlook.com> on 2018/06/18 22:56:04 UTC, 7 replies.
- Re: Review Request 65995: Ensured wanted offers in `RetryOperationStatusUpdate*` SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/19 04:31:11 UTC, 0 replies.
- Re: Review Request 67616: Added a length validation for container IDs. - posted by wei xiao <xw...@outlook.com> on 2018/06/19 05:45:52 UTC, 3 replies.
- Re: Review Request 67558: Added Cai ShuHua to the contributor list. - posted by cai shuhua <ca...@163.com> on 2018/06/19 06:31:34 UTC, 1 replies.
- Re: Review Request 67632: Always define PICOJSON_USE_INT64. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/19 17:35:48 UTC, 2 replies.
- Review Request 67655: Removed some debugging codes that were committed by mistake. - posted by Gilbert Song <so...@gmail.com> on 2018/06/19 18:38:10 UTC, 2 replies.
- Review Request 67656: Fixed Autotools `cd 3rdparty/stout && make tests` build. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/19 21:18:59 UTC, 3 replies.
- Review Request 67662: Allowed mounts if the container is launched in a new mount namespace. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/20 02:37:36 UTC, 4 replies.
- Re: Review Request 65975: Reconciled storage pools when destroying volumes with stale profiles. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 04:33:41 UTC, 0 replies.
- Re: Review Request 65976: Made SLRP be able to handle disappeared profiles. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 04:35:47 UTC, 0 replies.
- Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:32:36 UTC, 4 replies.
- Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:33:04 UTC, 4 replies.
- Review Request 67665: Made the `UriDiskProfileAdaptor` module configurable in SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:33:25 UTC, 1 replies.
- Review Request 67666: Added a `TestDiskProfileServer` helper. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:33:32 UTC, 3 replies.
- Review Request 67667: Renamed the `NewProfile` SLRP test and made it based on offers. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:33:39 UTC, 4 replies.
- Review Request 67668: Fixed a bug in `TestCSIPlugin::DeleteVolume`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:33:46 UTC, 2 replies.
- Review Request 67669: Removed an invariant check when updating the hierarchical allocator. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:34:00 UTC, 2 replies.
- Review Request 67670: Added a unit test for disappeared profiles. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:34:07 UTC, 12 replies.
- Re: Review Request 67501: Added authorization for storage operations. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/06/20 10:44:30 UTC, 21 replies.
- Review Request 67671: Prevented resource providers from changing their name or type. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/20 12:35:56 UTC, 2 replies.
- Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/20 14:32:55 UTC, 4 replies.
- Re: Review Request 53105: Added an hourly timer for `containerizer/docker/image_pull`. - posted by Zhitao Li <zh...@gmail.com> on 2018/06/20 18:25:17 UTC, 2 replies.
- Review Request 67677: Added doc for new pull latency metrics. - posted by Zhitao Li <zh...@gmail.com> on 2018/06/20 20:26:22 UTC, 3 replies.
- Review Request 67680: Fixed archiver failure to extract hardlinks to another directory. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/20 23:55:36 UTC, 5 replies.
- Re: Review Request 66881: Added benchmark test for master metrics. - posted by Gilbert Song <so...@gmail.com> on 2018/06/21 00:08:10 UTC, 2 replies.
- Re: Review Request 67669: Allowed allocation quantities to be changed when updating the sorter. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/21 04:52:08 UTC, 0 replies.
- Review Request 67681: Fixed flaky test `MasterAPITest.SubscribersReceiveHealthUpdates`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/21 05:16:19 UTC, 7 replies.
- Re: Review Request 67388: Moved libprocess POSIX and Windows implementations to separate folders. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/21 11:48:00 UTC, 3 replies.
- Review Request 67685: Windows: Added `windows_to_unix_epoch` function. - posted by Akash Gupta <ak...@hotmail.com> on 2018/06/21 11:54:37 UTC, 2 replies.
- Review Request 67693: Added filtering for `GET_OPERATIONS` calls. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/21 15:53:56 UTC, 5 replies.
- Review Request 67707: Added a support script to check for files missing in the cmake build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/22 21:47:49 UTC, 4 replies.
- Review Request 67708: Added `profiler_tests.cpp` to the libprocess cmake build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/22 21:47:52 UTC, 1 replies.
- Review Request 67709: Added two tests to the stout cmake build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/22 21:48:00 UTC, 3 replies.
- Review Request 67719: Fixed formatting in libprocess `README`. - posted by Benno Evers <be...@mesosphere.com> on 2018/06/25 08:13:06 UTC, 1 replies.
- Review Request 67722: Fixed unproperly guarded future. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/06/25 17:56:53 UTC, 5 replies.
- Review Request 67725: Added a principal to a disk resource's `source` field. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/25 18:07:58 UTC, 2 replies.
- Review Request 67724: Validate principal in `Create[Volume|Disk]` operations. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/25 18:07:59 UTC, 0 replies.
- Review Request 67723: Added a principal field to `Create[Volume|Disk]` operations. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/25 18:07:59 UTC, 0 replies.
- Review Request 67728: Fixed orphan container cleanup issue in CNI isolator. - posted by Jie Yu <yu...@gmail.com> on 2018/06/25 19:00:02 UTC, 6 replies.
- Review Request 67730: Made Git normalize all line endings automatically. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/25 19:10:47 UTC, 10 replies.
- Review Request 67736: Removed ifdef from library path construction. - posted by James Peach <jp...@apache.org> on 2018/06/26 03:57:43 UTC, 4 replies.
- Review Request 67737: Updated CNI slave recovery test. - posted by Jie Yu <yu...@gmail.com> on 2018/06/26 05:36:57 UTC, 7 replies.
- Review Request 67739: Documented the container-specific cgroups mounts feature. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/26 07:40:43 UTC, 2 replies.
- Review Request 67738: Renamed APR and SVN `find_package` implementations. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/26 07:41:41 UTC, 4 replies.
- Review Request 67742: Allowed SOME principal in ACLs for new destroy operations. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/26 13:33:50 UTC, 3 replies.
- Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/26 13:58:47 UTC, 3 replies.
- Review Request 67748: Added monitoring paragraph to high-availability.md. - posted by Till Toenshoff <to...@me.com> on 2018/06/26 19:12:58 UTC, 3 replies.
- Review Request 67751: WIP: Added missing files to CMake build. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/26 23:12:17 UTC, 3 replies.
- Re: Review Request 66819: Added FrameworkMetrics struct in framework struct. - posted by Gilbert Song <so...@gmail.com> on 2018/06/27 07:34:57 UTC, 0 replies.
- Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers. - posted by Gilbert Song <so...@gmail.com> on 2018/06/27 07:35:03 UTC, 0 replies.
- Re: Review Request 66822: Added per Framework Calls to metrics. - posted by Gilbert Song <so...@gmail.com> on 2018/06/27 07:35:20 UTC, 2 replies.
- Review Request 67762: Added minimum capability check during master recovery. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/27 20:26:15 UTC, 10 replies.
- Review Request 67761: Added a new registry field `minimum_capabilities`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/27 20:26:37 UTC, 6 replies.
- Review Request 67764: Fixed a typo in the agent flags and related docs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/06/27 21:05:05 UTC, 1 replies.
- Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/28 07:14:51 UTC, 2 replies.
- Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done. - posted by Qian Zhang <zh...@gmail.com> on 2018/06/28 13:32:47 UTC, 11 replies.
- Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 19:34:03 UTC, 9 replies.
- Re: Review Request 65784: Added validation of QuotaRequest. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 20:26:48 UTC, 0 replies.
- Review Request 67773: Removed redundant 'toUnreserved()' call in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 20:54:45 UTC, 1 replies.
- Review Request 67444: Persisted role consumed quota info in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 20:55:14 UTC, 3 replies.
- Review Request 67776: Added per Framework Calls to metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/06/28 22:41:23 UTC, 2 replies.
- Re: Review Request 66823: Added per framework metrics for framework events. - posted by Gilbert Song <so...@gmail.com> on 2018/06/28 22:41:37 UTC, 2 replies.
- Review Request 67777: Added a helper to match agent-framework capabilities in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 23:00:59 UTC, 4 replies.
- Review Request 67778: Fixed flaky test `DefaultExecutorTest.SigkillExecutor`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 23:31:59 UTC, 1 replies.
- Review Request 67779: WIP: Introduced `CREATE_DISK` and `DESTROY_DISK` operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/29 00:40:31 UTC, 1 replies.
- Review Request 67780: Removed incorrect symlink handling in archiver utility. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/29 01:00:59 UTC, 2 replies.
- Review Request 67783: Removed unused variable. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/06/29 12:02:24 UTC, 3 replies.
- Review Request 67786: Added per framework metrics for framework events. - posted by Greg Mann <gr...@mesosphere.io> on 2018/06/29 15:00:26 UTC, 0 replies.
- Re: Review Request 66845: Made per-framework metrics count heartbeat events. - posted by Gilbert Song <so...@gmail.com> on 2018/06/29 15:01:07 UTC, 0 replies.
- Review Request 67788: Added regression test for archiver utility symlink extraction. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/06/29 18:44:32 UTC, 3 replies.
- Review Request 67791: Prevented master from asking agents to shutdown on auth failures. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2018/06/29 23:23:12 UTC, 2 replies.
- Review Request 67792: Moved tests sources from libmesos to mesos-tests. - posted by James Peach <jp...@apache.org> on 2018/06/30 08:10:53 UTC, 2 replies.
- Review Request 67793: Combined headers and sources in `MESOS_LINUX_FILES`. - posted by James Peach <jp...@apache.org> on 2018/06/30 08:17:16 UTC, 4 replies.