You are viewing a plain text version of this content. The canonical link for it is here.

---

- Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/01 00:10:54 UTC, 2 replies.
- Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 00:20:18 UTC, 8 replies.
- Re: Review Request 66875: Added an hourly timer for docker store pull latency. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/01 01:01:09 UTC, 3 replies.
- Re: Review Request 66860: Avoid copying of register framework messages in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/01 01:20:53 UTC, 3 replies.
- Re: Review Request 66881: Added benchmark test for master metrics. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/01 02:19:19 UTC, 2 replies.
- Re: Review Request 66811: Added `libacl` as a dependency of stout. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/01 02:23:46 UTC, 1 replies.
- Re: Review Request 66812: Added `libacl` as a dependency of Mesos. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/01 02:25:16 UTC, 0 replies.
- Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 04:05:19 UTC, 8 replies.
- Re: Review Request 66883: Added/updated tests to check per framework metrics. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/01 04:55:13 UTC, 2 replies.
- Re: Review Request 53267: Added a PullGauge to track active subscribers. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 15:54:26 UTC, 0 replies.
- Re: Review Request 54986: Added pull gauges for slave message queue. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 15:54:56 UTC, 0 replies.
- Re: Review Request 66828: Introduced a push-based gauge metric. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 16:25:29 UTC, 2 replies.
- Review Request 66885: Removed unnecessary `get()` accessors. - posted by James Peach <jp...@apache.org> on 2018/05/01 16:33:15 UTC, 3 replies.
- Re: Review Request 66259: Added `max_completion_time` support to command executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 16:41:19 UTC, 0 replies.
- Re: Review Request 66283: Added support of `max_completion_time` in docker executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 16:42:00 UTC, 0 replies.
- Re: Review Request 66284: Tested `max_completion_time` support in docker executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 16:42:21 UTC, 0 replies.
- Re: Review Request 66291: Added support to `max_completion_time` in default executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 16:42:42 UTC, 0 replies.
- Re: Review Request 66293: Tested default executor support of `max_completion_time`. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 16:43:05 UTC, 2 replies.
- Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 18:50:14 UTC, 0 replies.
- Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 19:16:28 UTC, 2 replies.
- Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 19:58:05 UTC, 1 replies.
- Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/05/01 20:40:20 UTC, 6 replies.
- Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 20:49:57 UTC, 0 replies.
- Review Request 66892: Added `SubprocessTest.PipeLargeOutput`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/01 21:24:19 UTC, 4 replies.
- Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/01 21:24:27 UTC, 1 replies.
- Review Request 66893: Documented the changes in gRPC and CSI supports. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 21:26:36 UTC, 2 replies.
- Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/01 21:32:32 UTC, 0 replies.
- Review Request 66894: Fixed typos in `upgrades.md`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 21:33:06 UTC, 1 replies.
- Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 21:39:17 UTC, 2 replies.
- Review Request 66896: Updated `csi.md`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 21:45:21 UTC, 3 replies.
- Re: Review Request 66834: Windows: Specialized `flags::parse`. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 21:48:11 UTC, 3 replies.
- Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 21:48:35 UTC, 0 replies.
- Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/05/01 21:53:58 UTC, 0 replies.
- Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 22:34:31 UTC, 0 replies.
- Re: Review Request 66050: Implemented grow and shrink of persistent volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/01 22:35:47 UTC, 0 replies.
- Re: Review Request 65785: Added a test for QuotaRequest validation. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/01 23:34:21 UTC, 0 replies.
- Re: Review Request 65784: Added validation of QuotaRequest. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/01 23:40:14 UTC, 0 replies.
- Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/01 23:40:37 UTC, 9 replies.
- Review Request 66900: Avoid copying of re-register framework messages in the master. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/01 23:46:40 UTC, 6 replies.
- Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/02 01:26:33 UTC, 5 replies.
- Review Request 66901: Add the ASF events link to the website. - posted by James Peach <jp...@apache.org> on 2018/05/02 03:36:58 UTC, 4 replies.
- Review Request 66903: Fixed incorrect enum value comparisons. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/02 09:36:26 UTC, 4 replies.
- Review Request 66904: Added 'Ninja' byproducts for jemalloc. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/05/02 10:34:50 UTC, 2 replies.
- Re: Review Request 66776: Changed failure check for a call to os::system(). - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/02 12:49:33 UTC, 1 replies.
- Review Request 66908: Correctly reconciled dropped operation after agent failover. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/02 14:35:34 UTC, 6 replies.
- Review Request 66912: Resolved the `realpath` of the sandbox directory in tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/02 18:29:13 UTC, 5 replies.
- Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). - posted by Benno Evers <be...@mesosphere.com> on 2018/05/02 18:29:33 UTC, 4 replies.
- Review Request 66916: Disabled a resource provider resubscription test on Windows. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/02 19:30:24 UTC, 3 replies.
- Review Request 66919: Failure to update registry should abort the master process. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/02 21:37:41 UTC, 12 replies.
- Review Request 66920: Improved tests for resizing persistent volumes. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/02 21:47:32 UTC, 12 replies.
- Re: Review Request 66872: Updated FrameworkInfo comparator. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/05/02 22:21:28 UTC, 2 replies.
- Review Request 66923: Added documentation on volume resize support. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/03 00:01:40 UTC, 8 replies.
- Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call. - posted by Till Toenshoff <to...@me.com> on 2018/05/03 02:58:52 UTC, 3 replies.
- Review Request 66931: Fixed a race in resource provider resubscription test. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/03 11:46:04 UTC, 11 replies.
- Review Request 66932: Adden token based authentication for resource providers. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/05/03 12:55:59 UTC, 2 replies.
- Review Request 66933: Added a flag for resource provider authentication. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/05/03 12:56:46 UTC, 0 replies.
- Review Request 66934: Removed credential-based authentication of 'MockResourceProvider'. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/05/03 12:57:44 UTC, 2 replies.
- Re: Review Request 66849: Added missing test expectation. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/03 18:23:27 UTC, 1 replies.
- Re: Review Request 65572: Fixed two slave recovery tests. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/03 20:56:51 UTC, 1 replies.
- Review Request 66938: Made the 'SchedulerDriver' abort when operation's 'id' field is set. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/03 22:07:25 UTC, 12 replies.
- Review Request 66939: Improved validation messages for some operations. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/03 22:36:44 UTC, 7 replies.
- Review Request 66940: Documented the changes in the agent flags and modules. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/03 22:38:00 UTC, 3 replies.
- Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/04 00:00:05 UTC, 10 replies.
- Re: Review Request 66749: Added more logging to agent recovery path. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/04 03:39:16 UTC, 3 replies.
- Re: Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators. - posted by Gilbert Song <so...@gmail.com> on 2018/05/04 06:59:12 UTC, 5 replies.
- Re: Review Request 66634: Explicitly marked functions `override` in cgroup subsystems. - posted by Gilbert Song <so...@gmail.com> on 2018/05/04 06:59:22 UTC, 1 replies.
- Review Request 66947: Increased the timeout for waiting for `reaped` to be invoked. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/04 09:32:37 UTC, 4 replies.
- Review Request 66952: Windows: Added overlapped field to WindowsFD. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:15:55 UTC, 5 replies.
- Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:16:20 UTC, 3 replies.
- Review Request 66961: Windows: Ported sendfile_tests.cpp. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:17:40 UTC, 4 replies.
- Review Request 66963: Updated the 1.6 CHANGELOG. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/04 17:18:07 UTC, 3 replies.
- Review Request 66960: Windows: Added async version of `os::sendfile`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:18:41 UTC, 3 replies.
- Review Request 66959: Windows: Fixed pipe inheritance in Mesos containerizer. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:19:38 UTC, 4 replies.
- Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:20:17 UTC, 3 replies.
- Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:20:41 UTC, 4 replies.
- Review Request 66956: Windows: Added overlapped support to `os::write`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:21:06 UTC, 4 replies.
- Review Request 66955: Windows: Added overlapped support to `os::read`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:21:20 UTC, 3 replies.
- Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:21:42 UTC, 3 replies.
- Review Request 66962: Windows: Added tests for async IO functions. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/04 17:27:04 UTC, 10 replies.
- Re: Review Request 66230: Added test for adding/removing framework roles. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/05/04 17:33:06 UTC, 3 replies.
- Review Request 66965: Added MESOS-8054 to the 1.6 CHANGELOG. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/04 18:35:07 UTC, 3 replies.
- Review Request 66966: Fixed synchronization orders for destructing mock resource providers. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/04 19:15:10 UTC, 1 replies.
- Review Request 66968: Added MESOS-8649, MESOS-8793 and MESOS-8874 to the 1.6.0 CHANGELOG. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/04 20:23:50 UTC, 3 replies.
- Review Request 66964: Ported (some) Python 2 support scripts to Python 3. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/04 20:44:43 UTC, 5 replies.
- Review Request 66969: Added unresolved critical issues to the 1.6 CHANGELOG. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/04 21:10:04 UTC, 6 replies.
- Review Request 66970: Added MESOS-8682 and MESOS-8659 to the 1.6.0 CHANGELOG. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/04 21:18:45 UTC, 1 replies.
- Re: Review Request 66628: Added role tracking unit tests. - posted by Till Toenshoff <to...@me.com> on 2018/05/05 14:10:36 UTC, 2 replies.
- Re: Review Request 65940: Added integration tests validating hierarchical role accounting. - posted by Till Toenshoff <to...@me.com> on 2018/05/05 14:11:59 UTC, 0 replies.
- Review Request 66973: Updated role-endpoint test to validate deprecation of 'resources'. - posted by Till Toenshoff <to...@me.com> on 2018/05/05 14:12:21 UTC, 0 replies.
- Re: Review Request 66625: Updated role-endpoint tests for added reporting details. - posted by Till Toenshoff <to...@me.com> on 2018/05/05 14:13:28 UTC, 0 replies.
- Re: Review Request 65939: Updated role endpoints for detailed, hierarchical accounting. - posted by Till Toenshoff <to...@me.com> on 2018/05/05 14:14:00 UTC, 1 replies.
- Review Request 66975: Add documentation for the xfs_kill_containers flag. - posted by Harold Dost <h....@criteo.com> on 2018/05/06 15:03:35 UTC, 1 replies.
- Re: Review Request 66975: Add documentation for the xfs-kill-containers flag. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/06 16:31:55 UTC, 2 replies.
- Review Request 66977: Re-enable epoll support for libevent. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/07 01:15:26 UTC, 2 replies.
- Review Request 66978: Disabled debug mode for libevent. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/07 02:05:25 UTC, 3 replies.
- Re: Review Request 66228: Added Call for updating framework info. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/07 02:41:05 UTC, 3 replies.
- Review Request 66981: Added a new flag to the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 06:07:03 UTC, 0 replies.
- Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 06:09:22 UTC, 5 replies.
- Review Request 66983: Added an option to show if filtering is due to framework decline. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 06:15:28 UTC, 0 replies.
- Review Request 66984: WIP: exhaustively allocate declined resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 06:24:54 UTC, 2 replies.
- Re: Review Request 66933: Added a realm for resource provider authentication. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/05/07 12:12:59 UTC, 4 replies.
- Re: Review Request 66934: Added token-based authentication to resource provider tests. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/05/07 12:14:01 UTC, 6 replies.
- Review Request 66986: Fixed a disk space check in the XFS tests. - posted by James Peach <jp...@apache.org> on 2018/05/07 15:30:41 UTC, 2 replies.
- Review Request 66987: Renamed cgroups subsystem processes. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/07 15:56:15 UTC, 2 replies.
- Re: Review Request 66635: Introduced wrapper for access to cgroups system access. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/07 15:56:18 UTC, 12 replies.
- Re: Review Request 66984: Added the ability to exhaustively allocate declined resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 19:28:07 UTC, 4 replies.
- Review Request 66990: Added a new master flag `exhaustively_allocate_declined_resources`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 20:33:00 UTC, 1 replies.
- Review Request 66993: Removed unnecessary expectation on termination. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/07 22:25:58 UTC, 6 replies.
- Review Request 66994: Added a test for exhaustively allocating declined resources. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/07 22:31:43 UTC, 1 replies.
- Review Request 66992: Made the master drop operations with an ID on non-default resources. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/07 22:56:45 UTC, 2 replies.
- Review Request 66995: Prevented Master::drop() from sending operation updates to v0 framework. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/08 00:19:58 UTC, 1 replies.
- Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/08 03:23:29 UTC, 6 replies.
- Review Request 66997: Removed the OpenSSL dependency for building gRPC in libprocess. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/08 03:25:41 UTC, 5 replies.
- Review Request 67003: Fixed flakiness in a `MasterSlaveReconciliationTest`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/08 11:59:10 UTC, 2 replies.
- Review Request 67004: Added an option to keep downloaded patches to apply-reviews.py. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/08 12:54:08 UTC, 2 replies.
- Review Request 67009: Added tests of resource provider registrar recovery. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/08 15:16:43 UTC, 8 replies.
- Review Request 67008: Added documentation to website for Python components. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/08 15:39:24 UTC, 3 replies.
- Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/05/08 16:44:46 UTC, 0 replies.
- Re: Review Request 66819: Added FrameworkMetrics struct in framework struct. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/08 17:21:19 UTC, 5 replies.
- Re: Review Request 66821: Added framwork metrics helper normalize() and getPrefix(). - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/08 17:28:22 UTC, 0 replies.
- Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now) - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/08 18:41:38 UTC, 9 replies.
- Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/08 18:43:39 UTC, 4 replies.
- Review Request 67012: Resolve container target paths within their rootfs. - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/08 18:58:19 UTC, 1 replies.
- Review Request 67013: Sort container mounts by their target paths. - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/08 18:59:09 UTC, 4 replies.
- Re: Review Request 65900: Defer creation of volume target paths to container launch. - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/08 19:08:00 UTC, 3 replies.
- Re: Review Request 66822: Added per Framework Calls to metrics. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/08 20:33:33 UTC, 8 replies.
- Re: Review Request 66861: Added per-framework DRF position metrics to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/08 22:18:13 UTC, 2 replies.
- Review Request 67017: Removed unnecessary gRPC build flags in Mesos. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/08 22:46:53 UTC, 1 replies.
- Review Request 67018: Removed unnecessary gRPC build flags in libprocess. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/08 22:47:33 UTC, 2 replies.
- Re: Review Request 66841: Added a hash function for 'Duration'. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/08 23:18:08 UTC, 2 replies.
- Re: Review Request 64384: Added new 'any' setting for reconfiguration_policy flag. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/08 23:36:44 UTC, 1 replies.
- Review Request 67021: Windows: Enabled `ProtobufTest` suite. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/08 23:41:43 UTC, 3 replies.
- Re: Review Request 66882: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/09 00:06:09 UTC, 4 replies.
- Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/09 00:19:45 UTC, 5 replies.
- Review Request 67024: Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/09 02:27:53 UTC, 3 replies.
- Review Request 67025: Fixed the link order for gRPC in CMake. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/09 02:28:02 UTC, 5 replies.
- Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/09 08:34:43 UTC, 1 replies.
- Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings. - posted by Kevin Klues <kl...@gmail.com> on 2018/05/09 10:53:36 UTC, 3 replies.
- Re: Review Request 64970: Use tox for linting and testing code living uder src/python. - posted by Kevin Klues <kl...@gmail.com> on 2018/05/09 11:53:02 UTC, 0 replies.
- Review Request 67032: Removed pip install requirements-test.in in new CLI bootstrap script. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/09 13:13:12 UTC, 2 replies.
- Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/09 15:15:04 UTC, 25 replies.
- Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/09 19:28:34 UTC, 1 replies.
- Re: Review Request 66844: Added framework metrics for filtered resources to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/09 19:31:19 UTC, 1 replies.
- Re: Review Request 66870: Added per-framework metrics for suppressed roles. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/09 19:37:08 UTC, 0 replies.
- Re: Review Request 66874: Added per-framework metrics for active task states. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/09 19:50:46 UTC, 1 replies.
- Review Request 67041: Windows: Ported the rest of `path_tests.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/09 22:07:23 UTC, 2 replies.
- Review Request 67043: Made the master task state metrics track reregistered agents' tasks. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/09 23:40:36 UTC, 5 replies.
- Review Request 67044: Renamed a method in the master metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/09 23:42:16 UTC, 5 replies.
- Review Request 67047: Consolidated master framework validation at one place. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/05/10 01:12:14 UTC, 0 replies.
- Review Request 67048: Updated some Master functions to accept repeated fields. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/05/10 01:12:48 UTC, 0 replies.
- Review Request 67049: Modified Master::updateFramework to optionally return an Error. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/05/10 01:13:52 UTC, 0 replies.
- Re: Review Request 66230: Added test for updating framework info. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/05/10 01:15:15 UTC, 2 replies.
- Review Request 67051: Windows: Enabled more agent tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/10 02:54:43 UTC, 2 replies.
- Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/10 03:37:40 UTC, 4 replies.
- Review Request 67054: Added .tox to files excluded by Python linter. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/10 10:56:11 UTC, 4 replies.
- Review Request 67055: Added Python 3 version of cpplint. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/10 11:36:06 UTC, 3 replies.
- Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/10 12:52:37 UTC, 5 replies.
- Review Request 67059: Ported all support scripts to Python 3. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/10 16:24:40 UTC, 15 replies.
- Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/10 19:17:17 UTC, 0 replies.
- Re: Review Request 65665: Added operation state metrics in SLRP. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/10 20:43:44 UTC, 11 replies.
- Review Request 67064: Added libarchive, bzip2, and xz tarballs and associated build changes. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/05/10 21:06:44 UTC, 1 replies.
- Review Request 67065: Added a new stout utility header file which interfaces with libarchive. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/05/10 21:06:50 UTC, 7 replies.
- Review Request 67066: Modified the fetcher to use libarchive and added associated tests. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/05/10 21:06:55 UTC, 20 replies.
- Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags) - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/10 23:50:28 UTC, 7 replies.
- Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/11 03:32:11 UTC, 9 replies.
- Re: Review Request 66820: Added per framework metrics 'subscribed' and helpers. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 07:24:03 UTC, 4 replies.
- Re: Review Request 66823: Added per framework metrics for framework events. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 07:40:36 UTC, 4 replies.
- Re: Review Request 66845: Made per-framework metrics count heartbeat events. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 07:40:55 UTC, 1 replies.
- Re: Review Request 66825: Added per framework offer metrics. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 07:41:43 UTC, 3 replies.
- Re: Review Request 66846: Added per framework metrics support for terminal task state. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 07:44:29 UTC, 4 replies.
- Re: Review Request 66847: Added per framework metric for offer operation. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 07:46:21 UTC, 3 replies.
- Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/11 13:55:07 UTC, 5 replies.
- Re: Review Request 66650: Removed an invalid TODO in puller.cpp. - posted by Gilbert Song <so...@gmail.com> on 2018/05/11 17:47:56 UTC, 0 replies.
- Review Request 67094: Split linux chroot into prepare and enter phases. - posted by James Peach <jp...@apache.org> on 2018/05/11 18:31:42 UTC, 4 replies.
- Review Request 67095: Added a containerizer devices path helper. - posted by James Peach <jp...@apache.org> on 2018/05/11 18:32:03 UTC, 2 replies.
- Review Request 67096: Added a `linux/devices` isolator skeleton. - posted by James Peach <jp...@apache.org> on 2018/05/11 18:32:25 UTC, 1 replies.
- Review Request 67097: Added `linux/devices` isolator whitelist support. - posted by James Peach <jp...@apache.org> on 2018/05/11 18:32:44 UTC, 13 replies.
- Review Request 67098: Updated the container launcher mount sequence. - posted by James Peach <jp...@apache.org> on 2018/05/11 18:32:57 UTC, 10 replies.
- Re: Review Request 52695: Harden libprocess - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/11 21:34:05 UTC, 0 replies.
- Review Request 67099: Updated support scripts to check for Python 3. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/11 22:01:37 UTC, 6 replies.
- Review Request 67104: Fixed a race condition in the allocator metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/12 01:02:25 UTC, 3 replies.
- Re: Review Request 67101: Displayed modifications of all support scripts to Python 3. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/12 01:03:13 UTC, 0 replies.
- Review Request 67108: Did not omit frame pointers in debug builds. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 09:18:26 UTC, 4 replies.
- Review Request 67109: Did not omit frame pointers in debug builds in stout. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 09:18:27 UTC, 1 replies.
- Review Request 67110: Did not omit frame pointers in debug builds in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 09:18:28 UTC, 4 replies.
- Re: Review Request 67055: Updated cpplint to be compatible with Python 3. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/14 10:22:53 UTC, 9 replies.
- Re: Review Request 64610: Updated cpplint from upstream. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 15:32:27 UTC, 6 replies.
- Review Request 67115: Added more diagnostic info for a CHECK. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/05/14 16:58:58 UTC, 4 replies.
- Review Request 67116: Change XFS Kill Test to use ASSERT_GE. - posted by Harold Dost <h....@criteo.com> on 2018/05/14 17:18:32 UTC, 3 replies.
- Re: Review Request 66842: Added counter metrics for offer filter durations. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/14 17:26:30 UTC, 1 replies.
- Re: Review Request 66856: Tracked completed framework metrics in the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/14 17:28:15 UTC, 0 replies.
- Re: Review Request 67110: Disabled omission of frame pointers in debug builds in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 18:38:15 UTC, 0 replies.
- Re: Review Request 67109: Disabled omission of frame pointers in debug builds in stout. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 18:38:17 UTC, 0 replies.
- Re: Review Request 67108: Disabled omission of frame pointers in debug builds. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 18:38:18 UTC, 0 replies.
- Review Request 67118: Added bzip2, libarchive, and xz tarballs. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/05/14 22:42:01 UTC, 2 replies.
- Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/05/14 22:42:20 UTC, 6 replies.
- Review Request 67120: Windows: Disabled broken benchmarks test. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/14 22:42:50 UTC, 1 replies.
- Review Request 67123: Address comments - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/14 23:24:28 UTC, 2 replies.
- Review Request 67127: Updated cpplint from upstream. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/15 10:59:05 UTC, 4 replies.
- Review Request 67128: Removed extra `containerizer->wait()` calls in tests. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/15 11:02:39 UTC, 3 replies.
- Review Request 67130: Updated comments related to `wait`, `destroy` containerizer methods. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/15 13:50:45 UTC, 2 replies.
- Re: Review Request 66621: Add support for alg RS256 to JWT library. - posted by Till Toenshoff <to...@me.com> on 2018/05/15 14:30:29 UTC, 7 replies.
- Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/15 14:59:58 UTC, 3 replies.
- Review Request 67135: Added test to verify presence of nested container termination status. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/15 16:10:32 UTC, 3 replies.
- Review Request 67137: Avoided leaking file descriptors in Mesos containerizer. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/15 16:19:01 UTC, 31 replies.
- Review Request 67136: Added a function to get rlimits. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/15 16:19:03 UTC, 6 replies.
- Review Request 67145: Added `linux/devices` isolator whitelist tests. - posted by James Peach <jp...@apache.org> on 2018/05/16 00:30:58 UTC, 5 replies.
- Review Request 67146: Updated the container logger interface. - posted by Jie Yu <yu...@gmail.com> on 2018/05/16 00:44:45 UTC, 3 replies.
- Review Request 67147: Included a missing header in the master metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/16 02:11:01 UTC, 0 replies.
- Review Request 67150: Fixed links used in WebUI index.html to get assets. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/16 07:36:22 UTC, 1 replies.
- Review Request 67153: Enforced that `allowed_devices` entries must have a path. - posted by James Peach <jp...@apache.org> on 2018/05/16 17:56:57 UTC, 4 replies.
- Review Request 67154: Replaced `RpcResult` with `Try`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/16 19:20:12 UTC, 11 replies.
- Review Request 67155: Renamed `GRPC_RPC` and adapted the new gRPC async API. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/16 19:21:37 UTC, 2 replies.
- Review Request 67156: Renamed `grpc::Channel` to `grpc::client::Connection`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/16 19:25:24 UTC, 2 replies.
- Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/16 19:27:23 UTC, 10 replies.
- Review Request 67158: Updated the CSI client to use the new libprocess gRPC interface. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/16 19:28:11 UTC, 4 replies.
- Review Request 67164: Supported custom error types for `Try` in `AssertSome`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/16 22:02:04 UTC, 3 replies.
- Review Request 67165: WIP: Made `Error` explicitly stringifyable. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:32 UTC, 0 replies.
- Review Request 67166: WIP: Made use of generic `Error` stringification in stout. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:35 UTC, 0 replies.
- Review Request 67168: WIP: Made use of generic `Error` stringification in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:37 UTC, 0 replies.
- Review Request 67170: WIP: Changed `Result` and `Try` to not errors to `string`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:39 UTC, 0 replies.
- Review Request 67172: WIP: Adjusted libprocess for changes in `Result` and `Try`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:41 UTC, 0 replies.
- Review Request 67171: WIP: Adjusted stout for changes in `Result` and `Try`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:41 UTC, 0 replies.
- Review Request 67173: WIP: Adjusted code for changes in `Result` and `Try`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:44 UTC, 2 replies.
- Review Request 67169: WIP: Made use of generic `Error` stringification. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/16 22:50:44 UTC, 0 replies.
- Review Request 67175: Added support for marking slave mounts and creating non-existing paths. - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/17 01:23:54 UTC, 1 replies.
- Review Request 67176: Fixed target path resolution for mounts within container rootfs. - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/17 01:25:29 UTC, 0 replies.
- Review Request 67177: Sorted container mounts by their target paths. - posted by Jason Lai <ja...@jasonlai.net> on 2018/05/17 01:28:41 UTC, 3 replies.
- Review Request 67185: Added request_protobuf to mesos.http. - posted by Eric Chung <ci...@gmail.com> on 2018/05/17 14:36:59 UTC, 4 replies.
- Review Request 67187: Tested per-framework task state metrics. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/17 18:08:11 UTC, 2 replies.
- Review Request 67188: Windows: Implemented `os::shell` and enabled tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/17 19:03:29 UTC, 4 replies.
- Review Request 67189: Windows: Removed guards now that `os::shell` exists. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/17 19:03:56 UTC, 4 replies.
- Review Request 67190: Made `stringify` overloads for strings more efficient. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/17 19:35:40 UTC, 0 replies.
- Review Request 67191: Supported custom error types for the `Future(Try<...>)` constructor. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/17 19:35:59 UTC, 2 replies.
- Review Request 67193: Added the Mesos 1.6.0 release blog post. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/17 21:26:03 UTC, 6 replies.
- Review Request 67194: Windows: Fixed cURL copy command to run only once. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/17 21:27:01 UTC, 2 replies.
- Review Request 67195: Adding enforce_container_ports flag for network ports isolation. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/17 21:55:45 UTC, 14 replies.
- Review Request 67201: Whitelist handles that can be inherited by a child process. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/17 22:18:31 UTC, 20 replies.
- Re: Review Request 67190: Overloaded `stringify` for `Error`s to reduce overheads. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/17 22:25:41 UTC, 3 replies.
- Review Request 67202: Added ContainerID to container logger prepare interface. - posted by Jie Yu <yu...@gmail.com> on 2018/05/17 22:29:31 UTC, 1 replies.
- Review Request 67207: Windows: Changed health check image to be an environment variable. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/18 09:07:26 UTC, 1 replies.
- Review Request 67208: Windows: Updated information on docker health checks. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/18 09:08:10 UTC, 3 replies.
- Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/18 10:35:06 UTC, 3 replies.
- Review Request 67211: Used `*_SOME` macro for checking `Try` values in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/18 10:35:07 UTC, 3 replies.
- Review Request 67212: Used `*_SOME` macro for checking `Try` values. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/18 10:35:07 UTC, 6 replies.
- Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/18 12:36:43 UTC, 2 replies.
- Re: Review Request 65666: Added a unit test for SLRP operation state metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/18 17:46:44 UTC, 6 replies.
- Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/05/18 18:30:57 UTC, 5 replies.
- Review Request 67223: Used move constructors for making CSI gRPC calls. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/18 23:34:37 UTC, 1 replies.
- Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/18 23:46:25 UTC, 6 replies.
- Review Request 67226: Renamed tests/allocator.hpp to tests/mock_allocator.hpp. - posted by Till Toenshoff <to...@me.com> on 2018/05/19 00:05:48 UTC, 0 replies.
- Review Request 67227: Extracted allocator test fixture into header. - posted by Till Toenshoff <to...@me.com> on 2018/05/19 00:05:52 UTC, 0 replies.
- Review Request 67228: Added allocator benchmark test for various simulations. - posted by Till Toenshoff <to...@me.com> on 2018/05/19 00:05:59 UTC, 2 replies.
- Re: Review Request 66871: Added documentation about new gauge on `master/subscribers_active`. - posted by James Peach <jp...@apache.org> on 2018/05/21 16:09:09 UTC, 0 replies.
- Review Request 67235: Added per-framework metrics for types of resources contained in offers. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/21 18:59:32 UTC, 10 replies.
- Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/21 19:02:26 UTC, 8 replies.
- Review Request 67238: Fixed a quota-related metrics bug. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/21 22:13:10 UTC, 4 replies.
- Review Request 67241: Added isolator logs for volume/secret isolator and container logger. - posted by Gilbert Song <so...@gmail.com> on 2018/05/21 23:44:05 UTC, 12 replies.
- Review Request 67243: Windows: Changed test image to custom nanoserver. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/22 01:28:34 UTC, 4 replies.
- Review Request 67244: Adding enforce_container_ports flag for network ports isolation. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/22 04:01:16 UTC, 2 replies.
- Re: Review Request 66671: Updated composing containerizer tests. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/22 09:26:23 UTC, 2 replies.
- Review Request 67247: Added support script to check if Python >= 3.6 is available. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/22 12:39:24 UTC, 4 replies.
- Review Request 67248: Fixed `pem_to_rsa` for older SSL versions. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/22 12:58:57 UTC, 2 replies.
- Re: Review Request 67207: Windows: Changed health check image to use an image hosted by Mesos. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/22 23:09:45 UTC, 0 replies.
- Review Request 67255: Added per-CSI-call RPC metrics for SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:36:55 UTC, 9 replies.
- Review Request 67256: Added a unit test for CSI plugin RPC metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:38:19 UTC, 2 replies.
- Review Request 67257: Fixed filters in test `ROOT_ReconcileDroppedOperation` for consistency. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:38:52 UTC, 1 replies.
- Review Request 67258: Fixed flakiness for some `AgentResourceProviderConfigApiTest` tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:39:29 UTC, 3 replies.
- Review Request 67261: Skipped `UpdateSlaveMessage` for an empty 1st `oversubscribedResources`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/23 02:59:14 UTC, 0 replies.
- Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/23 05:02:51 UTC, 1 replies.
- Review Request 67264: Unmounted any dangling persistent volume in gc paths. - posted by Zhitao Li <zh...@gmail.com> on 2018/05/23 06:05:00 UTC, 7 replies.
- Review Request 67270: Fixed compilation error in libprocess example. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/23 17:22:19 UTC, 5 replies.
- Review Request 67271: Change ambiguous parameter name. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/23 17:57:31 UTC, 5 replies.
- Re: Review Request 66954: Windows: Added internal windows file for overlapped helpers. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/23 20:08:37 UTC, 0 replies.
- Review Request 67274: Validated that resources from frameworks are finite. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/23 22:30:01 UTC, 2 replies.
- Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/24 09:09:49 UTC, 14 replies.
- Review Request 67281: Reformated libprocess example code. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/24 11:50:23 UTC, 1 replies.
- Review Request 67280: Added libprocess example code to build. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/24 11:52:05 UTC, 3 replies.
- Re: Review Request 67270: Fixed various issues in libprocess example. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/24 12:38:50 UTC, 0 replies.
- Re: Review Request 67270: Fixed compilation issues in libprocess example. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/24 13:33:02 UTC, 5 replies.
- Review Request 67282: Added python3 to list of Pylint excluded files. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/24 14:34:33 UTC, 2 replies.
- Review Request 67285: Moved JWT test keys into the tests source file. - posted by James Peach <jp...@apache.org> on 2018/05/24 15:48:26 UTC, 5 replies.
- Review Request 67289: Introduced an overload for os::environment. - posted by Jie Yu <yu...@gmail.com> on 2018/05/24 17:08:32 UTC, 0 replies.
- Review Request 67290: Removed an unneeded test. - posted by Jie Yu <yu...@gmail.com> on 2018/05/24 17:08:50 UTC, 2 replies.
- Review Request 67291: Adjusted the tests that use nobody. - posted by Jie Yu <yu...@gmail.com> on 2018/05/24 17:09:17 UTC, 9 replies.
- Review Request 67288: White list fds that child processes can inherit in mesos containerizer. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/24 17:42:54 UTC, 7 replies.
- Review Request 67287: White list fds that child processes can inherit in libprocess. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/24 17:43:01 UTC, 3 replies.
- Review Request 67286: White list fds that child processes can inherit in stout. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/24 17:43:06 UTC, 4 replies.
- Review Request 67292: Added warning to Python version checker script. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/24 17:59:34 UTC, 5 replies.
- Re: Review Request 67271: Renamed an ambiguous variable in network port isolator. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/24 18:17:31 UTC, 1 replies.
- Review Request 67298: Fixed a performance issue in collect/await. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/24 21:22:14 UTC, 2 replies.
- Re: Review Request 67195: Added enforce_container_ports flag for network ports isolation. - posted by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/24 21:56:42 UTC, 1 replies.
- Re: Review Request 63280: Made the containerizer launch be explicit about O_CLOEXEC. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/24 22:36:19 UTC, 1 replies.
- Review Request 67301: Fixed a typo in libprocess documentation. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/05/24 22:51:01 UTC, 2 replies.
- Review Request 67303: Added documentation for resource provider and CSI plugin metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/25 01:03:25 UTC, 5 replies.
- Re: Review Request 65112: Added documentation about standalone containers. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/25 01:16:46 UTC, 0 replies.
- Review Request 67304: Added missing calls to the scheduler API docs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/05/25 01:23:26 UTC, 2 replies.
- Review Request 67305: Moved the "Resource Provider" section to `resource-provider.md`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/25 01:24:21 UTC, 3 replies.
- Review Request 67308: Documented how to setup and use cquery with Mesos. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/25 02:30:36 UTC, 7 replies.
- Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/25 02:52:56 UTC, 4 replies.
- Review Request 67309: Updated Future::select to take any iterable type. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/25 02:56:03 UTC, 2 replies.
- Review Request 67310: Updated hashmap and LinkedHashMap to return vectors from values(). - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/25 03:04:24 UTC, 2 replies.
- Review Request 67311: Updated await/collect to use vector instead of list. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/25 03:04:26 UTC, 3 replies.
- Review Request 67312: Updated mesos to use vector instead of list where possible. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/25 03:04:32 UTC, 7 replies.
- Review Request 67320: Sent task (health) check updates over the operator streaming API. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/05/25 10:21:08 UTC, 8 replies.
- Re: Review Request 67318: Updated python.m4 to be compatible with Python 3. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/05/25 10:46:26 UTC, 4 replies.
- Review Request 67317: Fixed flaky `TerminatedNestedStatus` test. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/25 10:50:02 UTC, 1 replies.
- Review Request 67321: Fixed python3/post-reviews type error. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/25 11:26:28 UTC, 0 replies.
- Re: Review Request 67321: Fixed python3/post-reviews.py type error. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/05/25 12:03:57 UTC, 0 replies.
- Review Request 67322: Added Python 2 check for Python bindings when using `configure`. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/25 13:01:02 UTC, 2 replies.
- Review Request 67328: Used italic fonts to denote placeholdes in metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/25 18:28:38 UTC, 1 replies.
- Review Request 67331: Documented the `linux/devices` isolator. - posted by James Peach <jp...@apache.org> on 2018/05/25 22:11:26 UTC, 4 replies.
- Review Request 67335: Added `windows/cpu` and `windows/mem` isolators into `agent.md`. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/28 02:08:15 UTC, 4 replies.
- Review Request 67339: Modified launch.cpp to writes its logs into cerr. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/05/28 10:37:32 UTC, 0 replies.
- Re: Review Request 67339: Modified launch.cpp to write its logs into cerr. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/05/28 11:02:09 UTC, 0 replies.
- Review Request 67340: Fixed python3/mesos-style.py type error. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/05/28 13:17:00 UTC, 1 replies.
- Review Request 67342: Added `cgroups/*` into the agent flag `--isolation`. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/28 14:58:06 UTC, 1 replies.
- Review Request 67343: Automatically loaded all the local enabled cgroups subsystems. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/28 15:00:09 UTC, 4 replies.
- Review Request 67344: Made disk allocatable on their own. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/28 15:11:28 UTC, 2 replies.
- Review Request 67345: Removed unchecked access to an optional in checker process. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/28 16:01:09 UTC, 1 replies.
- Review Request 67348: Changed python3 support check script to print to `stderr`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/29 07:48:48 UTC, 1 replies.
- Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/29 14:20:52 UTC, 3 replies.
- Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/29 14:20:58 UTC, 0 replies.
- Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/05/29 14:21:04 UTC, 1 replies.
- Review Request 67357: Added constant time comparison of JWT signatures. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/05/29 14:21:07 UTC, 4 replies.
- Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/29 14:22:05 UTC, 1 replies.
- Review Request 67360: Added link targets to master and agent flags. - posted by James Peach <jp...@apache.org> on 2018/05/29 17:46:15 UTC, 1 replies.
- Review Request 67362: Updated `linux/devices` isolator tests for compiler compatibility. - posted by James Peach <jp...@apache.org> on 2018/05/29 20:20:18 UTC, 2 replies.
- Review Request 67363: Switched test devices for the `linux/devices` isolator tests. - posted by James Peach <jp...@apache.org> on 2018/05/29 20:36:48 UTC, 3 replies.
- Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG. - posted by James Peach <jp...@apache.org> on 2018/05/29 22:46:04 UTC, 10 replies.
- Review Request 67369: Introduced a weighted shuffle algorithm implementation. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/30 00:55:09 UTC, 2 replies.
- Review Request 67370: Added a test for weighted shuffling. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/30 00:57:53 UTC, 1 replies.
- Review Request 67371: Introduced a random sorter as an alternative to the DRF sorter. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/30 01:00:44 UTC, 0 replies.
- Review Request 67372: Updated sorter tests to run against multiple sorters where possible. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/30 01:02:15 UTC, 0 replies.
- Review Request 67373: Added typedefs for using the allocator with random sorters. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/30 01:11:09 UTC, 0 replies.
- Review Request 67374: Updated flags to support choosing the random sorter. - posted by Benjamin Mahler <bm...@apache.org> on 2018/05/30 01:11:14 UTC, 1 replies.
- Review Request 67375: Added the `RPC` enum and `RPCTraits` helper. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/30 02:57:57 UTC, 2 replies.
- Review Request 67377: White list fds that child processes can inherit in mesos containerizer. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/30 06:27:53 UTC, 1 replies.
- Re: Review Request 67288: White list fds that child processes can inherit in stout. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/30 07:04:23 UTC, 2 replies.
- Review Request 67380: Replaced raw string literals with escaped C-style string literals. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/30 09:58:45 UTC, 1 replies.
- Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/30 13:04:37 UTC, 1 replies.
- Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/30 13:06:29 UTC, 1 replies.
- Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md. - posted by Qian Zhang <zh...@gmail.com> on 2018/05/30 13:10:20 UTC, 2 replies.
- Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:39:41 UTC, 1 replies.
- Review Request 67393: Windows: Ported io_tests.cpp. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:40:51 UTC, 2 replies.
- Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:41:39 UTC, 0 replies.
- Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:42:43 UTC, 0 replies.
- Review Request 67390: Windows: Integrated libwinio with libprocess code. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:46:13 UTC, 0 replies.
- Review Request 67389: Windows: Implemented Windows IOCP async backend. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:54:34 UTC, 3 replies.
- Review Request 67388: Moved: `io::internal::read/write` to separate file. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:55:40 UTC, 0 replies.
- Review Request 67387: Updated Mesos code to use `io::prepare_async`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:56:03 UTC, 0 replies.
- Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:56:54 UTC, 0 replies.
- Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/30 18:58:11 UTC, 0 replies.
- Review Request 67394: White list fds that child processes can inherit in mesos containerizer. - posted by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/05/30 19:25:00 UTC, 3 replies.
- Review Request 67395: Fixed socket creation bug in docker.cpp. - posted by Akash Gupta <ak...@hotmail.com> on 2018/05/31 02:59:39 UTC, 2 replies.
- Review Request 67398: Changed nested container tests to not use pipes for synchronization. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/05/31 14:55:49 UTC, 1 replies.
- Review Request 67401: Fixed segfault in libprocess due to order-of-evaluation bug. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/31 15:47:07 UTC, 2 replies.
- Re: Review Request 67401: Removed undefined behaviour in libprocess due to order-of-evaluation bug. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/31 16:11:11 UTC, 2 replies.
- Review Request 67403: Handled race condition when removing maintenance windows. - posted by Benno Evers <be...@mesosphere.com> on 2018/05/31 16:29:06 UTC, 5 replies.