You are viewing a plain text version of this content. The canonical link for it is here.
- Review Request 66387: Link subversion in stout build on FreeBSD. - posted by David Forsythe <df...@gmail.com> on 2018/04/01 03:25:13 UTC, 4 replies.
- Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/02 17:02:10 UTC, 7 replies.
- Re: Review Request 66385: Link execinfo in Glog build on FreeBSD. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/02 17:05:39 UTC, 4 replies.
- Re: Review Request 66365: Fixed generation of operation statuses in `Slave::applyOperation()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/02 17:15:12 UTC, 1 replies.
- Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/02 17:57:49 UTC, 6 replies.
- Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/02 17:59:09 UTC, 4 replies.
- Re: Review Request 66144: Enforced task launch order on the agent. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/02 18:04:29 UTC, 4 replies.
- Re: Review Request 66367: Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/02 18:15:18 UTC, 1 replies.
- Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. - posted by David Forsythe <df...@gmail.com> on 2018/04/02 18:16:14 UTC, 15 replies.
- Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/02 18:42:34 UTC, 16 replies.
- Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/04/02 20:30:07 UTC, 14 replies.
- Re: Review Request 66322: Fixed a potential race in `Sequence`. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/02 23:33:44 UTC, 1 replies.
- Re: Review Request 66165: Re-fixed many master allocator tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/03 09:22:41 UTC, 4 replies.
- Re: Review Request 66396: Bugfix for MESOS-8308. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/03 15:38:29 UTC, 0 replies.
- Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/03 16:19:30 UTC, 6 replies.
- Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). - posted by Benno Evers <be...@mesosphere.com> on 2018/04/03 16:27:08 UTC, 2 replies.
- Re: Review Request 63366: Add jemalloc release tarball and build rules. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/03 16:28:25 UTC, 1 replies.
- Re: Review Request 63368: Added MemoryProfiler class to Libprocess. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/03 16:29:19 UTC, 9 replies.
- Re: Review Request 63372: Added documentation for memory profiling. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/03 17:39:43 UTC, 14 replies.
- Re: Review Request 66145: Added a test to verify that task launch order is enforced. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/03 17:40:42 UTC, 6 replies.
- Re: Review Request 66178: Added a test to verify that task launch order is enforced. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/03 17:51:53 UTC, 4 replies.
- Review Request 66398: Bumped the CSI spec bundle to 0.2.0. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 18:45:40 UTC, 2 replies.
- Review Request 66407: Updated CSI client to support v0.2. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:12:21 UTC, 1 replies.
- Review Request 66408: Updated CSI helpers for v0.2. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:15:14 UTC, 5 replies.
- Review Request 66409: Used `csi::v0::VolumeCapability` in disk profile adaptors. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:18:19 UTC, 1 replies.
- Review Request 66410: Adapted storage local resource provider to use CSI v0.2. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:20:07 UTC, 5 replies.
- Review Request 66411: Made the test CSI plugin compatible to CSI v0.2. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:22:30 UTC, 5 replies.
- Review Request 66412: Fixed flaky agent test. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/03 22:10:22 UTC, 10 replies.
- Re: Review Request 66346: Added two matchers for TaskInfo and TaskGroup. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/04 00:15:04 UTC, 0 replies.
- Re: Review Request 66323: Added tests for failed task launch on agent. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/04 00:17:21 UTC, 9 replies.
- Re: Review Request 66347: Added a test for killing executor during task launch. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/04 00:58:34 UTC, 9 replies.
- Re: Review Request 66346: Added three matchers for agent tests. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/04 03:21:21 UTC, 0 replies.
- Review Request 66418: Handled failed publish and unpublish CSI calls properly. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/04 04:01:03 UTC, 4 replies.
- Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:46:59 UTC, 4 replies.
- Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:47:08 UTC, 2 replies.
- Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:47:13 UTC, 2 replies.
- Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:47:34 UTC, 4 replies.
- Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:47:39 UTC, 9 replies.
- Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:47:59 UTC, 3 replies.
- Review Request 66426: Windows: More constness in stout. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:48:08 UTC, 3 replies.
- Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:48:29 UTC, 3 replies.
- Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. - posted by Gilbert Song <so...@gmail.com> on 2018/04/04 05:48:37 UTC, 2 replies.
- Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:49:35 UTC, 5 replies.
- Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:49:50 UTC, 4 replies.
- Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:50:06 UTC, 3 replies.
- Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:50:37 UTC, 14 replies.
- Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc. - posted by Gilbert Song <so...@gmail.com> on 2018/04/04 05:50:56 UTC, 4 replies.
- Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:50:59 UTC, 6 replies.
- Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:51:24 UTC, 5 replies.
- Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:51:50 UTC, 4 replies.
- Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:52:04 UTC, 4 replies.
- Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:54:39 UTC, 3 replies.
- Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:55:55 UTC, 14 replies.
- Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:56:36 UTC, 4 replies.
- Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:56:45 UTC, 6 replies.
- Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:57:00 UTC, 8 replies.
- Review Request 66441: Fixed mismatched types in `process.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:57:09 UTC, 3 replies.
- Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:57:46 UTC, 4 replies.
- Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:58:13 UTC, 3 replies.
- Review Request 66444: Windows: Made `signals.hpp` compile. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:58:35 UTC, 4 replies.
- Review Request 66445: Windows: Cleaned up included CRT headers. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 05:58:43 UTC, 9 replies.
- Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/04 12:17:58 UTC, 6 replies.
- Review Request 66450: Added missing gmock expectation. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/04 12:21:39 UTC, 3 replies.
- Review Request 66451: Added devolve function for 'ResourceProviderInfo'. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/04 12:35:50 UTC, 3 replies.
- Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. - posted by Harold Dost <h....@criteo.com> on 2018/04/04 17:41:16 UTC, 6 replies.
- Review Request 66454: Updated the documented release schedule. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/04 18:48:10 UTC, 5 replies.
- Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/04 19:15:55 UTC, 3 replies.
- Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/04 19:20:43 UTC, 1 replies.
- Review Request 66457: Made resource provider API aware of workloads. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/04 23:22:54 UTC, 2 replies.
- Review Request 66458: Fixed handling of operations in `master::recoverFramework()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:47:26 UTC, 2 replies.
- Review Request 66459: Fixed bug in `Master::updateSlave()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:49:44 UTC, 3 replies.
- Review Request 66460: Added a `call()` method to the v1 scheduler library. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:53:03 UTC, 22 replies.
- Review Request 66461: Added an evolve function for `v1::scheduler::Response`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:54:28 UTC, 5 replies.
- Review Request 66462: Added new operation states to be used for status reconciliation. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:58:57 UTC, 6 replies.
- Review Request 66463: Added a master metric for operations reconciliation messages. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/04 23:59:34 UTC, 2 replies.
- Review Request 66464: Implemented operation status reconciliation. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/05 00:47:39 UTC, 12 replies.
- Review Request 66465: Updated `using` statements in `tests/mesos.hpp`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/05 00:48:37 UTC, 2 replies.
- Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/05 00:49:07 UTC, 2 replies.
- Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/05 00:50:09 UTC, 4 replies.
- Review Request 66471: Added stringification for resource provider message type. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/05 08:48:40 UTC, 3 replies.
- Re: Review Request 65462: Used the new 'route()' overload from libprocess. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/05 10:28:03 UTC, 2 replies.
- Review Request 66474: Updated minimum supported Linux kernel version. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/05 12:21:32 UTC, 4 replies.
- Review Request 66476: Tightened resource provider manager registrar tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/05 14:14:23 UTC, 3 replies.
- Re: Review Request 65940: Added test validating hierarchical role accounting. - posted by Till Toenshoff <to...@me.com> on 2018/04/05 16:15:35 UTC, 4 replies.
- Re: Review Request 65939: Updated role endpoints for hierarchical accounting. - posted by Till Toenshoff <to...@me.com> on 2018/04/05 16:15:39 UTC, 3 replies.
- Review Request 66481: Converted `pid` in command executor to `Option`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/05 23:31:16 UTC, 9 replies.
- Re: Review Request 66342: Added difference operator overload for hashset. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/06 03:25:50 UTC, 0 replies.
- Re: Review Request 66343: Added test for difference operator of hashset. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/06 03:26:52 UTC, 1 replies.
- Re: Review Request 64970: Use tox for linting and testing code living uder src/python. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/04/06 09:46:32 UTC, 1 replies.
- Re: Review Request 66311: Implement recovery of resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/06 14:22:35 UTC, 15 replies.
- Re: Review Request 66164: Added to a comment in master.cpp. - posted by Till Toenshoff <to...@me.com> on 2018/04/06 18:09:24 UTC, 0 replies.
- Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/06 23:09:14 UTC, 2 replies.
- Review Request 66489: Cleaned up internal evolve functions. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/07 00:16:55 UTC, 3 replies.
- Re: Review Request 65819: Enforced quota limit in the first resource allocation stage. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/07 00:42:53 UTC, 0 replies.
- Review Request 66493: Made FreeBSD default to non-GNU ld. - posted by David Forsythe <df...@gmail.com> on 2018/04/07 14:54:50 UTC, 15 replies.
- Re: Review Request 66258: Added `max_completion_time` to `TaskInfo` and new reason. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:51:25 UTC, 2 replies.
- Re: Review Request 66259: Added `max_completion_time` support to command executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:51:53 UTC, 3 replies.
- Re: Review Request 66260: Tested `max_completion_time` support in command executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:52:19 UTC, 2 replies.
- Re: Review Request 66283: Added support of `max_completion_time` in docker executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:52:45 UTC, 4 replies.
- Re: Review Request 66284: Tested `max_completion_time` support in docker executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:53:10 UTC, 3 replies.
- Re: Review Request 66291: Added support to `max_completion_time` in default executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:53:34 UTC, 2 replies.
- Re: Review Request 66293: Tested default executor support of `max_completion_time`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/08 00:54:16 UTC, 7 replies.
- Review Request 66508: Made sure test agent has reached stable state before starting test. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/09 14:07:08 UTC, 3 replies.
- Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/09 15:44:57 UTC, 4 replies.
- Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/09 15:45:03 UTC, 7 replies.
- Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/09 19:15:55 UTC, 18 replies.
- Review Request 66468: Added tests for operation status reconciliation. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/09 21:53:09 UTC, 16 replies.
- Re: Review Request 66050: Implemented grow and shrink of persistent volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/10 04:18:27 UTC, 26 replies.
- Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/10 04:21:19 UTC, 7 replies.
- Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/10 04:22:14 UTC, 7 replies.
- Re: Review Request 66415: Changed SLEEP_COMMAND to use ping instead of powershell Start-Sleep on Windows. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/10 09:21:19 UTC, 0 replies.
- Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:07:47 UTC, 5 replies.
- Re: Review Request 66308: Delayed construction of the agent's resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:07:54 UTC, 9 replies.
- Re: Review Request 66309: Externalize creation of resource provider manager backing storage. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:07:55 UTC, 1 replies.
- Re: Review Request 66310: Passed on registrar when constructing resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:07:56 UTC, 10 replies.
- Review Request 66527: Avoided copy in accessing resource provider subscription field. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:56:18 UTC, 2 replies.
- Review Request 66528: Added logging of failed resource provider registry updates. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:56:19 UTC, 3 replies.
- Review Request 66531: Added new authorization for `UpdateVolume`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/10 19:24:04 UTC, 9 replies.
- Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/10 19:24:30 UTC, 7 replies.
- Re: Review Request 66044: Refactored resources chopping logic in allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/10 22:00:02 UTC, 3 replies.
- Review Request 66538: Added unit test slave recovery for default executor tests. - posted by Gilbert Song <so...@gmail.com> on 2018/04/10 23:41:53 UTC, 6 replies.
- Review Request 66539: Fixed the agent recovery crash if metadata is missing. - posted by Gilbert Song <so...@gmail.com> on 2018/04/10 23:41:55 UTC, 2 replies.
- Review Request 66540: Added unit test for recovering nested container without slave state. - posted by Gilbert Song <so...@gmail.com> on 2018/04/10 23:41:56 UTC, 1 replies.
- Review Request 66541: Added default executor test for agent recovery without metadata. - posted by Gilbert Song <so...@gmail.com> on 2018/04/10 23:41:57 UTC, 7 replies.
- Re: Review Request 65334: Added quota limit to the master API protos. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/11 01:25:40 UTC, 2 replies.
- Re: Review Request 66457: WIP: Made resource provider API aware of workloads. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/11 02:38:36 UTC, 3 replies.
- Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/11 07:35:50 UTC, 5 replies.
- Review Request 66544: Remembered recovered and subscribed providers in ephemeral state. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/11 09:23:33 UTC, 3 replies.
- Review Request 66545: Added admitted resource providers to the manager's registry. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/11 09:23:35 UTC, 11 replies.
- Review Request 66546: Prevent resubscription of resource providers with unknown IDs. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/11 09:32:17 UTC, 12 replies.
- Re: Review Request 64211: Added options to build the Python CLI and run unit tests. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/11 10:14:16 UTC, 3 replies.
- Review Request 66553: Restructured Web UI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/04/11 15:21:25 UTC, 1 replies.
- Review Request 66554: Updated Web UI controllers to have one file per controller. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/04/11 15:23:08 UTC, 4 replies.
- Re: Review Request 66228: Added Call for updating framework info. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/04/11 17:28:38 UTC, 1 replies.
- Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/04/11 17:28:45 UTC, 4 replies.
- Review Request 66559: Made agent flag '--hadoop_home' as optional. - posted by Gilbert Song <so...@gmail.com> on 2018/04/11 18:31:04 UTC, 2 replies.
- Review Request 66560: Added a new agent flag . - posted by Gilbert Song <so...@gmail.com> on 2018/04/11 18:31:07 UTC, 3 replies.
- Review Request 66561: Supported hdfs fetching in local puller. - posted by Gilbert Song <so...@gmail.com> on 2018/04/11 18:31:11 UTC, 2 replies.
- Review Request 66562: Added test for local puller hdfs uri fetcher plugin. - posted by Gilbert Song <so...@gmail.com> on 2018/04/11 18:31:12 UTC, 3 replies.
- Re: Review Request 66230: Added test for adding/removing framework roles. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/11 18:51:34 UTC, 5 replies.
- Review Request 66568: Dropped GROW and SHRINK volume if combined with other operations. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/11 21:18:30 UTC, 2 replies.
- Re: Review Request 66219: Added helper functions to create grow and shrink volume in test. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/11 21:18:52 UTC, 1 replies.
- Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/11 21:19:16 UTC, 10 replies.
- Review Request 66569: Added a test to verify that grow and shrink cannot be combined. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/11 21:19:46 UTC, 2 replies.
- Review Request 66574: Updated filesystem layout for staging and mounting CSI volumes. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 01:33:11 UTC, 1 replies.
- Re: Review Request 63295: Update glog-0.3.3.patch to build on ARM. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/12 01:33:49 UTC, 0 replies.
- Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 01:35:31 UTC, 2 replies.
- Review Request 66576: Added `STAGE_UNSTAGE_VOLUME` capability to the test CSI plugin. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 01:36:31 UTC, 1 replies.
- Review Request 66577: Enabled CSI proto compilation by default. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 01:39:34 UTC, 11 replies.
- Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/12 02:06:43 UTC, 7 replies.
- Re: Review Request 61096: Building gRPC with CMake. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:22:55 UTC, 12 replies.
- Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:31:30 UTC, 3 replies.
- Re: Review Request 65974: Added comments and made some renaming in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:33:49 UTC, 3 replies.
- Re: Review Request 65594: Checkpointed profiles in storage local resource provider. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:35:12 UTC, 7 replies.
- Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:36:32 UTC, 2 replies.
- Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:37:04 UTC, 1 replies.
- Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 03:37:36 UTC, 1 replies.
- Re: Review Request 65665: Added operation state metrics in SLRP. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 05:11:13 UTC, 3 replies.
- Re: Review Request 66163: Built storage local resource provider with CMake. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 05:15:37 UTC, 10 replies.
- Re: Review Request 65585: Improved documentation regarding the new CLI setup. - posted by Kevin Klues <kl...@gmail.com> on 2018/04/12 12:21:23 UTC, 3 replies.
- Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths. - posted by Kevin Klues <kl...@gmail.com> on 2018/04/12 12:23:26 UTC, 2 replies.
- Re: Review Request 61118: Libprocess: Building gRPC support with CMake. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/12 16:55:08 UTC, 1 replies.
- Re: Review Request 65666: Added a unit test for SLRP operation state metrics. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/12 17:46:59 UTC, 3 replies.
- Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/12 21:17:09 UTC, 0 replies.
- Review Request 66591: Added a validation that `max_completion_time` must be non-negative. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/12 21:20:09 UTC, 2 replies.
- Re: Review Request 53267: Added a gauge to track active subscribers. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/12 21:32:55 UTC, 4 replies.
- Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/04/13 11:12:23 UTC, 0 replies.
- Re: Review Request 63366: Added jemalloc release tarball and build rules. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/13 12:03:33 UTC, 3 replies.
- Review Request 66608: Improved support for move-only types in `hashmap`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/13 13:09:52 UTC, 14 replies.
- Re: Review Request 64921: Fixed a typo and formatting in docs. - posted by Jie Yu <yu...@gmail.com> on 2018/04/13 22:00:57 UTC, 0 replies.
- Re: Review Request 64922: Added VOTING replica catch-up section to replicated log docs. - posted by Jie Yu <yu...@gmail.com> on 2018/04/13 22:01:42 UTC, 0 replies.
- Re: Review Request 64923: Added replicated log reader catch-up section to the upgrades doc. - posted by Jie Yu <yu...@gmail.com> on 2018/04/13 22:02:56 UTC, 0 replies.
- Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests. - posted by James Peach <jp...@apache.org> on 2018/04/13 23:57:45 UTC, 6 replies.
- Review Request 66616: Marked volume/block creation and destroy operations as experimental. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/14 01:06:13 UTC, 7 replies.
- Re: Review Request 66038: Add inodeUsage to provide inode usage. - posted by fei long <ca...@gmail.com> on 2018/04/14 08:43:54 UTC, 1 replies.
- Review Request 66621: Add alg RS256 support for JWT generator and validator. - posted by Clément Michaud <cl...@gmail.com> on 2018/04/14 22:15:57 UTC, 6 replies.
- Review Request 66635: Fixed potential races when interacting with cgroup subsystem isolators. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/16 15:03:20 UTC, 4 replies.
- Review Request 66634: Explicitly marked functions `override` in cgroup subsystems. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/16 15:03:21 UTC, 0 replies.
- Review Request 66637: Added a `createDockerInfo` helper API in Docker containerizer tests. - posted by James Peach <jp...@apache.org> on 2018/04/16 16:52:07 UTC, 6 replies.
- Re: Review Request 66344: Supported non-speculative operations on agent default resources. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/16 18:08:01 UTC, 2 replies.
- Review Request 66641: Added `FsTest.Open` to cover `os::open()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/16 20:24:53 UTC, 3 replies.
- Re: Review Request 66621: Add support for alg RS256 to JWT library. - posted by Clément Michaud <cl...@gmail.com> on 2018/04/16 21:00:16 UTC, 11 replies.
- Review Request 66643: WIP: Attribute filters. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/16 21:28:27 UTC, 2 replies.
- Re: Review Request 66052: Added new operator API to grow and shrink persistent volume. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/16 22:46:09 UTC, 2 replies.
- Review Request 66648: Marked the resource provider API as experimental. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/16 23:32:06 UTC, 6 replies.
- Review Request 66624: Deprecated Role::resources in favor of Role::allocated. - posted by Till Toenshoff <to...@me.com> on 2018/04/16 23:39:14 UTC, 0 replies.
- Review Request 66625: Updated role-endpoint tests for Role::resources rename. - posted by Till Toenshoff <to...@me.com> on 2018/04/16 23:39:39 UTC, 0 replies.
- Review Request 66628: Added role tracking unit tests. - posted by Till Toenshoff <to...@me.com> on 2018/04/16 23:42:46 UTC, 1 replies.
- Re: Review Request 61118: Building gRPC support in libprocess with CMake. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/17 03:17:45 UTC, 4 replies.
- Review Request 66650: Removed an invalid TODO in puller.cpp. - posted by Gilbert Song <so...@gmail.com> on 2018/04/17 05:32:49 UTC, 1 replies.
- Review Request 66651: Supported host and port in hdfs constructor. - posted by Gilbert Song <so...@gmail.com> on 2018/04/17 05:32:50 UTC, 2 replies.
- Review Request 66652: Renamed local_puller to image_tar_puller. - posted by Gilbert Song <so...@gmail.com> on 2018/04/17 05:32:56 UTC, 3 replies.
- Review Request 66657: Updated Config initialization for new CLI if file does not exist. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/04/17 09:43:27 UTC, 2 replies.
- Review Request 66666: Added MemoryProfiler to CHANGELOG. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/17 13:33:16 UTC, 4 replies.
- Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/17 15:23:28 UTC, 0 replies.
- Review Request 66669: Added clean up of `containers_` map in composing containerizer. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/17 15:23:35 UTC, 0 replies.
- Review Request 66670: Ensured that `wait()` and `destroy()` return the same result. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/17 15:23:42 UTC, 0 replies.
- Review Request 66671: Updated composing containerizer tests. (WIP) - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/17 15:23:50 UTC, 2 replies.
- Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/17 17:00:01 UTC, 23 replies.
- Review Request 66649: Added pb2gen.sh for generating python protobuf bindings. - posted by Eric Chung <ci...@gmail.com> on 2018/04/17 19:03:18 UTC, 5 replies.
- Review Request 66679: Made the master send operation status updates when dropping operations. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/18 00:21:02 UTC, 8 replies.
- Review Request 66683: Updated address field of new CLI config to accept URLs. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/04/18 13:14:21 UTC, 6 replies.
- Review Request 66692: Fixed an documentation error in `monitoring.md`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/18 17:37:43 UTC, 3 replies.
- Review Request 66694: Updated the 1.6.0 CHANGELOG. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/18 18:45:41 UTC, 4 replies.
- Review Request 66696: Updated Scheduler HTTP API doc for operation feedback. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/18 20:36:39 UTC, 7 replies.
- Review Request 66699: Added include to stouts os.hpp header. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/18 20:55:39 UTC, 2 replies.
- Review Request 66700: Changed call from os::shell() to os::system(). - posted by Benno Evers <be...@mesosphere.com> on 2018/04/18 20:56:12 UTC, 2 replies.
- Re: Review Request 66309: Externalized creation of resource provider manager backing storage. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/18 21:31:22 UTC, 10 replies.
- Review Request 66704: Refactored the executor launch path. - posted by James Peach <jp...@apache.org> on 2018/04/18 22:11:57 UTC, 2 replies.
- Review Request 66705: Propagated executor sandbox creation errors. - posted by James Peach <jp...@apache.org> on 2018/04/18 22:12:13 UTC, 4 replies.
- Review Request 66706: Handled failing to create the executor sandbox. - posted by James Peach <jp...@apache.org> on 2018/04/18 22:12:26 UTC, 3 replies.
- Review Request 66707: Added a test for launching a task as an unknown user. - posted by James Peach <jp...@apache.org> on 2018/04/18 22:12:42 UTC, 2 replies.
- Review Request 66708: Refactored sending a TASK_DROPPED status update. - posted by James Peach <jp...@apache.org> on 2018/04/18 22:13:16 UTC, 8 replies.
- Review Request 66709: Windows: Fixed Ninja in Release configuration. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/19 01:17:10 UTC, 2 replies.
- Review Request 66711: Made 3rdparty jemalloc only build when enabled. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/19 02:12:57 UTC, 5 replies.
- Re: Review Request 62472: Fixed the ordering of Mesos containerizer isolators. - posted by Gilbert Song <so...@gmail.com> on 2018/04/19 02:44:08 UTC, 4 replies.
- Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/19 16:30:58 UTC, 13 replies.
- Re: Review Request 66696: Updated documentation for operation feedback. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/19 18:12:03 UTC, 8 replies.
- Review Request 66725: Improved error message in the fetcher. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/19 23:08:20 UTC, 3 replies.
- Review Request 66726: Made CMake's `FindZLIB` module be able to find Zlib on Windows. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/20 02:23:54 UTC, 1 replies.
- Review Request 66727: Cherry-picked gRPC PR15128 for Windows compilation. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/20 02:24:40 UTC, 0 replies.
- Re: Review Request 66311: Set up recovery code paths of resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/20 10:23:22 UTC, 9 replies.
- Review Request 66733: Added a new `RESIZE_VOLUME` agent capability. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/20 18:38:49 UTC, 4 replies.
- Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/04/20 20:19:47 UTC, 4 replies.
- Review Request 66749: Added more logging to agent recovery path. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/20 22:02:09 UTC, 7 replies.
- Re: Review Request 66727: Cherry-picked gRPC PR #15128 for Windows compilation. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/20 23:08:39 UTC, 2 replies.
- Re: Review Request 66531: Added new authorization for `ResizeVolume`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/20 23:16:56 UTC, 2 replies.
- Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/20 23:17:27 UTC, 3 replies.
- Review Request 66753: Windows: Fixed build with OpenSSL due to missing header. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/20 23:52:32 UTC, 4 replies.
- Review Request 66759: Fixed a regression in isolator ordering. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/04/23 09:55:29 UTC, 4 replies.
- Review Request 66762: Removed `developers` from Java binding mesos.pom file. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/23 13:27:10 UTC, 3 replies.
- Review Request 66644: Remove unknown unreachable tasks when agent re-registers. - posted by Megha Sharma <ms...@apple.com> on 2018/04/23 18:11:16 UTC, 1 replies.
- Re: Review Request 66644: WIP:Remove unknown unreachable tasks when agent re-registers. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/23 20:58:10 UTC, 0 replies.
- Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/04/23 22:23:19 UTC, 4 replies.
- Review Request 66776: Changed failure check for a call to os::system(). - posted by Benno Evers <be...@mesosphere.com> on 2018/04/24 14:40:02 UTC, 2 replies.
- Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/24 17:12:21 UTC, 7 replies.
- Review Request 66778: Fixed Master which generated updates with the latest task state. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/04/24 18:03:23 UTC, 2 replies.
- Re: Review Request 66779: Inserted explicit moves in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/24 18:58:19 UTC, 1 replies.
- Review Request 66780: Removed redundant master flags in resource provider tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/24 19:28:41 UTC, 4 replies.
- Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/24 20:41:18 UTC, 3 replies.
- Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/24 23:18:53 UTC, 5 replies.
- Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/25 16:45:06 UTC, 3 replies.
- Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/25 16:46:54 UTC, 3 replies.
- Review Request 66405: Doc improvements (wip). - posted by Benno Evers <be...@mesosphere.com> on 2018/04/26 09:59:03 UTC, 0 replies.
- Re: Review Request 63371: Added unit test for new MemoryProfiler class. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/26 09:59:27 UTC, 1 replies.
- Review Request 66811: Added `libacl` as a dependency of stout. - posted by Qian Zhang <zh...@gmail.com> on 2018/04/26 14:03:42 UTC, 5 replies.
- Review Request 66812: Added `libacl` as a dependency of Mesos. - posted by Qian Zhang <zh...@gmail.com> on 2018/04/26 14:04:22 UTC, 0 replies.
- Review Request 66813: Added `setfacl()` and `getfacl()` in stout. - posted by Qian Zhang <zh...@gmail.com> on 2018/04/26 14:07:24 UTC, 0 replies.
- Review Request 66814: Added a test `FsAclTest.ManipulateAcl`. - posted by Qian Zhang <zh...@gmail.com> on 2018/04/26 14:09:23 UTC, 2 replies.
- Review Request 66815: Removed an unconditional .get() in DefaultExecutor. - posted by Benno Evers <be...@mesosphere.com> on 2018/04/26 15:24:39 UTC, 2 replies.
- Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/26 17:00:08 UTC, 2 replies.
- Review Request 66817: Enabled composing containerizer as a default containerizer in tests. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/04/26 17:18:34 UTC, 4 replies.
- Review Request 66828: Introduced a push-based gauge metric. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/26 21:54:13 UTC, 1 replies.
- Review Request 66830: Added a test for PushGauge. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/26 21:54:16 UTC, 1 replies.
- Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/26 21:54:17 UTC, 2 replies.
- Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/26 21:54:21 UTC, 3 replies.
- Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image. - posted by Qian Zhang <zh...@gmail.com> on 2018/04/27 01:35:39 UTC, 2 replies.
- Review Request 66834: Windows: Specialized `flags::parse`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/27 04:22:01 UTC, 2 replies.
- Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/27 04:22:24 UTC, 2 replies.
- Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/27 04:22:45 UTC, 4 replies.
- Re: Review Request 66820: Added framework metrics 'subscribed' and helpers. - posted by Gilbert Song <so...@gmail.com> on 2018/04/27 06:54:15 UTC, 1 replies.
- Re: Review Request 66840: Added `libacl` into a few Dockerfiles. - posted by Qian Zhang <zh...@gmail.com> on 2018/04/27 08:30:55 UTC, 1 replies.
- Review Request 66849: Added missing test expectation. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/27 10:15:06 UTC, 2 replies.
- Re: Review Request 66841: Added a hash function for 'Duration'. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/27 15:40:51 UTC, 0 replies.
- Re: Review Request 66842: Added counter metrics for offer filter durations. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/27 15:42:28 UTC, 1 replies.
- Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/27 15:44:32 UTC, 1 replies.
- Re: Review Request 66844: Added framework metrics for filtered resources to the allocator. - posted by Greg Mann <gr...@mesosphere.io> on 2018/04/27 16:54:16 UTC, 3 replies.
- Re: Review Request 66819: Added FrameworkMetrics struct in framework struct. - posted by Gilbert Song <so...@gmail.com> on 2018/04/27 18:39:59 UTC, 0 replies.
- Re: Review Request 66822: Added per Framework Calls to metrics. - posted by Gilbert Song <so...@gmail.com> on 2018/04/27 18:51:07 UTC, 1 replies.
- Re: Review Request 66438: Windows: Made `libevent` use `int_fd` correctly. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/04/27 20:50:51 UTC, 0 replies.
- Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/27 22:07:52 UTC, 1 replies.
- Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path. - posted by Benjamin Mahler <bm...@apache.org> on 2018/04/29 01:40:33 UTC, 5 replies.
- Review Request 66864: Updated FrameworkInfo comparator. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/04/29 03:36:27 UTC, 2 replies.
- Review Request 66868: Used `operator->` instead of `get`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/04/30 09:14:32 UTC, 3 replies.
- Re: Review Request 66821: Added framwork metrics helper normalize() and getPrefix(). - posted by Gilbert Song <so...@gmail.com> on 2018/04/30 18:41:11 UTC, 0 replies.
- Review Request 66871: Added documentation about new gauge on `master/subscribers_active`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 20:59:56 UTC, 0 replies.
- Re: Review Request 54986: Added metric for slave message queue. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 21:01:49 UTC, 1 replies.
- Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 21:09:16 UTC, 2 replies.
- Review Request 66872: Updated FrameworkInfo comparator. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/04/30 21:13:18 UTC, 0 replies.
- Re: Review Request 66870: Added per-framework metrics for suppressed roles. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/30 21:18:37 UTC, 0 replies.
- Re: Review Request 53330: Tracked layers and pull latency in docker store. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 21:23:43 UTC, 1 replies.
- Review Request 66860: Avoid copying of register framework messages in the master. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/30 21:47:53 UTC, 1 replies.
- Re: Review Request 65852: Added a test to ensure /quota and SET_QUOTA disallow limit. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/04/30 21:52:50 UTC, 0 replies.
- Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 22:35:59 UTC, 0 replies.
- Review Request 66875: Added an hourly timer for docker store pull latency. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 22:36:36 UTC, 2 replies.
- Re: Review Request 66292: Validated that all tasks in the same group have same max_duration. - posted by Zhitao Li <zh...@gmail.com> on 2018/04/30 22:51:13 UTC, 0 replies.
- Re: Review Request 66874: Added per-framework metrics for active task states. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/04/30 23:42:04 UTC, 0 replies.