reviews@mesos.apache.org, 2018-03

You are viewing a plain text version of this content. The canonical link for it is here.

- Re: Review Request 65683: Updated discard handling in `Docker::inspect()`. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/01 00:07:23 UTC, 0 replies.
- Re: Review Request 65839: Windows: Removed W* test-only macros in `windows.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/01 00:27:48 UTC, 0 replies.
- Re: Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/01 00:28:55 UTC, 2 replies.
- Re: Review Request 65841: Changed `os::system` to return `Option` instead of `int`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/01 00:32:06 UTC, 1 replies.
- Re: Review Request 65842: Changed `os::spawn` to return `Option` instead of `int`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/01 00:33:38 UTC, 1 replies.
- Review Request 65851: Disallow limit in /quota requests and SET_QUOTA calls. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:31:45 UTC, 3 replies.
- Review Request 65852: Added a test to ensure /quota and SET_QUOTA disallow limit. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:31:47 UTC, 0 replies.
- Re: Review Request 65780: Removed an unnecessary argument from master::Call validation. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:31:51 UTC, 1 replies.
- Review Request 65853: Updated createQuotaInfo helper to handle quota limit. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:34:12 UTC, 3 replies.
- Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2018/03/01 02:54:03 UTC, 0 replies.
- Re: Review Request 59987: Added protobuf map support. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/01 04:10:51 UTC, 1 replies.
- Review Request 65855: Added the `stall_timeout` parameter to `net::download()`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/01 05:13:24 UTC, 3 replies.
- Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/01 05:18:00 UTC, 6 replies.
- Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor. - posted by Gilbert Song <so...@gmail.com> on 2018/03/01 08:14:00 UTC, 5 replies.
- Re: Review Request 65759: Added inspect retries to the Docker executor. - posted by Gilbert Song <so...@gmail.com> on 2018/03/01 08:14:29 UTC, 0 replies.
- Re: Review Request 65839: Windows: Removed stout W* signal macros in `windows.hpp`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:45:51 UTC, 1 replies.
- Review Request 65864: Updated mesos code with the new `os::spawn`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:48:08 UTC, 4 replies.
- Re: Review Request 65842: Stout: Changed `os::spawn` to return `Option` instead of `int`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:50:42 UTC, 1 replies.
- Review Request 65863: Updated mesos code with the new `os::system`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:52:02 UTC, 1 replies.
- Review Request 65862: Windows: Removed signal macro in `checks/checker_process.cpp`. - posted by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:55:47 UTC, 1 replies.
- Review Request 65861: Windows: Removed use of W* signal macros in libprocess. - posted by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:56:25 UTC, 1 replies.
- Re: Review Request 65841: Stout: Changed `os::system` to return `Option` instead of `int`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/03/01 10:14:37 UTC, 1 replies.
- Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/03/01 13:49:11 UTC, 2 replies.
- Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/03/01 13:57:12 UTC, 9 replies.
- Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/03/01 14:07:38 UTC, 5 replies.
- Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/01 15:23:22 UTC, 5 replies.
- Review Request 65868: Added inspect retries to the docker containerizer in `update` method. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/03/01 18:12:45 UTC, 3 replies.
- Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/01 18:32:13 UTC, 3 replies.
- Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/01 19:19:57 UTC, 12 replies.
- Re: Review Request 63862: Windows: Ported docker_tests.cpp. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/03/01 20:24:23 UTC, 5 replies.
- Re: Review Request 65482: Improved handling of non-terminal operations after master failover. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/01 20:28:12 UTC, 2 replies.
- Re: Review Request 64970: Replace ad hoc venv under support/ with tox. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/01 22:21:55 UTC, 0 replies.
- Re: Review Request 64970: Use tox for linting and testing code living uder src/python. - posted by Eric Chung <ci...@gmail.com> on 2018/03/01 22:34:52 UTC, 6 replies.
- Re: Review Request 64211: Added options to build the Python CLI and run unit tests. - posted by Kevin Klues <kl...@gmail.com> on 2018/03/01 23:24:04 UTC, 9 replies.
- Review Request 65872: Windows: Fixed location of Docker's `config.json` file. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/01 23:57:06 UTC, 3 replies.
- Re: Review Request 65844: Added `upgradeResource` to some resource parsing functions. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/02 01:09:25 UTC, 0 replies.
- Re: Review Request 65845: Fixed broken test `SlavesEndpointFullResources`. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/02 01:09:27 UTC, 0 replies.
- Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/02 01:30:10 UTC, 0 replies.
- Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/02 01:33:19 UTC, 4 replies.
- Review Request 65875: Improved logging for offers and inverse offers. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/02 05:39:49 UTC, 7 replies.
- Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/02 05:42:46 UTC, 11 replies.
- Re: Review Request 63991: Added helpers to create and forward offer operation updates. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/02 08:06:35 UTC, 6 replies.
- Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/02 08:07:35 UTC, 17 replies.
- Re: Review Request 63994: Added a new test for validation of offer operation IDs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/02 08:07:54 UTC, 19 replies.
- Re: Review Request 65674: Introduced helper for creating Mesos UUIDs. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/03/02 12:31:00 UTC, 1 replies.
- Review Request 65886: Do not realpath executables from launcher_dir. - posted by Benjamin Peterson <be...@python.org> on 2018/03/02 17:03:40 UTC, 3 replies.
- Review Request 65887: Avoided orphan subprocess in the Docker library. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/02 19:07:50 UTC, 4 replies.
- Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now) - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/02 19:40:45 UTC, 5 replies.
- Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/02 19:41:32 UTC, 5 replies.
- Review Request 65890: Added used but not included header. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/02 23:16:01 UTC, 1 replies.
- Review Request 65891: Windows: Fixed bug with CPU isolator not checking the max boundary. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/02 23:16:40 UTC, 4 replies.
- Re: Review Request 65310: Added lambda::zip. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/02 23:40:20 UTC, 3 replies.
- Re: Review Request 65733: Windows: Fixed flaky Docker command health check test. - posted by Gilbert Song <so...@gmail.com> on 2018/03/03 00:36:30 UTC, 0 replies.
- Review Request 65898: Add `MesosContainerizerLaunchHelper` and subclasses for different OSes. - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/05 07:30:25 UTC, 3 replies.
- Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead. - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/05 07:31:36 UTC, 7 replies.
- Review Request 65905: Used SHA512 for release file checksums. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/05 13:42:57 UTC, 13 replies.
- Review Request 65906: Updated site's middleman to latest 3.x release. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/05 16:42:51 UTC, 13 replies.
- Re: Review Request 65587: Added hash function for mesos::UUID. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/05 19:21:51 UTC, 0 replies.
- Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/05 20:54:25 UTC, 0 replies.
- Review Request 65900: Defer creation of volume target paths to container launch. - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/05 22:01:07 UTC, 2 replies.
- Re: Review Request 65591: Explicitly tracked resource providers in master. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/05 22:21:02 UTC, 7 replies.
- Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/05 22:53:37 UTC, 0 replies.
- Re: Review Request 65589: Added comparison operators for operations. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/06 00:19:54 UTC, 0 replies.
- Re: Review Request 65590: Added helper function to determine provider ID of a conversion. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/06 00:27:57 UTC, 1 replies.
- Re: Review Request 61262: Added 'heartbeat' event for the operator API. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/06 02:44:43 UTC, 2 replies.
- Review Request 65915: Validated Docker info exists when container's type is DOCKER. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/06 07:34:04 UTC, 1 replies.
- Review Request 65916: Set Docker info for the test `TaskUsesDockerContainerInfo`. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/06 07:36:13 UTC, 1 replies.
- Review Request 65917: Added a test `TaskValidationTest.TaskMissingDockerInfo`. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/06 07:36:43 UTC, 3 replies.
- Review Request 65918: Made sure no `name` parameter exists in container's Docker info. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/06 08:40:33 UTC, 1 replies.
- Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/06 08:41:32 UTC, 4 replies.
- Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/06 09:29:12 UTC, 9 replies.
- Re: Review Request 65921: Simplified system requirements of balloon executor. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/06 13:08:57 UTC, 4 replies.
- Review Request 65928: Improved handling of many roles in Web UI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/06 15:24:44 UTC, 2 replies.
- Review Request 65930: Start heartbeater after SUBSCRIBED event. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/06 16:57:30 UTC, 11 replies.
- Review Request 65932: Added a generic mechanism to check for isolator requirements. - posted by James Peach <jp...@apache.org> on 2018/03/06 18:18:05 UTC, 5 replies.
- Re: Review Request 65719: Windows: Fixed CMake check of toolset for Ninja. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/06 20:04:51 UTC, 2 replies.
- Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/06 20:05:18 UTC, 7 replies.
- Re: Review Request 65721: Windows: Specified byproducts of `sasl2` imported target. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/06 20:05:47 UTC, 2 replies.
- Review Request 65938: Replaced "re-register" terminology with "reregister". - posted by James Peach <jp...@apache.org> on 2018/03/06 23:52:25 UTC, 3 replies.
- Review Request 65939: Updated role endpoints for hierarchical accounting. - posted by Till Toenshoff <to...@me.com> on 2018/03/07 00:22:55 UTC, 1 replies.
- Review Request 65940: Added test validating hierarchical role accounting. - posted by Till Toenshoff <to...@me.com> on 2018/03/07 00:23:01 UTC, 2 replies.
- Re: Review Request 65772: Moved some docker image setups to dedicated directory. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/07 10:05:48 UTC, 0 replies.
- Re: Review Request 65773: Introduced Docker image build and publish scripts. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/07 10:05:49 UTC, 0 replies.
- Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/03/07 12:37:40 UTC, 9 replies.
- Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/03/07 13:00:04 UTC, 0 replies.
- Review Request 65954: Add a gauge for how long agent recovery takes. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/07 17:08:21 UTC, 10 replies.
- Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/03/07 17:53:46 UTC, 16 replies.
- Review Request 65955: Fixed implicit conversion warnings. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/07 18:45:31 UTC, 2 replies.
- Review Request 65957: Updated Windows documentation. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/07 20:58:19 UTC, 3 replies.
- Re: Review Request 65719: Windows: Fixed CMake configuration for Ninja. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/07 21:43:55 UTC, 0 replies.
- Re: Review Request 65781: Added a TODO to clean up master::Call validation. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/07 23:16:52 UTC, 0 replies.
- Review Request 65959: Added a test to make sure `slave/recovery_secs` is reported in metrics. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/07 23:21:00 UTC, 2 replies.
- Re: Review Request 65692: Changed the signature of a DefaultExecutor kill method. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/03/07 23:42:41 UTC, 3 replies.
- Re: Review Request 65693: Made the default executor fail kills if the response isn't "200 OK". - posted by Joseph Wu <jo...@mesosphere.io> on 2018/03/07 23:43:03 UTC, 4 replies.
- Re: Review Request 65694: Made the default executor's handling of kill escalations more robust. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/03/07 23:50:21 UTC, 6 replies.
- Re: Review Request 65334: Added quota limit to the master API protos. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/08 00:33:40 UTC, 3 replies.
- Re: Review Request 65695: Made the default executor allow schedulers to retry task kills. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/03/08 00:43:03 UTC, 6 replies.
- Review Request 65962: Made the default executor use references to `Owned` pointers. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/08 02:07:46 UTC, 3 replies.
- Review Request 65964: Updated the master's status update handler to avoid unnecessary copying. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:28 UTC, 1 replies.
- Review Request 65965: Avoid copying of launch task messages in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:29 UTC, 1 replies.
- Review Request 65966: Updated the master's receive handler to take an rvalue reference. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:30 UTC, 1 replies.
- Review Request 65967: Eliminated some copying in the master's Accept call handler path. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:31 UTC, 3 replies.
- Review Request 65968: Updated the master's decline handler to take an rvalue reference. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:33 UTC, 3 replies.
- Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/08 04:24:07 UTC, 6 replies.
- Review Request 65969: Avoid a copy of the status update acknowledgements in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 04:24:47 UTC, 1 replies.
- Review Request 65970: Avoid copying acknowledgement message data in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 04:28:08 UTC, 1 replies.
- Review Request 65971: Avoid a copy of the scheduler->executor message in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 04:30:44 UTC, 2 replies.
- Review Request 65972: Avoid copying scheduler->executor message data in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 04:34:13 UTC, 1 replies.
- Review Request 65973: Avoid copying executor->scheduler message data in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/08 04:36:10 UTC, 3 replies.
- Review Request 65974: Added comments and made some renaming in SLRP. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/08 04:56:52 UTC, 1 replies.
- Re: Review Request 65594: Checkpointed profiles in storage local resource provider. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/08 05:04:44 UTC, 5 replies.
- Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/08 05:05:29 UTC, 1 replies.
- Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/08 05:05:36 UTC, 1 replies.
- Re: Review Request 65312: Refactored authorization logic in the master. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/08 05:07:43 UTC, 1 replies.
- Re: Review Request 65313: Refactored authorization logic in the agent. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/03/08 12:26:14 UTC, 7 replies.
- Re: Review Request 65314: Removed code which is not used. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/03/08 12:26:46 UTC, 4 replies.
- Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). - posted by Sagar Patwardhan <sa...@gmail.com> on 2018/03/08 17:07:42 UTC, 17 replies.
- Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/08 22:00:38 UTC, 9 replies.
- Review Request 65993: Added evolve functions for operation status updates. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/08 22:06:24 UTC, 2 replies.
- Review Request 65994: Made the master forward operation status updates to the schedulers. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/08 22:07:53 UTC, 9 replies.
- Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/08 23:39:51 UTC, 5 replies.
- Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. - posted by Harold Dost <h....@criteo.com> on 2018/03/09 17:04:28 UTC, 28 replies.
- Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs. - posted by Harold Dost <h....@criteo.com> on 2018/03/09 17:04:52 UTC, 3 replies.
- Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/03/09 19:27:41 UTC, 2 replies.
- Re: Review Request 66002: Fixed the HTTP API path variables on Windows. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2018/03/09 20:17:16 UTC, 9 replies.
- Review Request 66007: CMake: Set C++11 as standard automatically. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:37:44 UTC, 5 replies.
- Review Request 66008: CMake: Enabled compiler warnings. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:38:19 UTC, 10 replies.
- Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:38:49 UTC, 6 replies.
- Review Request 66010: Windows: Switched to default CRT linkage. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:14 UTC, 5 replies.
- Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:21 UTC, 3 replies.
- Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:28 UTC, 6 replies.
- Review Request 66013: Windows: Made ZooKeeper use default CRT linking. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:34 UTC, 4 replies.
- Review Request 66014: Windows: Made SASL use default CRT linking. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:40 UTC, 4 replies.
- Re: Review Request 65997: Added `PROTOC_SPEC_GENERATE` helper for cmake. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/09 22:44:25 UTC, 3 replies.
- Review Request 66015: Built CSI spec proto files with cmake. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/09 22:45:59 UTC, 4 replies.
- Re: Review Request 65665: Added operation state metrics in SLRP. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/09 22:55:23 UTC, 1 replies.
- Re: Review Request 65666: Added a unit test for SLRP operation state metrics. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/09 23:29:14 UTC, 3 replies.
- Review Request 66016: Refactored resource allocation logic. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/10 00:44:57 UTC, 8 replies.
- Review Request 66004: Updated task reconciliation path to avoid copying in v1. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/10 00:51:47 UTC, 3 replies.
- Review Request 66022: Based website-related Docker images on ubuntu16. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/10 17:49:27 UTC, 4 replies.
- Review Request 66025: Converted `JSON::String` to bool and integers. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/12 01:27:52 UTC, 5 replies.
- Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/12 01:30:42 UTC, 4 replies.
- Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/03/12 14:30:12 UTC, 2 replies.
- Review Request 65879: Added a new test for validation of offer operation IDs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/12 19:26:00 UTC, 0 replies.
- Review Request 66030: Fixed perf stat output parsing. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/03/13 00:03:47 UTC, 3 replies.
- Review Request 66031: Avoided copying when possible in Option::getOrElse. - posted by Benjamin Mahler <bm...@apache.org> on 2018/03/13 00:08:39 UTC, 1 replies.
- Review Request 66034: Remount several proc filesystem entries as read-only. - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/13 01:26:04 UTC, 7 replies.
- Re: Review Request 66025: Converted `JSON::String` to bool and numbers. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/13 06:48:25 UTC, 2 replies.
- Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools & numbers. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/13 07:09:41 UTC, 0 replies.
- Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/13 09:49:09 UTC, 2 replies.
- Review Request 66038: Add usageWithInode to check both disk and inode usage. - posted by fei long <ca...@gmail.com> on 2018/03/13 13:05:11 UTC, 1 replies.
- Review Request 66039: Check both disk and inode usage when slaves schedule gc. - posted by fei long <ca...@gmail.com> on 2018/03/13 13:05:20 UTC, 5 replies.
- Review Request 66037: Enabled agent resource provider capability by default. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/13 17:26:27 UTC, 21 replies.
- Review Request 66043: Renamed a variable in allocator to be consistent with others. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/13 18:07:30 UTC, 2 replies.
- Review Request 66044: Refactored resources chopping logic in allocator. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/13 22:04:19 UTC, 3 replies.
- Review Request 66045: Renamed `resources` in allocator to `toAllocate`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/13 22:18:02 UTC, 3 replies.
- Review Request 66046: CMake: Patched Boost to remove spurious warnings. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/13 22:30:22 UTC, 14 replies.
- Review Request 66048: Added missing comment on a test case. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/13 22:46:37 UTC, 2 replies.
- Review Request 66049: Added offer operation to grow and shrink persistent volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/13 22:48:26 UTC, 12 replies.
- Review Request 66050: Implement grow and shrink of persistent volume. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/13 22:49:08 UTC, 0 replies.
- Review Request 66052: Added new operator API to grow and shrink persistent volume. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/13 22:54:01 UTC, 6 replies.
- Review Request 66051: Implemented operator API to grow and shrink persistent volume. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/13 22:54:31 UTC, 11 replies.
- Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/13 23:19:46 UTC, 12 replies.
- Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/14 02:56:11 UTC, 9 replies.
- Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/14 09:00:22 UTC, 4 replies.
- Review Request 66056: Updated `CREATE_VOLUME()` helper to allow specifying an operation ID. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/14 09:08:07 UTC, 3 replies.
- Review Request 66057: Added a `createCallAcknowledgeOperationStatus()` test helper. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/14 09:08:51 UTC, 4 replies.
- Review Request 66058: Added v1 versions of some test helpers/matchers. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/14 09:11:05 UTC, 5 replies.
- Review Request 66060: Added end-to-end tests for operation feedback. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/14 09:29:04 UTC, 10 replies.
- Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/14 09:29:06 UTC, 3 replies.
- Review Request 66070: Document new `slave/recovery_time_secs` gauge. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/14 16:26:03 UTC, 2 replies.
- Re: Review Request 65959: Added a test to make sure `slave/recovery_time_secs` is reported. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/14 18:03:31 UTC, 1 replies.
- Re: Review Request 66015: Built CSI spec proto files with CMake. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 00:30:00 UTC, 1 replies.
- Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/15 02:38:57 UTC, 7 replies.
- Review Request 66088: Fixed crash on macOS during certain authorization calls. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/03/15 13:59:08 UTC, 4 replies.
- Review Request 66094: Bumped bundled gRPC to 1.10.0. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 19:18:24 UTC, 2 replies.
- Review Request 66095: Fixed gRPC compilation in standalone libprocess build. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 19:19:35 UTC, 3 replies.
- Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 19:20:30 UTC, 2 replies.
- Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 19:21:06 UTC, 4 replies.
- Review Request 66101: Added a helper to parse ContainerID. - posted by Jie Yu <yu...@gmail.com> on 2018/03/15 21:11:19 UTC, 1 replies.
- Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. - posted by Jason Lai <ja...@jasonlai.net> on 2018/03/15 22:31:14 UTC, 8 replies.
- Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. - posted by Michael Park <mp...@apache.org> on 2018/03/16 10:57:53 UTC, 6 replies.
- Review Request 66114: Added supporting scripts for Mesos LLVM Tools. - posted by Michael Park <mp...@apache.org> on 2018/03/16 10:58:07 UTC, 1 replies.
- Review Request 66118: Updated an agent test to use mock authorizer. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/16 18:17:40 UTC, 1 replies.
- Review Request 66119: Added a mock sandbox garbage collector. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/16 18:17:46 UTC, 6 replies.
- Review Request 66120: Updated an agent test to use mock garbage collector. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/16 18:17:50 UTC, 5 replies.
- Review Request 66123: Temporarily disabled some default executor tests. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/16 19:54:43 UTC, 7 replies.
- Re: Review Request 65782: Implemented master::Call validation for UPDATE_QUOTA. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/18 18:47:50 UTC, 1 replies.
- Re: Review Request 65783: Added a test for validation of UPDATE_QUOTA master::Call. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/18 18:59:21 UTC, 0 replies.
- Re: Review Request 65784: Added validation of QuotaRequest. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/18 20:28:09 UTC, 0 replies.
- Re: Review Request 65581: Made all allocator tests allow for slave backoff. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/03/19 14:14:48 UTC, 1 replies.
- Review Request 66137: Removed some redundant `get` calls. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/19 15:16:12 UTC, 2 replies.
- Review Request 66138: Add dockerfile for ARM. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2018/03/19 15:23:13 UTC, 2 replies.
- Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/19 18:08:14 UTC, 5 replies.
- Review Request 66141: Fixed whitespace in SLRP tests. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/19 18:08:41 UTC, 7 replies.
- Review Request 66144: Enforced task launch order on the agent. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/19 18:34:20 UTC, 9 replies.
- Review Request 66140: Fixed bug in `Framework::removeOperation()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/19 18:40:18 UTC, 6 replies.
- Review Request 66145: Added a test to verify that task launch order is enforced. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/19 18:42:30 UTC, 4 replies.
- Review Request 66126: Refactored agent task launch for better composition [1/2]. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/19 18:43:03 UTC, 8 replies.
- Review Request 66143: Refactored agent task launch for better composition [2/2]. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/19 18:43:10 UTC, 9 replies.
- Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/03/19 19:00:14 UTC, 4 replies.
- Review Request 66150: WIP: Add -Werror semantics to CMake. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/19 20:34:17 UTC, 1 replies.
- Review Request 66156: Compiled `csi.proto` when gRPC is disabled. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:29:11 UTC, 6 replies.
- Review Request 66157: Fixed header inclusions for `csi/spec.hpp`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:29:53 UTC, 2 replies.
- Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:38:20 UTC, 2 replies.
- Review Request 66159: Made tests `CSIClientTest.*` cross-platform. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:41:31 UTC, 2 replies.
- Review Request 66160: Renamed `disk_profile` files to `disk_profile_adatpor`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:46:31 UTC, 0 replies.
- Review Request 66161: Renamed the internal namespace `profile` to `storage`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:47:46 UTC, 3 replies.
- Review Request 66162: Changed names in tests related to `DiskProfileAdaptor` for consistency. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:49:00 UTC, 1 replies.
- Re: Review Request 61096: Building gRPC with CMake. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:50:43 UTC, 0 replies.
- Re: Review Request 61118: libprocess: Building gRPC support with CMake. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:53:08 UTC, 0 replies.
- Review Request 66163: Built storage local resource provider with CMake. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:59:14 UTC, 6 replies.
- Re: Review Request 53267: Added log and counter for tracking subscribers. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/20 00:06:07 UTC, 1 replies.
- Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 03:23:08 UTC, 0 replies.
- Review Request 66173: Add test for new `disk/xfs` kill functionality. - posted by Harold Dost <h....@criteo.com> on 2018/03/20 14:34:48 UTC, 6 replies.
- Review Request 66175: Added isolator checks for namespaces support. - posted by James Peach <jp...@apache.org> on 2018/03/20 16:51:55 UTC, 4 replies.
- Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/03/20 18:35:29 UTC, 3 replies.
- Review Request 66178: Added a test to verify that task launch order is enforced. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/20 18:36:37 UTC, 6 replies.
- Review Request 66165: Re-fixed many master allocator tests. - posted by Till Toenshoff <to...@me.com> on 2018/03/20 20:36:33 UTC, 5 replies.
- Review Request 66164: Added to a comment in master.cpp. - posted by Till Toenshoff <to...@me.com> on 2018/03/20 20:36:43 UTC, 1 replies.
- Re: Review Request 66096: Adapted the new `grpcpp` C++ header for gRPC v1.10 in libprocess. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 20:43:40 UTC, 0 replies.
- Re: Review Request 63994: Added new tests for validation of offer operation IDs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/03/20 21:46:17 UTC, 0 replies.
- Review Request 66182: Fixed grammar errors in comments in SLRP tests. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/20 22:12:19 UTC, 4 replies.
- Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 22:46:30 UTC, 2 replies.
- Re: Review Request 66162: Changed names related to `DiskProfileAdaptor` for consistency. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 22:52:43 UTC, 1 replies.
- Re: Review Request 66160: Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 23:47:50 UTC, 1 replies.
- Re: Review Request 66050: Implemented grow and shrink of persistent volumes. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/21 01:32:21 UTC, 19 replies.
- Re: Review Request 63368: Added MemoryProfiler class to Libprocess. - posted by Benno Evers <be...@mesosphere.com> on 2018/03/21 19:52:10 UTC, 0 replies.
- Review Request 66206: Used native protobuf map in Docker v1 image spec. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/22 06:56:31 UTC, 4 replies.
- Review Request 66207: Used native protobuf map in OCI v1 image spec. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/22 06:59:12 UTC, 3 replies.
- Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/03/22 09:37:01 UTC, 5 replies.
- Review Request 66211: Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/22 09:47:43 UTC, 1 replies.
- Review Request 66212: Updated `ParseV1ImageManifest` to check `Volumes` and `ExposedPorts`. - posted by Qian Zhang <zh...@gmail.com> on 2018/03/22 09:47:54 UTC, 1 replies.
- Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/22 16:28:30 UTC, 5 replies.
- Review Request 66219: Added helper functions to create grow and shrink volume in test. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/22 16:29:23 UTC, 2 replies.
- Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/22 16:30:03 UTC, 2 replies.
- Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/22 20:35:24 UTC, 2 replies.
- Review Request 66228: Added call/event for updating framework info. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/03/22 20:53:56 UTC, 0 replies.
- Review Request 66229: Implemented UPDATE_FRAMEWORK call. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/03/22 20:53:58 UTC, 0 replies.
- Review Request 66230: Added test for adding/removing framework roles. - posted by Kapil Arya <ka...@mesosphere.io> on 2018/03/22 20:53:59 UTC, 2 replies.
- Review Request 66223: WIP. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/23 02:07:16 UTC, 0 replies.
- Review Request 66232: Removed unnecessary/invalid checks from the default executor. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/23 02:10:31 UTC, 3 replies.
- Review Request 66233: Made the default executor log kill failures. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/23 02:13:00 UTC, 1 replies.
- Review Request 66234: Fixed variable shadowing in the default executor. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/23 02:14:04 UTC, 3 replies.
- Review Request 66235: Added a reference to MESOS-8557 to the default executor. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/23 02:17:56 UTC, 6 replies.
- Re: Review Request 63733: Don't print full usage for invocation errors. - posted by Benno Evers <be...@mesosphere.com> on 2018/03/23 14:39:38 UTC, 3 replies.
- Review Request 66248: Re-enabled SlaveTest.ChangeDomain. - posted by Benno Evers <be...@mesosphere.com> on 2018/03/23 14:40:31 UTC, 2 replies.
- Review Request 66256: Removed non minified third party JS library files. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/23 20:11:02 UTC, 1 replies.
- Review Request 66257: Added licenses for third party JS libraries used by Web UI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/23 20:13:22 UTC, 2 replies.
- Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/23 20:29:48 UTC, 4 replies.
- Review Request 66258: Added max_duration to `TaskInfo` and new reason for kill. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/23 20:51:25 UTC, 0 replies.
- Review Request 66259: Added max_duration support to command executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/23 20:51:47 UTC, 0 replies.
- Review Request 66260: Added test for max duration support in command executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/23 20:52:13 UTC, 2 replies.
- Re: Review Request 65585: Improved documentation regarding the new CLI setup. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/24 11:39:29 UTC, 0 replies.
- Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/24 11:39:39 UTC, 0 replies.
- Review Request 66278: Ensured correct termination order in IOSwitchboard's main function. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/03/26 12:48:57 UTC, 2 replies.
- Re: Review Request 66248: Removed SlaveTest.ChangeDomain. - posted by Benno Evers <be...@mesosphere.com> on 2018/03/26 16:09:57 UTC, 3 replies.
- Review Request 66283: Added support of max_duration in docker executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/26 18:04:59 UTC, 0 replies.
- Review Request 66284: Added test for max duration support in docker executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/26 18:05:25 UTC, 1 replies.
- Review Request 66291: Added support to max_duration in default executor. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/26 21:48:52 UTC, 1 replies.
- Review Request 66292: Validated that all tasks in the same group have same max_duration. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/26 21:49:22 UTC, 2 replies.
- Review Request 66293: Added test for default executor support of max_duration. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/26 21:49:49 UTC, 2 replies.
- Review Request 66289: Added fields to GET_STATE necessary for streaming Web UI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/03/27 00:10:46 UTC, 3 replies.
- Review Request 66307: Added implicit conversion from nullptr to Owned and Shared. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 15:34:13 UTC, 1 replies.
- Review Request 66308: Delayed construction of the agent's resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 15:34:13 UTC, 1 replies.
- Review Request 66309: Externalize creation of resource provider manager backing storage. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 15:34:14 UTC, 1 replies.
- Review Request 66310: Passed on registrar when constructing resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 15:34:15 UTC, 0 replies.
- Review Request 66311: Implement recovery of resource provider manager. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 15:34:16 UTC, 1 replies.
- Review Request 66313: Fixed an oversubscription test for agent registration backoff. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 18:32:52 UTC, 3 replies.
- Review Request 66314: Fix 3rdparty build commands for FreeBSD. - posted by David Forsythe <df...@gmail.com> on 2018/03/27 19:01:44 UTC, 5 replies.
- Review Request 66318: Made agent resource provider config API calls idempotent. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/27 23:27:08 UTC, 7 replies.
- Review Request 66322: Fixed a potential race in `Sequence`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/28 01:15:38 UTC, 2 replies.
- Review Request 66325: Implemented idempotency for agent resource provider config API calls. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/28 03:06:23 UTC, 4 replies.
- Review Request 66326: Added tests for agent resource provider API idempotency. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/28 03:09:03 UTC, 2 replies.
- Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/28 04:18:51 UTC, 5 replies.
- Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded arguments. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/03/28 10:25:22 UTC, 5 replies.
- Review Request 66331: Fixed test to assert precondition. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/03/28 14:21:42 UTC, 1 replies.
- Review Request 66342: Added difference operator overload for hashset. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/28 18:23:16 UTC, 1 replies.
- Review Request 66343: Added test for difference operator of hashset. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/28 18:23:39 UTC, 1 replies.
- Review Request 66344: Supported non-speculative operations on agent default resources. - posted by Zhitao Li <zh...@gmail.com> on 2018/03/28 18:24:43 UTC, 5 replies.
- Review Request 66323: Added tests for failed task launch on agent. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/28 20:30:08 UTC, 2 replies.
- Review Request 66346: Added two matchers for TaskInfo and TaskGroup. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/28 22:45:33 UTC, 0 replies.
- Review Request 66347: Added a test for killing executor during task launch. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/28 22:46:52 UTC, 2 replies.
- Review Request 66354: Remove forwarding of OpenSSL include dir. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/03/29 09:27:33 UTC, 2 replies.
- Review Request 66358: Updated CHANGELOG. - posted by Benno Evers <be...@mesosphere.com> on 2018/03/29 12:13:08 UTC, 6 replies.
- Review Request 66362: Fixed use of const reference for storing an rvalue in a test. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:17:04 UTC, 2 replies.
- Review Request 66363: Removed unnecessary code and a misleading comment from a test. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:18:25 UTC, 1 replies.
- Review Request 66364: Added missing `type` field to the `scheduler::Response` protos. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:18:53 UTC, 1 replies.
- Review Request 66365: Fixed generation of operation statuses in `Slave::applyOperation()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:19:24 UTC, 1 replies.
- Review Request 66366: Fixed generation of operation status updates in `Master::_apply()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:19:47 UTC, 2 replies.
- Review Request 66367: Made the master drop `RECONCILE_OPERATIONS` calls from v0 schedulers. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/29 17:23:04 UTC, 3 replies.
- Review Request 66345: Added two matchers for TaskInfo and TaskGroup. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/03/29 18:54:28 UTC, 0 replies.
- Review Request 66371: Temporarily disabled CSI proto compilation in CMake. - posted by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/29 23:58:58 UTC, 7 replies.
- Review Request 66384: Link libm in ZooKeeper build on FreeBSD. - posted by David Forsythe <df...@gmail.com> on 2018/03/31 18:48:18 UTC, 0 replies.
- Review Request 66385: Link execinfo in Glog build on FreeBSD. - posted by David Forsythe <df...@gmail.com> on 2018/03/31 18:48:24 UTC, 2 replies.