You are viewing a plain text version of this content. The canonical link for it is here.
- Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI. - posted by Eric Chung <ci...@gmail.com> on 2018/01/01 01:52:44 UTC, 9 replies.
- Re: Review Request 63437: Slave heartbeat add message sender distinguish. - posted by Andy Pang <pa...@huawei.com> on 2018/01/02 02:52:05 UTC, 0 replies.
- Review Request 64885: Made sure continuations using actor state are executed in actor context. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/02 10:38:16 UTC, 4 replies.
- Review Request 64888: Added check for handling of checkpointed resources in reregistration. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/02 15:39:37 UTC, 4 replies.
- Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/02 15:39:38 UTC, 6 replies.
- Review Request 64891: Future-proofed use of agent capabilities in tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/02 17:23:33 UTC, 3 replies.
- Re: Review Request 64879: Updated fetcher cache tests for the default executor. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/02 19:23:51 UTC, 2 replies.
- Re: Review Request 64868: Added initial doc about CSI support in Mesos. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/02 19:49:12 UTC, 14 replies.
- Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection. - posted by Michael Park <mp...@apache.org> on 2018/01/02 20:37:36 UTC, 2 replies.
- Review Request 64895: Renamed "normalize" to "upgrade" in resources adjustment operations. - posted by Michael Park <mp...@apache.org> on 2018/01/02 20:41:22 UTC, 1 replies.
- Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/02 20:47:04 UTC, 0 replies.
- Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/02 20:56:35 UTC, 3 replies.
- Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. - posted by Michael Park <mp...@apache.org> on 2018/01/02 21:03:18 UTC, 4 replies.
- Review Request 64897: Fixed CI build failure for `volume_profile.pb.h`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/02 21:15:29 UTC, 1 replies.
- Review Request 64898: Removed duplicated code that tests for removable tasks. - posted by James Peach <jp...@apache.org> on 2018/01/02 21:43:05 UTC, 4 replies.
- Review Request 64899: Removed `nodist_liburi_volume_profile_SOURCES`. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/02 22:48:55 UTC, 1 replies.
- Re: Review Request 63977: Used the protobuf-reflection-based 'downgradeResources' utility. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/02 22:50:38 UTC, 0 replies.
- Review Request 64901: Renamed ACL fields for standalone container API for consistency. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/03 00:49:31 UTC, 1 replies.
- Review Request 64906: Exposed `send()` helpers for `Socket`'s. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/01/03 07:19:52 UTC, 1 replies.
- Review Request 64907: Added abandonment and process exit support to `loop()`. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/01/03 07:20:19 UTC, 2 replies.
- Review Request 64908: Refactored `HttpProxy` to not rely on `SocketManager`. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/01/03 07:20:34 UTC, 1 replies.
- Review Request 64909: Removed unnecessary `SocketManager::dispose` data structure. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/01/03 07:21:53 UTC, 2 replies.
- Review Request 64211: Added configure/make options to build the new CLI and run unit tests. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/01/03 10:45:08 UTC, 1 replies.
- Review Request 64916: Added validation for operations applied on resource provider resources. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/03 13:24:07 UTC, 1 replies.
- Re: Review Request 64515: Used `reserve_resources` ACL for static reservations. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/01/03 19:01:01 UTC, 6 replies.
- Review Request 64919: Updated the comment for `precomputeResourcesContainment`. - posted by Michael Park <mp...@apache.org> on 2018/01/03 19:01:57 UTC, 1 replies.
- Review Request 64920: Introduced `upgradeResources` to complement `downgradeResources`. - posted by Michael Park <mp...@apache.org> on 2018/01/03 19:02:14 UTC, 2 replies.
- Re: Review Request 64743: Enabled function sections. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/03 19:06:06 UTC, 6 replies.
- Review Request 64921: Fixed a typo and formatting in docs. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/01/03 19:18:47 UTC, 0 replies.
- Review Request 64922: Added VOTING replica catch-up section to replicated log docs. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/01/03 19:18:57 UTC, 0 replies.
- Review Request 64923: Added replicated log reader catch-up section to the upgrades doc. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/01/03 19:19:06 UTC, 0 replies.
- Review Request 64924: Fixed the broken GRPC build. - posted by Michael Park <mp...@apache.org> on 2018/01/03 19:55:34 UTC, 1 replies.
- Re: Review Request 63422: Added os::eraseenv to clear the old environment value. - posted by James Peach <jp...@apache.org> on 2018/01/03 22:41:50 UTC, 4 replies.
- Re: Review Request 63423: Cleared the executor auth token after using it. - posted by James Peach <jp...@apache.org> on 2018/01/03 22:42:42 UTC, 3 replies.
- Review Request 64927: Updated the master to use .at for const access to `slaves.unreachable`. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/03 22:48:49 UTC, 1 replies.
- Review Request 64928: Added CHECKs to prevent accidental overwrite of slaves.unreachable. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/03 22:48:52 UTC, 1 replies.
- Review Request 64929: Documented a rate limiting bug in marking agents unreachable. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/03 22:48:53 UTC, 2 replies.
- Review Request 64930: Unified the marking agent unreachable logic in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/03 22:48:54 UTC, 6 replies.
- Review Request 64931: Added a TODO for informing frameworks that an agent is unreachable. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/03 22:48:56 UTC, 2 replies.
- Review Request 64932: Added example framework converting disk resources. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/03 22:50:40 UTC, 19 replies.
- Review Request 64933: Fixed flaky PartitionedSlaveReregistrationMasterFailover test. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/01/03 22:51:53 UTC, 1 replies.
- Review Request 64936: Improved the documentation of protos related to operation feedback. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/03 23:49:39 UTC, 5 replies.
- Review Request 64938: Fixed RecoverTest.CatchupTruncated test flakiness. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/01/04 00:07:23 UTC, 1 replies.
- Review Request 64939: Abort libprocess when a Process throws an uncaught exception. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/04 01:30:54 UTC, 3 replies.
- Review Request 64940: Prevented a crash when an agent with terminal tasks is lost. - posted by James Peach <jp...@apache.org> on 2018/01/04 01:35:56 UTC, 28 replies.
- Review Request 64941: Bumped bundled gRPC to 1.8.3. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/04 02:15:37 UTC, 0 replies.
- Re: Review Request 64888: Added test of handling of checkpointed resources in reregistration. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/04 10:06:07 UTC, 0 replies.
- Review Request 64953: Added error message in tests for orphaned containers. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/04 17:28:08 UTC, 1 replies.
- Re: Review Request 63860: Windows: Mapped the Docker network info types. - posted by Jie Yu <yu...@gmail.com> on 2018/01/04 20:42:14 UTC, 13 replies.
- Review Request 64957: Updated README for the gRPC bundle. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/04 21:05:35 UTC, 1 replies.
- Review Request 64963: Fixed typos in SRLP tests. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/04 23:16:29 UTC, 1 replies.
- Review Request 64964: Bumped the CSI spec bundle to 0.1.0. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/04 23:45:18 UTC, 1 replies.
- Re: Review Request 63859: Windows: Fixed mock signal values in stout. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:28:22 UTC, 9 replies.
- Re: Review Request 63861: Windows: Updated networking doc. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:29:49 UTC, 9 replies.
- Re: Review Request 63862: Windows: Ported docker_tests.cpp. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:30:31 UTC, 9 replies.
- Re: Review Request 64386: Windows: Enabled docker health checks. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:31:06 UTC, 8 replies.
- Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:32:39 UTC, 4 replies.
- Re: Review Request 64570: Windows: Temporarily fixed the docker executor. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:32:59 UTC, 4 replies.
- Re: Review Request 64387: Windows: Ported docker health check tests. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:33:23 UTC, 16 replies.
- Review Request 64968: Removed the inaccurate `slaves.transitioning` function in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/05 01:38:43 UTC, 2 replies.
- Review Request 64970: Replace ad hoc venv under support/ with tox. - posted by Eric Chung <ci...@gmail.com> on 2018/01/05 08:26:35 UTC, 4 replies.
- Review Request 64972: Renamed VolumeProfileAdaptor to DiskProfileAdaptor. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/05 10:46:05 UTC, 0 replies.
- Review Request 64973: Renamed VolumeProfileAdaptor to DiskProfileAdaptor (continued). - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/05 10:46:23 UTC, 2 replies.
- Re: Review Request 64805: Changed 'ConstantEndpointDetector' to have value semantics. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/05 11:33:04 UTC, 0 replies.
- Review Request 64978: WIP: Attached and detached executor volume directory for task. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/05 15:41:54 UTC, 0 replies.
- Review Request 64980: Updated health check doc with 3xx redirects. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/05 16:00:05 UTC, 2 replies.
- Review Request 64969: Added an performance benchmark for master `getstate` v1 api. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/05 20:13:04 UTC, 7 replies.
- Review Request 64961: Windows: Fixed memory leak. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:49:51 UTC, 1 replies.
- Review Request 64962: Windows: Explicitly state source and destination path for extract. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:50:05 UTC, 3 replies.
- Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:53:10 UTC, 5 replies.
- Re: Review Request 64730: Changed `Sorter::count()` to return `size_t` instead of `int`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:53:23 UTC, 2 replies.
- Re: Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:53:36 UTC, 1 replies.
- Re: Review Request 64732: Fixed conversion warnings in tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:53:48 UTC, 2 replies.
- Re: Review Request 64733: Fixed conversion warnings in tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:54:24 UTC, 2 replies.
- Re: Review Request 64734: Fixed conversion warnings. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:54:36 UTC, 3 replies.
- Re: Review Request 64735: Fixed conversion warnings in tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:54:51 UTC, 3 replies.
- Re: Review Request 64736: Fixed conversion warnings. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/05 21:55:10 UTC, 5 replies.
- Review Request 64993: Made the `os::read` error less redundant. - posted by James Peach <jp...@apache.org> on 2018/01/05 21:56:21 UTC, 1 replies.
- Review Request 64995: Improved image store manifest parsing errors. - posted by James Peach <jp...@apache.org> on 2018/01/05 21:57:07 UTC, 2 replies.
- Review Request 64992: Added SLRP unit tests for profile updates and corner cases. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/05 22:04:58 UTC, 10 replies.
- Review Request 64994: Renamed SLRP tests to describe them better. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/05 22:05:22 UTC, 1 replies.
- Review Request 64998: Added a SLRP test for CSI plugin restart. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/05 23:14:23 UTC, 6 replies.
- Re: Review Request 64630: Narrowed task sandbox permissions from 0755 to 0750. - posted by Ilya Pronin <ip...@twopensource.com> on 2018/01/05 23:53:34 UTC, 4 replies.
- Review Request 65000: Added an SLRP test for agent being registered with a new ID. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/06 00:40:03 UTC, 10 replies.
- Re: Review Request 64978: Made task's volume directory visible in the /files endpoints. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/07 10:00:31 UTC, 18 replies.
- Review Request 65011: Reverted back to alphabetical ordering of libprocess metrics in JSON. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/08 00:57:27 UTC, 1 replies.
- Review Request 65012: Added tests to ensure that libprocess metrics are alphabetical. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/08 00:57:30 UTC, 2 replies.
- Review Request 65013: Removed gtest thread safe filter in libprocess tests. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/08 00:57:33 UTC, 2 replies.
- Review Request 65016: Use flag class to perform example framework flag validation. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/08 10:05:39 UTC, 1 replies.
- Review Request 65019: Added new reconfiguration_policy flag to docs/updgrades.md. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/08 13:52:28 UTC, 2 replies.
- Review Request 65021: Returned `Try` from `protobuf::read(path)` rather than `Result`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 18:14:44 UTC, 1 replies.
- Review Request 65022: Updated uses of `protobuf::read(path)` which now returns `Try`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 18:14:46 UTC, 5 replies.
- Review Request 65023: Added `state::read` to complement `state::checkpoint`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 18:14:48 UTC, 1 replies.
- Review Request 65024: Replaced `protobuf::read` with `state::read`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 18:14:50 UTC, 1 replies.
- Review Request 65025: Replaced `os::read` with `state::read`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 18:14:51 UTC, 1 replies.
- Review Request 65026: Replaced `ResourcesState::recoverResources` with `state::read`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 18:14:53 UTC, 2 replies.
- Re: Review Request 63661: Updated tests to use `createCallSubscribe`. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/01/08 18:52:00 UTC, 5 replies.
- Review Request 65029: Added `vector` overloads for `(down/up)gradeResources`. - posted by Michael Park <mp...@apache.org> on 2018/01/08 20:26:45 UTC, 1 replies.
- Review Request 65030: Replaced `convertResourceFormat` with `upgradeResources` appropriately. - posted by Michael Park <mp...@apache.org> on 2018/01/08 20:27:01 UTC, 0 replies.
- Review Request 65031: Replaced `convertResourceFormat` with `downgradeResources` accordingly. - posted by Michael Park <mp...@apache.org> on 2018/01/08 20:36:55 UTC, 3 replies.
- Review Request 65032: Added a SLRP unit test for agent reboot. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/08 20:41:41 UTC, 4 replies.
- Re: Review Request 65030: Replaced `convertResourceFormat` with `upgradeResources` accordingly. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/01/08 21:25:01 UTC, 1 replies.
- Review Request 65034: Made resource provider manager conditionally set framework ID. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/09 00:21:05 UTC, 8 replies.
- Re: Review Request 64846: Updated example frameworks environment parameter prefix. - posted by Vinod Kone <vi...@apache.org> on 2018/01/09 01:23:45 UTC, 2 replies.
- Re: Review Request 64847: Added collection of example framework flag definitions. - posted by Vinod Kone <vi...@apache.org> on 2018/01/09 01:29:26 UTC, 7 replies.
- Re: Review Request 64857: Updated example frameworks for mesos-local. - posted by Till Toenshoff <to...@me.com> on 2018/01/09 03:19:47 UTC, 7 replies.
- Re: Review Request 64849: Added authentication to some example frameworks. - posted by Till Toenshoff <to...@me.com> on 2018/01/09 03:19:54 UTC, 6 replies.
- Re: Review Request 64848: Updated example frameworks to make use of added flags. - posted by Till Toenshoff <to...@me.com> on 2018/01/09 03:19:58 UTC, 6 replies.
- Review Request 65039: Tested reconciliation when operation is dropped en route to agent. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/09 09:21:46 UTC, 18 replies.
- Review Request 65042: Adjusted CSI example framework for recent changes. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/09 11:10:53 UTC, 10 replies.
- Review Request 65043: Moved agent response code into 'protobuf_utils.cpp'. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/09 13:27:07 UTC, 3 replies.
- Review Request 65044: Added the list of operations to the 'GET_AGENTS' response. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/09 13:28:02 UTC, 2 replies.
- Review Request 65045: Tested correct operation handling during master failover. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/09 13:28:54 UTC, 14 replies.
- Re: Review Request 64514: Refactor out `authorizeReserveResources` that takes a `Resources`. - posted by James Peach <jp...@apache.org> on 2018/01/09 16:02:23 UTC, 0 replies.
- Re: Review Request 64516: Improved documentation on resource reservations. - posted by James Peach <jp...@apache.org> on 2018/01/09 16:27:22 UTC, 4 replies.
- Re: Review Request 62161: Update boost version. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/09 17:18:06 UTC, 0 replies.
- Review Request 65048: Logged socket create/connect failures on warning level. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/09 18:19:50 UTC, 7 replies.
- Review Request 65049: Fixed the persistent volume permission issue in DockerContainerizer. - posted by Jie Yu <yu...@gmail.com> on 2018/01/09 19:31:42 UTC, 2 replies.
- Review Request 65050: Added some defensive checks for persistent volume sharing check. - posted by Jie Yu <yu...@gmail.com> on 2018/01/09 20:44:41 UTC, 2 replies.
- Review Request 65054: Fixed the order of parameters of `is_specialization_of` in stout. - posted by Michael Park <mp...@apache.org> on 2018/01/09 23:56:32 UTC, 1 replies.
- Review Request 65055: Fixed the order of parameters of `is_specialization_of` in libprocess. - posted by Michael Park <mp...@apache.org> on 2018/01/09 23:56:33 UTC, 2 replies.
- Review Request 65056: Added missing fields to the GET_MASTER operator API call. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/09 23:57:32 UTC, 15 replies.
- Review Request 65057: Tested that op status updates dropped en route to master are resent. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/10 00:25:51 UTC, 6 replies.
- Review Request 65059: Speeded up SLRP unit tests. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/10 02:32:06 UTC, 3 replies.
- Review Request 65060: Cleaned up endpoint directories after SLRP tests. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/10 02:37:08 UTC, 1 replies.
- Review Request 65061: Speeded up tests for resource provider config agent API. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/10 03:05:11 UTC, 1 replies.
- Review Request 65062: Cleaned up endpoint directories after RP config agent API tests. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/10 03:05:46 UTC, 2 replies.
- Review Request 65063: Replace `stringify()` with `jsonify()` in http serialization. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/10 07:06:45 UTC, 3 replies.
- Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/10 13:51:24 UTC, 3 replies.
- Re: Review Request 65070: WIP: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/10 14:14:15 UTC, 1 replies.
- Review Request 65071: Fixed composing containerizer hanging in `wait()` after recovery. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/10 15:13:53 UTC, 5 replies.
- Review Request 65072: Fixed handling of terminal operations in updateSlave handler. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/10 15:17:55 UTC, 9 replies.
- Review Request 65073: Fixed post-reviews for posting reviews from `master` branch. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/10 15:28:32 UTC, 5 replies.
- Review Request 65074: Fixed comparison logic for additive reconfiguration policy. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/10 16:07:22 UTC, 8 replies.
- Review Request 65077: Added a test to check `wait` of composing c'zer after recovery. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/10 18:54:09 UTC, 3 replies.
- Review Request 65085: WIP: Added a unit test for fd leakage with blocking HTTP calls. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/10 23:30:54 UTC, 1 replies.
- Review Request 65090: Added specific flag loader for zookeeper urls preventing password leaks. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/11 10:52:39 UTC, 2 replies.
- Review Request 65095: Made it possible to update an operation without mutating resources. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/11 13:53:41 UTC, 5 replies.
- Review Request 65096: Added a `CHECK` to master's `updateOperation`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/11 13:53:41 UTC, 1 replies.
- Review Request 65093: Simplified master's `updateOperation` function. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/11 13:53:42 UTC, 2 replies.
- Re: Review Request 63325: Refactored authorization logic in the agent. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/11 14:03:21 UTC, 0 replies.
- Re: Review Request 64770: Fixed a potential race condition in the test infrastructure. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/11 21:21:51 UTC, 0 replies.
- Review Request 65103: Updated quota documentation. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/12 00:30:26 UTC, 2 replies.
- Re: Review Request 63939: Added a script to build Mesos docker image. - posted by James Peach <jp...@apache.org> on 2018/01/12 00:47:20 UTC, 2 replies.
- Re: Review Request 64729: Templated operator overloads of `Duration`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/12 01:01:02 UTC, 0 replies.
- Review Request 65104: Updated documentation for `d_type` check regarding `xfs` on `overlay`. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/12 01:13:42 UTC, 2 replies.
- Review Request 65105: Fixed a couple of minor network/ports isolator issues. - posted by James Peach <jp...@apache.org> on 2018/01/12 01:14:42 UTC, 2 replies.
- Review Request 65106: Removed the misleading `isRemovable` helper in the master. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/12 01:34:39 UTC, 6 replies.
- Review Request 65107: Updated the task state metrics to be more readable. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/12 01:34:41 UTC, 1 replies.
- Review Request 65108: Added documentation for `protobuf::isTerminalState`. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/12 01:34:43 UTC, 2 replies.
- Review Request 65112: Added documentation about standalone containers. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/12 01:51:01 UTC, 4 replies.
- Review Request 65113: Added Developer Guide to documentation. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/12 02:06:45 UTC, 4 replies.
- Review Request 65114: Updated C++ Style Guide. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/12 02:07:03 UTC, 5 replies.
- Re: Review Request 62965: Added doc for cgroups devices isolator. - posted by Jie Yu <yu...@gmail.com> on 2018/01/12 02:20:39 UTC, 4 replies.
- Review Request 65109: Fixed a bug about lingering executors. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/12 02:33:31 UTC, 0 replies.
- Review Request 65110: Added mock method for `___run()` in mock slave. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/12 02:34:10 UTC, 0 replies.
- Review Request 65111: Added a test to verify the executor is shutdown if no task is delivered. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/12 02:34:35 UTC, 1 replies.
- Review Request 65116: Getting Started using the Mesos RPM Binaries. - posted by Senthil Kumaran <se...@uthcode.com> on 2018/01/12 02:36:51 UTC, 7 replies.
- Review Request 65117: Added gRPC documentation in libprocess. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/12 02:45:33 UTC, 1 replies.
- Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/12 10:53:28 UTC, 4 replies.
- Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/12 10:57:28 UTC, 3 replies.
- Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/12 12:23:38 UTC, 9 replies.
- Review Request 65125: Added a helper function for resource provider tests. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/12 14:15:59 UTC, 4 replies.
- Review Request 65126: Added a resource provider test case. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/12 14:16:36 UTC, 10 replies.
- Re: Review Request 64386: Refactored health checks to take in executor information. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/12 14:36:29 UTC, 6 replies.
- Review Request 65127: Windows: Enabled docker health checks. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/12 14:37:41 UTC, 13 replies.
- Review Request 65137: Added some deduplication logic to `Master::updateOperation`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/12 23:36:29 UTC, 6 replies.
- Review Request 65139: Reverted "Fixed `wait()` and `destroy()` in composing containerizer.". - posted by Gilbert Song <so...@gmail.com> on 2018/01/13 00:15:17 UTC, 1 replies.
- Review Request 65140: Reverted "Updated composing containerizer tests.". - posted by Gilbert Song <so...@gmail.com> on 2018/01/13 00:15:18 UTC, 1 replies.
- Review Request 65141: Fixed the default executor flaky testes in tests/cluster.cpp. - posted by Gilbert Song <so...@gmail.com> on 2018/01/13 00:15:21 UTC, 1 replies.
- Review Request 65143: Logged some additional information on a master CHECK. - posted by James Peach <jp...@apache.org> on 2018/01/13 00:44:51 UTC, 1 replies.
- Review Request 65144: Ported `os::which` to Windows. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/13 01:33:06 UTC, 6 replies.
- Review Request 65145: Fixed use of `os::which`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/13 01:33:19 UTC, 2 replies.
- Review Request 65146: Windows: Enabled internet tests. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/13 01:33:32 UTC, 1 replies.
- Review Request 65147: Windows: Fixed docker executor `PATH` variable. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/13 01:35:35 UTC, 8 replies.
- Re: Review Request 61158: Introduced http::Server in process.cpp. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/13 02:21:15 UTC, 0 replies.
- Review Request 65149: MesosTidy: Enabled `mesos-this-capture`. - posted by Michael Park <mp...@apache.org> on 2018/01/13 05:32:40 UTC, 2 replies.
- Review Request 65150: Added support for discarding a Future from Queue::get. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/13 21:35:28 UTC, 2 replies.
- Review Request 65151: Added a test for discarding a future from Queue::get. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/13 21:35:31 UTC, 2 replies.
- Re: Review Request 64073: Fixed ignored Socket::accept discard when using LibeventSSLSocketImpl. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/13 21:36:00 UTC, 0 replies.
- Re: Review Request 64910: Used `loop`() for `SocketManager` socket sending. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/13 22:01:46 UTC, 0 replies.
- Review Request 65153: Stopped applying empty executor resources in `network/ports` recovery. - posted by James Peach <jp...@apache.org> on 2018/01/14 05:05:39 UTC, 2 replies.
- Re: Review Request 65063: Use `jsonify()` in http serialization for better performance. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/14 06:04:29 UTC, 0 replies.
- Re: Review Request 64969: Added an performance benchmark for master `Getstate` v1 api. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/14 06:05:59 UTC, 3 replies.
- Review Request 65156: Detached the virtual paths regardless of the result of gc. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/14 14:17:08 UTC, 5 replies.
- Re: Review Request 64911: Refactored connection logic in libprocess. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/14 21:42:49 UTC, 1 replies.
- Review Request 65160: Removed some redundant `get` calls in stout. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/15 09:09:03 UTC, 0 replies.
- Review Request 65161: Removed some redundant `get` calls in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/15 09:09:06 UTC, 0 replies.
- Review Request 65162: Removed some redundant `get` calls. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/15 09:09:08 UTC, 2 replies.
- Review Request 65166: Added libprocess benchmarks to cmake build setup. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/15 11:48:40 UTC, 9 replies.
- Review Request 65167: Detached `virtualLatestPath` when recovering the executor. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/15 13:49:10 UTC, 3 replies.
- Review Request 65168: This patch is needed to trigger ASF CI build. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/15 14:10:13 UTC, 1 replies.
- Review Request 65171: Reduced copying of Response by adding extra override Headers. - posted by Benjamin Hindman <be...@berkeley.edu> on 2018/01/15 20:46:07 UTC, 5 replies.
- Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/15 20:58:31 UTC, 0 replies.
- Review Request 65179: Fixed flaky EOFBeforeRecv test. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/16 18:10:00 UTC, 3 replies.
- Review Request 65180: Removed a comment in io switchboard. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/16 19:05:14 UTC, 7 replies.
- Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/16 21:00:58 UTC, 7 replies.
- Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/16 21:41:57 UTC, 3 replies.
- Review Request 65184: Added missing registry-related flags to the master config docs. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/16 23:16:12 UTC, 2 replies.
- Re: Review Request 65109: Fixed a bug relating to lingering executors. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/17 06:14:15 UTC, 5 replies.
- Re: Review Request 65111: Added tests to verify the executor is shutdown if no task is delivered. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/01/17 07:13:36 UTC, 3 replies.
- Re: Review Request 64823: Documented the change in the Protobuf requirement. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/17 11:31:48 UTC, 1 replies.
- Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/17 12:22:10 UTC, 10 replies.
- Review Request 65190: Updated comments in io switchboard. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/17 15:15:40 UTC, 4 replies.
- Re: Review Request 62160: Fixed stout build with newer boost versions. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/17 16:06:31 UTC, 0 replies.
- Re: Review Request 62444: Added UNREACHABLE() macro to __cxa_pure_virtual. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/17 16:07:09 UTC, 0 replies.
- Re: Review Request 62161: Updated boost version. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/17 16:09:26 UTC, 0 replies.
- Re: Review Request 62445: Removed duplicate block in configure.ac. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/17 16:10:01 UTC, 0 replies.
- Re: Review Request 62447: Reverted usage of `-isystem` flag. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/17 16:10:44 UTC, 2 replies.
- Re: Review Request 63828: Added authorization tests for standalone container APIs. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/17 19:21:22 UTC, 1 replies.
- Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/17 19:21:45 UTC, 1 replies.
- Re: Review Request 63829: Modified Containerizer::remove to allow top-level containers. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/17 19:24:43 UTC, 1 replies.
- Review Request 65195: Windows: Fixed `fs::list` to return full paths. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/17 22:04:27 UTC, 0 replies.
- Review Request 65196: Removed workaround in ZooKeeper test. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/17 22:05:04 UTC, 1 replies.
- Review Request 65197: Updated Gaston Kleiman's entry in contributors.yaml. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/17 22:28:13 UTC, 1 replies.
- Review Request 65200: Added a default move constructor for Result. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/17 23:30:05 UTC, 1 replies.
- Review Request 65201: Added a global DEFAULT_TEST_TIMEOUT variable. - posted by James Peach <jp...@apache.org> on 2018/01/17 23:54:41 UTC, 0 replies.
- Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`. - posted by James Peach <jp...@apache.org> on 2018/01/17 23:55:20 UTC, 5 replies.
- Re: Review Request 65197: Added some missing email addresses to the contributors list. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/18 00:16:21 UTC, 9 replies.
- Review Request 65203: Updated the CHANGELOG for 1.5.0 release. - posted by Gilbert Song <so...@gmail.com> on 2018/01/18 00:21:49 UTC, 8 replies.
- Review Request 65204: Eliminated some unnecessary copying in the agent's HTTP operator API. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/18 01:19:35 UTC, 1 replies.
- Re: Review Request 62900: Enabled protobuf arenas code generation. - posted by Gilbert Song <so...@gmail.com> on 2018/01/18 07:54:40 UTC, 0 replies.
- Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/18 10:53:48 UTC, 3 replies.
- Re: Review Request 59746: Stopped accounting aborted container launches as failures. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/18 13:09:00 UTC, 0 replies.
- Re: Review Request 61811: Flattened continuation chains in containerizer for readability. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/18 13:10:43 UTC, 3 replies.
- Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/18 13:24:39 UTC, 2 replies.
- Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/18 14:10:01 UTC, 16 replies.
- Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/18 15:28:38 UTC, 5 replies.
- Review Request 65223: Removed duplicated "/help" prefix in links in /help response. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/18 17:46:27 UTC, 3 replies.
- Review Request 65226: Added SecurePathOrValue for file flags which need not to leak contents. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/18 18:53:17 UTC, 2 replies.
- Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/18 19:01:00 UTC, 4 replies.
- Review Request 65229: Made `GetNodeID` call depend on `PUBLISH_UNPUBLISH_VOLUME` capability. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/18 20:21:33 UTC, 3 replies.
- Re: Review Request 64970: Use tox for linting and testing code living uder src/python. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/01/19 00:23:31 UTC, 0 replies.
- Review Request 65231: Fixed detaching task volume directories of destroyed frameworks. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/19 00:37:34 UTC, 13 replies.
- Review Request 65232: Resumed the clock if necessary when destroying test agent. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/19 00:40:13 UTC, 4 replies.
- Review Request 65227: Added specific flag loader for zookeeper urls preventing password leaks. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/19 01:04:03 UTC, 0 replies.
- Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto. - posted by Gilbert Song <so...@gmail.com> on 2018/01/20 02:05:36 UTC, 5 replies.
- Review Request 65245: Renamed `LOG` by `Stream logs` in Web UI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/01/20 16:14:51 UTC, 3 replies.
- Review Request 65246: Added download button for master and agent logs in Web UI. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/01/20 16:16:24 UTC, 5 replies.
- Review Request 65255: Updated inverse-offers-framework with authentication. - posted by Till Toenshoff <to...@me.com> on 2018/01/20 17:27:24 UTC, 8 replies.
- Re: Review Request 50010: Added example framework for handling inverse offers. - posted by Till Toenshoff <to...@me.com> on 2018/01/20 17:32:31 UTC, 0 replies.
- Review Request 65256: Updated inverse-offer-framework for API updates. - posted by Till Toenshoff <to...@me.com> on 2018/01/20 19:18:07 UTC, 0 replies.
- Review Request 65215: Updated mesos-tidy setup for upgraded Boost version. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/22 12:58:12 UTC, 3 replies.
- Review Request 65261: Fixed connection refused error in IOSwitchboard for unix socket. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/22 13:00:38 UTC, 7 replies.
- Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/22 13:21:24 UTC, 4 replies.
- Review Request 65253: Avoided dropping events on the master operator API stream. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/22 18:43:37 UTC, 7 replies.
- Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/22 21:08:54 UTC, 4 replies.
- Review Request 65273: Added the agent flag --disk_profile_adaptor to agent.md file. - posted by Gilbert Song <so...@gmail.com> on 2018/01/22 21:55:55 UTC, 1 replies.
- Review Request 65274: Fixed --ip6 and --ip6_discovery_command document location. - posted by Gilbert Song <so...@gmail.com> on 2018/01/22 22:11:22 UTC, 1 replies.
- Re: Review Request 65253: Fixed dropped events on the master operator API stream. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/22 23:36:52 UTC, 1 replies.
- Review Request 65277: Logged pid of launched containers in the linux launcher. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/23 01:58:32 UTC, 2 replies.
- Review Request 65278: Fixed a race in the test `ROOT_MultiTaskgroupSharePidNamespace`. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/23 02:09:59 UTC, 8 replies.
- Review Request 65280: Fixed make clean without Python. - posted by Till Toenshoff <to...@me.com> on 2018/01/23 04:08:56 UTC, 2 replies.
- Re: Review Request 62861: Updated list of excluded files by Python linter. - posted by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/01/23 11:50:30 UTC, 0 replies.
- Review Request 65294: Add revocable resources support to mesos-execute. - posted by Zhitao Li <zh...@gmail.com> on 2018/01/23 17:53:17 UTC, 4 replies.
- Review Request 65298: Split test flags into header and source files. - posted by James Peach <jp...@apache.org> on 2018/01/23 21:58:13 UTC, 2 replies.
- Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/23 22:17:12 UTC, 8 replies.
- Review Request 65300: Added master metrics for operation status acknowledgments handling. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/23 22:17:14 UTC, 3 replies.
- Review Request 65301: Fixed resource statistics for Docker containers being destroyed. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/23 23:29:32 UTC, 2 replies.
- Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/24 00:54:14 UTC, 5 replies.
- Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/24 01:08:24 UTC, 4 replies.
- Re: Review Request 64062: Added 6 nested container tests for `docker/volume` isolator. - posted by Gilbert Song <so...@gmail.com> on 2018/01/24 03:27:36 UTC, 1 replies.
- Re: Review Request 63365: Re-ordered some configuration options alphabetically. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 13:58:35 UTC, 0 replies.
- Review Request 65308: WIP: Fix warnings in tests. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 14:57:26 UTC, 0 replies.
- Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 14:57:27 UTC, 4 replies.
- Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 15:12:12 UTC, 2 replies.
- Re: Review Request 65308: Fix shadowed sign-compare and enum-compare warnings in tests. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 16:17:56 UTC, 0 replies.
- Review Request 65289: Reverted usage of the -isystem flag for includes (2/3). - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 16:23:37 UTC, 0 replies.
- Review Request 65290: Reverted usage of the -isystem flag for includes (3/3). - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 16:23:46 UTC, 1 replies.
- Re: Review Request 63366: Added jemalloc release tarball and build rules. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 16:37:59 UTC, 1 replies.
- Review Request 65307: Cleaned up interface defintion in duration header. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 16:38:10 UTC, 1 replies.
- Re: Review Request 63372: Added documentation for memory profiling. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/24 16:40:56 UTC, 1 replies.
- Review Request 65310: Added lambda::zip. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/24 17:26:59 UTC, 2 replies.
- Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/24 17:30:06 UTC, 1 replies.
- Review Request 65312: Refactored authorization logic in the master. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/24 17:30:09 UTC, 0 replies.
- Review Request 65313: Refactored authorization logic in the agent. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/24 17:30:11 UTC, 0 replies.
- Review Request 65314: Removed code which is not used. - posted by Alexander Rojas <al...@mesosphere.io> on 2018/01/24 17:30:21 UTC, 3 replies.
- Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/24 18:05:06 UTC, 2 replies.
- Review Request 65317: Used a namespace for paths in IOSwitchboard. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/24 18:10:06 UTC, 1 replies.
- Review Request 65319: Implement os::eraseenv on Windows. - posted by James Peach <jp...@apache.org> on 2018/01/24 19:06:47 UTC, 3 replies.
- Review Request 65316: Added test for delayed authorization during operator events. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/24 19:34:10 UTC, 8 replies.
- Review Request 65320: WIP: Conditionally set LIBPROCESS_IP into docker container. - posted by Till Toenshoff <to...@me.com> on 2018/01/24 21:38:26 UTC, 0 replies.
- Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure. - posted by Till Toenshoff <to...@me.com> on 2018/01/24 21:38:28 UTC, 1 replies.
- Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter. - posted by Till Toenshoff <to...@me.com> on 2018/01/24 21:40:22 UTC, 2 replies.
- Review Request 65326: Fixed conversion warning. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/24 21:48:49 UTC, 5 replies.
- Review Request 65332: Tested that a CSI persistent volume can be used after recovery. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/25 01:56:07 UTC, 2 replies.
- Review Request 65333: Fixed errors in comments. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/25 01:56:48 UTC, 2 replies.
- Review Request 65334: Added quota limit to the master API protos. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/25 02:45:40 UTC, 3 replies.
- Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. - posted by Benjamin Bannier <be...@mesosphere.io> on 2018/01/25 06:32:54 UTC, 8 replies.
- Re: Review Request 63368: Added MemoryProfiler class to Libprocess. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/25 14:24:12 UTC, 3 replies.
- Re: Review Request 64574: Updated libprocess routing to treat trailing '/' as insignificant. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/25 18:47:40 UTC, 1 replies.
- Review Request 65343: Adopted `DEFAULT_TEST_TIMEOUT` in libprocess tests. - posted by James Peach <jp...@apache.org> on 2018/01/25 19:15:52 UTC, 0 replies.
- Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests. - posted by James Peach <jp...@apache.org> on 2018/01/25 19:29:19 UTC, 3 replies.
- Review Request 65344: Updated the docs for agent ping timeout flags. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/25 21:18:46 UTC, 4 replies.
- Re: Review Request 64297: Updated modules documentation with some more details. - posted by Till Toenshoff <to...@me.com> on 2018/01/25 21:58:07 UTC, 4 replies.
- Review Request 65347: Added missing protobuf include. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/26 11:41:22 UTC, 4 replies.
- Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/01/26 11:58:19 UTC, 3 replies.
- Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. - posted by Jan Schlicht <ja...@mesosphere.io> on 2018/01/26 12:55:30 UTC, 3 replies.
- ***UNCHECKED*** Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. - posted by Alexander Rukletsov <ru...@gmail.com> on 2018/01/26 13:23:43 UTC, 0 replies.
- Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. - posted by Andrei Budnik <ab...@mesosphere.com> on 2018/01/26 14:17:34 UTC, 2 replies.
- Re: Review Request 63369: Added new '/state' and '/statistics' endpoints to the MemoryProfiler. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/26 14:18:59 UTC, 0 replies.
- Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. - posted by Armand Grillet <ag...@mesosphere.io> on 2018/01/26 15:16:42 UTC, 5 replies.
- Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/26 18:12:02 UTC, 3 replies.
- Review Request 65357: Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:07 UTC, 1 replies.
- Review Request 65359: Added an extra CHECK to `Master::acknowledge()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:08 UTC, 1 replies.
- Review Request 65358: Removed unnecesssary validations from `Master::receive()`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:08 UTC, 1 replies.
- Review Request 65360: Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:09 UTC, 1 replies.
- Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:10 UTC, 3 replies.
- Review Request 65362: Added a method to increment invalid scheduler API call counters. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:27 UTC, 2 replies.
- Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/26 22:08:32 UTC, 0 replies.
- Review Request 65366: Added test for maintenance-related offer rescinding behavior. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/27 01:40:15 UTC, 1 replies.
- Review Request 65367: Added equality operator for Unavailability protobuf. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/27 01:40:18 UTC, 1 replies.
- Review Request 65368: Updated maintenance schedule logic. - posted by Joseph Wu <jo...@mesosphere.io> on 2018/01/27 01:40:21 UTC, 3 replies.
- Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill. - posted by Meng Zhu <mz...@mesosphere.io> on 2018/01/27 02:06:18 UTC, 3 replies.
- Review Request 65372: Replaced the `Os.Which` test to use `cat` rather than `ping`. - posted by Michael Park <mp...@apache.org> on 2018/01/28 21:48:35 UTC, 2 replies.
- Review Request 65375: Added move construction and assignment to Future. - posted by Benjamin Mahler <bm...@apache.org> on 2018/01/29 02:29:03 UTC, 3 replies.
- Review Request 65376: Reverted `protobuf::read(path)` to return `Result`. - posted by Michael Park <mp...@apache.org> on 2018/01/29 07:55:29 UTC, 2 replies.
- Review Request 65377: Updated `state::read` to return `Result`. - posted by Michael Park <mp...@apache.org> on 2018/01/29 07:55:30 UTC, 2 replies.
- Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. - posted by Michael Park <mp...@apache.org> on 2018/01/29 07:55:36 UTC, 7 replies.
- Review Request 65382: Not reap Docker executor when the container has exited. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/29 13:15:46 UTC, 0 replies.
- Review Request 65383: Recovered the executor pid in Docker containerizer. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/29 13:16:54 UTC, 0 replies.
- Review Request 65384: Fixed a coding error in a log message of Docker containerizer. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/29 13:18:14 UTC, 3 replies.
- Review Request 65391: Added a UTS namespace isolator. - posted by James Peach <jp...@apache.org> on 2018/01/29 18:18:57 UTC, 2 replies.
- Review Request 65392: Document the namespace/uts isolator. - posted by James Peach <jp...@apache.org> on 2018/01/29 18:19:38 UTC, 3 replies.
- Review Request 65393: Fixed docker command health check to use the right docker socket. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/29 18:20:38 UTC, 4 replies.
- Review Request 65396: Moved docker command check code inside health check library. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/29 18:21:50 UTC, 0 replies.
- Review Request 65395: Refactored health checks to cleanly separate each different check. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/29 18:26:12 UTC, 1 replies.
- Review Request 65394: Added separate structs for health check runtime and check types. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/29 18:38:21 UTC, 2 replies.
- Review Request 65397: Windows: Fixed `fs::list` to return full paths. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:32:39 UTC, 0 replies.
- Review Request 65398: Removed workaround in ZooKeeper test. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:32:58 UTC, 0 replies.
- Review Request 65399: Windows: Moved "kill on close" job object flag to own function. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:34:25 UTC, 0 replies.
- Review Request 65400: Windows: Tied task lifetimes to executors. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:34:51 UTC, 0 replies.
- Review Request 65401: Windows: Enabled `Flags::runtime_directory` for checkpointing. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:35:03 UTC, 0 replies.
- Review Request 65402: Windows: Use Unicode API to duplicate sockets. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:35:34 UTC, 0 replies.
- Review Request 65403: Windows: Implemented `os::cloexec` family for file descriptors. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:35:54 UTC, 1 replies.
- Review Request 65404: Windows: Commented `O_CLOEXEC` mapping in `open.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:38:10 UTC, 0 replies.
- Review Request 65405: Implemented `net::socket()` for Windows using `WSASocket`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:39:06 UTC, 1 replies.
- Review Request 65406: Added `TYPED_TEST_TEMP_DISABLED_ON_WINDOWS` macro. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:39:49 UTC, 0 replies.
- Review Request 65407: Windows: Enabled tests that were blocked by MESOS-7604. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:40:22 UTC, 0 replies.
- Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:40:58 UTC, 2 replies.
- Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:41:18 UTC, 4 replies.
- Review Request 65410: Windows: Enabled searching for executable in `cwd`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/29 20:50:33 UTC, 2 replies.
- Review Request 65414: Added tests for `Resources.find` on revocable resources. - posted by Zhitao Li <zh...@gmail.com> on 2018/01/30 00:02:16 UTC, 1 replies.
- Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`. - posted by Zhitao Li <zh...@gmail.com> on 2018/01/30 00:03:28 UTC, 4 replies.
- Review Request 65416: Enabled gRPC in the RPM spec file. - posted by Jie Yu <yu...@gmail.com> on 2018/01/30 03:41:15 UTC, 2 replies.
- Review Request 65419: Fixed quoting issues in docker executor command checks. - posted by Akash Gupta <ak...@hotmail.com> on 2018/01/30 10:12:53 UTC, 0 replies.
- Re: Review Request 65382: Reaped Docker executor only when it can be connected. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/30 15:35:24 UTC, 6 replies.
- Review Request 65420: Fixed a coding error in a log message of Docker containerizer. - posted by Qian Zhang <zh...@gmail.com> on 2018/01/30 15:42:06 UTC, 2 replies.
- Review Request 65423: Fixed duplicate protobuf linking in Python examples. - posted by Till Toenshoff <to...@me.com> on 2018/01/30 21:35:06 UTC, 2 replies.
- Review Request 65424: Improved task status acknowledgement logging messages. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/30 21:35:22 UTC, 1 replies.
- Re: Review Request 63990: Added the RESOURCE_PROVIDER capability to the agent. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/31 00:12:52 UTC, 0 replies.
- Re: Review Request 63991: Added helpers to create and forward offer operation updates. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/31 00:13:45 UTC, 0 replies.
- Review Request 65426: Made gRPC calls wait for the channel to be ready. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/31 00:59:49 UTC, 5 replies.
- Review Request 65427: Used unique CSI plugin names for SLRP tests. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/01/31 01:00:36 UTC, 1 replies.
- Review Request 65428: Reduced the output from Maven during builds. - posted by Michael Park <mp...@apache.org> on 2018/01/31 01:44:16 UTC, 1 replies.
- Re: Review Request 65315: Removed a redundant authorization helper class from the tests. - posted by Greg Mann <gr...@mesosphere.io> on 2018/01/31 02:52:16 UTC, 1 replies.
- Review Request 65432: Added `examples/flags.hpp` to `src/Makefile.am`. - posted by Michael Park <mp...@apache.org> on 2018/01/31 09:20:01 UTC, 3 replies.
- Review Request 65437: Added documentation for fault domains. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/31 17:50:59 UTC, 2 replies.
- Review Request 65439: Made cleanliness checks in post-reviews.py less strict. - posted by Benno Evers <be...@mesosphere.com> on 2018/01/31 17:51:12 UTC, 2 replies.
- Review Request 65438: Fixed flaky SlaveTest.RegisteredAgentReregisterAfterFailover. - posted by Jiang Yan Xu <ya...@jxu.me> on 2018/01/31 17:58:05 UTC, 2 replies.
- Review Request 65441: Deleted deprecated Windows build script. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/31 18:59:19 UTC, 3 replies.
- Review Request 65442: Made `ns::setns` overloads consistent. - posted by James Peach <jp...@apache.org> on 2018/01/31 21:00:47 UTC, 2 replies.
- Review Request 65451: Fixed `contributors.yaml`. - posted by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/31 23:28:29 UTC, 0 replies.