You are viewing a plain text version of this content. The canonical link for it is here.
- Re: Review Request 57161: Cleaned up header includes. - posted by Michael Park <mp...@apache.org> on 2017/03/01 00:04:37 UTC, 1 replies.
- Re: Review Request 57158: Added default parameter value to master validation function. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2017/03/01 00:16:52 UTC, 2 replies.
- Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/01 00:42:03 UTC, 5 replies.
- Re: Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/01 01:38:27 UTC, 0 replies.
- Re: Review Request 57121: Renamed 'SubprocessInfo' to 'ContainerIO' in 'ContainerLogger'. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/01 01:41:25 UTC, 2 replies.
- Re: Review Request 57122: Added STDIN IO to 'ContainerLogger::ContainerIO' class. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/01 01:42:02 UTC, 0 replies.
- Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/01 01:43:07 UTC, 0 replies.
- Review Request 57176: Pulled 'ContainerIO' out of the 'ContainerLogger'. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/01 01:43:51 UTC, 2 replies.
- Review Request 57177: Clarified naming rules in C++ style guide. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/01 01:50:20 UTC, 3 replies.
- Re: Review Request 57167: Updated quota handler logic for hierarchical roles. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2017/03/01 02:21:16 UTC, 28 replies.
- Re: Review Request 56667: Added support for JSON Web Tokens. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/01 07:24:17 UTC, 24 replies.
- Re: Review Request 56753: Implemented the JWT authenticator. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/01 07:41:25 UTC, 22 replies.
- Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2017/03/01 08:03:37 UTC, 0 replies.
- Review Request 57184: Fixed bugs in tests/mesos.hpp helpers. - posted by Gilbert Song <so...@gmail.com> on 2017/03/01 08:15:49 UTC, 2 replies.
- Review Request 57185: Support 'v1::createCallAccept()' helper with multi operations. - posted by Gilbert Song <so...@gmail.com> on 2017/03/01 08:15:51 UTC, 2 replies.
- Review Request 57186: Added unit test for persistent volume using default executor. - posted by Gilbert Song <so...@gmail.com> on 2017/03/01 08:15:52 UTC, 3 replies.
- Review Request 57191: Fixed flaky test MasterTest.MultiRoleFrameworkReceivesOffers. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 10:02:02 UTC, 0 replies.
- Re: Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2017/03/01 10:03:36 UTC, 0 replies.
- Re: Review Request 57165: Minor cleanup for quota validation code. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/01 10:17:19 UTC, 4 replies.
- Re: Review Request 57132: Fixed WebUI data-key. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 10:23:43 UTC, 2 replies.
- Review Request 57192: Updated WebUI to display role information under tab 'Frameworks'. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 10:24:51 UTC, 2 replies.
- Review Request 57195: Updated WebUI to display role information of tasks in homepage. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 10:24:55 UTC, 2 replies.
- Review Request 57193: Updated WebUI to display role information under tab 'Agents'. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 10:28:02 UTC, 2 replies.
- Review Request 57194: Updated WebUI to display role information under tab 'Offers'. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 10:33:02 UTC, 1 replies.
- Re: Review Request 57166: Updated role validation for hierarchical roles. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/01 10:43:16 UTC, 10 replies.
- Re: Review Request 56213: Added check tests for command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/01 10:55:04 UTC, 24 replies.
- Re: Review Request 56208: Updated checks library with general check support. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/01 12:50:40 UTC, 9 replies.
- Review Request 57190: Updated agent for hierarchical roles. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/01 14:47:33 UTC, 18 replies.
- Re: Review Request 55887: Check task user before allowing a task to be launched on the agent. - posted by Anindya Sinha <an...@apple.com> on 2017/03/01 16:15:05 UTC, 15 replies.
- Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents. - posted by Anindya Sinha <an...@apple.com> on 2017/03/01 16:15:29 UTC, 10 replies.
- Re: Review Request 55790: Support the full CNI DNS specification. - posted by James Peach <jp...@apache.org> on 2017/03/01 16:51:16 UTC, 8 replies.
- Re: Review Request 57191: Fixed flakiness in three MULTI_ROLE related tests. - posted by Jay Guo <gu...@gmail.com> on 2017/03/01 17:22:07 UTC, 1 replies.
- Re: Review Request 53369: Agent cgroup assignment should precede agent initialization. - posted by Anindya Sinha <an...@apple.com> on 2017/03/01 17:57:49 UTC, 15 replies.
- Re: Review Request 42806: Added the fetcher plugin module interface. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 17:59:18 UTC, 0 replies.
- Re: Review Request 46979: Introduced 'cni/config' endpoint. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:03:57 UTC, 0 replies.
- Re: Review Request 47032: Fixed HttpCachedConcurrent flakiness in slow machine. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:03:59 UTC, 0 replies.
- Re: Review Request 46975: Add title and heading in Mesos Log Page. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:00 UTC, 0 replies.
- Re: Review Request 46966: Form controls must have associated labels. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:01 UTC, 0 replies.
- Re: Review Request 47106: Corrected variable names and 'empty' histogram detection logic. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:02 UTC, 0 replies.
- Re: Review Request 47105: Decided to change the default initial task value. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:03 UTC, 0 replies.
- Re: Review Request 47104: Remove pid from pid-core tracking map. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:04 UTC, 0 replies.
- Re: Review Request 47103: Added reference count decrments to core histograms. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:05 UTC, 0 replies.
- Re: Review Request 47101: Process binding using greedy, submodular selection algorithm. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:06 UTC, 0 replies.
- Re: Review Request 47102: Corrected initial utilization value for cores. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:07 UTC, 0 replies.
- Re: Review Request 47120: Value from f() was used when it needs to be the value from map<> cost. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:08 UTC, 0 replies.
- Re: Review Request 47100: Process binding using greedy, submodular selection algorithm. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:09 UTC, 0 replies.
- Re: Review Request 47127: Forgot the algorithm is maximizing when it needs to minimize. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:10 UTC, 0 replies.
- Re: Review Request 47058: Fix accessibility of table in web GUI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:11 UTC, 0 replies.
- Re: Review Request 47126: Changed the submodular scheduler to constrained maximization. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:12 UTC, 0 replies.
- Re: Review Request 47203: Modified f() function, found a better way to express core utility. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:14 UTC, 0 replies.
- Re: Review Request 47238: Shifted from a cpu-core model of selection to processing unit model. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:04:15 UTC, 0 replies.
- Re: Review Request 46965: Using ARIA landmarks to identify regions of a page. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:50 UTC, 0 replies.
- Re: Review Request 46964: Using the summary attribute of the table element. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:51 UTC, 0 replies.
- Re: Review Request 46954: Ensuring that id attributes are unique on a Web page. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:51 UTC, 0 replies.
- Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:52 UTC, 0 replies.
- Re: Review Request 36610: Add explicit syscall header file to linux fs - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:53 UTC, 0 replies.
- Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:54 UTC, 0 replies.
- Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:55 UTC, 0 replies.
- Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:55 UTC, 0 replies.
- Re: Review Request 47518: Added test case for no volume and no checkpoint. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:56 UTC, 0 replies.
- Re: Review Request 48453: Track UPIDs based on executor id in scheduler driver. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:58 UTC, 0 replies.
- Re: Review Request 46182: Adding app runtime processing to appc store and provisioner. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:58 UTC, 0 replies.
- Re: Review Request 32058: Added protobuf-JSON validation - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:59 UTC, 0 replies.
- Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:07:59 UTC, 0 replies.
- Re: Review Request 49262: Added '--enable-netlink' into configure.ac. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:00 UTC, 0 replies.
- Re: Review Request 49598: Added ability to parse docker v1 'ImageManifest' from 'docker inspect'. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:01 UTC, 0 replies.
- Re: Review Request 32079: added a few more presentations - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:02 UTC, 0 replies.
- Re: Review Request 49731: Supported image volume rootfs mounted at container_path/rootfs. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:02 UTC, 0 replies.
- Re: Review Request 49910: Output disk resource source information. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:04 UTC, 0 replies.
- Re: Review Request 43472: Sped up ZooKeeperTest.LeaderContender by advance Clock. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:04 UTC, 0 replies.
- Re: Review Request 43473: Sped up ContenderDetectorShutdownNetwork by advance Clock. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:05 UTC, 0 replies.
- Re: Review Request 43474: Sped up MasterDetectorExpireSlaveZKSession by advance Clock. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:06 UTC, 0 replies.
- Re: Review Request 43475: Sped up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:07 UTC, 0 replies.
- Re: Review Request 43477: Sped up GroupTest.* test cases by advance clock. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:08 UTC, 0 replies.
- Re: Review Request 43471: Added the zookeeper patch for the slow add_auth calls. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:09 UTC, 0 replies.
- Re: Review Request 50249: Modified 'agent' to accecpt request with charset in Content-Type. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:10 UTC, 0 replies.
- Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:08:11 UTC, 0 replies.
- Re: Review Request 56474: Added support for multiple authenticators to libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/01 18:13:39 UTC, 1 replies.
- Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:00 UTC, 0 replies.
- Re: Review Request 43561: Improve Ranges parsing to handle single values. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:04 UTC, 0 replies.
- Re: Review Request 50298: Removed backward compat code for old (< 0.15) Mesos agents. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:05 UTC, 0 replies.
- Re: Review Request 50330: Updated authentication callsites in endpoint help. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:07 UTC, 0 replies.
- Re: Review Request 50329: Added readonly/readwrite authentication support to endpoint help. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:09 UTC, 0 replies.
- Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:10 UTC, 0 replies.
- Re: Review Request 50630: Update exclued_files in mesos-style.py. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:13 UTC, 0 replies.
- Re: Review Request 50633: Libprocess: [1/3] Parameterized decoder tests for incremental parsing. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:14 UTC, 0 replies.
- Re: Review Request 50713: Documented behavior of content-type header in presence of errors. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:15 UTC, 0 replies.
- Re: Review Request 50739: Updated '--fetcher_cache_dir' help string. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:20 UTC, 0 replies.
- Re: Review Request 50421: Added code to detect proper zookeeper home directory. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:23 UTC, 0 replies.
- Re: Review Request 50866: Updated `offerCallback` for allocator benchmark test. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:24 UTC, 0 replies.
- Re: Review Request 50954: Added documentation to Appc runtime support. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:26 UTC, 0 replies.
- Re: Review Request 50851: Decode Protobuf long int form strings. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:30 UTC, 0 replies.
- Re: Review Request 41787: Speed up SlaveRecoveryTest.*. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:33 UTC, 0 replies.
- Re: Review Request 51109: Added a Table abstraction and some functions to the CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:34 UTC, 0 replies.
- Re: Review Request 51113: Added the agent plugin the the Mesos CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:36 UTC, 0 replies.
- Re: Review Request 51127: Added the cluster plugin the the Mesos CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:38 UTC, 0 replies.
- Re: Review Request 51110: Introduced the PluginTestBase class into the CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:39 UTC, 0 replies.
- Re: Review Request 51145: Added testing for the cluster plugin of the CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:45 UTC, 0 replies.
- Re: Review Request 51146: Added testing for the agent plugin of the CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:46 UTC, 0 replies.
- Re: Review Request 51111: Added the container plugin to the Mesos CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:47 UTC, 0 replies.
- Re: Review Request 51157: Added testing for the container plugin of the CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:49 UTC, 0 replies.
- Re: Review Request 49689: Added Appc runtime isolator tests. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:51 UTC, 0 replies.
- Re: Review Request 50540: Add systemd watchdog support. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:51 UTC, 0 replies.
- Re: Review Request 51351: Update HttpDockerExecutor with v1 API. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:14:54 UTC, 0 replies.
- Re: Review Request 51352: Make docker executor unversioned. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:01 UTC, 0 replies.
- Re: Review Request 47771: Validate ACLs on creating an instance of local authorizer. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:03 UTC, 0 replies.
- Re: Review Request 39939: Made docker_socket option support different protocols. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:05 UTC, 0 replies.
- Re: Review Request 51497: Avoided blocking calls in `Docker::validateVersion`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:06 UTC, 0 replies.
- Re: Review Request 51508: Remove the useless http::get method. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:07 UTC, 0 replies.
- Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:09 UTC, 0 replies.
- Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:11 UTC, 0 replies.
- Re: Review Request 49617: Add benchmark for failover of many frameworks. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:12 UTC, 0 replies.
- Re: Review Request 52006: Supported docker/volume isolator to be nested aware. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:13 UTC, 0 replies.
- Re: Review Request 52331: Increased the resources used by the default executor test. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:15 UTC, 0 replies.
- Re: Review Request 52338: Master proxy MVP. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:15 UTC, 0 replies.
- Re: Review Request 52328: Added a test for health check failure to the default executor. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:16 UTC, 0 replies.
- Re: Review Request 52393: Allowed malformatted docker config file from '--docker_config'. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:17 UTC, 0 replies.
- Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:18 UTC, 0 replies.
- Re: Review Request 42860: Added paths::overlapping to check whether paths are overlapping. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:20 UTC, 0 replies.
- Re: Review Request 50326: Added script to build mesos-resolve. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:22 UTC, 0 replies.
- Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:23 UTC, 0 replies.
- Re: Review Request 52486: Decoupled QueuedTasks and QueuedTaskGroups on the agent. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:24 UTC, 0 replies.
- Re: Review Request 51108: Added additional parameters to the CLI config. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:26 UTC, 0 replies.
- Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:27 UTC, 0 replies.
- Re: Review Request 52855: Re-enabled the change user test in slave tests. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:28 UTC, 0 replies.
- Re: Review Request 51410: Enabled meta discovery and appc labels. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:30 UTC, 0 replies.
- Re: Review Request 50960: Added appc uri fetcher tests. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:31 UTC, 0 replies.
- Re: Review Request 50959: Added appc fetcher plugin to use rkt tool. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:31 UTC, 0 replies.
- Re: Review Request 51411: Added provisioner tests to provision using meta discovery. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:33 UTC, 0 replies.
- Re: Review Request 52809: User Namespaces Initial Implementation. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:35 UTC, 0 replies.
- Re: Review Request 52810: Added tests to test usernamespaces. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:36 UTC, 0 replies.
- Re: Review Request 51493: Add the query parameter in createRequest. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:37 UTC, 0 replies.
- Re: Review Request 51495: Replace http::get with http::request in libprocess project. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:39 UTC, 0 replies.
- Re: Review Request 51505: Replace http::get with http::request in mesos project. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:41 UTC, 0 replies.
- Re: Review Request 50380: Added new benchmark test for port resources. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:42 UTC, 0 replies.
- Re: Review Request 53009: Add support for task labels to example no_executor_framework. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:43 UTC, 0 replies.
- Re: Review Request 52942: Updated CLI pylint configuration to ignore the 'netifaces' module. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:44 UTC, 3 replies.
- Re: Review Request 52943: Updated CLI pylint configuration to disable no-self-use warnings. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:45 UTC, 2 replies.
- Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:47 UTC, 3 replies.
- Re: Review Request 52945: Added the ability for a CLI plugin command to have an alias. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:48 UTC, 0 replies.
- Re: Review Request 52948: Added a Table abstraction and some utility functions to the new CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:42 UTC, 0 replies.
- Re: Review Request 52950: Extended the basic CLI unit test infrastructure. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:43 UTC, 0 replies.
- Re: Review Request 52951: Introduced the notion of an AGENT_IP in the new CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:45 UTC, 0 replies.
- Re: Review Request 52952: Added a 'container' plugin to the CLI with a 'list()' command. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:46 UTC, 0 replies.
- Re: Review Request 52953: Added container 'exec' command to the CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:47 UTC, 0 replies.
- Re: Review Request 52543: Added configure/make options to build the new CLI and run unit tests. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:48 UTC, 0 replies.
- Re: Review Request 51033: Added validation benchmark test for resources. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:50 UTC, 0 replies.
- Re: Review Request 53016: Added test case for ranges value. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:51 UTC, 0 replies.
- Re: Review Request 53033: Improved agent re-registration log messages. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:52 UTC, 0 replies.
- Re: Review Request 53035: Tweaked an agent log message. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:53 UTC, 0 replies.
- Re: Review Request 53067: Added log message when terminating agent ID. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:54 UTC, 0 replies.
- Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' if pip-requirements.txt modified. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:56 UTC, 1 replies.
- Re: Review Request 52939: Updated CLI pylint configuration to add 'ip' to the list of good-names. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:57 UTC, 1 replies.
- Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:29:58 UTC, 1 replies.
- Re: Review Request 52946: Fixed some bugs in the CLI help formatting. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:00 UTC, 0 replies.
- Re: Review Request 53173: Removed flakiness from SlaveTest.KillTaskGroupBetweenRunTaskParts. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:02 UTC, 0 replies.
- Re: Review Request 52947: Updated parsing for CLI config to be more dynamic. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:02 UTC, 0 replies.
- Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:04 UTC, 0 replies.
- Re: Review Request 53113: Added benchmark for measuring call ingestion throughput. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:06 UTC, 0 replies.
- Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:07 UTC, 0 replies.
- Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:08 UTC, 0 replies.
- Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:09 UTC, 0 replies.
- Re: Review Request 53083: Made `cgroups::create` create cgroup recursively as default behaviour. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:11 UTC, 0 replies.
- Re: Review Request 53267: Added log and counter for tracking subscribers. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:12 UTC, 0 replies.
- Re: Review Request 51752: Add event for `FRAMEWORK_REMOVED`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:13 UTC, 0 replies.
- Re: Review Request 53293: Show framework's role and principal in WebUI. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:15 UTC, 0 replies.
- Re: Review Request 51031: Added non-recursive version of `cgroups::get`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:16 UTC, 0 replies.
- Re: Review Request 53389: Used `MasterInfo.address` to generate the leader information. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:18 UTC, 0 replies.
- Re: Review Request 53411: Use a random TCP port for framework tests. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:22 UTC, 0 replies.
- Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:22 UTC, 0 replies.
- Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:25 UTC, 1 replies.
- Re: Review Request 52668: Refactored nested container tests launcher orphans. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:25 UTC, 0 replies.
- Re: Review Request 53330: Tracked layers and pull latency in docker store. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:38 UTC, 0 replies.
- Re: Review Request 53501: Added a test to catch regressions to MESOS-4975. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:39 UTC, 0 replies.
- Re: Review Request 53567: Improved CREATE operation validation error message. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:42 UTC, 0 replies.
- Re: Review Request 51700: Add `FrameworkAdded` event to master event stream. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:42 UTC, 0 replies.
- Re: Review Request 53641: Refactored `CgroupsAnyHierarchyTest` test cases. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:44 UTC, 0 replies.
- Re: Review Request 50491: Added PIDGroup to libprocess. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:46 UTC, 0 replies.
- Re: Review Request 50492: Switched replicated log to use PIDGroup. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:47 UTC, 0 replies.
- Re: Review Request 50490: Separated ZooKeeper PIDGroup implementation into its own cpp/hpp. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:48 UTC, 0 replies.
- Re: Review Request 50494: Remove `base` from ZooKeeperPIDGroup. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:50 UTC, 0 replies.
- Re: Review Request 50495: Added PIDGroup module struct. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:51 UTC, 0 replies.
- Re: Review Request 53700: Refactored `group` in LogProcess into ZooKeeperPIDGroup. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:51 UTC, 0 replies.
- Re: Review Request 50496: Added pid group module to `createPIDGroup` method. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:53 UTC, 0 replies.
- Re: Review Request 50497: Added new constructors in Log and LogProcess. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:54 UTC, 0 replies.
- Re: Review Request 53702: Added a factory method to produce PIDGroup. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:55 UTC, 0 replies.
- Re: Review Request 50498: Added --master_pid_group flag in master. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:57 UTC, 0 replies.
- Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:58 UTC, 0 replies.
- Re: Review Request 53701: Renamed `group` in ZooKeeperPIDGroup to `observer`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:37:59 UTC, 0 replies.
- Re: Review Request 50493: Added `base` to PIDGroup. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:00 UTC, 0 replies.
- Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:01 UTC, 0 replies.
- Re: Review Request 52735: Updated comments for killing some garbage containers. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:02 UTC, 0 replies.
- Re: Review Request 50128: Overloaded the << operator for `Docker::Device`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:04 UTC, 0 replies.
- Re: Review Request 50947: Only check `gpu/nvidia` isolator for mesos containerizer. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:05 UTC, 0 replies.
- Re: Review Request 53532: Added `parse` helper function for `Docker::Device`. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:07 UTC, 0 replies.
- Re: Review Request 50599: Assigned Nvidia GPU devices to docker container. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:07 UTC, 0 replies.
- Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:09 UTC, 0 replies.
- Re: Review Request 50125: Added `--devices` flag to mesos-docker-executor. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:09 UTC, 0 replies.
- Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:11 UTC, 0 replies.
- Re: Review Request 46227: Added an user to indicate owner of persistent volume. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:12 UTC, 0 replies.
- Re: Review Request 50010: Added example framework for handling inverse offers. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:15 UTC, 0 replies.
- Re: Review Request 46230: Updated docs to reflect user in persistent volumes. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:15 UTC, 0 replies.
- Re: Review Request 52980: Updated os::mkdir() to take the mode as an input. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:15 UTC, 0 replies.
- Re: Review Request 53607: Added Seccomp imeplementation. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:17 UTC, 0 replies.
- Re: Review Request 53608: Added --enable-seccomp flag to configure options. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:18 UTC, 0 replies.
- Re: Review Request 54084: Made public Mesos header standalone. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:20 UTC, 0 replies.
- Re: Review Request 53119: Moved `ns.hpp` to stout [1/2]. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:21 UTC, 0 replies.
- Re: Review Request 54104: Adjusted code style in docker executor. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:22 UTC, 0 replies.
- Re: Review Request 53146: Added a child hook for switching the user. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:23 UTC, 0 replies.
- Re: Review Request 53147: Made health check run under the same user with tasks. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:25 UTC, 0 replies.
- Re: Review Request 53121: Added a child hook for entering the target pid's namespaces. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:27 UTC, 0 replies.
- Re: Review Request 53120: Moved `ns.hpp` to stout [2/2]. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:27 UTC, 0 replies.
- Re: Review Request 53122: Used child hooks to enter namespaces in health check. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:28 UTC, 0 replies.
- Re: Review Request 53123: Made `process::defaultClone` private. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:30 UTC, 0 replies.
- Re: Review Request 53604: Added SeccompInfo protobuf message. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:31 UTC, 0 replies.
- Re: Review Request 53605: Added --seccomp_profile flag to Mesos agent. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:34 UTC, 0 replies.
- Re: Review Request 53695: Allows caching extractable files when outputFile is set. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:35 UTC, 0 replies.
- Re: Review Request 53606: Added `linux/seccomp` isolator. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:35 UTC, 0 replies.
- Re: Review Request 46229: Add unit tests for adding a user for persistent volumes. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:37 UTC, 0 replies.
- Re: Review Request 46228: Create persistent volume with a supplied user. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:40 UTC, 0 replies.
- Re: Review Request 53479: Perform agent GC asynchronously. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:41 UTC, 0 replies.
- Re: Review Request 53882: Fix configure on FreeBSD. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:41 UTC, 0 replies.
- Re: Review Request 53912: Fix xattr for FreeBSD. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:44 UTC, 0 replies.
- Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:44 UTC, 0 replies.
- Re: Review Request 53925: Fix wait macros on FreeBSD. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:45 UTC, 0 replies.
- Re: Review Request 53926: Move isJailed for FreeBSD into utils. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:47 UTC, 0 replies.
- Re: Review Request 53927: Check isJailed in tests that call mknod. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:48 UTC, 0 replies.
- Re: Review Request 53931: Don't expect an init process in a FreeBSD jail. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:49 UTC, 0 replies.
- Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:51 UTC, 0 replies.
- Re: Review Request 50455: Enabled Java builds if Java is found. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:57 UTC, 0 replies.
- Re: Review Request 50456: Added custom command to generate Java protobufs. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:57 UTC, 0 replies.
- Re: Review Request 50414: Added variables for building Java Protobuf. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:38:57 UTC, 0 replies.
- Re: Review Request 50457: Added code to generate MesosNativeLibrary.java. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:41 UTC, 0 replies.
- Re: Review Request 50458: Added code to build mesos-java.jar. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:42 UTC, 0 replies.
- Re: Review Request 50459: Added code to generate JNI Header files. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:43 UTC, 0 replies.
- Re: Review Request 50460: Added code to build libstate shared library. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:44 UTC, 0 replies.
- Re: Review Request 50463: Added code to build libmesosjava shared library. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:46 UTC, 0 replies.
- Re: Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:47 UTC, 0 replies.
- Re: Review Request 50415: Added build step to build Java Protobuf. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:49 UTC, 0 replies.
- Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:50 UTC, 11 replies.
- Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:51 UTC, 0 replies.
- Re: Review Request 46425: Add helper function to simplify tokenize handling. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:53 UTC, 0 replies.
- Re: Review Request 54085: Made internal Mesos headers more standalone. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:53 UTC, 0 replies.
- Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:55 UTC, 0 replies.
- Re: Review Request 52002: Added helper methods to determine types of disk resources. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:57 UTC, 0 replies.
- Re: Review Request 51879: Autodetect value of resource when not specified in static resources. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:58 UTC, 0 replies.
- Re: Review Request 53713: Reversed recoursive path creation. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:45:59 UTC, 0 replies.
- Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:00 UTC, 0 replies.
- Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:02 UTC, 0 replies.
- Re: Review Request 52071: Updated docs to handle resources with no size in agent flags. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:03 UTC, 0 replies.
- Re: Review Request 50523: Updated docker recovery to account for GPU resources. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:03 UTC, 0 replies.
- Re: Review Request 54828: Fixed flags::fetch() to support Windows file paths. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:05 UTC, 0 replies.
- Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:06 UTC, 0 replies.
- Re: Review Request 54986: Added metric for slave message queue. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:07 UTC, 0 replies.
- Re: Review Request 52064: Support for multiple versions of docs. - posted by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:46:10 UTC, 0 replies.
- Re: Review Request 56016: Added a note about task status updates in scheduler and internal API. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/01 19:43:26 UTC, 5 replies.
- Re: Review Request 56017: Added a helper for building a task status from an existing one. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/01 19:46:03 UTC, 9 replies.
- Re: Review Request 54081: Added `--pidfile` option to master and agent binaries. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/01 20:47:59 UTC, 0 replies.
- Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`. - posted by Michael Park <mp...@apache.org> on 2017/03/01 20:51:44 UTC, 1 replies.
- Re: Review Request 57013: Expose offer allocation info within the master /state endpoint. - posted by Michael Park <mp...@apache.org> on 2017/03/01 21:35:34 UTC, 0 replies.
- Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`. - posted by Michael Park <mp...@apache.org> on 2017/03/01 23:18:11 UTC, 2 replies.
- Review Request 57235: Fixed a typo in the comment of master.cpp. - posted by Jay Guo <gu...@gmail.com> on 2017/03/02 08:04:00 UTC, 2 replies.
- Re: Review Request 57054: Fixed a bug in master and agent handler authorization logic. - posted by Adam B <ad...@mesosphere.io> on 2017/03/02 09:26:07 UTC, 0 replies.
- Re: Review Request 56852: Updated OCI spec parsing & validation code with latest OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/02 09:30:23 UTC, 3 replies.
- Re: Review Request 56901: Updated master validation code to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/02 18:41:54 UTC, 2 replies.
- Review Request 57254: Updated DRFSorter to support hierarchical roles. - posted by Neil Conway <ne...@gmail.com> on 2017/03/02 20:41:33 UTC, 24 replies.
- Re: Review Request 57109: Re-checkpointed the `Executor`s and `Task`s during agent recovery. - posted by Michael Park <mp...@apache.org> on 2017/03/02 21:48:58 UTC, 3 replies.
- Re: Review Request 56813: Updated master handlers to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/02 22:20:16 UTC, 8 replies.
- Re: Review Request 57110: Updated the master to handle frameworks that changes its roles. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/02 23:14:04 UTC, 21 replies.
- Review Request 57260: CMake: Refactored FindApr.cmake and FindSvn.cmake. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/02 23:53:48 UTC, 3 replies.
- Review Request 57261: CMake: Added configuration options for SSL builds. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/02 23:53:50 UTC, 2 replies.
- Review Request 57262: CMake: Added support for SSL-enabled builds. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/02 23:53:50 UTC, 6 replies.
- Re: Review Request 57149: Added a warning if command executor gets an unknown acknowledgement. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 00:16:45 UTC, 4 replies.
- Re: Review Request 56210: Reused previous task status for health updates in command executor. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 00:24:46 UTC, 3 replies.
- Re: Review Request 56211: Renamed health checker in command executor for clarity. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 00:25:38 UTC, 3 replies.
- Re: Review Request 56733: Mount all supported subsystems in the containerizer tests. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/03 00:36:52 UTC, 5 replies.
- Re: Review Request 56730: Kill stray tasks when tearing down test cgroups. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/03 00:40:33 UTC, 8 replies.
- Review Request 57264: Fixed ProvisionerDockerPullerTest.ROOT_RecoverNestedOnReboot. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/03 01:35:30 UTC, 2 replies.
- Re: Review Request 56212: Added support for general checks to command executor. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 02:10:24 UTC, 7 replies.
- Re: Review Request 57150: Simplified task id procurement in command executor. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 02:12:27 UTC, 4 replies.
- Re: Review Request 56754: Implemented a JWT secret generator. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/03 07:48:16 UTC, 17 replies.
- Review Request 57269: Added a test to ensure allocation roles are exposed in master API. - posted by Jay Guo <gu...@gmail.com> on 2017/03/03 08:30:41 UTC, 10 replies.
- Re: Review Request 56623: Implemented the 'Principal' type in libprocess. - posted by Adam B <ad...@mesosphere.io> on 2017/03/03 10:19:22 UTC, 4 replies.
- Review Request 57282: Sent `UpdateFrameworkMessage` even to disconnected frameworks. - posted by Michael Park <mp...@apache.org> on 2017/03/03 12:01:40 UTC, 4 replies.
- Re: Review Request 56665: Added a URL-safe base64 implementation. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/03/03 14:00:59 UTC, 5 replies.
- Re: Review Request 56666: Added a HMAC SHA256 generator. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/03/03 14:02:20 UTC, 5 replies.
- Re: Review Request 56618: Updated common Mesos code to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/03 18:39:10 UTC, 2 replies.
- Re: Review Request 56812: Updated agent handlers to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/03 18:43:21 UTC, 1 replies.
- Review Request 57298: Added a new libprocess test for invalid principals. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/03 18:50:53 UTC, 3 replies.
- Re: Review Request 56621: Updated Mesos tests to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/03 18:51:20 UTC, 1 replies.
- Re: Review Request 56449: Moved health checker closer to container in default executor. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 19:24:26 UTC, 9 replies.
- Re: Review Request 57262: WIP: CMake: Added support for SSL-enabled builds. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/03 21:05:58 UTC, 0 replies.
- Re: Review Request 56617: Updated libprocess handlers to use the 'Principal' type. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 23:22:51 UTC, 0 replies.
- Re: Review Request 57153: Removed unnecessary 'using' statement in master HTTP code. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 23:44:32 UTC, 0 replies.
- Re: Review Request 56619: Updated 'Files' handlers to use the 'Principal' type. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/03 23:58:50 UTC, 0 replies.
- Re: Review Request 56624: Updated libprocess tests to use the 'Principal' type. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/04 00:32:54 UTC, 0 replies.
- Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/04 01:58:16 UTC, 9 replies.
- Re: Review Request 57112: Updated existing test cases to allow for frameworks to change its roles. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/04 02:02:42 UTC, 3 replies.
- Review Request 57319: Fixed a bug around temporaries in `src/master/http.cpp`. - posted by Michael Park <mp...@apache.org> on 2017/03/05 03:23:37 UTC, 1 replies.
- Review Request 57329: Renamed `activeRoles` to `roles` in the master. - posted by Michael Park <mp...@apache.org> on 2017/03/06 10:50:09 UTC, 2 replies.
- Review Request 57330: Renamed `source` to `newInfo` for `Framework::updateFrameworkInfo`. - posted by Michael Park <mp...@apache.org> on 2017/03/06 10:50:19 UTC, 4 replies.
- Review Request 57331: Used `at` in a few instances. - posted by Michael Park <mp...@apache.org> on 2017/03/06 10:56:14 UTC, 0 replies.
- Re: Review Request 57331: Used `at` rather than `operator[]` in a few instances. - posted by Michael Park <mp...@apache.org> on 2017/03/06 10:57:02 UTC, 1 replies.
- Review Request 57335: Migrated `MultiRoleSchedulerUpgrade` from `MasterTest` to `UpgradeTest`. - posted by Michael Park <mp...@apache.org> on 2017/03/06 13:15:52 UTC, 3 replies.
- Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates. - posted by Michael Park <mp...@apache.org> on 2017/03/06 13:16:05 UTC, 7 replies.
- Review Request 57340: Remove adjustment code within Resources::apply. - posted by Jay Guo <gu...@gmail.com> on 2017/03/06 15:26:41 UTC, 6 replies.
- Re: Review Request 55901: Added support for command health checks to the default executor. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/06 16:23:01 UTC, 9 replies.
- Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/06 21:31:20 UTC, 0 replies.
- Re: Review Request 55323: Used process::loop for framework scheduler heartbeater. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/06 21:36:07 UTC, 0 replies.
- Review Request 57156: Minor cleanup for slave tests. - posted by Neil Conway <ne...@gmail.com> on 2017/03/06 21:41:06 UTC, 0 replies.
- Re: Review Request 57162: Minor cleanup for slave tests. - posted by Michael Park <mp...@apache.org> on 2017/03/06 21:43:57 UTC, 1 replies.
- Re: Review Request 57163: Cleaned up sorter test cases. - posted by Michael Park <mp...@apache.org> on 2017/03/06 21:46:20 UTC, 0 replies.
- Re: Review Request 57164: Cleaned up header includes. - posted by Michael Park <mp...@apache.org> on 2017/03/06 21:47:54 UTC, 0 replies.
- Re: Review Request 57058: Updated default executor tests to exclusively use v1 protos. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/07 01:15:23 UTC, 1 replies.
- Re: Review Request 57059: Updated default executor tests. - posted by Vinod Kone <vi...@gmail.com> on 2017/03/07 01:17:12 UTC, 4 replies.
- Review Request 57354: Added `initializer_list` constructors for `JSON::(Object|Array)`. - posted by Michael Park <mp...@apache.org> on 2017/03/07 01:33:46 UTC, 2 replies.
- Re: Review Request 56805: Simplified interface for setting weights in allocator. - posted by Michael Park <mp...@apache.org> on 2017/03/07 01:38:49 UTC, 1 replies.
- Review Request 57358: Fixed potential for circular dependencies in Future continuations. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/07 02:50:45 UTC, 0 replies.
- Review Request 57360: Replace `.get().` in favor of `->` in tests. - posted by Jay Guo <gu...@gmail.com> on 2017/03/07 03:39:41 UTC, 6 replies.
- Review Request 57364: Fixed flaky test FaultToleranceTest.FrameworkReregister. - posted by Jay Guo <gu...@gmail.com> on 2017/03/07 06:48:24 UTC, 4 replies.
- Re: Review Request 56757: Added the SecretGenerator module interface. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/07 07:13:53 UTC, 6 replies.
- Review Request 57382: Removed unused lambda captures. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/07 17:04:33 UTC, 2 replies.
- Review Request 57384: Added `Containerizer::cleanupArtifacts`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/07 17:13:31 UTC, 13 replies.
- Review Request 57385: Introduced proto changes needed for the DeleteNestedContainer API call. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/07 17:13:42 UTC, 4 replies.
- Review Request 57386: Introduced changes to the auth photos needed for DeleteNestedContainer. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/07 17:14:32 UTC, 2 replies.
- Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/07 17:15:28 UTC, 11 replies.
- Review Request 57387: Implemented the Agent API call `DeleteNestedContainer`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/07 17:16:10 UTC, 4 replies.
- Review Request 57388: Added documentation for the 'DeleteNestedContainer' Agent API call. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/07 17:17:09 UTC, 3 replies.
- Re: Review Request 57358: WIP: Fixed potential for circular dependencies in Future continuations. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/07 18:09:09 UTC, 0 replies.
- Re: Review Request 53840: Added a metric in the allocator to track previous allocation cycle. - posted by Anindya Sinha <an...@apple.com> on 2017/03/07 18:52:43 UTC, 0 replies.
- Re: Review Request 57358: Fixed FD leak in SSL server socket cleanup. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/07 20:18:49 UTC, 3 replies.
- Review Request 57394: Overloaded `<<` for `CheckInfo::Type`. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/07 20:38:49 UTC, 4 replies.
- Re: Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support. - posted by Aaron Wood via Review Board <no...@reviews.apache.org> on 2017/03/07 22:06:48 UTC, 0 replies.
- Review Request 57395: Fixed a typo in libprocess 'Socket'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/07 22:39:06 UTC, 2 replies.
- Re: Review Request 53840: Metric in the allocator to track latency between allocation cycles. - posted by Anindya Sinha <an...@apple.com> on 2017/03/07 23:41:27 UTC, 0 replies.
- Re: Review Request 53842: Add role specific metrics for sorting runs. - posted by Anindya Sinha <an...@apple.com> on 2017/03/07 23:41:31 UTC, 1 replies.
- Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator. - posted by Anindya Sinha <an...@apple.com> on 2017/03/07 23:41:31 UTC, 0 replies.
- Review Request 57399: Expanded the critical section inside `ProcessManager::spawn`. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/08 00:01:42 UTC, 0 replies.
- Review Request 57401: Removed redundant 'root' user set in containerizer::launch(). - posted by Gilbert Song <so...@gmail.com> on 2017/03/08 01:27:16 UTC, 1 replies.
- Review Request 57402: Fixed command task with container image 'root' user issue. - posted by Gilbert Song <so...@gmail.com> on 2017/03/08 01:27:21 UTC, 1 replies.
- Review Request 57403: Added unit test for verifying user in command task with image specified. - posted by Gilbert Song <so...@gmail.com> on 2017/03/08 01:27:25 UTC, 1 replies.
- Re: Review Request 56731: Fix perf-stat parsing for recent perf releases. - posted by haosdent huang <ha...@apache.org> on 2017/03/08 02:12:48 UTC, 0 replies.
- Re: Review Request 56732: Remove unnecessary perf version checks. - posted by haosdent huang <ha...@apache.org> on 2017/03/08 02:14:00 UTC, 0 replies.
- Re: Review Request 57386: Introduced changes to the auth protos needed for DeleteNestedContainer. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/08 11:08:03 UTC, 4 replies.
- Review Request 57422: Removed misleading comment from protobuf file. - posted by Neil Conway <ne...@gmail.com> on 2017/03/08 15:56:31 UTC, 4 replies.
- Re: Review Request 53264: Added test for CNI port-mapper plugin. - posted by Avinash sridharan <av...@mesosphere.io> on 2017/03/08 16:57:04 UTC, 15 replies.
- Review Request 57425: Added pull method to Containerizer. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/08 17:11:13 UTC, 1 replies.
- Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/08 17:11:21 UTC, 4 replies.
- Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/08 17:11:25 UTC, 3 replies.
- Re: Review Request 56027: Consistently add the FollowSymlink stat argument on POSIX. - posted by Michael Park <mp...@apache.org> on 2017/03/08 17:27:31 UTC, 11 replies.
- Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows. - posted by Michael Park <mp...@apache.org> on 2017/03/08 17:30:19 UTC, 8 replies.
- Review Request 57442: Update website for Mesos 1.2.0 release. - posted by Adam B <ad...@mesosphere.io> on 2017/03/09 02:44:16 UTC, 3 replies.
- Re: Review Request 57386: Introduced changes to the authz protos needed for DeleteNestedContainer. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/09 14:33:47 UTC, 0 replies.
- Review Request 57469: Made the default executor populate volume mappings for disk resources. - posted by Anand Mazumdar <an...@apache.org> on 2017/03/09 17:48:16 UTC, 5 replies.
- Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/03/09 18:25:24 UTC, 14 replies.
- Review Request 57473: Added support for authorization of Hierachical roles. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/03/09 18:25:38 UTC, 7 replies.
- Review Request 57474: Added test for authorization of hierarchical roles. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/03/09 18:26:40 UTC, 8 replies.
- Re: Review Request 56689: Windows: Prevented crash if sandbox `stdout` file already exists. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/09 20:27:26 UTC, 0 replies.
- Review Request 57479: Clarified a comment for 'Principal' in libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/09 22:00:39 UTC, 1 replies.
- Review Request 57480: Replaced an instance of `/dev/null` with `os::DEV_NULL`. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/09 22:23:31 UTC, 0 replies.
- Review Request 57481: Replaced most instances of `/dev/null` with `os::DEV_NULL`. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/09 22:23:37 UTC, 3 replies.
- Re: Review Request 56475: Added libprocess tests for multiple authenticators. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/09 23:41:13 UTC, 0 replies.
- Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/09 23:41:43 UTC, 5 replies.
- Re: Review Request 56474: Added the 'CombinedAuthenticator'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/09 23:43:27 UTC, 15 replies.
- Re: Review Request 56478: Renamed 'unsetAuthenticator' to 'unsetAuthenticators' in libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/09 23:44:06 UTC, 0 replies.
- Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/09 23:45:59 UTC, 12 replies.
- Review Request 57490: Windows: Add Glog patch for enabling stack trace. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/10 01:59:13 UTC, 1 replies.
- Review Request 57491: Windows: Update libprocess CMake setup for Glog patch. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/10 01:59:52 UTC, 4 replies.
- Review Request 57512: Fixed whitespace in Mesos. - posted by Neil Conway <ne...@gmail.com> on 2017/03/10 17:05:10 UTC, 1 replies.
- Review Request 57511: Fixed whitespace in stout. - posted by Neil Conway <ne...@gmail.com> on 2017/03/10 17:05:21 UTC, 1 replies.
- Review Request 57510: Fixed whitespace in libprocess. - posted by Neil Conway <ne...@gmail.com> on 2017/03/10 17:05:32 UTC, 2 replies.
- Review Request 57513: Cleaned up `strings::tokenize` and `strings::split`. - posted by Neil Conway <ne...@gmail.com> on 2017/03/10 17:05:43 UTC, 4 replies.
- Re: Review Request 57384: Added `Containerizer::remove`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/10 17:58:53 UTC, 8 replies.
- Re: Review Request 57385: Introduced proto changes needed for the RemoveNestedContainer API call. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/10 18:00:52 UTC, 4 replies.
- Re: Review Request 57386: Introduced changes to the authz protos needed for RemoveNestedContainer. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/10 18:02:02 UTC, 4 replies.
- Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/10 18:04:14 UTC, 7 replies.
- Re: Review Request 57388: Added documentation for the 'RemoveNestedContainer' Agent API call. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/10 18:05:27 UTC, 5 replies.
- Review Request 57516: Updated CHANGELOG for hierarchical roles. - posted by Neil Conway <ne...@gmail.com> on 2017/03/10 18:12:10 UTC, 2 replies.
- Review Request 57527: Moved management of weights from allocator to sorter. - posted by Neil Conway <ne...@gmail.com> on 2017/03/11 01:32:41 UTC, 2 replies.
- Review Request 57528: Reordered DRFSorter member function. - posted by Neil Conway <ne...@gmail.com> on 2017/03/11 01:33:11 UTC, 2 replies.
- Review Request 57529: Improved Stout string tests slightly. - posted by Neil Conway <ne...@gmail.com> on 2017/03/11 01:37:12 UTC, 2 replies.
- Re: Review Request 48291: Use varint comparator in replica log. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/03/11 10:17:49 UTC, 1 replies.
- Review Request 57539: Added ability to dynamically load '/dev/nvidia-uvm' in GPU isolator. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/12 04:24:41 UTC, 4 replies.
- Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' when necessary. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/12 23:35:42 UTC, 1 replies.
- Review Request 57560: Removed unnecessary curly braces wrapping case statements. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/13 15:11:36 UTC, 5 replies.
- Review Request 57562: Added a missing header to fix 'make distcheck'. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/03/13 16:26:36 UTC, 2 replies.
- Review Request 57520: Bumped up the number of args allowed in some libprocess templates. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/13 17:08:01 UTC, 1 replies.
- Review Request 57534: Added and implemented RegisterAgent ACL. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/13 17:09:50 UTC, 12 replies.
- Review Request 57564: Changed DRFSorter's representation of inactive clients. - posted by Neil Conway <ne...@gmail.com> on 2017/03/13 18:04:02 UTC, 13 replies.
- Re: Review Request 57358: WIP: Fixed FD leak in SSL server socket cleanup. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/13 22:34:09 UTC, 1 replies.
- Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit. - posted by Jie Yu <yu...@gmail.com> on 2017/03/14 00:04:41 UTC, 4 replies.
- Review Request 57575: Added a test to test the cgroup limit swap functionality. - posted by Jie Yu <yu...@gmail.com> on 2017/03/14 00:05:35 UTC, 2 replies.
- Re: Review Request 55252: Moved some logic from `Master::Http::_roles` into `filterRoles`. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 10:29:26 UTC, 0 replies.
- Re: Review Request 55253: Added `roles` to `/state` endpoint of master. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 10:29:52 UTC, 0 replies.
- Review Request 57592: Augmented a master test to check `roles` in `/state` endpoint. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 10:31:02 UTC, 0 replies.
- Review Request 57593: Sorted enum values in `authorizer.proto` by numerical order. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/14 11:20:42 UTC, 2 replies.
- Review Request 57594: Added a helper for building a task status from scratch. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/14 14:05:48 UTC, 2 replies.
- Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/14 14:08:47 UTC, 5 replies.
- Review Request 57597: Added comments regarding exit status on Windows vs. Posix. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/14 14:09:16 UTC, 4 replies.
- Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/14 14:09:17 UTC, 2 replies.
- Review Request 57605: Added `GetRoles` to `GetState` in master.proto. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 17:10:00 UTC, 0 replies.
- Review Request 57606: Extracted some logic from `getRoles` into `_getRoles`. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 17:10:26 UTC, 0 replies.
- Review Request 57607: Added `GetRoles` to `GetState` API. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 17:11:00 UTC, 0 replies.
- Review Request 57608: Augmented master api test to check `GetRoles` is included. - posted by Jay Guo <gu...@gmail.com> on 2017/03/14 17:11:32 UTC, 1 replies.
- Review Request 57535: Applied RegisterAgent ACL to the master. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/14 18:27:12 UTC, 11 replies.
- Review Request 57624: Modified an erroneous comment in the Master API proto. - posted by Anand Mazumdar <an...@apache.org> on 2017/03/14 22:27:48 UTC, 2 replies.
- Review Request 57622: Introduced a Roles tab in the webui. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/14 22:28:21 UTC, 9 replies.
- Review Request 57623: Updated the maintenance tab in the webui to auto-refresh. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/14 22:30:22 UTC, 2 replies.
- Review Request 57627: Modified CNI isolator to treat "__MESOST_TEST__*" as a test network. - posted by Avinash sridharan <av...@mesosphere.io> on 2017/03/14 23:05:08 UTC, 2 replies.
- Review Request 57628: Added a utility function to get back non-loopback address on the host. - posted by Avinash sridharan <av...@mesosphere.io> on 2017/03/14 23:06:57 UTC, 4 replies.
- Review Request 57629: Fixed a webui bug where the maintenance tab is not shown as active. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/15 02:06:13 UTC, 2 replies.
- Review Request 57630: Renamed `adjustOfferOperation` to `injectAllocationInfo`. - posted by Jay Guo <gu...@gmail.com> on 2017/03/15 03:26:45 UTC, 1 replies.
- Review Request 57631: Augmented a test to check protobuf::stripAllocationInfo. - posted by Jay Guo <gu...@gmail.com> on 2017/03/15 03:27:09 UTC, 2 replies.
- Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 14:58:10 UTC, 5 replies.
- Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 14:58:25 UTC, 2 replies.
- Review Request 57645: Added support for pausing health checks. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 14:59:32 UTC, 7 replies.
- Review Request 57646: Made COMMAND health checks resilient to agent failovers. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 14:59:46 UTC, 14 replies.
- Review Request 57647: Made CMD health checks not reuse the check `ContainerID`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 14:59:50 UTC, 8 replies.
- Review Request 57648: Improved failure message in `MesosContainerizer::remove()`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 16:22:02 UTC, 6 replies.
- Review Request 57651: Update http authenticator tests to work with any http response. - posted by Silas Snider <sw...@apple.com> on 2017/03/15 16:46:45 UTC, 1 replies.
- Review Request 57652: Allow authenticators to return any http Response. - posted by Silas Snider <sw...@apple.com> on 2017/03/15 16:47:50 UTC, 1 replies.
- Re: Review Request 57358: Implemented discard behavior in process::Queue. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/15 18:01:28 UTC, 6 replies.
- Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/15 18:31:40 UTC, 1 replies.
- Re: Review Request 56681: Use glog to log EXIT() messages. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/15 21:45:29 UTC, 3 replies.
- Review Request 57663: Updated documentation for multiple HTTP authenticators. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 21:55:20 UTC, 5 replies.
- Review Request 57664: Added the '--executor_secret_key' agent flag. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 22:02:52 UTC, 10 replies.
- Review Request 57615: Added support for auth tokens to the V1 executor library. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 22:04:08 UTC, 11 replies.
- Review Request 57665: Renamed a constant. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 22:06:35 UTC, 5 replies.
- Review Request 57666: Added agent flag to enable executor authentication. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 22:08:39 UTC, 2 replies.
- Review Request 57667: Added executor authentication to the docs. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 22:09:21 UTC, 10 replies.
- Review Request 57670: Enabled authentication on the V1 executor API. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 23:37:50 UTC, 5 replies.
- Review Request 57671: Allowed the agent to require executor authentication. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 23:39:03 UTC, 15 replies.
- Re: Review Request 57666: Added the '--authenticate_http_executors' agent flag. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/15 23:40:07 UTC, 9 replies.
- Re: Review Request 56214: Hashed unacknowledged updates by UUID string in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 11:18:19 UTC, 0 replies.
- Review Request 57689: Replaced Boost Type Traits with STL in Stout. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/16 13:18:30 UTC, 1 replies.
- Review Request 57690: Replaced Boost Type Traits with STL in libprocess. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/16 13:18:35 UTC, 1 replies.
- Review Request 57691: Enabled AsyncExecutorProcess::execute() via a template parameter. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/16 13:18:40 UTC, 2 replies.
- Re: Review Request 56217: Added support for general checks to default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:03:58 UTC, 6 replies.
- Review Request 57694: Added a warning if default executor gets an unknown acknowledgement. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:45:52 UTC, 6 replies.
- Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:45:54 UTC, 8 replies.
- Re: Review Request 56215: Reused previous task status to generate a new one in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:45:56 UTC, 5 replies.
- Review Request 57696: Overloaded `<<` for `CheckStatusInfo`. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:46:00 UTC, 8 replies.
- Re: Review Request 56218: Added a check test for default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/16 16:46:05 UTC, 9 replies.
- Re: Review Request 56895: Allow agents to recover slave state post a reboot. - posted by Megha Sharma <ms...@apple.com> on 2017/03/16 18:25:27 UTC, 3 replies.
- Review Request 57700: Modified a test to also check if the data was written to the volume. - posted by Anand Mazumdar <an...@apache.org> on 2017/03/16 18:49:45 UTC, 2 replies.
- Review Request 57707: Added multi-role framework support to the CHANGELOG. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/16 22:47:03 UTC, 2 replies.
- Review Request 57710: Added `register_agents` to authorization.md. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/16 23:05:50 UTC, 4 replies.
- Review Request 57712: No need to set `agent_subsystems` for all the slave tests. - posted by Anindya Sinha <an...@apple.com> on 2017/03/17 00:00:32 UTC, 2 replies.
- Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`. - posted by Kevin Klues <kl...@gmail.com> on 2017/03/17 00:19:44 UTC, 7 replies.
- Review Request 57714: Fixed typo in comment. - posted by Neil Conway <ne...@gmail.com> on 2017/03/17 00:40:36 UTC, 2 replies.
- Re: Review Request 57527: Avoided storing weights in the allocator. - posted by Neil Conway <ne...@gmail.com> on 2017/03/17 01:12:15 UTC, 11 replies.
- Re: Review Request 50871: Supported auto backend in Unified Containerizer. - posted by kaiyu shi <sk...@gmail.com> on 2017/03/17 02:42:12 UTC, 1 replies.
- Review Request 57719: Fixed some coding style issues. - posted by Avinash sridharan <av...@mesosphere.io> on 2017/03/17 05:38:28 UTC, 1 replies.
- Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/17 15:53:32 UTC, 0 replies.
- Review Request 57731: Fix a test in MasterAuthorizationTest. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/17 15:55:27 UTC, 1 replies.
- Re: Review Request 56410: Increased granularity of environment handling in command executor. - posted by Till Toenshoff <to...@me.com> on 2017/03/17 17:09:35 UTC, 0 replies.
- Re: Review Request 55895: Add zero byte disk resource support to XFS. - posted by James Peach <jp...@apache.org> on 2017/03/17 21:57:15 UTC, 0 replies.
- Re: Review Request 55897: Add support for not enforcing XFS quotas. - posted by James Peach <jp...@apache.org> on 2017/03/17 21:57:17 UTC, 0 replies.
- Re: Review Request 55903: Update XFS disk isolator documentation. - posted by James Peach <jp...@apache.org> on 2017/03/17 21:57:19 UTC, 1 replies.
- Review Request 57739: Completed frameworks should be tracked based on source. - posted by Anindya Sinha <an...@apple.com> on 2017/03/17 23:36:45 UTC, 2 replies.
- Review Request 57743: Updated the agent to generate executor secrets. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 01:47:35 UTC, 21 replies.
- Review Request 57744: Added secret generation to the local agent. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 01:49:28 UTC, 1 replies.
- Review Request 57745: Added secret generation to the agent binary. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 01:51:43 UTC, 1 replies.
- Review Request 57746: Adjusted namespaces in the tests to prevent collisions. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 01:53:32 UTC, 3 replies.
- Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 01:56:22 UTC, 4 replies.
- Review Request 57748: Enabled executor authentication in the tests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 02:00:32 UTC, 7 replies.
- Review Request 57749: Updated the mock agent for executor authentication. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 02:02:10 UTC, 1 replies.
- Review Request 57750: Turned off executor authentication in the ExecutorHttpApiTests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/18 02:06:57 UTC, 11 replies.
- Review Request 57752: Fixed crash with tasks that use very small resource values. - posted by Neil Conway <ne...@gmail.com> on 2017/03/19 04:21:58 UTC, 1 replies.
- Review Request 57762: Fixed environment duplication in default executor. - posted by Till Toenshoff <to...@me.com> on 2017/03/20 02:17:47 UTC, 18 replies.
- Review Request 57763: Fixed environment overwrite warning to not leak possibly sensitive data. - posted by Till Toenshoff <to...@me.com> on 2017/03/20 02:51:10 UTC, 9 replies.
- Review Request 57764: Removed containerizer flag logging to prevent leak of sensitive data. - posted by Till Toenshoff <to...@me.com> on 2017/03/20 03:15:43 UTC, 9 replies.
- Review Request 57765: Remove and Update ARP and ICMP filters using handle. - posted by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2017/03/20 06:20:03 UTC, 1 replies.
- Re: Review Request 56680: Apply glog to agent exit messages. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/03/20 08:37:04 UTC, 0 replies.
- Review Request 57767: Added quota information to /roles endpoint of master. - posted by Jay Guo <gu...@gmail.com> on 2017/03/20 08:40:39 UTC, 0 replies.
- Review Request 57768: Added a test to check /roles endpoint of master includes quota info. - posted by Jay Guo <gu...@gmail.com> on 2017/03/20 08:55:40 UTC, 3 replies.
- Review Request 57773: Improved logging on a fatal condition in command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/20 11:50:54 UTC, 1 replies.
- Review Request 57774: Printed a note that docker executor does not support general checks. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/20 11:57:22 UTC, 4 replies.
- Review Request 57775: Ensured check's exit code is interpreted correctly on Windows. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/20 11:58:53 UTC, 13 replies.
- Review Request 57783: Updated website for 1.1.1 release. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/20 17:18:42 UTC, 2 replies.
- Review Request 57784: Updated blog post section in the release guide. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/20 17:18:46 UTC, 3 replies.
- Re: Review Request 56680: Use the EXIT() macro more consistently in agent startup. - posted by James Peach <jp...@apache.org> on 2017/03/20 17:50:27 UTC, 0 replies.
- Review Request 57788: Changed allocator to skip batch allocate on weight change. - posted by Neil Conway <ne...@gmail.com> on 2017/03/20 18:14:50 UTC, 3 replies.
- Review Request 57787: Factor out common validation in agent's 'run()' code path. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/20 18:15:36 UTC, 2 replies.
- Review Request 57789: Updated the style guide with escape rules for IDs. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/20 18:41:20 UTC, 1 replies.
- Re: Review Request 54954: Improve the warning when failing to find the executor PID. - posted by Anand Mazumdar <an...@apache.org> on 2017/03/20 22:16:53 UTC, 3 replies.
- Review Request 57798: Fixed Java V1 Framework unit test for macOS. - posted by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/03/21 01:19:16 UTC, 9 replies.
- Review Request 57808: Updated the default executor to authenticate with the agent. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/21 14:38:41 UTC, 1 replies.
- Review Request 57807: Updated 'SchedulerTest.TaskGroupRunning'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/21 14:42:20 UTC, 14 replies.
- Review Request 57815: Added `offers_suppressed` field in SUBSCRIBE. - posted by Anindya Sinha <an...@apple.com> on 2017/03/21 17:48:53 UTC, 1 replies.
- Review Request 57816: Add a scheduler flag `offers_suppressed`. - posted by Anindya Sinha <an...@apple.com> on 2017/03/21 17:48:58 UTC, 1 replies.
- Review Request 57817: Suppress offers for frameworks on registration. - posted by Anindya Sinha <an...@apple.com> on 2017/03/21 17:49:03 UTC, 1 replies.
- Review Request 57818: Added unit tests to verify offers are suppressed based on registration. - posted by Anindya Sinha <an...@apple.com> on 2017/03/21 17:49:08 UTC, 2 replies.
- Review Request 57821: Added logic to check for discard in the server socket's loop. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/21 21:40:40 UTC, 0 replies.
- Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2017/03/21 23:44:53 UTC, 5 replies.
- Review Request 57825: Added Eric Chung to contributors.yaml. - posted by Eric Chung <ci...@gmail.com> on 2017/03/22 01:02:51 UTC, 5 replies.
- Re: Review Request 57767: Added quota to /roles endpoint of master. - posted by Jay Guo <gu...@gmail.com> on 2017/03/22 04:46:37 UTC, 3 replies.
- Re: Review Request 57731: Fixed a test in MasterAuthorizationTest. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2017/03/22 05:44:03 UTC, 1 replies.
- Review Request 57828: Modified WebUI to display quota under `roles` tab. - posted by Jay Guo <gu...@gmail.com> on 2017/03/22 06:28:57 UTC, 5 replies.
- Review Request 57836: Fixed UpdateFrameworkMessage handling backwards incompatibility. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/22 11:34:59 UTC, 6 replies.
- Review Request 57838: Fixed a typo in a log message. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/03/22 12:47:24 UTC, 4 replies.
- Review Request 57840: Changed the namespaces of the secret generators. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/22 13:38:47 UTC, 3 replies.
- Re: Review Request 57808: Added support for auth tokens to the default executor. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/22 14:41:20 UTC, 0 replies.
- Re: Review Request 55065: Added support for s390x architecture - posted by Till Toenshoff <to...@me.com> on 2017/03/22 14:45:20 UTC, 13 replies.
- Re: Review Request 57647: Made COMMAND health checks not reuse the check `ContainerID`. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/22 16:24:24 UTC, 5 replies.
- Review Request 57846: Docker environment gets passed by key and invocation environment. - posted by Till Toenshoff <to...@me.com> on 2017/03/22 16:51:20 UTC, 5 replies.
- Review Request 57854: Improved log/failure messages in the (health)checker libraries. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/22 17:58:51 UTC, 11 replies.
- Review Request 57857: Fix post-reviews.py to work on Windows. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/22 18:08:30 UTC, 4 replies.
- Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes. - posted by Neil Conway <ne...@gmail.com> on 2017/03/22 18:36:09 UTC, 3 replies.
- Re: Review Request 57714: Fixed typos in comments. - posted by Neil Conway <ne...@gmail.com> on 2017/03/22 18:36:22 UTC, 2 replies.
- Review Request 57859: Fix 'all be it' typo. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/22 19:10:47 UTC, 2 replies.
- Review Request 57860: Docker environment gets passed by key and invocation environment. - posted by Till Toenshoff <to...@me.com> on 2017/03/22 20:33:47 UTC, 2 replies.
- Re: Review Request 57774: Bailed out in docker executor in a check is specified. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/23 12:19:32 UTC, 1 replies.
- Review request update - posted by James Peach <jo...@gmail.com> on 2017/03/23 14:57:10 UTC, 0 replies.
- Review Request 57877: WIP: Handled env var in a cross-platform way in check tests. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/23 15:33:16 UTC, 5 replies.
- Re: Review Request 57774: Bailed out in docker executor if a check is specified. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/23 16:12:56 UTC, 0 replies.
- Review Request 57879: Turned on executor authentication in the DefaultExecutorTests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/23 16:18:50 UTC, 3 replies.
- Review Request 57880: Added a 'MockSecretGenerator'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/23 16:19:52 UTC, 5 replies.
- Review Request 57882: Added SecretGenerator injection to the MockSlave. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/23 16:21:02 UTC, 7 replies.
- Review Request 57883: Added a new test for executor secret generation. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/23 16:22:27 UTC, 0 replies.
- Review Request 57884: Ensure that host /etc/* files are mounted RDONLY by the CNI Isolator. - posted by Silas Snider <sw...@apple.com> on 2017/03/23 17:11:48 UTC, 2 replies.
- Review Request 57889: Fixed flags logging in Docker executor. - posted by Till Toenshoff <to...@me.com> on 2017/03/23 19:43:22 UTC, 2 replies.
- Review Request 57891: Added a new unmocked method to the mock agent. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/23 20:32:45 UTC, 2 replies.
- Re: Review Request 57883: Added new tests for executor secret generation. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/23 20:35:18 UTC, 10 replies.
- Review Request 57896: Configuration of cli_new in config.toml file. - posted by Armand Grillet <ag...@mesosphere.com> on 2017/03/23 23:05:30 UTC, 3 replies.
- Review Request 57898: Windows: Add deprecation warning for VS 2015. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/23 23:12:51 UTC, 2 replies.
- Re: Review Request 55901: Added support for COMMAND health checks to the default executor. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/23 23:39:32 UTC, 0 replies.
- Re: Review Request 56288: Improved the wording of what's logged on COMMAND health check timeouts. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/23 23:39:45 UTC, 1 replies.
- Re: Review Request 57762: Relocated environment duplication warnings. - posted by Till Toenshoff <to...@me.com> on 2017/03/24 01:53:55 UTC, 0 replies.
- Re: Review Request 57762: Fixed environment duplication in command executor. - posted by Till Toenshoff <to...@me.com> on 2017/03/24 02:24:30 UTC, 4 replies.
- Re: Review Request 57846: Docker environment gets passed on docker run command. - posted by Till Toenshoff <to...@me.com> on 2017/03/24 02:53:47 UTC, 2 replies.
- Re: Review Request 57860: Docker environment gets passed on docker run command. - posted by Till Toenshoff <to...@me.com> on 2017/03/24 05:08:04 UTC, 1 replies.
- Review Request 57911: WIP: Added UNKNOWN DiskInfo.Source type. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/24 15:39:05 UTC, 3 replies.
- Re: Review Request 57839: WIP: Added an example framework demonstrating multirole capabilities. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/24 15:39:55 UTC, 1 replies.
- Review Request 57912: Enabled pause/resume for checks. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/24 15:44:22 UTC, 4 replies.
- Review Request 57923: Changed the agent's SecretGenerator from Owned to pointer. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/24 21:22:08 UTC, 2 replies.
- Review Request 57924: Added 'shutdownExecutor' methods to the mock agent. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/24 21:26:26 UTC, 2 replies.
- Review Request 57925: Added further tests for executor secret generation. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/24 21:29:05 UTC, 7 replies.
- Review Request 57926: Windows: Fix return of bad types in stat.hpp. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/24 21:41:26 UTC, 7 replies.
- Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/24 23:53:04 UTC, 0 replies.
- Review Request 57929: Added a streaming operator overload for Secret::Type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/25 04:30:31 UTC, 2 replies.
- Review Request 57933: Fixed the ordering of the stream operator overload for RLimitInfo. - posted by Greg Mann <gr...@mesosphere.io> on 2017/03/25 19:09:36 UTC, 1 replies.
- Review Request 57935: Added a check to ensure scalar quantities match in `DRFSorter::update`. - posted by Anindya Sinha <an...@apple.com> on 2017/03/26 01:16:15 UTC, 1 replies.
- Review Request 57950: Reordered messages in 'acls.proto'. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/27 09:50:29 UTC, 3 replies.
- Re: Review Request 57896: Renamed 'config.py' to 'settings.py' in the new CLI. - posted by Armand Grillet <ag...@mesosphere.com> on 2017/03/27 11:56:18 UTC, 0 replies.
- Review Request 57951: Moved new CLI settings into a user-defined TOML file. - posted by Armand Grillet <ag...@mesosphere.com> on 2017/03/27 11:57:38 UTC, 3 replies.
- Review Request 57952: Added 'config' plugin to the new CLI. - posted by Armand Grillet <ag...@mesosphere.com> on 2017/03/27 11:58:55 UTC, 4 replies.
- Review Request 57963: Metrics for used resources should incorporate shared resources. - posted by Anindya Sinha <an...@apple.com> on 2017/03/27 18:26:55 UTC, 3 replies.
- Review Request 57964: Added a test to verify metrics when shared resources are present. - posted by Anindya Sinha <an...@apple.com> on 2017/03/27 18:26:59 UTC, 3 replies.
- Re: Review Request 56851: Updated OCI protobuf messages with latest OCI image spec. - posted by Jie Yu <yu...@gmail.com> on 2017/03/27 20:21:05 UTC, 2 replies.
- Re: Review Request 56853: Update OCI tests with the latest OCI image spec. - posted by Jie Yu <yu...@gmail.com> on 2017/03/27 20:27:50 UTC, 2 replies.
- Re: Review Request 56193: Use Docker cpus instead of cpu_share if possible. - posted by Jie Yu <yu...@gmail.com> on 2017/03/27 20:38:37 UTC, 0 replies.
- Re: Review Request 54688: Added a `docker_store_dir` flag to tests. - posted by Jie Yu <yu...@gmail.com> on 2017/03/27 20:52:00 UTC, 0 replies.
- Re: Review Request 56364: Windows: Stout: Rewrite job object wrappers. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:10:59 UTC, 3 replies.
- Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:12:31 UTC, 3 replies.
- Review Request 57971: Added test filtering framework to libprocess-tests. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2017/03/27 22:14:34 UTC, 0 replies.
- Review Request 57972: Added base stout Environment class to mesos-tests Environment class. - posted by John Kordich via Review Board <no...@reviews.apache.org> on 2017/03/27 22:15:05 UTC, 1 replies.
- Review Request 57973: Windows: Add `JobObjectManager` actor. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:37:26 UTC, 3 replies.
- Review Request 57974: Windows: Replace WindowsLauncher with SubprocessLauncher. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:38:20 UTC, 0 replies.
- Review Request 57975: Windows: Use Subprocess in default executor. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:39:04 UTC, 3 replies.
- Review Request 57976: Refactor default executor for `launchTaskSubprocess`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:39:57 UTC, 3 replies.
- Re: Review Request 56366: Windows: Refactor executor to use `SharedHandle` semantics. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:43:47 UTC, 0 replies.
- Re: Review Request 56362: Windows: Create the Windows container launcher. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:44:29 UTC, 0 replies.
- Re: Review Request 56365: Windows: Refactor `WindowsLauncher` to use Job Objects. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/27 22:45:13 UTC, 0 replies.
- Review Request 57984: Fixed indents. - posted by Klaus Ma <kl...@gmail.com> on 2017/03/28 07:09:03 UTC, 2 replies.
- Review Request 57989: Removing deprecated ACL `ShutdownFramework`. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/03/28 09:35:16 UTC, 1 replies.
- Review Request 57994: Fixed a regression hiding previously exposed master and agent flags. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/28 14:01:11 UTC, 2 replies.
- Re: Review Request 57911: Added UNKNOWN DiskInfo.Source type. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/28 18:06:21 UTC, 3 replies.
- Review Request 58011: CMake: Add Cotire module (version 1.7.9). - posted by Jeff Coffler <je...@taltos.com> on 2017/03/29 00:54:42 UTC, 3 replies.
- Review Request 58012: Fix code issues to facilitate use of precompiled headers on Windows. - posted by Jeff Coffler <je...@taltos.com> on 2017/03/29 00:54:53 UTC, 2 replies.
- Review Request 58013: WIN32: Add compile/link flags to improve incremental link times. - posted by Jeff Coffler <je...@taltos.com> on 2017/03/29 00:55:35 UTC, 3 replies.
- Review Request 58014: CMake: Setup cotire for 'mesos-agent' target. - posted by Jeff Coffler <je...@taltos.com> on 2017/03/29 00:56:29 UTC, 8 replies.
- Review Request 58015: Add name to contributors.yaml file for first contribution. - posted by Jeff Coffler <je...@taltos.com> on 2017/03/29 01:00:13 UTC, 2 replies.
- Re: Review Request 52379: Added agent flag '--oci_store_dir'. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/29 07:15:41 UTC, 1 replies.
- Review Request 58030: Added support for COMMAND checks to the default executor. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/29 16:39:10 UTC, 2 replies.
- Review Request 58037: Removed redundant call to `std::string::c_str()` in stout. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:41:01 UTC, 2 replies.
- Review Request 58038: Removed redundant call to `std::string::c_str()` in Mesos. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:41:38 UTC, 3 replies.
- Review Request 58039: Avoid redundant copies when using `std::get` on a tuple. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:42:00 UTC, 3 replies.
- Review Request 58040: Avoid various redundant copies. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:42:31 UTC, 3 replies.
- Review Request 58041: Don't mark a value parameter `const`. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:43:06 UTC, 3 replies.
- Review Request 58042: Remove unused include in libprocess. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:43:29 UTC, 1 replies.
- Review Request 58043: Cleanup usage of namespace-qualified identifiers. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:43:40 UTC, 2 replies.
- Review Request 58044: Removed unused "using" statements. - posted by Neil Conway <ne...@gmail.com> on 2017/03/29 19:44:00 UTC, 3 replies.
- Review Request 58055: Documentation updates to reflect multi-role framework support. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/30 01:13:49 UTC, 4 replies.
- Re: Review Request 55331: Added 'OCI' message into 'Image' message. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:16:52 UTC, 1 replies.
- Review Request 58060: Added a check to default clang-tidy check list. - posted by Neil Conway <ne...@gmail.com> on 2017/03/30 01:17:47 UTC, 2 replies.
- Review Request 58056: Temp: Added rapid-fire socket test for reinitialization testing. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/30 01:20:06 UTC, 0 replies.
- Review Request 58057: Changed SSL Socket destruction into a synchronous operation. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/30 01:20:08 UTC, 1 replies.
- Review Request 58058: Moved libprocess initialization of worker threads later. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/30 01:20:09 UTC, 0 replies.
- Review Request 58059: Changed libprocess SocketManager to refer to HttpProxy by PID. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/03/30 01:20:10 UTC, 1 replies.
- Review Request 58061: Added MULTI_ROLE support to the upgrades documentation. - posted by Benjamin Mahler <bm...@apache.org> on 2017/03/30 01:38:04 UTC, 3 replies.
- Re: Review Request 54638: Added agent flag '--oci_default_locator'. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:41:00 UTC, 0 replies.
- Re: Review Request 52382: Added stubs for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:42:32 UTC, 0 replies.
- Review Request 58062: Added puller interface for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:44:28 UTC, 1 replies.
- Review Request 58063: Added stubs for prefix puller. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:45:54 UTC, 1 replies.
- Review Request 58064: Implemented the 'create()' method of puller interface. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:54:26 UTC, 0 replies.
- Re: Review Request 54639: Implemented the 'create()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:56:12 UTC, 0 replies.
- Re: Review Request 55332: Added 'message.proto' for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 01:59:31 UTC, 0 replies.
- Re: Review Request 56147: Implemented metadata manager for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:01:16 UTC, 0 replies.
- Re: Review Request 55333: Implemented the 'get()' and '__get()' methods of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:02:47 UTC, 0 replies.
- Re: Review Request 56148: Implemented the '_get()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:03:52 UTC, 0 replies.
- Re: Review Request 56149: Implemented the 'pull()' method of prefix puller. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:04:59 UTC, 0 replies.
- Re: Review Request 56150: Implemented the 'fetchIndex()' method of prefix puller. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:05:39 UTC, 0 replies.
- Re: Review Request 56152: Implemented the 'fetchManifest()' method of prefix puller. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:06:49 UTC, 0 replies.
- Re: Review Request 56153: Implemented the 'fetchConfig()' method of prefix puller. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:07:25 UTC, 0 replies.
- Re: Review Request 56154: Implemented the 'fetchLayers()' method of prefix puller. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:07:53 UTC, 0 replies.
- Re: Review Request 56155: Implemented the 'moveImage()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/03/30 02:08:30 UTC, 0 replies.
- Review Request 58065: Added initial code for the python mesoshttp package. - posted by Eric Chung <ci...@gmail.com> on 2017/03/30 02:50:07 UTC, 1 replies.
- Review Request 58084: Adjust `using` style in a few places. - posted by Neil Conway <ne...@gmail.com> on 2017/03/30 16:49:18 UTC, 1 replies.
- Review Request 58095: Refactored functions that render /roles and GetRoles endpoints. - posted by Jay Guo <gu...@gmail.com> on 2017/03/31 04:52:54 UTC, 0 replies.
- Review Request 58097: Added a test to check framework filtering in /roles endpoint. - posted by Jay Guo <gu...@gmail.com> on 2017/03/31 04:53:50 UTC, 0 replies.
- Review Request 58096: Added authorization for frameworks in /roles endpoint. - posted by Jay Guo <gu...@gmail.com> on 2017/03/31 04:53:51 UTC, 0 replies.
- Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API. - posted by Jay Guo <gu...@gmail.com> on 2017/03/31 05:52:52 UTC, 1 replies.
- Re: Review Request 58048: Added id to Resource.DiskInfo. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/31 09:38:08 UTC, 0 replies.
- Re: Review Request 57998: Added ResourceProviderID to Resource protos. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/31 09:38:11 UTC, 0 replies.
- Re: Review Request 57999: Made Path and Mount root optional in Resource.DiskInfo.Source. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/31 09:38:11 UTC, 0 replies.
- Re: Review Request 58047: Introduce BLOCK and RAW disk types. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/03/31 09:38:12 UTC, 0 replies.
- Review Request 58101: Augmented release guide with GPG goodies and a formatting reminder. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/31 09:42:18 UTC, 4 replies.
- Review Request 58103: Replaced
tags with formatting in release guide for consistency.
- posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/31 10:51:35 UTC, 1 replies.
- Review Request 58108: Used operator<< for `CheckStatusInfo` instead of manual printing. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/03/31 15:48:41 UTC, 1 replies.
- Review Request 58110: Removed separation `allocations` map in DRFSorter. - posted by Neil Conway <ne...@gmail.com> on 2017/03/31 16:37:56 UTC, 0 replies.
- Review Request 58112: Cleaned up coding of `DRFComparator::operator()`. - posted by Neil Conway <ne...@gmail.com> on 2017/03/31 16:39:47 UTC, 1 replies.
- Re: Review Request 57254: Added support for hierarchical roles to DRFSorter. - posted by Neil Conway <ne...@gmail.com> on 2017/03/31 16:40:53 UTC, 2 replies.
- Review Request 58117: Update the container image doc about the support of capabilities. - posted by Jie Yu <yu...@gmail.com> on 2017/03/31 19:10:42 UTC, 1 replies.
- Review Request 58118: Updated the container image doc about Docker networking support. - posted by Jie Yu <yu...@gmail.com> on 2017/03/31 19:11:02 UTC, 2 replies.
- Re: Review Request 58110: Removed `allocations` map from DRFSorter. - posted by Neil Conway <ne...@gmail.com> on 2017/03/31 20:01:55 UTC, 4 replies.
- Re: Review Request 55065: Updated ldcache flags to 32bit width. - posted by Ayanampudi Varsha <av...@us.ibm.com> on 2017/03/31 20:26:05 UTC, 1 replies.
- Re: Review Request 56364: Windows: Stout: Rewrote job object wrappers. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:33:45 UTC, 0 replies.
- Re: Review Request 56367: Windows: Stout: Shimmed `os::killtree` to terminate job objects. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:34:49 UTC, 0 replies.
- Re: Review Request 57973: Windows: Added `JobObjectManager` actor. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:36:14 UTC, 0 replies.
- Re: Review Request 57976: Refactored default executor for `launchTaskSubprocess`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:43:59 UTC, 0 replies.
- Review Request 58125: Stout: Added stringify for std::wstring. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:45:33 UTC, 1 replies.
- Review Request 58126: Windows: Stout: Reimplemented `stringify_args`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:49:40 UTC, 1 replies.
- Review Request 58127: Windows: Rewrote subprocess helpers. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:52:25 UTC, 0 replies.
- Review Request 58128: Windows: Updated use of UTF-16 `getSystemEnvironment`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/03/31 23:59:31 UTC, 0 replies.