reviews@mesos.apache.org, 2016-12

You are viewing a plain text version of this content. The canonical link for it is here.

- Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 00:14:10 UTC, 4 replies.
- Re: Review Request 54219: Added validation for the attach container input call on the agent. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 00:14:47 UTC, 0 replies.
- Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord. - posted by Jie Yu <yu...@gmail.com> on 2016/12/01 00:23:44 UTC, 1 replies.
- Re: Review Request 54229: Enabled the IO switchboard server by default for tests. - posted by Jie Yu <yu...@gmail.com> on 2016/12/01 00:24:03 UTC, 2 replies.
- Re: Review Request 53688: Implement a namespace/ipc isolator. - posted by James Peach <jp...@apache.org> on 2016/12/01 00:24:46 UTC, 7 replies.
- Re: Review Request 53689: Use a common fixture for the PID namespace test. - posted by James Peach <jp...@apache.org> on 2016/12/01 00:25:02 UTC, 5 replies.
- Re: Review Request 53690: Add namespaces/ipc documentation. - posted by James Peach <jp...@apache.org> on 2016/12/01 00:25:42 UTC, 4 replies.
- Re: Review Request 54193: Refactored `Slave::Http::launcNestedContainer()`. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/01 00:29:29 UTC, 0 replies.
- Re: Review Request 54147: Added a server side component for the IOSwitchboard. - posted by Jie Yu <yu...@gmail.com> on 2016/12/01 00:36:30 UTC, 2 replies.
- Re: Review Request 54220: Made the agent's `api/v1` handler handle request streaming. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 00:52:25 UTC, 2 replies.
- Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/01 00:54:37 UTC, 0 replies.
- Re: Review Request 53939: Added implementation for containerizer 'attach()' call. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/01 00:55:24 UTC, 2 replies.
- Re: Review Request 54197: Introduced Resource.AllocationInfo. - posted by Guangya Liu <gy...@gmail.com> on 2016/12/01 01:10:29 UTC, 2 replies.
- Re: Review Request 54198: Added Resource.Allocation in Offer. - posted by Guangya Liu <gy...@gmail.com> on 2016/12/01 01:18:11 UTC, 3 replies.
- Re: Review Request 54199: Minor style fix. - posted by Guangya Liu <gy...@gmail.com> on 2016/12/01 01:33:00 UTC, 1 replies.
- Review Request 54238: Added `getContainerIOSwitchboardAddress` helper to containerizer paths. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/01 01:45:22 UTC, 2 replies.
- Re: Review Request 54115: Added an http::serve abstraction. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/01 01:48:31 UTC, 3 replies.
- Re: Review Request 54167: Removed cyclic header dependency in libprocess. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/01 02:26:05 UTC, 0 replies.
- Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration. - posted by Mesos ReviewBot <re...@mesos.apache.org> on 2016/12/01 02:35:36 UTC, 2 replies.
- Review Request 54069: Changed master to validate roles instead of just role. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/01 02:41:46 UTC, 0 replies.
- Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 03:22:13 UTC, 8 replies.
- Review Request 54241: Updated IOSwitchboard to block IO until connected for DEBUG containers. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/01 04:12:16 UTC, 3 replies.
- Review Request 54242: Added a test for the `ATTACH_CONTAINER_INPUT` call on the Agent API. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/01 04:44:15 UTC, 1 replies.
- Review Request 54243: Fixed the attach output container test to use the mock containerizer. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/01 04:44:41 UTC, 1 replies.
- Review Request 54245: Updated signatures of v1 agent API handlers. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 06:44:32 UTC, 2 replies.
- Re: Review Request 54193: Refactored `Slave::Http::launchNestedContainer()`. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 06:45:23 UTC, 1 replies.
- Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/01 06:46:24 UTC, 8 replies.
- Re: Review Request 53853: Expanded the comment around `ContainerInfo` protobuf. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/01 16:50:41 UTC, 4 replies.
- Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes. - posted by Jiang Yan Xu <ya...@jxu.me> on 2016/12/01 17:38:45 UTC, 14 replies.
- Re: Review Request 52295: Added additional unit tests for shared resources. - posted by Jiang Yan Xu <ya...@jxu.me> on 2016/12/01 19:00:09 UTC, 0 replies.
- Re: Review Request 54194: Added `devolve` helper for `ContainerID`. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/01 19:49:19 UTC, 0 replies.
- Re: Review Request 53287: Overrided the default navbar color to match project website. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/01 20:04:28 UTC, 0 replies.
- Re: Review Request 53288: Show Mesos logo in the navbar brand. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/01 20:04:36 UTC, 0 replies.
- Review Request 54262: Added macOS 10.12 instructions to the getting started page. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/01 20:49:35 UTC, 5 replies.
- Re: Review Request 46228: Create persistent volume with a supplied user. - posted by Greg Mann <gr...@mesosphere.io> on 2016/12/01 21:33:43 UTC, 2 replies.
- Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks. - posted by Neil Conway <ne...@gmail.com> on 2016/12/01 22:16:25 UTC, 7 replies.
- Re: Review Request 54179: Updated master to use BoundedHashMap. - posted by Neil Conway <ne...@gmail.com> on 2016/12/01 22:34:43 UTC, 3 replies.
- Re: Review Request 54062: Added logic to validate FrameworkInfo roles. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/01 22:36:33 UTC, 3 replies.
- Re: Review Request 53096: Fix handling in shared count in total resources in the sorter. - posted by Anindya Sinha <an...@apple.com> on 2016/12/01 22:37:30 UTC, 7 replies.
- Re: Review Request 49571: Added a benchmark test for allocations. - posted by Anindya Sinha <an...@apple.com> on 2016/12/01 22:38:19 UTC, 6 replies.
- Review Request 54271: Disambiguate return type of lambda passed to `Future::then`. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/01 23:46:13 UTC, 0 replies.
- Re: Review Request 54271: Disambiguated return type of lambda passed to `Future::then`. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/01 23:48:41 UTC, 2 replies.
- Review Request 54274: Made `http::serv()` use the streaming request decoder. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/02 00:11:12 UTC, 3 replies.
- Review Request 54275: Fixed inaccurate documentation of `--hostname` for master and agent. - posted by Michael Park <mp...@apache.org> on 2016/12/02 00:12:30 UTC, 3 replies.
- Re: Review Request 54183: Improved management of unreachable and completed tasks in master. - posted by Neil Conway <ne...@gmail.com> on 2016/12/02 00:24:53 UTC, 3 replies.
- Review Request 54278: Made `configure.ac` default to use brew apr on OS X in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/02 00:58:36 UTC, 2 replies.
- Review Request 54279: Made `configure.ac` default to use brew apr on OS X in libprocess. - posted by Michael Park <mp...@apache.org> on 2016/12/02 01:00:31 UTC, 1 replies.
- Review Request 54280: Made `configure.ac` default to use to brew apr on OS X in mesos. - posted by Michael Park <mp...@apache.org> on 2016/12/02 01:00:33 UTC, 2 replies.
- Re: Review Request 46229: Add unit tests for adding a user for persistent volumes. - posted by Greg Mann <gr...@mesosphere.io> on 2016/12/02 01:08:52 UTC, 1 replies.
- Re: Review Request 53479: Perform GC asynchronously. - posted by Jacob Janco <jj...@gmail.com> on 2016/12/02 02:58:02 UTC, 1 replies.
- Re: Review Request 53479: Perform agent GC asynchronously. - posted by Jacob Janco <jj...@gmail.com> on 2016/12/02 02:58:15 UTC, 2 replies.
- Re: Review Request 54088: Removed unused header include from stout's hashmap. - posted by Michael Park <mp...@apache.org> on 2016/12/02 03:43:05 UTC, 0 replies.
- Review Request 54289: Added a check to require I/O switchboard server for TTY support. - posted by Jie Yu <yu...@gmail.com> on 2016/12/02 06:42:41 UTC, 4 replies.
- Review Request 54290: Added a ErrnoFailure similar to ErrnoError. - posted by Jie Yu <yu...@gmail.com> on 2016/12/02 06:42:45 UTC, 4 replies.
- Review Request 54291: Added os::ptsname to stout. - posted by Jie Yu <yu...@gmail.com> on 2016/12/02 06:42:48 UTC, 9 replies.
- Review Request 54292: Added os::setctty to stout. - posted by Jie Yu <yu...@gmail.com> on 2016/12/02 06:42:52 UTC, 5 replies.
- Review Request 54293: Supported TTY in I/O switchboard. - posted by Jie Yu <yu...@gmail.com> on 2016/12/02 06:42:57 UTC, 7 replies.
- Review Request 54294: Added an I/O switchboard test with TTY enabled. - posted by Jie Yu <yu...@gmail.com> on 2016/12/02 06:43:00 UTC, 6 replies.
- Review Request 54295: Added a synchronous version of loop for io::read/write/redirect. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/02 06:45:44 UTC, 5 replies.
- Review Request 54296: Updated the IOSwitchboard http handler to work with streaming requests. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/02 06:48:17 UTC, 1 replies.
- Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/02 06:54:56 UTC, 19 replies.
- Re: Review Request 54062: Introduced validateRoles method for FrameworkInfo. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/02 08:44:31 UTC, 7 replies.
- Review Request 54301: Introduced 'roles' validation in master. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/02 08:49:28 UTC, 3 replies.
- Review Request 54302: Added three tests to ensure master validates roles. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/02 08:51:45 UTC, 3 replies.
- Review Request 54300: Added a test for validateRoles method. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/02 08:51:57 UTC, 6 replies.
- Review Request 54304: Added explicit break statements in switch. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/02 10:48:29 UTC, 3 replies.
- Review Request 54309: Fixed ownership semantics of `DynamicLibrary`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/02 15:45:20 UTC, 2 replies.
- Review Request 54310: Added missing break statements. - posted by Neil Conway <ne...@gmail.com> on 2016/12/02 16:50:17 UTC, 2 replies.
- Review Request 54311: Fixes for whitespace, style. - posted by Neil Conway <ne...@gmail.com> on 2016/12/02 16:51:04 UTC, 1 replies.
- Review Request 54312: Added TASK_UNREACHABLE to master's state-summary endpoint. - posted by Neil Conway <ne...@gmail.com> on 2016/12/02 17:02:46 UTC, 0 replies.
- Re: Review Request 53897: Changed how master represents "recovered" frameworks. - posted by Neil Conway <ne...@gmail.com> on 2016/12/02 17:18:46 UTC, 11 replies.
- Re: Review Request 53310: Updated no-longer-accurate comment. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 18:30:38 UTC, 0 replies.
- Re: Review Request 53885: Removed stuttering from teardown test names. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 18:32:27 UTC, 0 replies.
- Re: Review Request 53886: Improved TeardownTest.Success. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 18:38:02 UTC, 1 replies.
- Re: Review Request 53887: Improved FaultToleranceTest.FrameworkReregister. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 18:43:54 UTC, 1 replies.
- Re: Review Request 53888: Improved SlaveRecoveryTest.ReconcileShutdownFramework. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 18:53:20 UTC, 1 replies.
- Re: Review Request 53889: Improved comments in the master. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 20:45:10 UTC, 0 replies.
- Re: Review Request 53890: Tweaked usage of `getFramework`. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 20:49:47 UTC, 0 replies.
- Re: Review Request 53891: Replaced "slave" with "agent" in status update messages. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 21:20:26 UTC, 0 replies.
- Re: Review Request 53892: Fixed typo, removed hard tab character. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 21:20:45 UTC, 0 replies.
- Re: Review Request 53893: Avoided sending `LostSlaveMessage` to disconnected frameworks. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 21:22:27 UTC, 0 replies.
- Re: Review Request 53894: Added helper function, `Master::isCompletedFramework`. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 21:26:39 UTC, 0 replies.
- Re: Review Request 54036: Fixed WebUI error on Firefox 45. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/02 21:57:59 UTC, 0 replies.
- Re: Review Request 52778: Added Windows support to Agent test environment harness. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/02 22:09:03 UTC, 1 replies.
- Re: Review Request 54324: Fixed switchboard build break on Windows. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/02 22:15:31 UTC, 1 replies.
- Re: Review Request 53896: Refactored representation of framework connectedness. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/02 22:54:34 UTC, 4 replies.
- Review Request 54328: Fixed HttpServeTests to connect to a non-ANY address. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/02 23:44:07 UTC, 3 replies.
- Re: Review Request 52210: Fixed warnings in `getcwd.hpp`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/03 00:01:40 UTC, 0 replies.
- Re: Review Request 53552: Remove unnecessary use of `typename` causing Windows build break. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/03 00:06:29 UTC, 1 replies.
- Re: Review Request 53551: Fix namespace resolution issue for Windows builds. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/03 00:06:32 UTC, 0 replies.
- Re: Review Request 53550: Rename symbols in log.proto to avoid naming collision in win32 API. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/03 00:06:36 UTC, 3 replies.
- Re: Review Request 53882: Fix configure on FreeBSD. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:22:00 UTC, 0 replies.
- Re: Review Request 53912: Fix xattr for FreeBSD. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:28:04 UTC, 0 replies.
- Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:29:55 UTC, 0 replies.
- Re: Review Request 53925: Fix wait macros on FreeBSD. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:30:26 UTC, 0 replies.
- Re: Review Request 53926: Move isJailed for FreeBSD into utils. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:31:21 UTC, 0 replies.
- Re: Review Request 53927: Check isJailed in tests that call mknod. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:32:15 UTC, 0 replies.
- Re: Review Request 53931: Don't expect an init process in a FreeBSD jail. - posted by Ian Downes <ia...@gmail.com> on 2016/12/03 00:32:50 UTC, 0 replies.
- Re: Review Request 52349: Add protobuf messages for OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2016/12/03 01:50:59 UTC, 7 replies.
- Re: Review Request 52379: Added agent flag '--oci_store_dir'. - posted by Qian Zhang <zh...@gmail.com> on 2016/12/03 01:51:19 UTC, 3 replies.
- Re: Review Request 52382: Added stubs for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2016/12/03 01:51:48 UTC, 2 replies.
- Review Request 54333: Fixed error messages to say "form body" rather than "query parameter". - posted by Michael Park <mp...@apache.org> on 2016/12/03 02:14:50 UTC, 2 replies.
- Review Request 54337: Fixed the attach input call validation on the agent. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/03 06:01:50 UTC, 4 replies.
- Review Request 54340: Fixed an attach container input test impacted by stricter validation. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/03 18:04:41 UTC, 2 replies.
- Review Request 54342: Made the `deserializer()` not validate the Agent API calls too. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/03 19:19:12 UTC, 0 replies.
- Re: Review Request 54342: Fixed the Agent API to return `BadRequest` for deserialization errors. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/03 19:48:28 UTC, 1 replies.
- Review Request 54343: Pulled the validation code from `deserializer()`. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/03 19:49:53 UTC, 1 replies.
- Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/03 19:57:47 UTC, 7 replies.
- Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/04 00:31:43 UTC, 3 replies.
- Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/04 07:35:18 UTC, 2 replies.
- Re: Review Request 54013: Added user doc for nested container and task group. - posted by haosdent huang <ha...@gmail.com> on 2016/12/04 17:11:01 UTC, 10 replies.
- Review Request 54349: Added os::dup2 to stout. - posted by Jie Yu <yu...@gmail.com> on 2016/12/04 21:17:30 UTC, 4 replies.
- Review Request 54350: Added a DUP2 child hook to Subprocess. - posted by Jie Yu <yu...@gmail.com> on 2016/12/04 21:18:01 UTC, 3 replies.
- Review Request 54351: Allowed subprocess to take duplicated FDs. - posted by Jie Yu <yu...@gmail.com> on 2016/12/04 21:20:50 UTC, 6 replies.
- Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 00:38:15 UTC, 7 replies.
- Review Request 54353: Added short circuit for `local` mode in `IOSwitchboard::connect()'. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 00:38:16 UTC, 2 replies.
- Review Request 54354: Added path helpers for checkpointing the io switchboard pid. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 00:38:18 UTC, 2 replies.
- Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 00:38:20 UTC, 13 replies.
- Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 00:38:23 UTC, 9 replies.
- Review Request 54358: Introduced ControlFlow for process::loop. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/05 04:36:12 UTC, 4 replies.
- Review Request 54361: Added a test to ensure roles from multi-role framework are added. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 04:55:59 UTC, 10 replies.
- Review Request 54360: Changed master to add roles for a multi-role framework. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 04:57:47 UTC, 3 replies.
- Review Request 54359: Removed redundant empty statements. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 04:58:10 UTC, 1 replies.
- Review Request 54362: Changed master to remove roles for a multi-role framework. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 07:53:34 UTC, 5 replies.
- Review Request 54363: Added a test to ensure multi-role framework being removed properly. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 07:54:31 UTC, 2 replies.
- Review Request 54365: Fixed indentation of a function argument in master.cpp. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 08:47:54 UTC, 8 replies.
- Re: Review Request 53982: Added documentation for posix/rlimit isolator. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/05 09:37:59 UTC, 7 replies.
- Review Request 54368: Added helpers to checkpoint a 'destroy-on-recovery' file for containers. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 09:40:33 UTC, 2 replies.
- Review Request 54367: Added support to destroy running DEBUG containers on agent recovery. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 09:40:38 UTC, 4 replies.
- Review Request 54380: Don't send PIDs of disconnected frameworks to re-registering agents. - posted by Neil Conway <ne...@gmail.com> on 2016/12/05 16:08:59 UTC, 2 replies.
- Re: Review Request 54177: Slightly simplified two test cases. - posted by Neil Conway <ne...@gmail.com> on 2016/12/05 16:12:27 UTC, 1 replies.
- Review Request 54381: Adds authorization support when attaching containers input/output. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/05 16:19:08 UTC, 13 replies.
- Re: Review Request 54014: Fixed missing protobuf java package definition. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/05 16:48:45 UTC, 0 replies.
- Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/05 16:49:09 UTC, 0 replies.
- Re: Review Request 54311: Fixed whitespace, code style in Network::Address. - posted by Neil Conway <ne...@gmail.com> on 2016/12/05 17:23:41 UTC, 1 replies.
- Review Request 54335: Add os::var() to stout. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/05 17:38:13 UTC, 8 replies.
- Review Request 54336: Windows: Fix `Flags::runtime_dir` value. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/05 17:38:30 UTC, 17 replies.
- Re: Review Request 54134: Removed test assumptions about arrival order of status updates. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/05 18:21:10 UTC, 1 replies.
- Re: Review Request 54133: Fixed includes in default_executor_tests.cpp. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/05 18:21:48 UTC, 0 replies.
- Re: Review Request 54015: Added V1 API protos to python bindings. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/05 19:17:24 UTC, 0 replies.
- Review Request 54387: Removed an inaccurate comment. - posted by Neil Conway <ne...@gmail.com> on 2016/12/05 20:05:29 UTC, 1 replies.
- Re: Review Request 53688: Implement a namespaces/ipc isolator. - posted by James Peach <jp...@apache.org> on 2016/12/05 20:44:25 UTC, 0 replies.
- Review Request 54389: Fixed typo. - posted by Neil Conway <ne...@gmail.com> on 2016/12/05 21:23:04 UTC, 2 replies.
- Review Request 54395: Enabled build of Agent test harness on Windows. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/05 22:05:55 UTC, 5 replies.
- Review Request 54391: Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/05 22:16:49 UTC, 3 replies.
- Re: Review Request 54077: Made sure parser settings member is properly initialized. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/05 22:18:11 UTC, 0 replies.
- Review Request 54401: Reorganized location of checkpointed files for the 'IOSwitchboard'. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/06 00:17:21 UTC, 1 replies.
- Review Request 54407: Refactored Master::removeFramework to use Master::deactivate. - posted by Neil Conway <ne...@gmail.com> on 2016/12/06 02:00:48 UTC, 0 replies.
- Review Request 54408: Replace Master::Framework::active with a new `state` enum value. - posted by Neil Conway <ne...@gmail.com> on 2016/12/06 02:01:11 UTC, 1 replies.
- Re: Review Request 54359: Removed redundant semicolons. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/06 03:05:33 UTC, 0 replies.
- Review Request 54411: Fixed the colspan number of task tables in WebUI. - posted by haosdent huang <ha...@gmail.com> on 2016/12/06 08:54:02 UTC, 4 replies.
- Review Request 54410: Made the style of `.navbar-text` consistent with others. - posted by haosdent huang <ha...@gmail.com> on 2016/12/06 08:54:02 UTC, 5 replies.
- Review Request 54414: Cleaned up rlimits documentation. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/06 10:41:51 UTC, 4 replies.
- Review Request 54415: Stout: Fixed two bugs in `mkdtemp` that block agent tests. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/06 11:29:59 UTC, 2 replies.
- Review Request 54422: Removed test assumptions about arrival order of status updates. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/06 14:09:08 UTC, 2 replies.
- Review Request 54426: Avoided building glog tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/06 15:27:10 UTC, 6 replies.
- Review Request 54432: Added os::unsetCloexec to stout. - posted by Jie Yu <yu...@gmail.com> on 2016/12/06 18:43:43 UTC, 1 replies.
- Review Request 54433: Added a UNSET_CLOEXEC child hook to subprocess. - posted by Jie Yu <yu...@gmail.com> on 2016/12/06 18:44:00 UTC, 1 replies.
- Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard. - posted by Jie Yu <yu...@gmail.com> on 2016/12/06 18:44:40 UTC, 3 replies.
- Re: Review Request 53803: Added a new libprocess HTTP test. - posted by Greg Mann <gr...@mesosphere.io> on 2016/12/06 19:28:27 UTC, 2 replies.
- Review Request 54441: Added function to unblock IOSwitchboard when waiting for connection. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/06 19:46:04 UTC, 3 replies.
- Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/06 19:46:06 UTC, 6 replies.
- Review Request 54446: Windows: Added `authentication_tests.cpp` build. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/06 20:51:30 UTC, 1 replies.
- Review Request 54449: Check quotas are enabled in the XFS disk isolator. - posted by James Peach <jp...@apache.org> on 2016/12/06 21:21:09 UTC, 12 replies.
- Review Request 54453: Transitioned to `in_memory` log as default in tests involving Master. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/06 22:34:19 UTC, 6 replies.
- Re: Review Request 54081: Added `--pidfile` option to master and agent binaries. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/06 22:42:09 UTC, 5 replies.
- Review Request 54455: Added test for IOSwitchboard `recovery()`. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/06 23:03:47 UTC, 1 replies.
- Review Request 54462: Windows: Added APR include path to libprocess configuration. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/07 02:27:06 UTC, 4 replies.
- Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/07 02:44:04 UTC, 4 replies.
- Re: Review Request 54360: Changed master to add/remove roles for a multi-role framework. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/07 03:58:45 UTC, 1 replies.
- Re: Review Request 54361: Added tests for add/remove multi-role framework. - posted by Jay Guo <gu...@cn.ibm.com> on 2016/12/07 03:59:20 UTC, 6 replies.
- Re: Review Request 54177: Simplified some test code. - posted by Neil Conway <ne...@gmail.com> on 2016/12/07 04:07:38 UTC, 1 replies.
- Review Request 54467: Fixed incorrect warning messages. - posted by Neil Conway <ne...@gmail.com> on 2016/12/07 04:19:55 UTC, 1 replies.
- Review Request 54468: Added some additional CHECKs to the master. - posted by Neil Conway <ne...@gmail.com> on 2016/12/07 04:19:57 UTC, 1 replies.
- Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value. - posted by Neil Conway <ne...@gmail.com> on 2016/12/07 04:20:25 UTC, 3 replies.
- Review Request 54470: Windows: Fixed default isolators in Agent. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/07 05:09:16 UTC, 4 replies.
- Review Request 54472: Waited for the domain socket file in IOSwitchboard::connect. - posted by Jie Yu <yu...@gmail.com> on 2016/12/07 05:21:15 UTC, 2 replies.
- Re: Review Request 54410: Made the style of the cluster name consistent with others. - posted by haosdent huang <ha...@gmail.com> on 2016/12/07 08:27:42 UTC, 4 replies.
- Re: Review Request 54200: Added a helper function to get roles from FrameworkInfo. - posted by Jay Guo <gu...@gmail.com> on 2016/12/07 08:59:40 UTC, 2 replies.
- Review Request 54483: Fixed GMock warning. - posted by Neil Conway <ne...@gmail.com> on 2016/12/07 15:55:08 UTC, 2 replies.
- Review Request 54485: Suppress offers in mesos-execute. - posted by James Peach <jp...@apache.org> on 2016/12/07 16:46:03 UTC, 2 replies.
- Review Request 54486: Added default values for all required IOSwitchboardServerFlags. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/07 17:06:18 UTC, 7 replies.
- Review Request 54487: Used agent environment variables for I/O switchboard. - posted by Jie Yu <yu...@gmail.com> on 2016/12/07 18:12:33 UTC, 5 replies.
- Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/07 18:49:57 UTC, 11 replies.
- Review Request 54490: Move POSIX-specific temporary directory selection out of Agent tests. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/07 19:06:00 UTC, 1 replies.
- Review Request 54281: Added new test for LAUNCH_NESTED_CONTAINER_SESSION. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/07 19:19:53 UTC, 8 replies.
- Review Request 54493: Turned off Master's auth flags tests when platform doesn't support it. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/07 20:02:55 UTC, 8 replies.
- Review Request 54495: Ensured master always relinks during scheduler re-registration. - posted by Neil Conway <ne...@gmail.com> on 2016/12/07 20:04:13 UTC, 3 replies.
- Review Request 54497: Added a test for the 'ATTACH_CONTAINER_INPUT' call. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/07 20:15:48 UTC, 5 replies.
- Review Request 54496: Made the IO Switchboard wait for the reader to signal before exiting. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/07 20:15:52 UTC, 3 replies.
- Review Request 54494: Fixed container-logger subprocess environment setup. - posted by Till Toenshoff <to...@me.com> on 2016/12/07 20:23:53 UTC, 6 replies.
- Re: Review Request 53708: Remove warnings from `duration.hpp`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/07 22:17:04 UTC, 0 replies.
- Review Request 54502: Made the default 'Accept-Type' be JSON on the Agent API. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/07 22:25:29 UTC, 1 replies.
- Review Request 54506: Added logging for I/O switchboard. - posted by Jie Yu <yu...@gmail.com> on 2016/12/07 23:35:10 UTC, 1 replies.
- Review Request 54508: Added a TTY test for LAUNCH_NESTED_CONTAINER_SESSION. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/07 23:51:33 UTC, 4 replies.
- Review Request 54504: Added Mesos logo to the list of files installed for the web UI. - posted by Greg Mann <gr...@mesosphere.io> on 2016/12/07 23:53:00 UTC, 2 replies.
- Re: Review Request 53709: Remuved warnings from gzip.hpp. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/07 23:58:44 UTC, 0 replies.
- Re: Review Request 54335: Add os::var() to Stout. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/08 00:21:14 UTC, 1 replies.
- Re: Review Request 53710: Removed warnings from `dirent.hpp`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/08 00:30:35 UTC, 0 replies.
- Re: Review Request 54335: Add `os::var()` to Stout. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/08 00:39:59 UTC, 13 replies.
- Review Request 54514: Add `os::runtime_dir()` to Stout. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/08 00:40:52 UTC, 5 replies.
- Review Request 54515: Replace `/var/run/mesos` with `os::runtime_dir()` in `Flags`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/08 00:41:08 UTC, 6 replies.
- Review Request 54516: Removed the TODO in AgentAPITest.AttachContainerOutputFailure test. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/08 01:24:37 UTC, 3 replies.
- Review Request 54518: Refactored the reaping logic in I/O switchboard. - posted by Jie Yu <yu...@gmail.com> on 2016/12/08 01:46:32 UTC, 5 replies.
- Review Request 54519: Stout: Moved `os::getenv` from `os.hpp` -> `os/getenv.hpp`. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/08 02:23:00 UTC, 1 replies.
- Re: Review Request 51065: Changed hostname used for SSL cert creation in tests. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/08 02:31:00 UTC, 2 replies.
- Review Request 54521: Removed "*" role from default response of `getRoles` API. - posted by Jay Guo <gu...@gmail.com> on 2016/12/08 06:02:25 UTC, 1 replies.
- Review Request 54522: Added a test for `getRoles` helper function. - posted by Jay Guo <gu...@gmail.com> on 2016/12/08 06:07:16 UTC, 2 replies.
- Re: Review Request 50523: Updated docker recovery to account for GPU resources. - posted by Rajat Phull <rp...@nvidia.com> on 2016/12/08 07:09:25 UTC, 2 replies.
- Review Request 54524: Updated `resources()` method to return resources used by role. - posted by Jay Guo <gu...@gmail.com> on 2016/12/08 07:10:44 UTC, 10 replies.
- Re: Review Request 54205: Improved equality check in SlaveTest.StateEndpoint. - posted by Till Toenshoff <to...@me.com> on 2016/12/08 13:35:39 UTC, 4 replies.
- Review Request 54529: Exposed framework roles in master and agent endpoints. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 14:21:48 UTC, 8 replies.
- Review Request 54535: WIP: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/08 15:38:18 UTC, 4 replies.
- Review Request 54537: Support 'Basic' auth docker registry on Unified Containerizer. - posted by Gilbert Song <so...@gmail.com> on 2016/12/08 17:31:16 UTC, 5 replies.
- Review Request 54538: WIP: Enabled fine grained authorization for the getContainers API Call. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/08 17:33:01 UTC, 5 replies.
- Re: Review Request 50414: Added variables for building Java Protobuf. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/08 18:19:08 UTC, 1 replies.
- Re: Review Request 50415: Added build step to build Java Protobuf. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/08 18:19:30 UTC, 6 replies.
- Review Request 54544: Added AgentAPITest.LaunchNestedContainerSessionDisconnected. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/08 20:25:33 UTC, 5 replies.
- Review Request 54545: Cleaned up expectations in api_tests.cpp. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/08 21:32:17 UTC, 2 replies.
- Re: Review Request 53238: Changed agent to report "retired" agent IDs on registration. - posted by Neil Conway <ne...@gmail.com> on 2016/12/08 22:10:00 UTC, 0 replies.
- Review Request 54553: Removed `using namespace` decl from slave namespace. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 23:05:31 UTC, 1 replies.
- Review Request 54555: Removed using declarations in headers in global scope in libprocess. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 23:05:33 UTC, 2 replies.
- Review Request 54554: Do not assume std symbols are visible without using FQN. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 23:05:34 UTC, 1 replies.
- Review Request 54228: WIP. - posted by Neil Conway <ne...@gmail.com> on 2016/12/08 23:26:54 UTC, 0 replies.
- Re: Review Request 54178: Added a fixed-capacity hashmap to stout. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/08 23:41:00 UTC, 3 replies.
- Re: Review Request 54180: Updated agent to use BoundedHashMap. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/09 00:51:17 UTC, 0 replies.
- Re: Review Request 54181: Synchronized v1 and unversioned master.proto. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/09 00:51:38 UTC, 0 replies.
- Re: Review Request 54182: Improved various comments. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/09 00:58:47 UTC, 2 replies.
- Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/09 01:00:06 UTC, 10 replies.
- Review Request 54559: Added the `io_switchboard_enable_server` flag for windows builds. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/09 01:11:53 UTC, 0 replies.
- Review Request 54560: Added a heartbeat for both input/output connections on an IOSwitchboard. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/09 01:18:20 UTC, 3 replies.
- Review Request 54561: Added tests for IOSwitchboard heartbeat. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/09 01:20:08 UTC, 8 replies.
- Review Request 54562: Added a grace period for I/O switchboard server termination. - posted by Jie Yu <yu...@gmail.com> on 2016/12/09 01:24:05 UTC, 1 replies.
- Review Request 54570: Added comments around some health check limitations. - posted by Alexander Rukletsov <ru...@gmail.com> on 2016/12/09 04:27:06 UTC, 9 replies.
- Review Request 54571: Timed health check duration. - posted by Alexander Rukletsov <ru...@gmail.com> on 2016/12/09 04:27:35 UTC, 7 replies.
- Review Request 54572: Added metrics counter for scheduler calls. - posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2016/12/09 04:38:07 UTC, 2 replies.
- Review Request 54573: Updated metrics counter during scheduler api calls. - posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2016/12/09 04:40:20 UTC, 1 replies.
- Review Request 54574: Updated test case for call based metrics for scheduler api. - posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2016/12/09 04:45:54 UTC, 2 replies.
- Review Request 54587: Introduce a ScaleTestContainerizer suitable for scale testing. - posted by Ilya Pronin <ip...@twitter.com> on 2016/12/09 16:16:33 UTC, 1 replies.
- Review Request 54589: Improved operator HTTP API docs. - posted by Neil Conway <ne...@gmail.com> on 2016/12/09 17:13:21 UTC, 6 replies.
- Review Request 54597: Introduced an `os::pipe` abstraction in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/09 18:17:55 UTC, 1 replies.
- Review Request 54607: Add Andrew Schwartzmeyer to contributors. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/09 19:51:37 UTC, 1 replies.
- Review Request 54610: Windows: qualify string, map, vector in `subprocess.hpp`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/09 21:28:48 UTC, 2 replies.
- Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing. - posted by Ilya Pronin <ip...@twitter.com> on 2016/12/09 21:29:32 UTC, 0 replies.
- Review Request 54611: Windows: Added `recordio_tests.cpp` to Agent build. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/09 21:47:38 UTC, 3 replies.
- Review Request 54613: Install a symlink rather than building mesos-slave twice. - posted by James Peach <jp...@apache.org> on 2016/12/09 23:26:30 UTC, 6 replies.
- Re: Review Request 52461: Ported apply-reviews.py script to Windows. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/09 23:38:36 UTC, 0 replies.
- Re: Review Request 52938: Added temporary disabled TEST_P macro for Windows. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/10 00:41:41 UTC, 0 replies.
- Re: Review Request 50857: Modified a scheduler test to run with SSL enabled. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/10 00:47:22 UTC, 0 replies.
- Re: Review Request 52002: Added helper methods to determine types of disk resources. - posted by Anindya Sinha <an...@apple.com> on 2016/12/10 01:19:23 UTC, 1 replies.
- Re: Review Request 51879: Autodetect value of resource when not specified in static resources. - posted by Anindya Sinha <an...@apple.com> on 2016/12/10 01:19:26 UTC, 5 replies.
- Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks. - posted by Anindya Sinha <an...@apple.com> on 2016/12/10 01:19:27 UTC, 4 replies.
- Re: Review Request 52071: Updated docs to handle resources with no size in agent flags. - posted by Anindya Sinha <an...@apple.com> on 2016/12/10 01:19:30 UTC, 4 replies.
- Re: Review Request 53803: Added new libprocess socket tests. - posted by Greg Mann <gr...@mesosphere.io> on 2016/12/10 01:31:16 UTC, 1 replies.
- Review Request 54618: Windows: Added `http_tests.cpp` and `type_utils_tests.cpp` to build. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/10 02:00:30 UTC, 1 replies.
- Review Request 54620: Removed "enable_io_switchboard_server" agent flag. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/10 05:08:05 UTC, 5 replies.
- Review Request 54627: Forced variant of 'http::connect()' to use POLL even when SSL enabled. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/10 18:29:56 UTC, 3 replies.
- Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/10 18:31:15 UTC, 5 replies.
- Re: Review Request 50455: Enabled Java builds if Java is found. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:18:52 UTC, 0 replies.
- Re: Review Request 50456: Added custom command to generate Java protobufs. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:18:59 UTC, 0 replies.
- Re: Review Request 50457: Added code to generate MesosNativeLibrary.java. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:19:17 UTC, 0 replies.
- Re: Review Request 50458: Added code to build mesos-java.jar. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:19:23 UTC, 0 replies.
- Re: Review Request 50459: Added code to generate JNI Header files. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:19:29 UTC, 0 replies.
- Re: Review Request 50460: Added code to build libstate shared library. - posted by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:19:34 UTC, 0 replies.
- Re: Review Request 54618: Windows: Added trivially passable tests to build. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/10 22:06:13 UTC, 5 replies.
- Review Request 54631: Windows: Disambiguated `os::write` by adding another overload. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/10 22:51:28 UTC, 3 replies.
- Review Request 54632: Added agent API test for attaching input to a nested container session. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/11 00:54:50 UTC, 2 replies.
- Review Request 54630: Added a `http_heartbeat_interval` flag to the agent flags. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/11 01:02:50 UTC, 3 replies.
- Re: Review Request 54560: Added a bi-directional heartbeat for IOSwitchboard connections. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/11 01:03:46 UTC, 1 replies.
- Re: Review Request 50463: Added code to build libmesosjava shared library. - posted by Mesos ReviewBot <re...@mesos.apache.org> on 2016/12/11 01:05:23 UTC, 0 replies.
- Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh. - posted by David Forsythe <df...@gmail.com> on 2016/12/11 04:00:48 UTC, 1 replies.
- Re: Review Request 54627: Updated address of 'http::connect()' with http scheme for SSL support. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/11 04:35:22 UTC, 2 replies.
- Review Request 54637: Fixed EOF bug when tty is enabled in switch board server. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/11 04:46:41 UTC, 4 replies.
- Review Request 54638: Added agent flags '--oci_discovery' and '--oci_discovery_prefix'. - posted by Qian Zhang <zh...@gmail.com> on 2016/12/11 14:18:05 UTC, 0 replies.
- Review Request 54639: Implemented the 'create()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2016/12/11 14:20:57 UTC, 1 replies.
- Review Request 54643: Added union assignment operator in hashset. - posted by Jiang Yan Xu <ya...@jxu.me> on 2016/12/12 03:13:34 UTC, 2 replies.
- Review Request 54645: MESOS-6644: Fix failure of large message devolution. - posted by Zhongbo Tian <wi...@gmail.com> on 2016/12/12 07:14:11 UTC, 0 replies.
- Review Request 54649: Fixed minor argument style. - posted by Jay Guo <gu...@gmail.com> on 2016/12/12 08:41:40 UTC, 1 replies.
- Review Request 54650: Added validation for roles in ACCEPT call. - posted by Jay Guo <gu...@gmail.com> on 2016/12/12 08:42:34 UTC, 14 replies.
- Re: Review Request 51027: Track allocation candidates to bound allocator. - posted by Jiang Yan Xu <ya...@jxu.me> on 2016/12/12 09:30:18 UTC, 4 replies.
- Re: Review Request 54538: Enabled fine grained authorization for the getContainers API Call. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 09:45:42 UTC, 7 replies.
- Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 09:45:44 UTC, 2 replies.
- Re: Review Request 54535: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 10:45:14 UTC, 2 replies.
- Review Request 54661: Enable authorization for the GET_FLAGS API Call. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 14:35:56 UTC, 5 replies.
- Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 14:37:08 UTC, 3 replies.
- Review Request 54663: Acked correct task id in DefaultExecutorTest.KillTask test. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/12 16:01:52 UTC, 2 replies.
- Review Request 54664: Acked correct task id in DefaultExecutorTest.KillTaskGroupOnTaskFailure. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/12 16:02:46 UTC, 3 replies.
- Re: Review Request 52534: Dispatch filter expiration twice. - posted by Jiang Yan Xu <ya...@jxu.me> on 2016/12/12 17:00:01 UTC, 4 replies.
- Review Request 54671: Changed the timing of entering mount namespace for DEBUG container. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 19:21:44 UTC, 1 replies.
- Review Request 54672: Used exitWithStatus(EXIT_SUCCESS) at the end of launch.cpp. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 19:22:05 UTC, 0 replies.
- Review Request 54673: Fixed an unreachable statement in launch.cpp. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 19:22:23 UTC, 2 replies.
- Re: Review Request 53299: Fixed memory leak in implementation of Future::after(). - posted by Joris Van Remoortere <jo...@gmail.com> on 2016/12/12 20:31:54 UTC, 7 replies.
- Review Request 54676: Fixed the environment overriding order in MesosContainerizer. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 21:53:27 UTC, 2 replies.
- Re: Review Request 52064: Support for multiple versions of docs. - posted by Tim Anderegg <ti...@gmail.com> on 2016/12/12 22:03:29 UTC, 3 replies.
- Review Request 54677: Windows: Enabled 495 passing tests on Agent builds. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/12 22:08:32 UTC, 5 replies.
- Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/12 22:11:44 UTC, 4 replies.
- Review Request 54678: Added John Kordich to contributors. - posted by John Kordich <jo...@microsoft.com> on 2016/12/12 22:26:54 UTC, 2 replies.
- Review Request 54681: Used None() for some IOSwitchboardServer flags. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 23:42:13 UTC, 2 replies.
- Review Request 54682: Fixed the tests by turning off agent subsystems in IOSwitchboard tests. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 23:42:35 UTC, 4 replies.
- Review Request 54683: Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer. - posted by Jie Yu <yu...@gmail.com> on 2016/12/12 23:43:11 UTC, 1 replies.
- Re: Review Request 54681: Made some IOSwitchboardServer flags optional. - posted by Jie Yu <yu...@gmail.com> on 2016/12/13 00:11:53 UTC, 1 replies.
- Review Request 54685: Windows: Fix build break in libprocess tests. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/13 00:33:10 UTC, 4 replies.
- Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/13 00:47:31 UTC, 4 replies.
- Re: Review Request 53344: Updated `/slaves.md` doc. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/13 00:52:08 UTC, 4 replies.
- Review Request 54686: Moved the `IOSwitchboardServer::isRequired` to `IOSwitchBoard`. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/13 00:52:57 UTC, 2 replies.
- Review Request 54687: Moved `IOSwitchboard::requiresServer()` implementation to cpp. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/13 01:10:06 UTC, 1 replies.
- Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem - posted by Jason Lai <ja...@jasonlai.net> on 2016/12/13 05:12:05 UTC, 12 replies.
- Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/13 10:13:36 UTC, 7 replies.
- Re: Review Request 53790: Move containerizer Rootfs support to a cpp file. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/13 10:24:18 UTC, 4 replies.
- Review Request 54700: Fixed bug that prevented window size updates in the IOSwitchboard. - posted by Kevin Klues <kl...@gmail.com> on 2016/12/13 12:34:25 UTC, 2 replies.
- Review Request 54702: Fixed the tests by turning off agent subsystems in IOSwitchboard tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/13 12:52:43 UTC, 2 replies.
- Re: Review Request 51028: Fix tests with rapidly triggered allocations. - posted by Jiang Yan Xu <ya...@jxu.me> on 2016/12/13 16:30:09 UTC, 5 replies.
- Review Request 54712: Use the stout ELF parser to implement ldd. - posted by James Peach <jp...@apache.org> on 2016/12/13 18:35:43 UTC, 3 replies.
- Review Request 54590: Removed unused peek function. - posted by Michael Park <mp...@apache.org> on 2016/12/13 20:44:59 UTC, 4 replies.
- Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. - posted by Michael Park <mp...@apache.org> on 2016/12/13 20:45:04 UTC, 5 replies.
- Review Request 54592: Introduced an `os::lseek` abstraction in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/13 21:01:31 UTC, 5 replies.
- Review Request 54593: Replaced `::lseek` with `os::lseek` in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/13 21:01:43 UTC, 3 replies.
- Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos. - posted by Michael Park <mp...@apache.org> on 2016/12/13 21:01:54 UTC, 2 replies.
- Review Request 54595: Introduced an `os::dup` abstraction in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/13 21:02:14 UTC, 4 replies.
- Review Request 54720: Added a test that verifies container attach after agent restart. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/13 22:20:36 UTC, 9 replies.
- Review Request 54716: Modified the initialization logic for `network/cni` isolator. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/13 23:51:59 UTC, 8 replies.
- Review Request 54717: Modified `network/cni` isolator for dynamic addition of CNI networks. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/13 23:55:49 UTC, 5 replies.
- Review Request 54718: Removed dependency of `detach` and `recover` on cached networks. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/14 00:05:00 UTC, 1 replies.
- Review Request 54596: Replaced `::dup` with `os::dup` in libprocess. - posted by Michael Park <mp...@apache.org> on 2016/12/14 00:09:07 UTC, 2 replies.
- Review Request 54719: Added support for deleting CNI network from `network/cni` isolator. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/14 00:32:35 UTC, 1 replies.
- Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/14 00:46:57 UTC, 7 replies.
- Review Request 54731: Fixed a check bug in LAUNCH_NESTED_CONTAINER_SESSION_CALL. - posted by Vinod Kone <vi...@gmail.com> on 2016/12/14 04:15:47 UTC, 2 replies.
- Review Request 54732: Reused same json helper for `SlaveInfo`. - posted by Zhitao Li <zh...@gmail.com> on 2016/12/14 04:52:13 UTC, 1 replies.
- Re: Review Request 54085: Made internal Mesos headers more standalone. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/14 09:04:02 UTC, 1 replies.
- Re: Review Request 54083: Made headers in stout standalone. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/14 09:04:02 UTC, 1 replies.
- Review Request 54739: Used correct shell string comparison operator in test. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/14 12:44:23 UTC, 3 replies.
- Review Request 54751: Used process::loop in infinitely recursive functions. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/14 16:32:55 UTC, 2 replies.
- Review Request 54753: Leaked module libraries to avoid inconsitencies in library unloading. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/14 16:55:41 UTC, 2 replies.
- Review Request 54755: Kept the listening socket while accept is in flight. - posted by Jie Yu <yu...@gmail.com> on 2016/12/14 18:03:33 UTC, 2 replies.
- Re: Review Request 54211: Fixed overlay backend symlink error message. - posted by Jie Yu <yu...@gmail.com> on 2016/12/14 18:45:00 UTC, 0 replies.
- Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink. - posted by Jie Yu <yu...@gmail.com> on 2016/12/14 19:31:52 UTC, 7 replies.
- Re: Review Request 53264: Added test for CNI port-mapper plugin. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/14 19:45:59 UTC, 0 replies.
- Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid(). - posted by Jie Yu <yu...@gmail.com> on 2016/12/14 19:47:35 UTC, 1 replies.
- Re: Review Request 52772: Added a filter for '_CNIPLUGINS_'. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/14 20:03:16 UTC, 1 replies.
- Re: Review Request 54017: Changed implementation of LinkedHashMap. - posted by Michael Park <mp...@apache.org> on 2016/12/14 21:30:53 UTC, 4 replies.
- Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends. - posted by Michael Park <mp...@apache.org> on 2016/12/14 21:34:15 UTC, 3 replies.
- Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap. - posted by Michael Park <mp...@apache.org> on 2016/12/14 21:35:44 UTC, 1 replies.
- Re: Review Request 54087: Updated stout's README. - posted by Michael Park <mp...@apache.org> on 2016/12/14 21:44:15 UTC, 2 replies.
- Re: Review Request 46425: Add helper function to simplify tokenize handling. - posted by Joris Van Remoortere <jo...@gmail.com> on 2016/12/14 22:35:28 UTC, 0 replies.
- Review Request 54601: Replaced `int` with `int_fd` in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/14 23:52:52 UTC, 3 replies.
- Review Request 54602: Replaced `int` with `int_fd` in libprocess. - posted by Michael Park <mp...@apache.org> on 2016/12/14 23:56:18 UTC, 3 replies.
- Review Request 54603: Replaced `int` with `int_fd` in mesos. - posted by Michael Park <mp...@apache.org> on 2016/12/14 23:56:20 UTC, 5 replies.
- Review Request 54762: Introduced an os::pipe abstraction to stout. - posted by Michael Park <mp...@apache.org> on 2016/12/14 23:56:25 UTC, 1 replies.
- Review Request 54763: Replaced `::pipe` with `os::pipe` in libprocess. - posted by Michael Park <mp...@apache.org> on 2016/12/14 23:56:52 UTC, 1 replies.
- Review Request 54764: Replaced `::pipe` with `os::pipe` in mesos. - posted by Michael Park <mp...@apache.org> on 2016/12/14 23:57:07 UTC, 1 replies.
- Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'. - posted by Joris Van Remoortere <jo...@gmail.com> on 2016/12/15 01:33:21 UTC, 4 replies.
- Review Request 54770: Fixed the 'IOSwitchboardTest.KillSwitchboardContainerDestroyed' test. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/15 02:03:37 UTC, 2 replies.
- Review Request 54769: Fixed a cleanup related bug in the IO switchboard. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/15 02:03:44 UTC, 2 replies.
- Review Request 54775: Made /dev/urandom the fill source in disk_full_framework. - posted by David Forsythe <df...@gmail.com> on 2016/12/15 09:16:37 UTC, 1 replies.
- Re: Review Request 53582: Updated mesos-tidy image to upstream 3.9 release. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/15 10:40:07 UTC, 1 replies.
- Review Request 54783: Added tests for authorization of launching container sessions. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/15 15:33:25 UTC, 1 replies.
- Review Request 54784: Adds tests for authorization when attaching to a container input. - posted by Alexander Rojas <al...@mesosphere.io> on 2016/12/15 15:33:57 UTC, 2 replies.
- Re: Review Request 54213: Supported more layers through symlink for aufs backend. - posted by Gilbert Song <so...@gmail.com> on 2016/12/15 17:52:41 UTC, 1 replies.
- Re: Review Request 54214: Added unit test for aufs backend supporting many layers. - posted by Gilbert Song <so...@gmail.com> on 2016/12/15 17:53:11 UTC, 1 replies.
- Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store. - posted by Gilbert Song <so...@gmail.com> on 2016/12/15 17:53:27 UTC, 1 replies.
- Re: Review Request 50871: Supported auto backend in Unified Containerizer. - posted by Gilbert Song <so...@gmail.com> on 2016/12/15 17:54:23 UTC, 0 replies.
- Review Request 54792: Updated the Windows doc to refer to `.\support\windows-build.bat`. - posted by Michael Park <mp...@apache.org> on 2016/12/15 18:07:55 UTC, 2 replies.
- Re: Review Request 54333: Specified that we search for the query parameter in the request body. - posted by Michael Park <mp...@apache.org> on 2016/12/15 19:16:46 UTC, 1 replies.
- Review Request 54793: Prevented task launches that reuse unreachable task IDs. - posted by Neil Conway <ne...@gmail.com> on 2016/12/15 20:56:53 UTC, 0 replies.
- Review Request 54794: Tweaked `TeardownTest.RecoveredFrameworkAfterMasterFailover`. - posted by Neil Conway <ne...@gmail.com> on 2016/12/15 20:57:10 UTC, 0 replies.
- Re: Review Request 54794: Cleaned up teardown tests slightly. - posted by Neil Conway <ne...@gmail.com> on 2016/12/15 21:13:34 UTC, 1 replies.
- Re: Review Request 52773: Added a loopback test with CNI ptp plugin. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/15 21:54:55 UTC, 0 replies.
- Review Request 54796: Avoided capturing `this` in `process::loop`. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/15 22:02:39 UTC, 2 replies.
- Re: Review Request 53546: Added stub classes for rest cgroups subsystems. - posted by Jie Yu <yu...@gmail.com> on 2016/12/15 22:38:12 UTC, 1 replies.
- Re: Review Request 53706: Implemented `os::user' on Windows. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/15 23:01:00 UTC, 0 replies.
- Re: Review Request 54515: Use `os::var()` in `Flags::runtime_dir`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/15 23:44:02 UTC, 2 replies.
- Review Request 54800: Implemented `os::user' on Windows. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/16 00:51:34 UTC, 2 replies.
- Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/16 02:47:23 UTC, 17 replies.
- Review Request 54807: Windows: Disable CHECK-failing on symlink creation. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/16 06:43:17 UTC, 3 replies.
- Review Request 54816: Replaced os::getcwd() to sandbox.get() in provisioner test. - posted by Gilbert Song <so...@gmail.com> on 2016/12/16 18:05:12 UTC, 0 replies.
- Re: Review Request 54717: Modified isolator for dynamic addition/deletion of CNI networks. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/16 20:34:03 UTC, 10 replies.
- Re: Review Request 54718: Removed dependency of `recover` on cached networks. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/16 20:37:00 UTC, 2 replies.
- Re: Review Request 54034: Introduced common fixture to PosixRLimitsIsolatorTest. - posted by Jie Yu <yu...@gmail.com> on 2016/12/16 22:11:27 UTC, 1 replies.
- Review Request 54825: Made sure process::Loop instances can only be created as shared_ptrs. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/16 23:11:19 UTC, 1 replies.
- Review Request 54827: Made CMake build default to use brew APR on OS X. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/16 23:16:57 UTC, 3 replies.
- Review Request 54828: Fixed flags::fetch() to support Windows file paths. - posted by John Kordich <jo...@microsoft.com> on 2016/12/16 23:27:37 UTC, 3 replies.
- Review Request 54830: Added helper function to get per-role resource allocations. - posted by Guangya Liu <gy...@gmail.com> on 2016/12/17 02:49:27 UTC, 10 replies.
- Review Request 54831: Removed extra space in method definition in 3rdparty [1/2]. - posted by haosdent huang <ha...@gmail.com> on 2016/12/17 09:38:01 UTC, 1 replies.
- Review Request 54832: Removed extra space in method definitions in src [2/2]. - posted by haosdent huang <ha...@gmail.com> on 2016/12/17 09:38:02 UTC, 2 replies.
- Re: Review Request 53291: Fixed incorrect `/monitor/statistics` URL in WebUI. - posted by haosdent huang <ha...@gmail.com> on 2016/12/17 09:40:21 UTC, 0 replies.
- Review Request 54833: Fixed the metrics display bug in agent.html. - posted by haosdent huang <ha...@gmail.com> on 2016/12/17 09:41:17 UTC, 2 replies.
- Review Request 54834: Fixed a typo in webui. - posted by haosdent huang <ha...@gmail.com> on 2016/12/17 09:41:35 UTC, 1 replies.
- Review Request 54838: Used process::io::BUFFERED_READ_SIZE instead of constant. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/17 21:35:36 UTC, 1 replies.
- Review Request 54839: Updated Mesos process::loop uses with process::ControlFlow. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/17 21:37:52 UTC, 2 replies.
- Review Request 54840: Used process::loop to avoid stack overflow due to recursion. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/17 21:38:12 UTC, 4 replies.
- Review Request 54841: Used `loop` in implementation of io::read and io::write. - posted by Benjamin Hindman <be...@berkeley.edu> on 2016/12/17 21:40:39 UTC, 3 replies.
- Review Request 54842: Updated Resources to handle Resource.AllocationInfo. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/17 22:50:07 UTC, 1 replies.
- Review Request 54836: Added helpers to allocate / unallocate Resources. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/17 22:50:38 UTC, 5 replies.
- Review Request 54837: Added a CHECK when adding a framework in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2016/12/17 22:50:40 UTC, 2 replies.
- Review Request 54846: Removed `docker exec` when perform health checks in docker executor. - posted by haosdent huang <ha...@gmail.com> on 2016/12/18 17:26:26 UTC, 1 replies.
- Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options. - posted by Zhitao Li <zh...@gmail.com> on 2016/12/18 17:37:27 UTC, 13 replies.
- Re: Review Request 54035: Extended test coverage of posix/rlimits isolator. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/19 11:07:12 UTC, 1 replies.
- Review Request 54859: Shortened socket paths used in test. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/19 11:16:44 UTC, 1 replies.
- Re: Review Request 53713: Reversed recoursive path creation. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/19 18:34:07 UTC, 0 replies.
- Re: Review Request 53712: Added `system` environement variables in ` execvpe.cpp`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/19 19:07:35 UTC, 1 replies.
- Review Request 54873: WIP: Added asynchronous libcurl support to Mesos. - posted by Jie Yu <yu...@gmail.com> on 2016/12/19 20:44:36 UTC, 1 replies.
- Re: Review Request 53237: Improved slave recovery tests to check reconciliation, metrics. - posted by Neil Conway <ne...@gmail.com> on 2016/12/19 21:05:44 UTC, 0 replies.
- Re: Review Request 53237: Improved slave recovery tests. - posted by Neil Conway <ne...@gmail.com> on 2016/12/19 21:15:26 UTC, 3 replies.
- Re: Review Request 53239: Changed master to make use of "retired" agent IDs. - posted by Neil Conway <ne...@gmail.com> on 2016/12/19 21:15:40 UTC, 0 replies.
- Review Request 54875: CMake: Fixed typo `-DHAS_AUTHENTICATION=0` instructions. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/19 22:12:35 UTC, 3 replies.
- Re: Review Request 52190: Removed deprecated compiler warnings. - posted by Daniel Pravat <dp...@outlook.com> on 2016/12/19 23:09:16 UTC, 0 replies.
- Review Request 54877: Windows: Stout: Removed dependency on Shell API. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2016/12/19 23:20:16 UTC, 9 replies.
- Review Request 54878: Add some simple ldd() tests. - posted by James Peach <jp...@apache.org> on 2016/12/19 23:22:54 UTC, 0 replies.
- Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/19 23:34:56 UTC, 0 replies.
- Re: Review Request 53717: Added `Winsock` initialization in `docker-mesos-executor`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/20 00:34:32 UTC, 0 replies.
- Review Request 54880: Added unit-test for dynamic addition/deletion of CNI config. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/20 03:37:36 UTC, 4 replies.
- Review Request 54889: Handled all possible offers in test. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/20 11:48:53 UTC, 10 replies.
- Re: Review Request 51028: Fix broken tests post batched event allocation. - posted by Jacob Janco <jj...@gmail.com> on 2016/12/20 12:05:06 UTC, 1 replies.
- Review Request 54896: Fixed copy-template-and-create-symlink make target. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/20 13:53:25 UTC, 5 replies.
- Review Request 54898: Added a CHECK in updateFrameworkInfo. - posted by Jay Guo <gu...@gmail.com> on 2016/12/20 15:06:22 UTC, 1 replies.
- Review Request 54901: Updated description of "--agent_reregister_timeout". - posted by Neil Conway <ne...@gmail.com> on 2016/12/20 16:09:20 UTC, 2 replies.
- Review Request 54909: Added member to agent to avoid spurious re-registrations. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/20 17:54:58 UTC, 1 replies.
- Review Request 54910: Fixed more tests to pass when `HAS_AUTHENTICATION` is undefined. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/20 18:02:51 UTC, 3 replies.
- Re: Review Request 53718: Defined and used Windows string `docker-mesos-executor.exe`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/20 21:20:37 UTC, 0 replies.
- Re: Review Request 53719: Created default mount point on Windows. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/20 21:29:40 UTC, 0 replies.
- Review Request 54913: Added some missing log statements for scheduler calls. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/20 21:40:10 UTC, 2 replies.
- Re: Review Request 53715: Define docker `--entrypoint` for `Windows`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/20 21:53:46 UTC, 0 replies.
- Re: Review Request 53716: Used `Shell::entrypoint`. - posted by Joseph Wu <jo...@mesosphere.io> on 2016/12/20 22:06:28 UTC, 0 replies.
- Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout. - posted by Michael Park <mp...@apache.org> on 2016/12/20 22:31:50 UTC, 1 replies.
- Review Request 54921: Added blog post for the 0.28.3 release. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/20 23:33:49 UTC, 1 replies.
- Review Request 54920: Updated releases.yml for Mesos 0.28.3. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/20 23:33:58 UTC, 1 replies.
- Review Request 54919: Fixed target version for the 1.1.0 release. - posted by Anand Mazumdar <an...@apache.org> on 2016/12/20 23:34:15 UTC, 1 replies.
- Review Request 54926: Augmented a fault_tolerance_test to cover update of role. - posted by Jay Guo <gu...@gmail.com> on 2016/12/21 03:06:24 UTC, 1 replies.
- Re: Review Request 54909: Fixed spurious registration bug in framework and agent. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/21 03:09:34 UTC, 1 replies.
- Review Request 54927: Fixed partition to pass when `HAS_AUTHENTICATED` is undefined. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/21 03:16:10 UTC, 1 replies.
- Review Request 54928: Added initial random delay to agent (re)registration. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/21 03:16:13 UTC, 2 replies.
- Review Request 54946: Made sure classes deriving from FlagBase use virtual inheritance. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/21 21:07:11 UTC, 1 replies.
- Review Request 54949: Remove the use of FORTIFY_SOURCE from Mesos. - posted by Aaron Wood <aa...@verizon.com> on 2016/12/21 22:02:58 UTC, 1 replies.
- Review Request 54950: Remove the use of FORTIFY_SOURCE from libprocess. - posted by Aaron Wood <aa...@verizon.com> on 2016/12/21 22:04:57 UTC, 1 replies.
- Review Request 54951: Remove the use of FORTIFY_SOURCE from stout. - posted by Aaron Wood <aa...@verizon.com> on 2016/12/21 22:06:25 UTC, 1 replies.
- Review Request 54952: Added EINVAL to the list of expected `getpwnam_r()` errors. - posted by Neil Conway <ne...@gmail.com> on 2016/12/21 22:38:05 UTC, 1 replies.
- Review Request 54953: Set -pie conditionally on whether hardening is enabled or not. - posted by Aaron Wood <aa...@verizon.com> on 2016/12/21 22:50:11 UTC, 6 replies.
- Review Request 54954: Improve the warning when failing to find the executor PID. - posted by James Peach <jp...@apache.org> on 2016/12/21 22:53:16 UTC, 0 replies.
- Re: Review Request 54590: Removed unused `peek` function. - posted by Michael Park <mp...@apache.org> on 2016/12/21 23:40:47 UTC, 0 replies.
- Review Request 54974: Actually overloaded function from base class in LibeventSSLSocketImpl. - posted by Benjamin Bannier <be...@mesosphere.io> on 2016/12/22 11:29:13 UTC, 1 replies.
- Review Request 54983: Fixed the CMake test target in stout. - posted by Michael Park <mp...@apache.org> on 2016/12/22 16:41:50 UTC, 2 replies.
- Review Request 54985: Fixed the CMake test target in mesos. - posted by Michael Park <mp...@apache.org> on 2016/12/22 16:41:50 UTC, 1 replies.
- Review Request 54984: Fixed the CMake test target in libprocess. - posted by Michael Park <mp...@apache.org> on 2016/12/22 16:41:50 UTC, 1 replies.
- Review Request 54986: Added metric for slave message queue. - posted by Zhitao Li <zh...@gmail.com> on 2016/12/22 17:12:29 UTC, 1 replies.
- Review Request 54987: Updated `docs/monitoring/md` for new slave event queue metrics. - posted by Zhitao Li <zh...@gmail.com> on 2016/12/22 17:13:28 UTC, 1 replies.
- Review Request 54688: Added a `docker_store_dir` flag to tests. - posted by Avinash sridharan <av...@mesosphere.io> on 2016/12/22 19:34:54 UTC, 0 replies.
- Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support. - posted by Aaron Wood <aa...@verizon.com> on 2016/12/22 20:46:34 UTC, 5 replies.
- Re: Review Request 54952: Made `getpwnam_r` error handling more robust. - posted by Neil Conway <ne...@gmail.com> on 2016/12/22 20:50:26 UTC, 4 replies.
- Review Request 54996: Fix SIGBUS crash on ARM64/AArch64. - posted by Aaron Wood <aa...@verizon.com> on 2016/12/22 21:03:16 UTC, 6 replies.
- Review Request 54999: Fixed test flakiness due to floating point conversions. - posted by Neil Conway <ne...@gmail.com> on 2016/12/22 22:54:50 UTC, 4 replies.
- Review Request 55004: CMake: renamed `stout_tests` to `stout-tests` to match autotools. - posted by Michael Park <mp...@apache.org> on 2016/12/23 02:09:41 UTC, 1 replies.
- Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools. - posted by Michael Park <mp...@apache.org> on 2016/12/23 02:09:42 UTC, 1 replies.
- Review Request 55006: CMake: renamed test binaries to match autotools. - posted by Michael Park <mp...@apache.org> on 2016/12/23 02:09:44 UTC, 3 replies.
- Review Request 55021: Added a framework capabilities struct. - posted by Jay Guo <gu...@gmail.com> on 2016/12/24 00:12:10 UTC, 5 replies.
- Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/24 09:31:47 UTC, 0 replies.
- Review Request 55023: Windows: Fixed malformatted containerizer command in launcher. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/24 10:02:59 UTC, 1 replies.
- Review Request 55024: Windows: Start the socket stack in `process::initialize`. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/24 10:46:32 UTC, 0 replies.
- Review Request 55025: Transitioned `BUILD_DIR` to use Unix-style paths on Windows. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/24 11:08:55 UTC, 1 replies.
- Review Request 55026: Windows: Shortened test directories on Windows to avoid path errors. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/24 11:14:34 UTC, 0 replies.
- Re: Review Request 54873: Added asynchronous libcurl support to Mesos. - posted by Jie Yu <yu...@gmail.com> on 2016/12/24 23:02:23 UTC, 4 replies.
- Review Request 55028: Propagate `os::killtree` error correctly in `PosixLauncher::destroy`. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/25 05:38:10 UTC, 0 replies.
- Review Request 55029: CMake: Added source groups to Stout build. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/25 05:38:49 UTC, 0 replies.
- Review Request 55030: CMake: Added source groups for libprocess build. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/25 05:39:18 UTC, 0 replies.
- Review Request 55033: Added libcurl test for write callback. - posted by Jie Yu <yu...@gmail.com> on 2016/12/26 01:42:35 UTC, 0 replies.
- Review Request 55034: Added support to get curl response code. - posted by Jie Yu <yu...@gmail.com> on 2016/12/26 01:43:20 UTC, 0 replies.
- Review Request 55037: Added default PATH value in `launch.cpp` for Windows case. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/26 09:53:55 UTC, 1 replies.
- Review Request 55038: CMake: Stop searching for SVN and APR after we've found them. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/26 09:53:59 UTC, 0 replies.
- Review Request 55039: CMake: Removed unnecessary calls to FindApr and FindSvn. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/26 09:54:05 UTC, 0 replies.
- Review Request 55040: CMake: Added correct values for some build flags. - posted by Alex Clemmer <cl...@gmail.com> on 2016/12/26 09:54:07 UTC, 1 replies.
- Review Request 55042: Let MesosContainerizer support ramdisk. - posted by Andy Pang <pa...@huawei.com> on 2016/12/26 12:01:26 UTC, 4 replies.
- Re: Review Request 53679: Implement capacity heuristic check related tests. - posted by Zhitao Li <zh...@gmail.com> on 2016/12/27 11:23:58 UTC, 1 replies.
- Re: Review Request 53691: Implemented some quota functionality tests. - posted by Zhitao Li <zh...@gmail.com> on 2016/12/27 11:24:16 UTC, 2 replies.
- Re: Review Request 52284: Implement more quota validation tests. - posted by Alexander Rukletsov <ru...@gmail.com> on 2016/12/27 20:10:37 UTC, 0 replies.
- Review Request 55065: Added support for s390x architecture - posted by Ayanampudi Varsha <av...@us.ibm.com> on 2016/12/28 08:24:48 UTC, 1 replies.
- Review Request 55066: Added Capabilities to Framework struct of Master and Agent. - posted by Jay Guo <gu...@gmail.com> on 2016/12/28 08:32:56 UTC, 0 replies.
- Review Request 55068: Added Capabilities to Framework struct of Hierarchical allocator. - posted by Jay Guo <gu...@gmail.com> on 2016/12/28 08:32:58 UTC, 1 replies.
- Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186). - posted by Deshi Xiao <xi...@gmail.com> on 2016/12/29 08:04:01 UTC, 0 replies.